List comprehension rather than loop

I've now learned this is quicker
2017-07-24 10:15:12 +01:00
parent ec21f72ce3
commit d43604c3ff
1 changed files with 2 additions and 7 deletions
@@ -1919,13 +1919,8 @@ class SQLFORM(FORM):
        if 'table_name' in attributes:
            del attributes['table_name']

-        fields_with_clones = []
-        for field in fields:
-            if isinstance(field, Field):
-                fields_with_clones.append(field.clone())
-            else:
-                # We have a table, so pass it along
-                fields_with_clones.append(field)                
+        # Clone fields, while passing tables straight through
+        fields_with_clones = [f.clone() if isinstance(f, Field) else f for f in fields]                  
            
        return SQLFORM(DAL(None).define_table(table_name, *fields_with_clones), **attributes)