dinislage/redmine_rate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
73 Commits 3 Branches 3 Tags
ace208da8af65d7c034fbc2f83ec6bcf6df5fbf8
Commit Graph
73 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Eric Davis ace208da8a Replaced all custom back_url redirection with Redmine's redirect_back_or_default. #1916 2009-01-20 13:06:39 -08:00
Eric Davis 2c752210ae Refactored params[:back_url] to @back_url. #1916 2009-01-20 12:57:42 -08:00
Eric Davis fcd8f24b69 Changed back_url so it's always set and added a test for it. #1916 2009-01-20 12:55:56 -08:00
Eric Davis 56298bc867 Added a link to delete a Rate. #1919 2009-01-20 11:34:43 -08:00
Eric Davis 158969e359 Added an error message when a locked rate is tried to be deleted. #1919 2009-01-20 11:33:08 -08:00
Eric Davis dc8dd4abe4 Redirect to a back_url when deleting a rate also. #1919 2009-01-20 11:29:33 -08:00
Eric Davis a294ff0154 Once deleting a Rate, the user should be redirected back to the user rate list. #1919 2009-01-20 11:27:40 -08:00
Eric Davis 3fccd98102 Added hints to the edit form so a user will not edit a locked Rate. #1919 2009-01-20 11:17:37 -08:00
Eric Davis a52afb7a2b Protect locked rates from being updated. 
* Locked rates will fail to save
* Attempting to save a Locked rates will display an error and reload the
  Rate from the database so the update parameters are thrown away

  #1919
 2009-01-20 11:05:19 -08:00
Eric Davis 1cd24e451b Sorting the Project column by project name now 
* Including projects in Rate.history_for_user
* Moved the valid sort options to a constant on the RatesController
* Changed the ValidSortOptions to use the Project name for project_id
* Updated admin view to use RatesController::ValidSortOptions instead of a
  duplicated string.

  #1915
 2009-01-20 10:46:16 -08:00
Eric Davis 05dd3649f6 Fixed the sorts by updated to 0.8 to use the new sort API and fixing the update element id. #1915 2009-01-19 15:00:43 -08:00
Eric Davis f870a6019e Hacked some column sorting onto RatesController 
* Added SortHelper to RatesController
* Init and updating the sorting (pre 0.8 sort_update)
* RatesController#index will only render the layout on non-xhr requests
* Changed Rate.history_for_user to take an order clause
* Added rate_sort_header_tag and rate_sort_link to the SortHelper in order
  to get the correct parameters for sorting Rates
* Added rate_sort_header_tags to the Rate lists

  #1915
 2009-01-19 14:43:54 -08:00
Eric Davis 3f4ea96777 Changed RatesController#update to redirect to: 
* Rate list for user or
* the back_url if provided

  #1914
 2009-01-19 11:54:54 -08:00
Eric Davis e97a68be0d Show different buttons based on if the Rate is new. #1914 2009-01-19 11:49:43 -08:00
Eric Davis 7d32fc7088 Added a new helper to UsersHelper. 
* project_options_for_select doesn't allow setting the selected project
  so it is replaced with project_options_for_select_with_selected in the views

  #1914
 2009-01-19 11:47:02 -08:00
Eric Davis 627a03c5e6 Enabled the edit link on index. 2009-01-19 11:35:39 -08:00
Eric Davis 22ec6f56b7 Added a back_url field to the Rate for that will store the redirect path. 
* Used in the User Administration panel so RatesController can redirect back to
  the panel as needed.

  #1914
 2009-01-19 11:32:27 -08:00
Eric Davis cc063768b6 Once saving a rate, the user is redirected to the rate list. #1914 2009-01-19 11:22:42 -08:00
Eric Davis b7a4850b06 Wrong name for the project select field. #1914 2009-01-19 11:20:00 -08:00
Eric Davis 2fe0bd3052 Refactored duplicate logic to a before_filter. #1914 2009-01-19 11:17:13 -08:00
Eric Davis 86c1990faa Require a user_id on the new action. #1914 2009-01-19 11:14:57 -08:00
Eric Davis 8fe67ef8ae Updated the form to use the form_for now that there is a Rate object. #1914 2009-01-19 11:14:39 -08:00
Eric Davis 83764cfe40 Use the same form for new as well as edit. #1916 2009-01-19 10:57:28 -08:00
Eric Davis c178f616d5 Integrated views into the controller specs. #1916 2009-01-19 10:56:39 -08:00
Eric Davis e6bb0de7e7 Updated url documentation 2009-01-19 10:46:51 -08:00
Eric Davis ae0be85f76 Using form partial for the new rate. #1916 2009-01-19 10:45:53 -08:00
Eric Davis c3250c882a Blocked all non-admins from using the RatesController. #1916 2009-01-19 10:40:42 -08:00
Eric Davis 6698ff8169 Moved the Rate History out of the users partial and into a partial for Rates 
* This will allow the RatesController to use the same view

  #1916
 2009-01-19 10:28:58 -08:00
Eric Davis a2e77e8182 Converted RatesController#index to require a user_id parameter 
* This action will turn into the Rate History screen

  #1916
 2009-01-19 10:25:04 -08:00
Eric Davis 441a86e7a6 Added generated RESTful RatesController. #1916 2009-01-19 09:53:47 -08:00
Eric Davis 8eeb0f4872 Moved form to a partial, it will be used with other views. #1914 2009-01-19 09:46:14 -08:00
Eric Davis ff93fc6df7 Removed custom project selector with one from the helpers. #1914 2009-01-19 09:43:54 -08:00
Eric Davis 973e6bc2b6 Mocked up a nonfunctional New Rate form. #1914 2009-01-19 09:39:44 -08:00
Eric Davis b993a5ae2f Refactored the date checks into a separate methods. #1920 2009-01-16 17:03:24 -08:00
Eric Davis 2950051383 Checking date input for Rate#for. #1920 2009-01-16 16:59:49 -08:00
Eric Davis 7bca02b511 Instead of returning nil, which could get confused with No Rate, passing 
incorrect objects to Rate#for will now throw a Rate::InvalidParameterException
back to the caller.

Normally you don't need to be this strict but this is a public API that will
be consumed by several third parties so we need to be very clear what happened.

  #1920
 2009-01-16 16:53:00 -08:00
Eric Davis 94e8aad493 Rate#for should handle invalid projects. #1920 2009-01-16 16:43:26 -08:00
Eric Davis 08b267741b Rate#for should handle invalid users. #1920 2009-01-16 16:40:50 -08:00
Eric Davis bab1fa7763 Singular rate 2009-01-16 16:35:05 -08:00
Eric Davis da891cc607 Refactored Rate#for_user_project_and_date to allow nil projects. #1920 2009-01-16 16:34:38 -08:00
Eric Davis 4599e21dfb More spec refactoring, duplicated mocks. #1920 2009-01-16 16:26:08 -08:00
Eric Davis 8b2022fa98 Removed a bunch of custom finders from the specs due to the private method refactoring and stubs. #1920 2009-01-16 16:24:38 -08:00
Eric Davis 82cf412560 Removed duplication 2009-01-16 16:22:45 -08:00
Eric Davis 24c445cce9 Extracted specs from Rate#for for Rate#for_user_project_and_date #1920 2009-01-16 16:21:45 -08:00
Eric Davis 3451286011 Typo, don't need two rates. Rate.rate_for... #1920 2009-01-16 16:21:18 -08:00
Eric Davis 06f8258b38 Extracted an ugly finder method from Rate#for to a private method. #1920 2009-01-16 16:16:39 -08:00
Eric Davis 68b7df3237 Added specs to test for using the default (today) date. #1920 2009-01-16 16:13:57 -08:00
Eric Davis 69d922a029 Refactored Rate#for to only get one record. #1920 2009-01-16 16:08:13 -08:00
Eric Davis 6a211c3e5e Rate#for will now return the most current rate for the user matching the parameters. #1920 2009-01-16 16:06:12 -08:00
Eric Davis b59c87b1f6 Implementing Rate#for's internal logic. #1920 2009-01-16 16:03:15 -08:00