dinislage/redmine_contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[#6441] Refactor: extract method

Browse Source
This commit is contained in:
Eric Davis
2011-08-10 15:11:45 -07:00
parent 1b4191dc15
commit 6357fd83e4
1 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/helpers/contracts_helper.rb
+12 -8
View File
@@ -30,14 +30,7 @@ module ContractsHelper
# skip
else
options = contract.deliverables.collect do |deliverable|
option_attributes = {}
option_attributes[:value] = h(deliverable.id)
option_attributes[:selected] = "selected" if selected_key.to_i == deliverable.id
option_attributes[:disabled] = "disabled" if (deliverable.locked? || contract.locked?) && selected_key.to_i != deliverable.id
next if deliverable.closed? && option_attributes[:selected].blank? # Skip unselected, closed
content_tag(:option, h(deliverable.title), option_attributes)
deliverable_option(deliverable, contract, selected_key)
end
html << content_tag(:optgroup, options.join("\n"), :label => h(contract.name))
@@ -46,6 +39,17 @@ module ContractsHelper
end.join('\n')
end
def deliverable_option(deliverable, contract, selected_key)
option_attributes = {}
option_attributes[:value] = h(deliverable.id)
option_attributes[:selected] = "selected" if selected_key.to_i == deliverable.id
option_attributes[:disabled] = "disabled" if (deliverable.locked? || contract.locked?) && selected_key.to_i != deliverable.id
return "" if deliverable.closed? && option_attributes[:selected].blank? # Skip unselected, closed
content_tag(:option, h(deliverable.title), option_attributes)
end
def deliverable_options_for_contract(contract)
contract.deliverables.collect {|d| [d.title, d.id]}
end