dinislage/redmine_contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor: extract method.

Browse Source
This commit is contained in:
Eric Davis
2010-07-19 08:48:19 -07:00
parent 79ead02f7a
commit 22191b99d1
1 changed files with 15 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/redmine_contracts/budget_plugin_migration.rb
+15 -12
View File
@@ -62,18 +62,7 @@ module RedmineContracts
@total = 0
end
if old_deliverable['overhead'].present?
deliverable.overhead_budgets << OverheadBudget.new(:deliverable => deliverable,
:budget => old_deliverable['overhead'],
:hours => 0)
elsif old_deliverable['overhead_percent'].present?
overhead = @total * (old_deliverable['overhead_percent'].to_f / 100)
deliverable.overhead_budgets << OverheadBudget.new(:deliverable => deliverable,
:budget => overhead,
:hours => 0)
end
convert_overhead(deliverable, old_deliverable, @total)
convert_materials(deliverable, old_deliverable, @total)
append_old_deliverable_to_notes(old_deliverable, deliverable)
@@ -102,6 +91,20 @@ module RedmineContracts
contract
end
def self.convert_overhead(deliverable, old_deliverable, total)
if old_deliverable['overhead'].present?
deliverable.overhead_budgets << OverheadBudget.new(:deliverable => deliverable,
:budget => old_deliverable['overhead'],
:hours => 0)
elsif old_deliverable['overhead_percent'].present?
overhead = total * (old_deliverable['overhead_percent'].to_f / 100)
deliverable.overhead_budgets << OverheadBudget.new(:deliverable => deliverable,
:budget => overhead,
:hours => 0)
end
end
def self.convert_materials(deliverable, old_deliverable, total)
if old_deliverable['materials'].present? && old_deliverable['materials'] > 0.0
deliverable.overhead_budgets << OverheadBudget.new(:deliverable => deliverable,