[#6441] Fix a Deliverable validation error when editing with a status change

This commit is contained in:
Eric Davis committed 2011-08-09 15:23:08 -07:00
1 parent ac24ae08e6
commit 0a916fea70
2 files changed
+3 -3

No files matched your search

+3 -1
View File
@@ -86,7 +86,9 @@ class Deliverable < ActiveRecord::Base
noop("Allow changes to the status only") noop("Allow changes to the status only")
elsif changes["status"].present? && changes["status"].second == "open" elsif changes["status"].present? && changes["status"].second == "open"
noop("Allow any changes when going to 'open'") noop("Allow any changes when going to 'open'")
elsif changes["status"].present? elsif changes["status"].present? && changes["status"].first == "open"
noop("Allow any changes when going from 'open' to another status")
else
errors.add_to_base(:cant_update_locked_deliverable) if locked? errors.add_to_base(:cant_update_locked_deliverable) if locked?
errors.add_to_base(:cant_update_closed_deliverable) if closed? errors.add_to_base(:cant_update_closed_deliverable) if closed?
end end
@@ -618,8 +618,6 @@ class DeliverablesEditTest < ActionController::IntegrationTest
end end
should "be allowed to change the status on a closed deliverables to Locked" do should "be allowed to change the status on a closed deliverables to Locked" do
assert @fixed_deliverable.lock!
visit_contract_page(@contract) visit_contract_page(@contract)
click_link_within "#deliverable_details_#{@fixed_deliverable.id}", 'Edit' click_link_within "#deliverable_details_#{@fixed_deliverable.id}", 'Edit'
assert_response :success assert_response :success