[#6441] Fix a Deliverable validation error when editing with a status change
This commit is contained in:
@@ -86,7 +86,9 @@ class Deliverable < ActiveRecord::Base
|
||||
noop("Allow changes to the status only")
|
||||
elsif changes["status"].present? && changes["status"].second == "open"
|
||||
noop("Allow any changes when going to 'open'")
|
||||
elsif changes["status"].present?
|
||||
elsif changes["status"].present? && changes["status"].first == "open"
|
||||
noop("Allow any changes when going from 'open' to another status")
|
||||
else
|
||||
errors.add_to_base(:cant_update_locked_deliverable) if locked?
|
||||
errors.add_to_base(:cant_update_closed_deliverable) if closed?
|
||||
end
|
||||
|
||||
@@ -618,8 +618,6 @@ class DeliverablesEditTest < ActionController::IntegrationTest
|
||||
end
|
||||
|
||||
should "be allowed to change the status on a closed deliverables to Locked" do
|
||||
assert @fixed_deliverable.lock!
|
||||
|
||||
visit_contract_page(@contract)
|
||||
click_link_within "#deliverable_details_#{@fixed_deliverable.id}", 'Edit'
|
||||
assert_response :success
|
||||
|
||||
Reference in New Issue
Block a user