dinislage/redmine
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
3,126 Commits 20 Branches 82 Tags
7376ef2ad73d71b8e60582d0dcbb2269be29da86
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Eric Davis 7376ef2ad7 Typecast issue ids when searched for. 
Older Postgres versions don't allow searching over the id field's max size.

Contributed by Holger Just

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3806 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-20 20:01:32 +00:00
Eric Davis c98f46d691 Handle unsuccessful destroys in TimelogController. #5700 
Contributed by Jan

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3805 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-20 19:30:51 +00:00
Eric Davis acef1d5352 Exclude fields_for in the TabularFormBuilder, it has a different method 
signature. #5416

Contributed by Jean-Baptiste Barth

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3804 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-20 19:03:09 +00:00
Eric Davis d2f8feb7c5 Optimize the N+1 query in watcher_recipients. #5415 
Contributed by Holger Just

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3803 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-20 18:41:30 +00:00
Eric Davis 116c7a7964 Add a link to the cross project time entries page to /projects. #4935 
Contributed by Jan.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3802 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-20 16:29:12 +00:00
Eric Davis 4083e7e622 Truncate incoming email subject lines to 255 characters. #5698 
Contributed by Jan

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3801 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-20 16:22:36 +00:00
Eric Davis c5863c0ad0 Support listing directories in svn which include square brackets. #5548 
Contributed by Gregor Schmidt

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3800 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-20 16:08:26 +00:00
Eric Davis 70da33fc29 Add some assertions on the default data loading test to debug a Ruby 1.9 failure. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3799 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-20 16:08:20 +00:00
Eric Davis 95c3c63cfe Fix for Ruby 1.9 strings. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3798 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-20 16:08:15 +00:00
Eric Davis 5db9a982cc Added two hooks to the issues report. #5233 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3797 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-20 03:37:42 +00:00
Eric Davis 41ff1b9cb2 Display the correct ISO week number on the project calendar. 
http://en.wikipedia.org/wiki/ISO_week

Contributed by Holger Just

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3790 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 22:52:15 +00:00
Eric Davis b2e903ff7c Calculate the correct week number for weeks starting at any date. #4857 
http://en.wikipedia.org/wiki/ISO_week

Contributed by Holger Just

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3789 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 22:52:09 +00:00
Eric Davis 093853b56a Added tests for #5533's behavior. 
Contributed by Gregor Schmidt.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3788 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 22:17:34 +00:00
Eric Davis b10818f4a1 Add a css class to hide content when printing. #5508 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3787 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 21:53:58 +00:00
Eric Davis b53de502ab Display the link name when external links are used in the toc macro. #5445 
Contributed by Yuki Kita and Jean-Baptiste Barth

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3786 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 21:39:21 +00:00
Eric Davis 69d9600f48 Added documentation about the session_path. #3968 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3785 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 20:04:47 +00:00
Eric Davis 2562bc5bcd Hide the role forms when editing or adding Project members. #5452 
Contributed by Yuki Kita

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3784 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 19:51:43 +00:00
Eric Davis d48eb2de47 Accept email from anonymous users with an empty from address. #5604 
Contributed by Andrew Fenn

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3783 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 19:24:17 +00:00
Eric Davis 5f93750c80 Pin shoulda, 2.11.x changes it's API and deprecates a lot of macros. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3782 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 19:01:53 +00:00
Eric Davis 921b425b8e Accept key authentication to ProjectsController#index (for feeds). #5317 
Contributed by Greg Mefford

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3777 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 17:45:04 +00:00
Eric Davis d635fff3f5 Add ATOM auto discovery link to the Projects list. #5317 
Contributed by Greg Mefford

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3776 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 17:44:59 +00:00
Eric Davis 43fabab950 Fixed HTML validation errors 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3775 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 16:50:13 +00:00
Eric Davis f08b2a394d Unused variable 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3774 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 03:54:28 +00:00
Eric Davis cf334cee31 Refactor: extract test method 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3773 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 03:54:23 +00:00
Eric Davis c56c0f411c Fix a nil error when a Project cannot save attachments. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3772 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-19 03:54:17 +00:00
Eric Davis 759858d11d Add example url and author url to the plugin generator. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3771 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-17 19:02:13 +00:00
Eric Davis 1a145dca25 Plugin models and controllers must be unloadable. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3770 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-17 19:02:07 +00:00
Eric Davis 28519714e0 Updated the project calendar for greater accessibility. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3769 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-15 23:20:32 +00:00
Eric Davis f18c0c790b Ignore rubinius .rbc files 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3768 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-09 22:01:21 +00:00
Eric Davis 345301284a Added JSON support to the issues API. #1214 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3766 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-05 03:52:59 +00:00
Eric Davis f484fe8556 Convert tests to shoulda 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3765 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-06-05 03:52:53 +00:00
Eric Davis e94c45d548 Add an "Assigned To" keyword to receiving email. #5594 
Will take a user's email address, login, or full name.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3764 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-29 00:05:24 +00:00
Eric Davis 080dc2212e Add 'Start date' and 'End date' keywords for incoming email. #5595 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3763 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-28 23:45:45 +00:00
Eric Davis 1a4b23731f Include the Project name when sorting versions. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3761 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-27 17:16:15 +00:00
Eric Davis f3cc84b343 Show subproject versions on the Roadmap. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3760 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-27 17:16:10 +00:00
Eric Davis e5ac73b7dc Somehow ran out of unique identifiers. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3759 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-27 17:16:05 +00:00
Eric Davis 6e529f82a7 Make the Gantt zoom images more accessible 
* Correct the alt text
* Add text links next to the images
* Size the images in em to support browser scaling

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3757 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-26 22:48:35 +00:00
Eric Davis ab4bdc379e Refactor: extract gantt zoom links to a helper. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3756 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-26 22:48:17 +00:00
Eric Davis c3c3460e0d Add the page title when editing /my/page. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3755 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-26 21:52:03 +00:00
Eric Davis e320017cf0 Convert the file attachment's description to a label. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3750 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-25 00:11:58 +00:00
Eric Davis 0d34c3731b Add error messages to MembersController#new so a user is informed of missing data. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3749 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-24 20:21:16 +00:00
Eric Davis f97ff28628 Invalid HTML 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3748 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-24 20:21:08 +00:00
Eric Davis 52a92b1822 Added a missing label to my/page_layout. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3747 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-24 18:23:42 +00:00
Eric Davis 51d3f51159 Added missing labels to the Issue Calendar. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3746 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-24 18:07:43 +00:00
Eric Davis 908d44519c Allow AuthSources to control if they allow password changes. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3745 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-23 03:16:37 +00:00
Eric Davis 715c9d16ef Refactor AuthSourcesController to support non-LDAP sources. #1131 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3744 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-23 03:16:31 +00:00
Eric Davis a1f73c8b20 Remove hard coded LDAP log message. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3743 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-23 03:16:25 +00:00
Eric Davis a7b80fcc06 Use present? instead of any?. Handles nil case. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3736 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-14 17:15:09 +00:00
Eric Davis 36c82ecc1f Refactor: move Project Calendar to it's own controller. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3732 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-05-03 16:02:37 +00:00
Eric Davis 306ca5e714 Refactor: Pull up #find_optional_project to ApplicationController. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3716 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-30 17:24:11 +00:00
Eric Davis 7ccdaee110 Only copy visible issues. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3698 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-29 23:26:52 +00:00
Eric Davis 488879d9cf Refactor: pull #query_statement_invalid up to ApplicationController. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3696 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-29 15:19:19 +00:00
Eric Davis e65c3cfc7d Refactor: Move gantts to a separate controller. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3695 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-28 15:54:46 +00:00
Eric Davis df7edb843b Refactor: move method to helper. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3691 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-27 15:28:52 +00:00
Eric Davis dfc448030d Refactor: extract error to new method with before_filter. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3690 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-26 15:08:06 +00:00
Eric Davis 23f097e344 Refactor: Extract duplicated code to a new method. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3689 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-23 15:05:13 +00:00
Eric Davis 2c898d8a81 Refactor: Split IssuesController#new to #new and #create to match REST pattern. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3688 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-22 15:43:57 +00:00
Eric Davis 9b595c689d Refactor: Move the rest of the routing tests to RoutingTest. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3687 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-21 16:02:55 +00:00
Eric Davis 0fc884cf42 Move more routing tests into the routing integration test. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3686 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-20 15:42:57 +00:00
Eric Davis 657aa624a4 Adding missing setter for Query#available_columns 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3685 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-20 15:42:52 +00:00
Eric Davis bf33b57aa4 Refactor: Move method to Query model 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3684 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-19 15:08:28 +00:00
Eric Davis 538642c5c4 Let custom field formats control how they are edited. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3675 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-16 15:34:05 +00:00
Eric Davis 4cb943571a Change the case statement into a method call based on the name 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3674 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-16 15:34:00 +00:00
Eric Davis d22723ed04 Refactor: Move method 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3673 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-16 15:33:55 +00:00
Eric Davis 88db9d0bdc Replace the hardcoded CustomField::FIELD_FORMATS with a class. 
Custom Field Formats are now full objects and can be registered with
Redmine::CustomFieldFormat to add new formats.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3672 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-16 15:33:49 +00:00
Eric Davis 6a6f403978 Added missing Enumeration STI exemplars. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3670 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-13 05:57:27 +00:00
Eric Davis 3979224693 Removed count from issues.xml. It causes a typecast error in ActiveResource. (#4745) 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3631 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-10 07:30:06 +00:00
Eric Davis f3e3752759 Added rake task to generate the yardoc (rake yard) 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3630 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-04-09 23:42:41 +00:00
Eric Davis 6e6e260cea Refactor: Extract Query#sortable_columns from the controller. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3604 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-19 15:42:03 +00:00
Eric Davis b5d9a1dfbd Refactor: Extract method to the Member model 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3601 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-18 15:49:11 +00:00
Eric Davis 194dab8e96 Refactor: Change the different find_object filters to share a common method. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3597 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-17 15:41:58 +00:00
Eric Davis 0f999ef0e0 Fixes undefined method 'notes' error from r3594 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3596 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-17 04:13:05 +00:00
Eric Davis e6c8760ad7 Refactor: Split the find_object methods to prep for a larger refactoring. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3591 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-16 15:17:47 +00:00
Eric Davis c7c3c0cc7c Refactor: Extract method for setting the flash on bulk issue saves. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3560 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-11 16:34:08 +00:00
Eric Davis ddaa95523a Use assert_select to check the download link. (#4204) 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3558 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-10 05:38:58 +00:00
Eric Davis 22c1e2b8cf Adds named scopes to replace custom finders. 
* Adds watched_by class method in ActsAsWatchable
* Adds Issue#recently_updated, Issue#with_limit and Issue#on_active_project

  #2482

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3557 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-10 05:10:43 +00:00
Eric Davis c07696b578 Refactor: Remove duplicated case statements. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3554 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-08 16:47:57 +00:00
Eric Davis 43e3c43cbd Refactor: Extract similar logic in IssuesHelper#show_detail to a new method. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3553 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-08 16:47:52 +00:00
Eric Davis 1a73f8fa0f Added unit tests for IssuesHelper#show_detail 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3552 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-08 16:47:47 +00:00
Eric Davis d65922afde Remove double negative condition 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3546 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-05 17:25:51 +00:00
Eric Davis 3f3e30c2aa Refactor: Moved the contents of #issue_update into Issue. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3545 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-05 17:11:50 +00:00
Eric Davis c58dc83e74 Refactor: Replace @journal with @issue.current_journal 
This removes an instance variable in #issue_update which will let it be moved
to the Issue model.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3540 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-04 16:18:51 +00:00
Eric Davis 7514e12d33 Hide the main menu div if there isn't any items for it. #3259 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3539 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-04 06:01:05 +00:00
Eric Davis afdcd770dc Refactor: Extract method 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3538 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-04 05:33:54 +00:00
Eric Davis bc79caaf69 Refactor: Extract method 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3537 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-04 05:33:49 +00:00
Eric Davis be20d98040 Refactor: Extract methods to before_filters 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3536 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-04 05:33:45 +00:00
Eric Davis 3a99f18913 Refactor: Split method 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3535 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-04 05:33:40 +00:00
Eric Davis ca6df3d78d Refactor: Extract method 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3534 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-04 05:33:35 +00:00
Eric Davis 976cba0c5d Refactor: use the existing Issue#new_statuses_allowed_to method. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3533 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-04 00:58:52 +00:00
Eric Davis fe1e3ccd18 Refactor: Decouple failed attachments and the flash messages 
Attachment#attach_files will no longer need to return a flash message,
instead it will put unsaved attachments into object#unsaved_attachments
where the calling object can access them.

A utility method #render_attachment_warning_if_needed is included for setting
the standard flash warning.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3528 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-03 17:05:00 +00:00
Eric Davis 44955a519c Added test for when an attachment fails to save. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3527 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-03 17:04:55 +00:00
Eric Davis f6d8752e44 Fixes destroying attachments if the update fails. (r2875 r3523) 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3526 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-03 17:04:50 +00:00
Eric Davis 3c0c0a7677 Allow multiple selected projects in #project_tree_options_for_select 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3525 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-03 03:37:40 +00:00
Eric Davis 0fd7e2d696 Refactor: Moved ApplicationController#attach_files to the Attachment model 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3523 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-02 19:26:03 +00:00
Eric Davis 81d617cd5b Fixes failing tests from r3521 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3522 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-02 19:25:58 +00:00
Eric Davis f5f5a5f64f Verify issues are updated by HTTP PUT only. Regression from r3486. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3520 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-01 18:29:18 +00:00
Eric Davis 8699e5bbcd Refactor: Decouple building Issue and TimeEntry objects in #issue_update. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3519 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-03-01 17:40:54 +00:00
Eric Davis ddec53b9a2 Refactor: Extracted saving logic out of #update and into a utility method 
Now #issue_update can be refactored and push to the Model(s) while keeping
the public interface (#update) clean.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3497 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-26 16:16:18 +00:00
Eric Davis 3de1f2e157 Refactor: Extracted the duplication from the last commit into a new method 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3487 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-25 17:01:10 +00:00
Eric Davis c68d853bf4 Refactor: Move the updating of an Issue to the #update method. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3486 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2010-02-25 17:01:05 +00:00