Commit Graph
100 Commits
Author SHA1 Message Date
Eric Davis 4425acafff Setup shoulda for testing. (#4005)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2925 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-10-17 20:37:23 +00:00
Eric Davis bcbf08017a Upgrade the Engines plugin to get the bugfix for Rails::Plugin::GemLocator
This update will allow Rails Engines to be installed as gems.  For example:

    # config/environment.rb
    Rails::Initializer.run do |config|
      ...
      config.gem 'timesheet_plugin'
    end

Will load the timesheet_plugins's RubyGem and allow it to work as if it was
installed to vendor/plugins.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2904 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-10-07 16:43:50 +00:00
Eric Davis 19df1b636c Fixed a bug where the form would POST causing a routing error. (#3918)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2902 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-09-25 00:39:02 +00:00
Eric Davis 7b0cb6aba8 Upgraded to Rails 2.3.4 (#3597)
* Ran the Rails upgrade
* Upgraded to Rails Engines 2.3.2
* Added a plugin to let Engines override application views.
* Converted tests to use the new classes:
** ActionController::TestCase for functional
** ActiveSupport::TestCase for units
* Converted ActiveRecord::Error message to a string.
* ActiveRecord grouping returns an ordered hash which doesn't have #sort!
* Updated the I18n storage_units format.
* Added some default initializers from a fresh rails app
* Changed the order of check_box_tags and hidden_field_tags.  The hidden tag
  needs to appear first in Rails 2.3, otherwise it will override any value in
  the check_box_tag.
* Removed the custom handler for when the cookie store is tampered with.
  Rails 2.3 removed the TamperedWithCookie exception and instead Rails will not
  load the data from it when it's been tampered with (e.g. no user login).
* Fixed mail layouts, 2.3 has problems with implicit multipart emails that
  use layouts.  Also removed some custom Redmine mailer code.
* Fixed a bug that occurred in tests where the "required" span tag would be
  added to the :field_status translation.  This resulted in an email string of:

    <li>Status<span class="required"> *</span><span class="required"> *</span>

  Instead of:

    <li>Status: New</li>

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2887 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-09-13 17:14:35 +00:00
Eric Davis 847c7367b4 Added plugin hook, :view_projects_show_sidebar_bottom
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2866 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-09-12 00:08:38 +00:00
Eric Davis 677d1769d6 Reset the default language for the test, autotest was caught it staying at :no
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2855 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-09-04 03:24:20 +00:00
Eric Davis 609faba6a3 Allow referencing issue numbers in brackets. This style is used by other
bug trackers.

Examples:

* "[#nnn] Worked on this issue"
* "[#nnn, #mmm] Worked on these"
* "[#nnn #mmm] Working some more"

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2854 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-09-03 01:21:11 +00:00
Eric Davis cd1e094ce8 Missing 'test_' prefix on a helper test caused it to not run.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2853 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-09-03 01:03:10 +00:00
Eric Davis 71abeb5898 Add some margin to journal notes if Gravatars are enabled. (#3771)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2848 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-09-01 04:09:32 +00:00
Eric Davis c28b044d68 Added branch and tag support to the git repository viewer. (#1406)
Many thanks to Adam Soltys and everyone else who tested this patch.

* Updated git test repository so it has a branch with some differences from the master branch
* Moved redmine diff class into a module so as not to clash with diff-lcs gem which is required by grit
* Find changesets from all branches, not just master
* Got revision browsing working
* Got file actions working properly
* Allow browsing by short form of commit identifier
* Added a method to retrieve repository branches
* Allow browsing by branch names as well as commit numbers
* Handle the case where a git repository has no master branch
* Expand revision box and handle finding revisions by first 8 characters
* Added branches dropdown to repository show page
* Combined repository browse and show into a single action.  Moved branch/revision navigation into a partial.
* Renamed partial navigation -> breadcrumbs
* Made it so latest revisions list uses branch and path context
* Preserve current path when changing branch or revision
* Perform slightly more graceful error handling in the case of invalid repository URLs
* Allow branch names to contain periods
* Allow dashes in branch names
* Sort branches by name
* Adding tags dropdown
* Need to disable both branches and tags dropdowns before submitting revision form
* Support underscores in revision (branch/tag) names
* Making file history sensitive to current branch/tag/revision, adding common navigation to changes page
* Updated translation files to include labels for 'branch', 'tag', and 'view all revisions'
* Reenable fields after submit so they don't look disabled and don't stay disabled on browser back button
* Instead of dashes just use empty string for default dropdown value
* Individual entry views now sport the upgraded revision navigation
* Don't display dropdowns with no entries
* Consider all revisions when doing initial load
* Fixed bug grabbing changesets.  Thanks to Bernhard Furtmueller for catching.
* Always check the entire log to find new revisions, rather than trying to go forward from the latest known one
* Added some cleverness to avoid selecting the whole changesets table any time someone views the repository root
* File copies and renames being detected properly
* Return gracefully if no revisions are found in the git log
* Applied patch from Babar Le Lapin to improve Windows compatibility

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2840 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-08-15 22:41:40 +00:00
Eric Davis a39bc8f1f4 Adding .gitignore based on the svn-ignores.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2839 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-08-15 19:27:49 +00:00
Eric Davis 30526d55c3 Added missing fixture file from r2837 (#3731)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2838 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-08-13 16:57:36 +00:00
Eric Davis 9886827a66 Allow spaces between the keyword and colon in incoming mail. (#3731)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2837 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-08-12 23:26:32 +00:00
Eric Davis ff0e5b019c Fixed missing translation for 'field_issue_to', the translation files ended in _id.
#3678

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2835 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-08-02 04:55:16 +00:00
Eric Davis 9ed048dc42 Include the issue status in search results and the Activity page. (#3700)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2834 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-08-02 04:36:06 +00:00
Eric Davis 06ff26f092 Enable SSL gravatars when Redmine is using https. (#2718)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2833 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-08-02 04:19:49 +00:00
Eric Davis 560e915c50 Upgraded the gravatar plugin from http://github.com/woods/gravatar-plugin
This will update the gravatar.com url (#2921) and provide support for SSL
gravatars (#2718).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2832 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-08-02 04:19:44 +00:00
Eric Davis bb61c9a0ec Added two new plugin hooks to Administration > Users > Memberships
* view_users_memberships_table_header
* view_users_memberships_table_row

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2829 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-08-01 18:14:39 +00:00
Eric Davis 26bbad5f23 Switch from a custom rcov task to the metric_fu gem.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2825 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-07-27 00:55:43 +00:00
Eric Davis 1a9942ba99 Change subversion adapter to not cache authentication and run non interactively
#3424

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2819 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-07-10 03:24:46 +00:00
Eric Davis a9ee946053 Change links to closed issues to be a grey color. (#3495)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2818 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-07-10 03:03:13 +00:00
Eric Davis 2221d68c4d Added workaround for a Ruby BigDecimal bug, CVE-2009-1904. (#3475)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2790 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-06-14 16:22:23 +00:00
Eric Davis 724cf47605 Added the Rails i18n language file to the plugin generator.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2785 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-06-10 03:39:02 +00:00
Eric Davis 97383f78d0 Added an empty tmp/test directory so rake test will run out of the box.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2784 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-06-08 02:07:30 +00:00
Eric Davis 199b213bbb Converted script/about to use Unix line ending. It has DOS line endings and would fail.
(#3387)

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2783 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-06-07 18:22:27 +00:00
Eric Davis 62e58f26b0 Changed Enumerations to use a Single Table Inheritance
* Added migrations to change Enumerations to an STI relationship
* Added TimeEntryActivity model (STI)
* Added DocumentCategory model (STI)
* Added IssuePriority model (STI)
* Added Enumeration#get_subclasses to get a list of the subclasses of Enumeration
* Changed Enumeration to use the STI type field instead of the opt field
* Changed Enumeration#opt to return the old opt values but with a deprecation warning.
* Removed Enumeration::OPTIONS
* Removed the dynamic named_scopes in favor of specific named_scopes.  Kept for
  compatibility reasons.
* Added Enumeration#default so each subclass can easily find it's default record.
* Fixed Enumeration#default to use the STI scoping with a fake default scope for finding Enumeration's default.
* Added a 'all' named scope for getting all records in order by position.
* Added Deprecation warnings to the old named_scopes in Enumerations.
* Moved various methods off of Enumeration and onto the concrete classes
* Changed the EnumerationsController to use types
* Updated the Enumeration list template
* Added has_many relationships to the Enumeration STI classes.
* Fixes for tests.

  #3007

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2777 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-05-30 23:30:36 +00:00
Eric Davis fbfb349496 Added Redmine::Info.issue to get links to specific issue numbers.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2776 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-05-30 23:00:22 +00:00
Eric Davis 211b13c9ec Added plugin hook, :controller_timelog_edit_before_save. (#3341)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2775 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-05-30 22:49:39 +00:00
Eric Davis 4ba8308507 Added more plugin hooks:
* :controller_messages_new_after_save
* :controller_messages_reply_after_save
* :controller_wiki_edit_after_save

  #3306

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2774 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-05-30 22:43:01 +00:00
Eric Davis ea7ff8dd76 Added hook, :model_changeset_scan_commit_for_issue_ids_pre_issue_update. #3279
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2773 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-05-30 22:34:27 +00:00
Eric Davis 3224773ada Added two plugin hooks to the account page:
* :view_account_left_bottom
* :view_account_right_bottom

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2772 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-05-30 22:09:49 +00:00
Eric Davis 964245e30a Added :view_versions_show_contextual hook. (#3036)
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2771 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-05-30 21:57:47 +00:00
Eric Davis 68c7af6c91 Fixed failing test in #3391. Quotes (") are html escaped.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2770 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-05-30 21:47:10 +00:00
Eric Davis 6bdd07275b Fixed an interpolation argument error in nl.yml
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2757 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-05-17 18:10:28 +00:00
Eric Davis 0985d4219c Link projects and users in the issue list.
#3086

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2713 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-05-06 04:47:20 +00:00
Eric Davis f90b85f8be Link the project name in simple issue lists.
#3085

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2712 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-05-06 04:47:13 +00:00
Eric Davis fa7bd1c71d Added the ability to copy a project in the Project Administration panel.
* Added Copy project button.
* Added Project#copy_from to duplicate a project to be modified and saved by the user
* Added a ProjectsController#copy based off the add method
** Used Project#copy_from to create a duplicate project in memory
* Implemented Project#copy to copy data for a project from another and save it.
** Members
** Project level queries
** Project custom fields
* Added a plugin hook for Project#copy.

  #1125  #1556  #886  #309

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2704 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-05-03 21:25:37 +00:00
Eric Davis 5ab582387e Added some new view hooks to the welcome page.
* :view_welcome_index_left
* :view_welcome_index_right

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2687 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-04-24 21:25:10 +00:00
Eric Davis 1be0b8f0cb Added two new plugin hooks to the Project Overview page
* :view_projects_show_left
* :view_projects_show_right

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2686 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-04-24 21:25:03 +00:00
Eric Davis b4be8849c0 Added observers to watch model objects for mail delivery instead of calling Mailer.
* Added an IssueObserver to watch when Issues are created
* Added a JournalObserver to watch when Journals are created (Issue updates)
* Added a NewsObserver for News items.
* Added a DocumentObserver for Document notifications.
* Setup IssuesController#new to use the IssueObserver.
* Setup IssuesController#edit to use the IssueObserver.
* Setup IssuesController#bulk_edit to use the JournalObserver.
* Removed the Mailer call in Changeset#scan_commit_for_issue_ids, the
  JournalObserver will handle it.
* Removed Mailer calls in MailHandler in favor of the Observers.

  #2659

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2637 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-03-28 00:38:57 +00:00
Eric Davis c2dfffd7f2 Added some RDoc documentation for some models.
Submitted by austenito on Github.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2612 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-03-21 00:39:53 +00:00
Eric Davis 451ef7f21f Added several more plugin hooks:
* :controller_custom_fields_new_after_save
* :controller_custom_fields_edit_after_save
* :view_custom_fields_form_upper_box
* :view_custom_fields_form_* (type of custom field)
* :view_issue_statuses_form
* :view_issues_show_description_bottom
* :view_my_account
* :view_users_form

  #2599

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2611 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-03-21 00:22:59 +00:00
Eric Davis b67d624754 Added plugin hooks to the context menu
* :view_issues_context_menu_start
* :view_issues_context_menu_end

  #3013

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2610 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-03-21 00:01:48 +00:00
Eric Davis e48cc150ec Added a plugin hook for :controller_account_success_authentication_after
#3019

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2609 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-03-20 23:52:42 +00:00
Eric Davis 40a039ce1c Updated INSTALL doc for Rails 2.2.2
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2600 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-03-19 03:34:45 +00:00
Eric Davis 7774642b03 Extend the settings.name column so it can fit longer plugin names.
#3010

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2599 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-03-19 00:01:24 +00:00
Eric Davis 4baf32b166 Fixing Plugin and Mailer default_url_options.
Both the plugin hooks and Mailer were setting default_url_options incorrectly
and causing ActionContoller::UrlWritter to cache the settings on the module
(mattr_accessor) causing several url generators to fail in either the plugin
hooks or the Mailer.

* Replaced Mailer's use of the default_url_options accessor with the proper class method
* Replaced Hook's use of the default_url_options accessor with the proper class method on the ViewListener class
* Added a test to reproduce the bugs in the Mailer when a hook is registered (thanks Chaoqun Zou)

  #2542

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2522 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-25 07:25:01 +00:00
Eric Davis 9a986ac0a5 Refactored the mess known as Hook default_url_options in favor of the simpler
:only_path as suggested by splatteal on GitHub.

  #2542

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2491 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-21 00:23:28 +00:00
Eric Davis 00b568c194 Implementing the missing tests now that HookTest has a cleaner setup.
Controller and Views are now tested through the Redmine::Hook::Helper module.

  #2542

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2490 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-21 00:23:22 +00:00
Eric Davis b6c4b21b47 Refactored the HookTest methods to use Redmine::Hook::Helper instead
of the Redmine::Hook class directly.  Redmine::Hook::Helper is the
public API so it should be one that is tested.

  #2542

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2489 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-21 00:23:16 +00:00
Eric Davis 3fa9535670 List the Default Columns displayed on the issue list vertically
instead of horizontally so it's easier to read.

  #2745

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2488 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-20 22:59:59 +00:00
Eric Davis befe278fa9 Allow the other format links to appear on the issue list (ATOM, PDF, CSV).
#2779

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2487 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-20 22:45:16 +00:00
Eric Davis 24ee6b9a1b Fixed the bug in the OpenID registration where the form wouldn't take a login
AccountController#open_id_authenticate was adding an auth_source_registration
to the session which caused AccountController#register to use the wrong codepath.

  #2757

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2483 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-20 00:31:50 +00:00
Eric Davis aed1787d51 Fixed a bug in the OpenID login when a user signed up with OpenID but hasn't
been activated yet.

When logging in the user would come back to the login page with the back_url
of My Page.  This was caused by open_id_authenticate sending the user to My Page
and My Page redirecting the user back to the login page because they haven't
been activated.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2482 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-20 00:16:45 +00:00
Eric Davis 60dc357271 Normalize the identity_url when it's set.
OpenId uses a specific format for the url it uses which requires the protocol
and trailing slash.  This change will normalize the value to when a user sets it.

  #699

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2453 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-12 04:31:28 +00:00
Eric Davis 14e445c600 Fixed the bundled ruby-openid gem
* The open_id_authentication plugin will require the gem automatically so
  it doesn't need to be added to environment.rb
* Changed the version requirement on the open_id_authentication to match
  the latest stable version.  Rails config.gem looks for a directory named
  after that specific version and will not load newer versions.

  #699

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2452 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-12 01:32:50 +00:00
Eric Davis f1b8bf22a2 Added a space so words don't runtogeatherlikethis. #699
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2450 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:45:53 +00:00
Eric Davis 8d53e433c5 Added a system setting for allowing OpenID logins and registrations
* Defaults to off
* Is set in the Administration panel under Authentication

  #699

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2449 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:24:28 +00:00
Eric Davis 85ad791d81 Prevent registration via OpenID if self registration is off. #699
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2448 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:07:41 +00:00
Eric Davis 720f928cd2 Refactored common methods out of register and open_id_authenticate
* Extracted register_by_email_activation
* Extracted register_automatically
* Extracted register_manually_by_administrator

  #699

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2447 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:07:34 +00:00
Eric Davis 8194cfaf86 Added user setup needed based on the system's registration settings
* Copied the register action's chunk of code used to setup the account
  based on Setting.self_registration
* Extracted method for when onthefly_creation_failed
* Added tests to confirm the behavior

  #699

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2446 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:07:28 +00:00
Eric Davis 876fb69271 Added tests for the other OpenID authentication cases. #699
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2445 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:07:23 +00:00
Eric Davis 48e26aa75b Adding OpenID mock and test. #699
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2444 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:07:18 +00:00
Eric Davis 0310f43126 Hooked up on the fly OpenID user creation.
* Use OpenID registration fields for the user.
* Generate a random password when a user is created.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2443 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:07:12 +00:00
Eric Davis 896e64b759 Added the ability to login via OpenID.
* Refactored AccountController#login to use either
  password or openid based authentication
* Extracted AccountController#successful_authentication
  to setup a user's session cookies and redirect
* Implemented the start of AccountController#open_id_authentication
  which will check with the OpenID server and perform authentication.
* Added text field for the OpenID url to /login
* Added identity_url for OpenID to the user forms.
* Added option to login with OpenID to the register form.
* Added a root url route, which is used by the OpenID plugin

  #699

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2442 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:07:07 +00:00
Eric Davis a4e6e13b70 Fixed a bug in open_id_authentication, where relative_url_root is defined
on ActionController:AbstractRequest not Base

  #699

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2441 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:07:00 +00:00
Eric Davis dbf02e2654 Added identity_url to User. #699
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2440 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:06:55 +00:00
Eric Davis ca3960dee5 Added OpenID tables. #699
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2439 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:06:50 +00:00
Eric Davis 30171f3ab6 Added open_id_authentication plugin
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2438 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:06:45 +00:00
Eric Davis f70be197e0 Unpacked OpenID gem. #699
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2437 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-11 19:06:37 +00:00
Eric Davis b75a30a21a Renamed variables to be more descriptive. #2542
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2430 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-10 03:12:45 +00:00
Eric Davis 5b7a5c39a7 Added request and controller objects to the hooks by default.
The request and controller objects are now added to all hook contexts by
default.  This will also make url_for work better in hooks by setting up
the default_url_options :host, :port, and :protocol.

Finally a new helper method @render_or@ has been added to ViewListener.  This
will let a hook easily render a partial without a full method definition.

Thanks to Thomas Löber for the original patch.  #2542

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2429 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-10 03:12:40 +00:00
Eric Davis a3fa56d988 Added two new plugin hooks:
* :view_layouts_base_sidebar
* :view_layouts_base_content

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2428 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-10 01:24:32 +00:00
Eric Davis 0d01e07430 Added plugin hook :view_projects_roadmap_version_bottom. #2543
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2427 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-02-10 01:18:49 +00:00
Eric Davis 0bbebedada Fixed clearing the Issue filters in the issue list, broken by #2317
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2325 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-27 20:59:02 +00:00
Eric Davis 2fc7897044 Fixes Issue sorting in a project, broken by #2317
Issues were sorting but the project id wasn't being added so the
IssuesController would return all issues (cross-project).


git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2324 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-27 20:42:19 +00:00
Eric Davis 765f7abc60 Converted routing and urls to follow the Rails REST convention.
Patch supplied by commits from Gerrit Kaiser on Github.  Existing routes will
still work (backwards compatible) but any new urls will be generated using the
new routing rules.

Changes listed below:

* made the URLs for some project tabs and project settings follow the new rails RESTful conventions of /collection/:id/subcollection/:sub_id
* prettier URL for project roadmap
* more nice project URLs
* use GET for filtering form
* prettified URLs used on issues tab
* custom route for activity atom feeds
* prettier repository urls
* fixed broken route definition
* fixed failing tests for issuecontroller that were hardcoding the url string
* more RESTful routes for boards and messages
* RESTful routes for wiki pages
* RESTful routes for documents
* moved old routes that are retained for compatibility to the bottom and grouped them together
* added RESTful URIs for issues
* RESTfulness for the news section
* fixed route order
* changed hardcoded URLs in tests
* fixed badly written tests
* fixed forgotten parameter in routes
* changed hardcoded URLS to new scheme
* changed project add url to the standard POST to collection
* create new issue by POSTing to collection
* changed hardcoded URLs in integrations tests
* made project add form work again
* restful routes for project deletion
* prettier routes for project (un)archival
* made routes table more readable
* fixed note quoting
* user routing
* fixed bug
* always sort by GET
* Fixed: cross-project issue list should not show issues of projects for which the issue tracking module was disabled.
* prettified URLs used on issues tab
* urls for time log
* fixed reply routing
* eliminate revision query paremeter for diff and entry actions
* fixed test failures with hard-coded urls
* ensure ajax links always use get
* refactored ajax link generation into separate method

  #1901


git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2317 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-26 01:47:51 +00:00
Eric Davis 75c10a1cac Added two new plugin hooks to IssuesController:
* :controller_issues_new_after_save
* :controller_issues_edit_after_save

  #2475


git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2261 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-12 04:52:56 +00:00
Eric Davis 17d455c72f Codified instructions from RUNNING_TESTS as rake tasks for convenience
Rake tasks are in testing.rake and can be run by `rake test:scm:setup:<scm>`
Updated RUNNING_TESTS

Contributed by Gerrit Kaiser


git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2260 e93f8b46-1217-0410-a6f0-8f06a7374b81
2009-01-12 04:44:01 +00:00
Eric Davis ce64a42250 Fixed a failing test caused by comparing a Time object (n.day.ago) with a Date object
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2141 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-18 07:10:23 +00:00
Eric Davis da98386bf7 Added plugin hooks around Journal editing
* :controller_journals_edit_post
* :view_journals_notes_form_after_notes
* :view_journals_update_rjs_bottom


git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2121 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-10 23:44:22 +00:00
Eric Davis cf77c93cb4 Added several useful hooks to the Issue sidebar
* :view_issues_sidebar_issues_bottom
* :view_issues_sidebar_planning_bottom
* :view_issues_sidebar_queries_bottom


git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2093 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-06 00:51:03 +00:00
Eric Davis 956437b7fe Final refactoring on Query#sql_for_field to rename v to value
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2092 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-05 22:56:13 +00:00
Eric Davis a464d26e73 Bit more refactoring on Query#sql_for_field to remove multiple returns
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2091 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-05 22:56:08 +00:00
Eric Davis ea77929d62 Refactor: Extracted new method Query#sql_for_field from Query#statement in
order to clean up Query#statement.


git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2090 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-05 22:56:03 +00:00
Eric Davis 996b2a5c1d Added :view_issues_history_journal_bottom hook
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2089 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-05 21:03:55 +00:00
Eric Davis 1b4f0c38ce Added :view_issues_edit_notes_bottom hook
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2087 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-03 23:18:12 +00:00
Eric Davis 5f9b1b0e0b Added :controller_issues_edit_before_save hook
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2086 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-12-03 23:18:07 +00:00
Eric Davis 9d810f0059 Changed the CSS clear on journals so they will wrap around the revisions. #2165
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2029 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-11-13 01:07:58 +00:00
Eric Davis 81eee10d5b Removing the custom Redmine hook in routes in favor of Engine's hook.
* Plugins' routes.rb are now added automatically to Redmine's routing,
  including the ability to override Redmine's default routing.

  Thank you to Jean-Baptiste Barth for the suggestion.  #2142


git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@1991 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-11-08 00:12:43 +00:00
Eric Davis 8b3a8ac1b4 Included Redmine::Hook::Helper to ActionController::Base so call_hook
is available in all controllers. #2111


git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@1979 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-11-06 05:37:29 +00:00
Eric Davis b1cb9cd3bd Added :view_projects_form plugin hook
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@1978 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-11-04 18:27:13 +00:00
Eric Davis ba20a67873 Added an option to turn user Gravatars on or off
* Option can be found in Administration > General, called
  "Use Gravatar user icons"
* Defaulting Gravatars to off
* Added a helper gravatar_for_mail to check the setting before rendering
  the Gravatar.

  #1776


git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@1972 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-10-31 00:41:28 +00:00
Eric Davis 048fa5bd77 Tighened up the gravator CSS in the issue div
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@1971 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-10-31 00:19:48 +00:00
Eric Davis 3bc2a5cf2f Tweaking of the CSS for the gravatars. #1776
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@1970 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-10-31 00:09:36 +00:00
Eric Davis 41dba2db86 Link the version name to VersionsController#show in the issue list.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@1969 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-10-30 03:49:04 +00:00
Eric Davis e85a9f8609 Fixed typo in an English string, 'View calender'
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@1968 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-10-30 03:29:30 +00:00
Eric Davis b84dd8ec83 Added gravatar image to the user's public account page
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@1967 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-10-30 02:58:34 +00:00
Eric Davis 01fd8e685b Fixed a bug with using gravatar on a nil value.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@1966 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-10-30 02:58:28 +00:00
Eric Davis 1a6595aa17 Reduced the size of the gravatar on the issue history
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@1965 e93f8b46-1217-0410-a6f0-8f06a7374b81
2008-10-30 02:58:23 +00:00