don't use localhost as the HELO on outgoing SMTP connections

It can be configured using `dns.helo_hostname` or will be set to `dns.smtp_server_hostname`

Related to #19
This commit is contained in:
Adam Cooke
2017-04-27 09:49:53 +01:00
parent 2ad3eb92aa
commit 4de6dc20e6
2 changed files with 6 additions and 1 deletions
+1
View File
@@ -68,6 +68,7 @@ dns:
return_path: rp.postal.example.com
route_domain: routes.postal.example.com
track_domain: track.postal.example.com
helo_hostname: # By default, this will be the same as the `smtp_server_hostname`
dkim_identifier: postal
domain_verify_prefix: postal-verification
custom_return_path_prefix: psrp
+5 -1
View File
@@ -57,7 +57,7 @@ module Postal
else
# Nothing
end
smtp_client.start(@source_ip_address ? @source_ip_address.hostname : "localhost")
smtp_client.start(@source_ip_address ? @source_ip_address.hostname : self.class.default_helo_hostname)
log "Connected to #{@remote_ip}:#{port} (#{hostname})"
rescue => e
log "Cannot connect to #{@remote_ip}:#{port} (#{hostname}) (#{e.class}: #{e.message})"
@@ -244,5 +244,9 @@ module Postal
end
end
def self.default_helo_hostname
Postal.config.dns.helo_hostname || Postal.config.dns.smtp_server_hostname || "localhost"
end
end
end