[-] Fix: OrderHistory::changeIdOrderState

&$id_order break compatibility with existing codes :

1/ it's unnecessary : Objects are passed by references by default
2/ it causes fatal errors: 
```PHP
$foo->changeIdOrderState((int)$id_order_state, (int)$id_order);
```
Fatal error: Only variables can be passed by reference
This commit is contained in:
Shagshag committed 2013-01-08 10:51:42 +01:00
1 parent e138fd239e
commit 868effab13
1 file changed
+2 -2
+2 -2
View File
@@ -70,10 +70,10 @@ class OrderHistoryCore extends ObjectModel
* Sets the new state of the given order * Sets the new state of the given order
* *
* @param int $new_order_state * @param int $new_order_state
* @param int $id_order * @param int/object $id_order
* @param bool $use_existing_payment * @param bool $use_existing_payment
*/ */
public function changeIdOrderState($new_order_state, &$id_order, $use_existing_payment = false) public function changeIdOrderState($new_order_state, $id_order, $use_existing_payment = false)
{ {
if (!$new_order_state || !$id_order) if (!$new_order_state || !$id_order)
return; return;