From 868effab13cf9c1058418f2b2a1842ce6aa7d070 Mon Sep 17 00:00:00 2001 From: Shagshag Date: Tue, 8 Jan 2013 10:51:42 +0100 Subject: [PATCH] [-] Fix: OrderHistory::changeIdOrderState &$id_order break compatibility with existing codes : 1/ it's unnecessary : Objects are passed by references by default 2/ it causes fatal errors: ```PHP $foo->changeIdOrderState((int)$id_order_state, (int)$id_order); ``` Fatal error: Only variables can be passed by reference --- classes/order/OrderHistory.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/classes/order/OrderHistory.php b/classes/order/OrderHistory.php index 43b425548..0b0489713 100644 --- a/classes/order/OrderHistory.php +++ b/classes/order/OrderHistory.php @@ -70,10 +70,10 @@ class OrderHistoryCore extends ObjectModel * Sets the new state of the given order * * @param int $new_order_state - * @param int $id_order + * @param int/object $id_order * @param bool $use_existing_payment */ - public function changeIdOrderState($new_order_state, &$id_order, $use_existing_payment = false) + public function changeIdOrderState($new_order_state, $id_order, $use_existing_payment = false) { if (!$new_order_state || !$id_order) return;