From cd957cf52b7e10400c32b26a04e2fe740d1ff86a Mon Sep 17 00:00:00 2001 From: Alfonso de la Guarda Reyes Date: Sat, 5 Oct 2013 07:59:04 -0500 Subject: [PATCH] Fixes for some pep and code syntax --- gluon/admin.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/gluon/admin.py b/gluon/admin.py index f22c64f0..0661d80e 100644 --- a/gluon/admin.py +++ b/gluon/admin.py @@ -353,7 +353,7 @@ def plugin_install(app, fobj, request, filename): return False -def check_new_version(myversion, version_URL): +def check_new_version(myversion, version_url): """ Compares current web2py's version with the latest stable web2py version. @@ -374,7 +374,7 @@ def check_new_version(myversion, version_URL): """ try: from urllib import urlopen - version = urlopen(version_URL).read() + version = urlopen(version_url).read() pversion = parse_version(version) pmyversion = parse_version(myversion) except IOError: @@ -398,7 +398,7 @@ def unzip(filename, dir, subfolder=''): raise RuntimeError('Not a valid zipfile') zf = zipfile.ZipFile(filename) if not subfolder.endswith('/'): - subfolder = subfolder + '/' + subfolder += '/' n = len(subfolder) for name in sorted(zf.namelist()): if not name.startswith(subfolder): @@ -432,11 +432,11 @@ def upgrade(request, url='http://web2py.com'): web2py_version = request.env.web2py_version gluon_parent = request.env.gluon_parent if not gluon_parent.endswith('/'): - gluon_parent = gluon_parent + '/' + gluon_parent += '/' (check, version) = check_new_version(web2py_version, url + '/examples/default/version') if not check: - return (False, 'Already latest version') + return False, 'Already latest version' if os.path.exists(os.path.join(gluon_parent, 'web2py.exe')): version_type = 'win' destination = gluon_parent @@ -452,7 +452,6 @@ def upgrade(request, url='http://web2py.com'): full_url = url + '/examples/static/web2py_%s.zip' % version_type filename = abspath('web2py_%s_downloaded.zip' % version_type) - file = None try: write_file(filename, urllib.urlopen(full_url).read(), 'wb') except Exception, e: