From 7d5cdb9220976b1d96ef981d0ef4b5058ac6c80d Mon Sep 17 00:00:00 2001 From: ilvalle Date: Mon, 28 Oct 2013 10:17:47 +0100 Subject: [PATCH 1/3] fix for empty file in admin editor --- .../admin/static/codemirror/addon/fold/indent-fold.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/applications/admin/static/codemirror/addon/fold/indent-fold.js b/applications/admin/static/codemirror/addon/fold/indent-fold.js index b54da347..7ae005d9 100644 --- a/applications/admin/static/codemirror/addon/fold/indent-fold.js +++ b/applications/admin/static/codemirror/addon/fold/indent-fold.js @@ -1,8 +1,9 @@ CodeMirror.registerHelper("fold", "indent", function(cm, start) { var lastLine = cm.lastLine(), tabSize = cm.getOption("tabSize"), - firstLine = cm.getLine(start.line), - myIndent = CodeMirror.countColumn(firstLine, null, tabSize); + firstLine = cm.getLine(start.line); + if (!tabSize || !firstLine) return; + var myIndent = CodeMirror.countColumn(firstLine, null, tabSize); function foldEnded(curColumn, prevColumn) { return curColumn < myIndent || From 7675d605ea2cf7e321a771913bfa8ce747adf752 Mon Sep 17 00:00:00 2001 From: ilvalle Date: Tue, 29 Oct 2013 17:02:50 +0100 Subject: [PATCH 2/3] fix width after window resize --- applications/admin/views/default/edit.html | 25 +++++++--------------- 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/applications/admin/views/default/edit.html b/applications/admin/views/default/edit.html index 5c94de76..ae1baa41 100644 --- a/applications/admin/views/default/edit.html +++ b/applications/admin/views/default/edit.html @@ -39,24 +39,24 @@ - - - + + + From 1bbb99b5481976bf37b8df229b814160c1537f50 Mon Sep 17 00:00:00 2001 From: ilvalle Date: Tue, 29 Oct 2013 17:24:46 +0100 Subject: [PATCH 3/3] fix codemirror gutter managment --- applications/admin/views/default/edit.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/applications/admin/views/default/edit.html b/applications/admin/views/default/edit.html index ae1baa41..ceb3a18a 100644 --- a/applications/admin/views/default/edit.html +++ b/applications/admin/views/default/edit.html @@ -136,8 +136,8 @@ function update_editor(preferences) { editor.setOption("indentUnit", parseInt(preferences.tabwidth)); editor.setOption("tabSize", parseInt(preferences.tabwidth)); editor.setOption("indentWithTabs", (preferences.indentwithtabs === 'true')); - if (preferences.linenumbers === 'true') { - gutters = editor.getOption("gutters"); + gutters = editor.getOption("gutters"); + if ( preferences.linenumbers === 'true' && $.inArray('CodeMirror-linenumbers', gutters) === -1 ) { gutters.splice(0, 0, 'CodeMirror-linenumbers'); editor.setOption("gutter", gutters); }