Fixes #1634 by adding a parameter "ignore_extension" to Request.restful which allows you to leave the args untouched if you set it to True.
This commit is contained in:
+2
-2
@@ -349,14 +349,14 @@ class Request(Storage):
|
|||||||
current.session.forget()
|
current.session.forget()
|
||||||
redirect(URL(scheme='https', args=self.args, vars=self.vars))
|
redirect(URL(scheme='https', args=self.args, vars=self.vars))
|
||||||
|
|
||||||
def restful(self):
|
def restful(self, ignore_extension=False):
|
||||||
def wrapper(action, request=self):
|
def wrapper(action, request=self):
|
||||||
def f(_action=action, *a, **b):
|
def f(_action=action, *a, **b):
|
||||||
request.is_restful = True
|
request.is_restful = True
|
||||||
env = request.env
|
env = request.env
|
||||||
is_json = env.content_type=='application/json'
|
is_json = env.content_type=='application/json'
|
||||||
method = env.request_method
|
method = env.request_method
|
||||||
if len(request.args) and '.' in request.args[-1]:
|
if not ignore_extension and len(request.args) and '.' in request.args[-1]:
|
||||||
request.args[-1], _, request.extension = request.args[-1].rpartition('.')
|
request.args[-1], _, request.extension = request.args[-1].rpartition('.')
|
||||||
current.response.headers['Content-Type'] = \
|
current.response.headers['Content-Type'] = \
|
||||||
contenttype('.' + request.extension.lower())
|
contenttype('.' + request.extension.lower())
|
||||||
|
|||||||
+72
-24
@@ -10,27 +10,76 @@ import re
|
|||||||
import unittest
|
import unittest
|
||||||
|
|
||||||
from gluon.globals import Request, Response, Session
|
from gluon.globals import Request, Response, Session
|
||||||
|
from gluon.rewrite import regex_url_in
|
||||||
from gluon import URL
|
from gluon import URL
|
||||||
from gluon._compat import basestring
|
from gluon._compat import basestring
|
||||||
|
|
||||||
|
|
||||||
def setup_clean_session():
|
def setup_clean_session():
|
||||||
request = Request(env={})
|
request = Request(env={})
|
||||||
request.application = 'a'
|
request.application = 'a'
|
||||||
request.controller = 'c'
|
request.controller = 'c'
|
||||||
request.function = 'f'
|
request.function = 'f'
|
||||||
request.folder = 'applications/admin'
|
request.folder = 'applications/admin'
|
||||||
response = Response()
|
response = Response()
|
||||||
session = Session()
|
session = Session()
|
||||||
session.connect(request, response)
|
session.connect(request, response)
|
||||||
|
from gluon.globals import current
|
||||||
|
current.request = request
|
||||||
|
current.response = response
|
||||||
|
current.session = session
|
||||||
|
return current
|
||||||
|
|
||||||
|
|
||||||
|
class testRequest(unittest.TestCase):
|
||||||
|
|
||||||
|
def setUp(self):
|
||||||
from gluon.globals import current
|
from gluon.globals import current
|
||||||
current.request = request
|
current.response = Response()
|
||||||
current.response = response
|
|
||||||
current.session = session
|
def test_restful_simple(self):
|
||||||
return current
|
env = {'request_method': 'GET', 'PATH_INFO': '/welcome/default/index/1.pdf'}
|
||||||
|
r = Request(env)
|
||||||
|
regex_url_in(r, env)
|
||||||
|
|
||||||
|
@r.restful()
|
||||||
|
def simple_rest():
|
||||||
|
def GET(*args, **vars):
|
||||||
|
return args[0]
|
||||||
|
return locals()
|
||||||
|
|
||||||
|
self.assertEqual(simple_rest(), '1')
|
||||||
|
|
||||||
|
def test_restful_calls_post(self):
|
||||||
|
env = {'request_method': 'POST', 'PATH_INFO': '/welcome/default/index'}
|
||||||
|
r = Request(env)
|
||||||
|
regex_url_in(r, env)
|
||||||
|
|
||||||
|
@r.restful()
|
||||||
|
def post_rest():
|
||||||
|
def POST(*args, **vars):
|
||||||
|
return 'I posted'
|
||||||
|
return locals()
|
||||||
|
|
||||||
|
self.assertEqual(post_rest(), 'I posted')
|
||||||
|
|
||||||
|
def test_restful_ignore_extension(self):
|
||||||
|
env = {'request_method': 'GET', 'PATH_INFO': '/welcome/default/index/127.0.0.1'}
|
||||||
|
r = Request(env)
|
||||||
|
regex_url_in(r, env)
|
||||||
|
|
||||||
|
@r.restful(ignore_extension=True)
|
||||||
|
def ignore_rest():
|
||||||
|
def GET(*args, **vars):
|
||||||
|
return args[0]
|
||||||
|
return locals()
|
||||||
|
|
||||||
|
self.assertEqual(ignore_rest(), '127.0.0.1')
|
||||||
|
|
||||||
|
|
||||||
class testResponse(unittest.TestCase):
|
class testResponse(unittest.TestCase):
|
||||||
|
|
||||||
#port from python 2.7, needed for 2.5 and 2.6 tests
|
# port from python 2.7, needed for 2.5 and 2.6 tests
|
||||||
def assertRegexpMatches(self, text, expected_regexp, msg=None):
|
def assertRegexpMatches(self, text, expected_regexp, msg=None):
|
||||||
"""Fail the test unless the text matches the regular expression."""
|
"""Fail the test unless the text matches the regular expression."""
|
||||||
if isinstance(expected_regexp, basestring):
|
if isinstance(expected_regexp, basestring):
|
||||||
@@ -99,8 +148,8 @@ class testResponse(unittest.TestCase):
|
|||||||
response.files.append(URL('a', 'static', 'css/file.css'))
|
response.files.append(URL('a', 'static', 'css/file.css'))
|
||||||
content = return_includes(response)
|
content = return_includes(response)
|
||||||
self.assertEqual(content,
|
self.assertEqual(content,
|
||||||
'<script src="https://code.jquery.com/jquery-1.11.3.min.js?var=0" type="text/javascript"></script>' +
|
'<script src="https://code.jquery.com/jquery-1.11.3.min.js?var=0" type="text/javascript"></script>' +
|
||||||
'<link href="/a/static/css/file.css" rel="stylesheet" type="text/css" />')
|
'<link href="/a/static/css/file.css" rel="stylesheet" type="text/css" />')
|
||||||
|
|
||||||
response = Response()
|
response = Response()
|
||||||
response.files.append(('js', 'http://maps.google.com/maps/api/js?sensor=false'))
|
response.files.append(('js', 'http://maps.google.com/maps/api/js?sensor=false'))
|
||||||
@@ -109,12 +158,11 @@ class testResponse(unittest.TestCase):
|
|||||||
response.files.append(URL('a', 'static', 'css/file.ts'))
|
response.files.append(URL('a', 'static', 'css/file.ts'))
|
||||||
content = return_includes(response)
|
content = return_includes(response)
|
||||||
self.assertEqual(content,
|
self.assertEqual(content,
|
||||||
'<script src="https://code.jquery.com/jquery-1.11.3.min.js?var=0" type="text/javascript"></script>' +
|
'<script src="https://code.jquery.com/jquery-1.11.3.min.js?var=0" type="text/javascript"></script>' +
|
||||||
'<link href="/a/static/css/file.css" rel="stylesheet" type="text/css" />' +
|
'<link href="/a/static/css/file.css" rel="stylesheet" type="text/css" />' +
|
||||||
'<script src="/a/static/css/file.ts" type="text/typescript"></script>' +
|
'<script src="/a/static/css/file.ts" type="text/typescript"></script>' +
|
||||||
'<script src="http://maps.google.com/maps/api/js?sensor=false" type="text/javascript"></script>'
|
'<script src="http://maps.google.com/maps/api/js?sensor=false" type="text/javascript"></script>'
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
response = Response()
|
response = Response()
|
||||||
response.files.append(URL('a', 'static', 'css/file.js'))
|
response.files.append(URL('a', 'static', 'css/file.js'))
|
||||||
@@ -122,13 +170,13 @@ class testResponse(unittest.TestCase):
|
|||||||
content = return_includes(response, extensions=['css'])
|
content = return_includes(response, extensions=['css'])
|
||||||
self.assertEqual(content, '<link href="/a/static/css/file.css" rel="stylesheet" type="text/css" />')
|
self.assertEqual(content, '<link href="/a/static/css/file.css" rel="stylesheet" type="text/css" />')
|
||||||
|
|
||||||
#regr test for #628
|
# regr test for #628
|
||||||
response = Response()
|
response = Response()
|
||||||
response.files.append('http://maps.google.com/maps/api/js?sensor=false')
|
response.files.append('http://maps.google.com/maps/api/js?sensor=false')
|
||||||
content = return_includes(response)
|
content = return_includes(response)
|
||||||
self.assertEqual(content, '')
|
self.assertEqual(content, '')
|
||||||
|
|
||||||
#regr test for #628
|
# regr test for #628
|
||||||
response = Response()
|
response = Response()
|
||||||
response.files.append(('js', 'http://maps.google.com/maps/api/js?sensor=false'))
|
response.files.append(('js', 'http://maps.google.com/maps/api/js?sensor=false'))
|
||||||
content = return_includes(response)
|
content = return_includes(response)
|
||||||
@@ -147,7 +195,7 @@ class testResponse(unittest.TestCase):
|
|||||||
def test_cookies(self):
|
def test_cookies(self):
|
||||||
current = setup_clean_session()
|
current = setup_clean_session()
|
||||||
cookie = str(current.response.cookies)
|
cookie = str(current.response.cookies)
|
||||||
session_key='%s=%s'%(current.response.session_id_name,current.response.session_id)
|
session_key = '%s=%s' % (current.response.session_id_name, current.response.session_id)
|
||||||
self.assertRegexpMatches(cookie, r'^Set-Cookie: ')
|
self.assertRegexpMatches(cookie, r'^Set-Cookie: ')
|
||||||
self.assertTrue(session_key in cookie)
|
self.assertTrue(session_key in cookie)
|
||||||
self.assertTrue('Path=/' in cookie)
|
self.assertTrue('Path=/' in cookie)
|
||||||
|
|||||||
Reference in New Issue
Block a user