Merge pull request #134 from niphlod/issue/admin_refactor

first step to a nicer code style of admin

applications/admin/controllers/default.py

@@ -1770,4 +1770,3 @@ def git_push():
             session.flash = T("Push failed, there are unmerged entries in the cache. Resolve merge issues manually and try again.")
             redirect(URL('site'))
     return dict(app=app, form=form)
-

applications/admin/languages/it.py

@@ -8,6 +8,7 @@
 '%Y-%m-%d': '%d/%m/%Y',
 '%Y-%m-%d %H:%M:%S': '%d/%m/%Y %H:%M:%S',
 '(requires internet access)': '(requires internet access)',
+'(requires internet access, experimental)': '(requires internet access, experimental)',
 '(something like "it-it")': '(qualcosa simile a "it-it")',
 '@markmin\x01(file **gluon/contrib/plural_rules/%s.py** is not found)': '(file **gluon/contrib/plural_rules/%s.py** is not found)',
 '@markmin\x01Searching: **%s** %%{file}': 'Searching: **%s** files',
@@ -43,6 +44,7 @@
 'ATTENTION: Login requires a secure (HTTPS) connection or running on localhost.': "ATTENZIONE: L'accesso richiede una connessione sicura (HTTPS) o l'esecuzione di web2py in locale (connessione su localhost)",
 'ATTENTION: TESTING IS NOT THREAD SAFE SO DO NOT PERFORM MULTIPLE TESTS CONCURRENTLY.': 'ATTENTZIONE: NON ESEGUIRE PIÙ TEST IN PARALLELO (I TEST NON SONO "THREAD SAFE")',
 'ATTENTION: you cannot edit the running application!': "ATTENZIONE: non puoi modificare l'applicazione correntemente in uso ",
+'Autocomplete Python Code': 'Autocomplete Python Code',
 'Available databases and tables': 'Database e tabelle disponibili',
 'back': 'indietro',
 'cache': 'cache',
@@ -113,10 +115,12 @@
 'Edit': 'modifica',
 'Edit application': 'Modifica applicazione',
 'edit controller': 'modifica controller',
+'edit controller:': 'edit controller:',
 'Edit current record': 'Modifica record corrente',
 'edit profile': 'modifica profilo',
 'Edit This App': 'Modifica questa applicazione',
 'edit views:': 'modifica viste (view):',
+'Editing bigul': 'Editing bigul',
 'Editing file "%s"': 'Modifica del file "%s"',
 'Editing Language file': 'Modifica file linguaggio',
 'Enterprise Web Framework': 'Enterprise Web Framework',
@@ -140,6 +144,8 @@
 'file saved on %(time)s': "file salvato nell'istante %(time)s",
 'file saved on %s': 'file salvato: %s',
 'filter': 'filter',
+'Find Next': 'Find Next',
+'Find Previous': 'Find Previous',
 'Frames': 'Frames',
 'Functions with no doctests will result in [passed] tests.': 'I test delle funzioni senza "doctests" risulteranno sempre [passed].',
 'Get from URL:': 'Get from URL:',
@@ -177,15 +183,16 @@
 'License for': 'Licenza relativa a',
 'loading...': 'caricamento...',
 'locals': 'locals',
-'login': 'accesso',
 'Login': 'Accesso',
+'login': 'accesso',
 'Login to the Administrative Interface': "Accesso all'interfaccia amministrativa",
 'Logout': 'uscita',
 'Main Menu': 'Menu principale',
+'Manage': 'Manage',
 'Menu Model': 'Menu Modelli',
 'merge': 'unisci',
-'models': 'modelli',
 'Models': 'Modelli',
+'models': 'modelli',
 'Modules': 'Moduli',
 'modules': 'moduli',
 'new application "%s" created': 'creata la nuova applicazione "%s"',
@@ -198,6 +205,7 @@
 'NO': 'NO',
 'No databases in this application': 'Nessun database presente in questa applicazione',
 'no match': 'nessuna corrispondenza',
+'online designer': 'online designer',
 'or alternatively': 'or alternatively',
 'Or Get from URL:': 'Or Get from URL:',
 'or import from csv file': 'oppure importa da file CSV',
@@ -206,6 +214,7 @@
 'Overwrite installed app': 'sovrascrivi applicazione installata',
 'Pack all': 'crea pacchetto',
 'Pack compiled': 'crea pacchetto del codice compilato',
+'Pack custom': 'Pack custom',
 'pack plugin': 'crea pacchetto del plugin',
 'PAM authenticated user, cannot change password here': 'utente autenticato tramite PAM, impossibile modificare password qui',
 'password changed': 'password modificata',
@@ -217,15 +226,19 @@
 'Plural-Forms:': 'Plural-Forms:',
 'Powered by': 'Powered by',
 'previous 100 rows': '100 righe precedenti',
-'private files': 'private files',
 'Private files': 'Private files',
+'private files': 'private files',
 'Query:': 'Richiesta (query):',
+'Rapid Search': 'Rapid Search',
 'record': 'record',
 'record does not exist': 'il record non esiste',
 'record id': 'ID del record',
 'register': 'registrazione',
 'reload': 'reload',
+'Reload routes': 'Reload routes',
 'Remove compiled': 'rimozione codice compilato',
+'Replace': 'Replace',
+'Replace All': 'Replace All',
 'request': 'request',
 'Resolve Conflict file': 'File di risoluzione conflitto',
 'response': 'response',
@@ -237,6 +250,8 @@
 "Run tests in this file (to run all files, you may also use the button labelled 'test')": "Run tests in this file (to run all files, you may also use the button labelled 'test')",
 'Running on %s': 'Running on %s',
 'Save': 'Save',
+'Save file:': 'Save file:',
+'Save file: %s': 'Save file: %s',
 'Save via Ajax': 'Save via Ajax',
 'Saved file hash:': 'Hash del file salvato:',
 'selected': 'selezionato',
@@ -245,23 +260,24 @@
 'shell': 'shell',
 'Site': 'sito',
 'some files could not be removed': 'non è stato possibile rimuovere alcuni files',
+'Start searching': 'Start searching',
 'Start wizard': 'start wizard',
 'state': 'stato',
 'static': 'statico',
 'Static': 'Static',
 'Static files': 'Files statici',
 'Stylesheet': 'Foglio di stile (stylesheet)',
-'submit': 'invia',
 'Submit': 'Submit',
+'submit': 'invia',
 'Sure you want to delete this object?': 'Vuoi veramente cancellare questo oggetto?',
 'table': 'tabella',
 'test': 'test',
 'Testing application': 'Test applicazione in corsg',
 'The "query" is a condition like "db.table1.field1==\'value\'". Something like "db.table1.field1==db.table2.field2" results in a SQL JOIN.': 'La richiesta (query) è una condizione come ad esempio  "db.tabella1.campo1==\'valore\'". Una condizione come "db.tabella1.campo1==db.tabella2.campo2" produce un "JOIN" SQL.',
-'The application logic, each URL path is mapped in one exposed function in the controller': 'The application logic, each URL path is mapped in one exposed function in the controller',
 'the application logic, each URL path is mapped in one exposed function in the controller': 'logica dell\'applicazione, ogni percorso "URL" corrisponde ad una funzione esposta da un controller',
-'The data representation, define database tables and sets': 'The data representation, define database tables and sets',
+'The application logic, each URL path is mapped in one exposed function in the controller': 'The application logic, each URL path is mapped in one exposed function in the controller',
 'the data representation, define database tables and sets': 'rappresentazione dei dati, definizione di tabelle di database e di "set" ',
+'The data representation, define database tables and sets': 'The data representation, define database tables and sets',
 'The presentations layer, views are also known as templates': 'The presentations layer, views are also known as templates',
 'the presentations layer, views are also known as templates': 'Presentazione dell\'applicazione, viste (views, chiamate anche "templates")',
 'There are no controllers': 'Non ci sono controller',
@@ -273,8 +289,8 @@
 'There are no translators, only default language is supported': 'Non ci sono traduzioni, viene solo supportato il linguaggio di base',
 'There are no views': 'Non ci sono viste ("view")',
 'These files are not served, they are only available from within your app': 'These files are not served, they are only available from within your app',
-'these files are served without processing, your images go here': 'questi files vengono serviti così come sono, le immagini vanno qui',
 'These files are served without processing, your images go here': 'These files are served without processing, your images go here',
+'these files are served without processing, your images go here': 'questi files vengono serviti così come sono, le immagini vanno qui',
 'This is the %(filename)s template': 'Questo è il template %(filename)s',
 'Ticket': 'Ticket',
 'Ticket ID': 'Ticket ID',
@@ -322,8 +338,8 @@
 'Version %s.%s.%s (%s) %s': 'Version %s.%s.%s (%s) %s',
 'versioning': 'sistema di versioni',
 'Versioning': 'Versioning',
-'view': 'vista',
 'View': 'Vista',
+'view': 'vista',
 'Views': 'viste',
 'views': 'viste',
 'Web Framework': 'Web Framework',

applications/admin/static/js/ajax_editor.js

@@ -1,4 +1,4 @@
-function prepareDataForSave(name,data) {
+function prepareDataForSave(name, data) {
   var obj = new Object();
   obj.Name = name;
   obj.Data = data;
@@ -7,35 +7,37 @@ function prepareDataForSave(name,data) {
 
 function prepareMultiPartPOST(data) {
   // var boundary = 'sPlItME' + Math.floor(Math.random()*10000);
-    var boundary = '' + Math.floor(Math.random()*10000);
+  var boundary = '' + Math.floor(Math.random() * 10000);
   var reqdata = '--' + boundary + '\r\n';
   //console.log(data.length);
-    for (var i=0;i < data.length;i++) {
+  for(var i = 0; i < data.length; i++) {
     reqdata += 'content-disposition: form-data; name="';
     reqdata += data[i].Name + '"';
-		reqdata += "\r\n\r\n" ;
+    reqdata += "\r\n\r\n";
     reqdata += data[i].Data;
-		reqdata += "\r\n" ;
+    reqdata += "\r\n";
     reqdata += '--' + boundary + '\r\n';
   }
-    return new Array(reqdata,boundary);
+  return new Array(reqdata, boundary);
 }
 
 function on_error() {
-    jQuery("input[name='saved_on']").attr('style','background-color:red');
+  jQuery("input[name='saved_on']").attr('style', 'background-color:red');
   jQuery("input[name='saved_on']").val('communication error');
 }
 
 function doHighlight(highlight) {
   // Put the cursor at the offending line:
-    editor.setCursor({line:highlight.lineno-1,
+  editor.setCursor({
-                                 ch:highlight.offset+1});
+    line: highlight.lineno - 1,
-    }
+    ch: highlight.offset + 1
+  });
+}
 
 
 function doClickSave() {
   var currentTabID = '#' + jQuery('#edit_placeholder div.tab-pane.active').attr('id');
-	var editor = jQuery (currentTabID + ' textarea').data('editor');	
+  var editor = jQuery(currentTabID + ' textarea').data('editor');
   var data = editor.getValue();
   var dataForPost = prepareMultiPartPOST(new Array(
     prepareDataForSave('data', data),
@@ -45,7 +47,7 @@ function doClickSave() {
       jQuery(currentTabID + " input[name='saved_on']").val()),
     prepareDataForSave('saved_on',
       jQuery(currentTabID + " input[name='saved_on']").val()),
-	prepareDataForSave('from_ajax','true')));
+    prepareDataForSave('from_ajax', 'true')));
   // console.info(area.textarea.value);
   jQuery(currentTabID + " input[name='saved_on']").attr('style',
     'background-color:yellow');
@@ -53,57 +55,60 @@ function doClickSave() {
   currentUrl = jQuery(currentTabID + ' form').attr('action');
   jQuery.ajax({
     type: "POST",
-	  contentType: 'multipart/form-data;boundary="'
+    contentType: 'multipart/form-data;boundary="' + dataForPost[1] + '"',
-		    + dataForPost[1] + '"',
     url: currentUrl,
     dataType: "json",
     data: dataForPost[0],
     timeout: 5000,
-          beforeSend: function(xhr) {
+    beforeSend: function (xhr) {
       xhr.setRequestHeader('web2py-component-location',
         document.location);
       xhr.setRequestHeader('web2py-component-element',
         'doClickSave');
     },
-          success: function(json,text,xhr){
+    success: function (json, text, xhr) {
       jQuery(editor).data('saved', true); // Set as saved
       editor.on("change", store_changes_function); // Re-enable change watcher
       // reenable disabled submit button
-		    var t=jQuery("input[name='save']");
+      var t = jQuery("input[name='save']");
-		    t.attr('class','');
+      t.attr('class', '');
-            t.attr('disabled','');
+      t.attr('disabled', '');
       try {
-		if (json.error) {
+        if(json.error) {
-			window.location.href=json.redirect;
+          window.location.href = json.redirect;
         } else {
           // console.info( json.file_hash );
           jQuery(currentTabID + " input[name='file_hash']").val(json.file_hash);
           jQuery(currentTabID + " input[name='saved_on']").val(json.saved_on);
-		    if (json.highlight) {
+          if(json.highlight) {
             doHighlight(json.highlight);
           } else {
-				jQuery(currentTabID + " input[name='saved_on']").attr('style','background-color:#99FF99');
+            jQuery(currentTabID + " input[name='saved_on']").attr('style', 'background-color:#99FF99');
             //jQuery(".flash").delay(1000).fadeOut('slow');
           }
           // console.info(jQuery("input[name='file_hash']").val());
           var output = '<b>exposes:</b> ';
-		    for ( var i in json.functions) {
+          for(var i in json.functions) {
             output += ' <a target="_blank" href="/' + json.application + '/' + json.controller + '/' + json.functions[i] + '">' + json.functions[i] + '</a>,';
           }
-		    if(output!='<b>exposes:</b> ') {
+          if(output != '<b>exposes:</b> ') {
-				jQuery(currentTabID + " .exposed").html( output.substring(0, output.length-1));
+            jQuery(currentTabID + " .exposed").html(output.substring(0, output.length - 1));
           }
         }
-	    } catch(e) { on_error();}
+      } catch(e) {
+        on_error();
+      }
     },
-		    error: function(json) { on_error(); }
+    error: function (json) {
+      on_error();
+    }
   });
   return false;
 }
 
 function getActiveEditor() {
   var currentTabID = '#' + jQuery('#edit_placeholder div.tab-pane.active').attr('id');
-	var editor = jQuery (currentTabID + ' textarea').data('editor');
+  var editor = jQuery(currentTabID + ' textarea').data('editor');
   return editor;
 }
 
@@ -118,7 +123,7 @@ function getSelectionRange() {
 
 function doToggleBreakpoint(filename, url, sel) {
   var editor = getActiveEditor();
-    if (sel==null) {
+  if(sel == null) {
     // use cursor position to determine the breakpoint line
     // (gutter already tell us the selected line)
     sel = getSelectionRange();
@@ -130,87 +135,97 @@ function doToggleBreakpoint(filename, url, sel) {
     prepareDataForSave('data', sel['data'])));
   jQuery.ajax({
     type: "POST",
-	  contentType: 'multipart/form-data;boundary="'+dataForPost[1]+'"',
+    contentType: 'multipart/form-data;boundary="' + dataForPost[1] + '"',
     url: url,
     dataType: "json",
     data: dataForPost[0],
     timeout: 5000,
-      beforeSend: function(xhr) {
+    beforeSend: function (xhr) {
       xhr.setRequestHeader('web2py-component-location',
         document.location);
       xhr.setRequestHeader('web2py-component-element',
-			       'doSetBreakpoint');},
+        'doSetBreakpoint');
-	  success: function(json,text,xhr){
+    },
+    success: function (json, text, xhr) {
       // show flash message (if any)
-	     var flash=xhr.getResponseHeader('web2py-component-flash');
+      var flash = xhr.getResponseHeader('web2py-component-flash');
-	     if (flash) {
+      if(flash) {
         jQuery('.flash').html(decodeURIComponent(flash))
           .append('<a href="#" class="close">&times;</a>')
           .slideDown();
-		}
+      } else jQuery('.flash').hide();
-	     else jQuery('.flash').hide();
       try {
-		 if (json.error) {
+        if(json.error) {
-		     window.location.href=json.redirect;
+          window.location.href = json.redirect;
         } else {
-             if (json.ok==true) {
+          if(json.ok == true) {
             // mark the breakpoint if ok=True
-				 editor.setGutterMarker(json.lineno-1, "breakpoints", makeMarker());
+            editor.setGutterMarker(json.lineno - 1, "breakpoints", makeMarker());
- 		     } else if (json.ok==false) {
+          } else if(json.ok == false) {
             // remove mark if ok=False
-				  editor.setGutterMarker(json.lineno-1, "breakpoints", null);
+            editor.setGutterMarker(json.lineno - 1, "breakpoints", null);
           }
         }
-	     } catch(e) { on_error(); }
+      } catch(e) {
+        on_error();
+      }
     },
-		    error: function(json) { on_error(); }
+    error: function (json) {
+      on_error();
+    }
   });
   return false;
 }
 
 // on load, update all breakpoints markers:
+
 function doListBreakpoints(filename, url, editor) {
   var dataForPost = prepareMultiPartPOST(new Array(
     prepareDataForSave('filename', filename)
   ));
   jQuery.ajax({
     type: "POST",
-	  contentType: 'multipart/form-data;boundary="'+dataForPost[1]+'"',
+    contentType: 'multipart/form-data;boundary="' + dataForPost[1] + '"',
     url: url,
     dataType: "json",
     data: dataForPost[0],
     timeout: 5000,
-      beforeSend: function(xhr) {
+    beforeSend: function (xhr) {
       xhr.setRequestHeader('web2py-component-location',
         document.location);
       xhr.setRequestHeader('web2py-component-element',
-			       'doListBreakpoints');},
+        'doListBreakpoints');
-	  success: function(json,text,xhr){
+    },
+    success: function (json, text, xhr) {
       try {
-			if (json.error) {
+        if(json.error) {
-				window.location.href=json.redirect;
+          window.location.href = json.redirect;
         } else {
           var editor = getActiveEditor();
-				for (i in json.breakpoints) {
+          for(i in json.breakpoints) {
             lineno = json.breakpoints[i];
             // mark the breakpoint if ok=True
-					editor.setGutterMarker(lineno-1, "breakpoints",makeMarker());
+            editor.setGutterMarker(lineno - 1, "breakpoints", makeMarker());
           }
         }
-	     } catch(e) { on_error(); }
+      } catch(e) {
+        on_error();
+      }
     },
-      error: function(json) { on_error(); }
+    error: function (json) {
+      on_error();
+    }
   });
   return false;
 }
 
-		function makeMarker() {
+function makeMarker() {
   var marker = document.createElement("div");
   marker.style.color = "#822";
   marker.innerHTML = "●";
   marker.className = "breakpoint";
   return marker;
-	  }
+}
 
 
 function keepalive(url) {
@@ -218,39 +233,44 @@ function keepalive(url) {
     type: "GET",
     url: url,
     timeout: 1000,
-	  success: function(){},
+    success: function () {},
-	  error: function(x) { on_error(); } });
+    error: function (x) {
+      on_error();
+    }
+  });
 }
 
-function load_file (url) {
+function load_file(url) {
   jQuery.ajax({
     type: "GET",
     dataType: 'json',
     url: url,
     timeout: 1000,
-		success: function(json){
+    success: function (json) {
-			if (typeof(json['plain_html']) !== undefined) {
+      if(typeof (json['plain_html']) !== undefined) {
-				if (jQuery('#' + json['id']).length === 0 || json['force'] === true) {			
+        if(jQuery('#' + json['id']).length === 0 || json['force'] === true) {
           // Create a tab and put the code in it
-				    var tab_header = '<li><a href="#'+json['id']+'" data-toggle="tab">'+json['filename']+'<button type="button" class="close">&times;</button></a></li>';
+          var tab_header = '<li><a href="#' + json['id'] + '" data-toggle="tab">' + json['filename'] + '<button type="button" class="close">&times;</button></a></li>';
           var tab_body = '<div id="' + json['id'] + '" class="tab-pane fade in " >' + json['plain_html'] + '</div>';
-					if (json['force'] === false) {
+          if(json['force'] === false) {
             jQuery('#filesTab').append(jQuery(tab_header));
             jQuery('#myTabContent').append(jQuery(tab_body));
           } else {
             jQuery('#' + json['id']).html(jQuery(tab_body));
           }
         }
-				jQuery("a[href='#" + json['id'] + "']" ).click();
+        jQuery("a[href='#" + json['id'] + "']").click();
       }
     },
-		error: function(x) { on_error(); }
+    error: function (x) {
+      on_error();
+    }
   });
 }
 
 function set_font(editor, incr) {
   var fontSize = '';
-	if (incr !== 0) {
+  if(incr !== 0) {
     fontSize = parseInt(jQuery(editor.getWrapperElement()).css('font-size'));
     fontSize = fontSize + incr + "px";
   }
@@ -259,4 +279,3 @@ function set_font(editor, incr) {
 }
 
 var template_js = '<p class="repo-name">{{{a_tag}}}</p><small>{{address}}</small>';
-

applications/admin/views/default/edit.html

@@ -38,10 +38,10 @@
 <link rel="stylesheet" href="{{=cm}}/addon/dialog/dialog.css">
 <script src="{{=cm}}/addon/selection/active-line.js"></script>
 <script src="{{=cm}}/emmet.min.js"></script>
-<script language="Javascript" type="text/javascript" src="{{=URL('static','js/ajax_editor.js')}}"></script>
+<script src="{{=URL('static','js/ajax_editor.js')}}"></script>
 <link rel="stylesheet" href="{{=URL('static/css','typeahead.js-bootstrap.css')}}">
 <link rel="stylesheet" href="{{=URL('static/css','web2py-codemirror.css')}}">
-<script language="Javascript" type="text/javascript">
+<script type="text/javascript">
 var current_theme = "web2py";  //Default theme
 var current_font_incr = 0; // Default font-size, 0 means don't set
 jQuery(document).on('shown click', 'a[data-toggle="tab"]', function (e) {

applications/admin/views/default/site.html

@@ -151,4 +151,3 @@
   </div> <!-- /sidebar -->
 </div> <!-- /row-fluid
 <!-- end "site" block -->
-