From 42e5bea36f1c5babbe10e61592141e4dc9c8f19e Mon Sep 17 00:00:00 2001 From: Massimo Di Pierro Date: Thu, 1 Mar 2012 09:12:19 -0600 Subject: [PATCH] improved ldap_auth, thanks Gyuris --- VERSION | 2 +- gluon/contrib/login_methods/ldap_auth.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/VERSION b/VERSION index 36fcbcb8..b5fcf3c1 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -Version 1.99.4 (2012-03-01 08:54:35) stable +Version 1.99.4 (2012-03-01 09:12:01) stable diff --git a/gluon/contrib/login_methods/ldap_auth.py b/gluon/contrib/login_methods/ldap_auth.py index ccd63b4e..208c88bf 100644 --- a/gluon/contrib/login_methods/ldap_auth.py +++ b/gluon/contrib/login_methods/ldap_auth.py @@ -201,8 +201,6 @@ def ldap_auth( server = 'ldap', port = None, return True except ldap.LDAPError, e: - import traceback - logging.error( traceback.format_exc() ) return False except IndexError, ex: # for AD membership test return False @@ -265,6 +263,8 @@ def ldap_auth( server = 'ldap', port = None, group = group_row[1] ldap_groups_of_the_user.extend( group[group_name_attrib] ) + con.unbind() + # # Get all group name where the user is in actually in local db # #############################################################