fixed a potential timing attack, thanks Kirill Spitsin

This commit is contained in:
Massimo Di Pierro
2012-06-13 16:45:30 -05:00
parent 8f0de10856
commit 3149c21240
3 changed files with 8 additions and 3 deletions
+3 -2
View File
@@ -25,7 +25,7 @@ from HTMLParser import HTMLParser
from htmlentitydefs import name2codepoint
from storage import Storage
from utils import web2py_uuid, hmac_hash
from utils import web2py_uuid, hmac_hash, compare
from highlight import highlight
regex_crlf = re.compile('\r|\n')
@@ -455,7 +455,8 @@ def verifyURL(request, hmac_key=None, hash_vars=True, salt=None, user_signature=
# return whether or not the signature in the request matched the one we just generated
# (I.E. was the message the same as the one we originally signed)
return original_sig == sig
return compare(original_sig, sig)
URL.verify = verifyURL