Merge pull request #252 from timrichardson/issue/1692v3

Issue/1692v3 OK merged my fix for virtual fields when fields argument is specified
This commit is contained in:
mdipierro committed 2013-10-12 07:23:25 -07:00
commit 1a2a69b21a
1 file changed
+8 -6
+8 -6
View File
@@ -1913,6 +1913,11 @@ class SQLFORM(FORM):
tablenames += db._adapter.tables(join) tablenames += db._adapter.tables(join)
tables = [db[tablename] for tablename in tablenames] tables = [db[tablename] for tablename in tablenames]
if fields: if fields:
#add missing tablename to virtual fields
for table in tables:
for k,f in table.iteritems():
if isinstance(f,Field.Virtual):
f.tablename = table._tablename
columns = [f for f in fields if f.tablename in tablenames] columns = [f for f in fields if f.tablename in tablenames]
else: else:
fields = [] fields = []
@@ -1926,9 +1931,8 @@ class SQLFORM(FORM):
if not k.startswith('_'): if not k.startswith('_'):
if isinstance(f,Field.Virtual) and f.readable: if isinstance(f,Field.Virtual) and f.readable:
f.tablename = table._tablename f.tablename = table._tablename
columns.append(f)
fields.append(f) fields.append(f)
columns.append(f)
if not field_id: if not field_id:
if groupby is None: if groupby is None:
field_id = tables[0]._id field_id = tables[0]._id
@@ -2271,11 +2275,9 @@ class SQLFORM(FORM):
limitby = (paginate*page,paginate*(page+1)) limitby = (paginate*page,paginate*(page+1))
else: else:
limitby = None limitby = None
try: try:
table_fields = filter( table_fields = [field for field in fields
lambda f: (f.tablename in tablenames) and \ if (field.tablename in tablenames and not(isinstance(field,Field.Virtual)))]
(not(isinstance(f,Field.Virtual))),fields)
if dbset._db._adapter.dbengine=='google:datastore': if dbset._db._adapter.dbengine=='google:datastore':
rows = dbset.select(left=left,orderby=orderby, rows = dbset.select(left=left,orderby=orderby,
groupby=groupby,limitby=limitby, groupby=groupby,limitby=limitby,