dinislage/web2py
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

possible fix for Issue 1426:Count(*) query is incorrect when SQLFORM.grid() contains groupby parameter, thanks daveshih01

Browse Source
This commit is contained in:
mdipierro
2013-04-04 21:11:19 -05:00
parent cc8a21aedf
commit 0f0a62ef7f
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
VERSION
+1 -1
View File
@@ -1 +1 @@
Version 2.4.5-stable+timestamp.2013.04.03.16.48.32 Version 2.4.5-stable+timestamp.2013.04.04.21.10.38
gluon/sqlhtml.py
+4 -1
View File
@@ -2122,7 +2122,10 @@ class SQLFORM(FORM):
dbset = dbset(subquery) dbset = dbset(subquery)
try: try:
if left or groupby: if left or groupby:
c = 'count(*)' if groupby:
c = 'count(distinct %s)' % str(groupby)
else:
c = 'count(*)'
nrows = dbset.select(c, left=left, cacheable=True, nrows = dbset.select(c, left=left, cacheable=True,
groupby=groupby).first()[c] groupby=groupby).first()[c]
elif dbset._db._adapter.dbengine=='google:datastore': elif dbset._db._adapter.dbengine=='google:datastore':