[#4601] Change Manage Budget to a givable permission

test/integration/deliverables_delete_test.rb

@@ -8,9 +8,31 @@ class DeliverablesDeleteTest < ActionController::IntegrationTest
     @contract = Contract.generate!(:project => @project, :name => 'A Contract')
     @manager = User.generate!
     @deliverable = FixedDeliverable.generate!(:contract => @contract, :manager => @manager)
+    @user = User.generate_user_with_permission_to_manage_budget(:project => @project)
+    
+    login_as(@user.login, 'contracts')
   end
 
-  should "allow anyone to delete the deliverable" do
+  should "block anonymous users from deleting the deliverable" do
+    logout
+    delete "/projects/#{@project.identifier}/contracts/#{@contract.id}/deliverables/#{@deliverable.id}"
+    follow_redirect!
+    
+    assert_requires_login
+  end
+  
+  should "block unauthorized users from deleting the deliverable" do
+    logout
+
+    @user = User.generate!(:password => 'test', :password_confirmation => 'test')
+    login_as(@user.login, 'test')
+    
+    delete "/projects/#{@project.identifier}/contracts/#{@contract.id}/deliverables/#{@deliverable.id}"
+
+    assert_forbidden
+  end
+
+  should "allow authorized users to delete the deliverable" do
     visit_contract_page(@contract)
 
     click_link_within "#deliverable_details_#{@deliverable.id}", 'Delete'