dinislage/redmine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add support for unattached menus (generated dynamically)

Browse Source 
A MenuItem can define a :child_menus option with a Proc.  When the menus
are rendered, the Proc will be run and the resulting MenuItems will be
added to the page as child menus

  #4250

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3091 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Eric Davis
2009-11-25 05:36:50 +00:00
parent 1f06cf8899
commit b0999e3764
4 changed files with 181 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/unit/lib/redmine/menu_manager/menu_helper_test.rb
+101
View File
@@ -101,6 +101,107 @@ class Redmine::MenuManager::MenuHelperTest < HelperTestCase
end
def test_render_menu_node_with_child_menus
User.current = User.find(2)
parent_node = Redmine::MenuManager::MenuItem.new(:parent_node,
'/test',
{
:child_menus => Proc.new {|p|
child_menus = []
3.times do |time|
child_menus << Redmine::MenuManager::MenuItem.new("test_child_#{time}",
{:controller => 'issues', :action => 'index'},
{})
end
child_menus
}
})
@response.body = render_menu_node(parent_node, Project.find(1))
assert_select("li") do
assert_select("a.parent-node", "Parent node")
assert_select("ul") do
assert_select("li a.test-child-0", "Test child 0")
assert_select("li a.test-child-1", "Test child 1")
assert_select("li a.test-child-2", "Test child 2")
end
end
end
def test_render_menu_node_with_nested_items_and_child_menus
User.current = User.find(2)
parent_node = Redmine::MenuManager::MenuItem.new(:parent_node,
'/test',
{
:child_menus => Proc.new {|p|
child_menus = []
3.times do |time|
child_menus << Redmine::MenuManager::MenuItem.new("test_child_#{time}", {:controller => 'issues', :action => 'index'}, {})
end
child_menus
}
})
parent_node << Redmine::MenuManager::MenuItem.new(:child_node,
'/test',
{
:child_menus => Proc.new {|p|
child_menus = []
6.times do |time|
child_menus << Redmine::MenuManager::MenuItem.new("test_dynamic_child_#{time}", {:controller => 'issues', :action => 'index'}, {})
end
child_menus
}
})
@response.body = render_menu_node(parent_node, Project.find(1))
assert_select("li") do
assert_select("a.parent-node", "Parent node")
assert_select("ul") do
assert_select("li a.child-node", "Child node")
assert_select("ul") do
assert_select("li a.test-dynamic-child-0", "Test dynamic child 0")
assert_select("li a.test-dynamic-child-1", "Test dynamic child 1")
assert_select("li a.test-dynamic-child-2", "Test dynamic child 2")
assert_select("li a.test-dynamic-child-3", "Test dynamic child 3")
assert_select("li a.test-dynamic-child-4", "Test dynamic child 4")
assert_select("li a.test-dynamic-child-5", "Test dynamic child 5")
end
assert_select("li a.test-child-0", "Test child 0")
assert_select("li a.test-child-1", "Test child 1")
assert_select("li a.test-child-2", "Test child 2")
end
end
end
def test_render_menu_node_with_child_menus_without_an_array
parent_node = Redmine::MenuManager::MenuItem.new(:parent_node,
'/test',
{
:child_menus => Proc.new {|p| Redmine::MenuManager::MenuItem.new("test_child", "/testing", {})}
})
assert_raises Redmine::MenuManager::MenuError, ":child_menus must be an array of MenuItems" do
@response.body = render_menu_node(parent_node, Project.find(1))
end
end
def test_render_menu_node_with_incorrect_child_menus
parent_node = Redmine::MenuManager::MenuItem.new(:parent_node,
'/test',
{
:child_menus => Proc.new {|p| ["a string"] }
})
assert_raises Redmine::MenuManager::MenuError, ":child_menus must be an array of MenuItems" do
@response.body = render_menu_node(parent_node, Project.find(1))
end
end
def test_menu_items_for_should_yield_all_items_if_passed_a_block
menu_name = :test_menu_items_for_should_yield_all_items_if_passed_a_block
Redmine::MenuManager.map menu_name do |menu|
test/unit/lib/redmine/menu_manager/menu_item_test.rb
+14
View File
@@ -92,6 +92,20 @@ class Redmine::MenuManager::MenuItemTest < Test::Unit::TestCase
})
end
def test_new_menu_item_should_require_a_proc_to_use_the_child_menus_option
assert_raises ArgumentError do
Redmine::MenuManager::MenuItem.new(:test_error, '/test',
{
:child_menus => ['not_a_proc']
})
end
assert Redmine::MenuManager::MenuItem.new(:test_good_child_menus, '/test',
{
:child_menus => Proc.new{}
})
end
def test_new_should_not_allow_setting_the_parent_menu_item_to_the_current_item
assert_raises ArgumentError do
Redmine::MenuManager::MenuItem.new(:test_error, '/test', { :parent_menu => :test_error })
test/unit/lib/redmine/menu_manager_test.rb
+4
View File
@@ -25,4 +25,8 @@ class Redmine::MenuManagerTest < Test::Unit::TestCase
context "MenuManager#items" do
should "be tested"
end
should "be tested" do
assert true
end
end