Extracts custom field values validation from CustomValue so that they can be validated globally from the customized object (#1189).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8717 e93f8b46-1217-0410-a6f0-8f06a7374b81

test/unit/custom_field_test.rb

@@ -1,5 +1,5 @@
 # Redmine - project management software
-# Copyright (C) 2006-2011  Jean-Philippe Lang
+# Copyright (C) 2006-2012  Jean-Philippe Lang
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License
@@ -44,6 +44,14 @@ class CustomFieldTest < ActiveSupport::TestCase
     assert field.save
   end
 
+  def test_default_value_should_be_validated
+    field = CustomField.new(:name => 'Test', :field_format => 'int')
+    field.default_value = 'abc'
+    assert !field.valid?
+    field.default_value = '6'
+    assert field.valid?
+  end
+
   def test_possible_values_should_accept_an_array
     field = CustomField.new
     field.possible_values = ["One value", ""]
@@ -85,4 +93,75 @@ class CustomFieldTest < ActiveSupport::TestCase
   def test_new_subclass_instance_with_non_subclass_name_should_return_nil
     assert_nil CustomField.new_subclass_instance('Project')
   end
+
+  def test_string_field_validation_with_blank_value
+    f = CustomField.new(:field_format => 'string')
+
+    assert f.valid_field_value?(nil)
+    assert f.valid_field_value?('')
+
+    f.is_required = true
+    assert !f.valid_field_value?(nil)
+    assert !f.valid_field_value?('')
+  end
+
+  def test_string_field_validation_with_min_and_max_lengths
+    f = CustomField.new(:field_format => 'string', :min_length => 2, :max_length => 5)
+
+    assert f.valid_field_value?(nil)
+    assert f.valid_field_value?('')
+    assert f.valid_field_value?('a' * 2)
+    assert !f.valid_field_value?('a')
+    assert !f.valid_field_value?('a' * 6)
+  end
+
+  def test_string_field_validation_with_regexp
+    f = CustomField.new(:field_format => 'string', :regexp => '^[A-Z0-9]*$')
+
+    assert f.valid_field_value?(nil)
+    assert f.valid_field_value?('')
+    assert f.valid_field_value?('ABC')
+    assert !f.valid_field_value?('abc')
+  end
+
+  def test_date_field_validation
+    f = CustomField.new(:field_format => 'date')
+
+    assert f.valid_field_value?(nil)
+    assert f.valid_field_value?('')
+    assert f.valid_field_value?('1975-07-14')
+    assert !f.valid_field_value?('1975-07-33')
+    assert !f.valid_field_value?('abc')
+  end
+
+  def test_list_field_validation
+    f = CustomField.new(:field_format => 'list', :possible_values => ['value1', 'value2'])
+
+    assert f.valid_field_value?(nil)
+    assert f.valid_field_value?('')
+    assert f.valid_field_value?('value2')
+    assert !f.valid_field_value?('abc')
+  end
+
+  def test_int_field_validation
+    f = CustomField.new(:field_format => 'int')
+
+    assert f.valid_field_value?(nil)
+    assert f.valid_field_value?('')
+    assert f.valid_field_value?('123')
+    assert f.valid_field_value?('+123')
+    assert f.valid_field_value?('-123')
+    assert !f.valid_field_value?('6abc')
+  end
+
+  def test_float_field_validation
+    f = CustomField.new(:field_format => 'float')
+
+    assert f.valid_field_value?(nil)
+    assert f.valid_field_value?('')
+    assert f.valid_field_value?('11.2')
+    assert f.valid_field_value?('-6.250')
+    assert f.valid_field_value?('5')
+    assert !f.valid_field_value?('6abc')
+  end
 end