Tests should not change settings.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9949 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-07-08 12:23:47 +00:00
parent 133ca59edb
commit 7acd04fb87
15 changed files with 94 additions and 61 deletions
@@ -33,11 +33,12 @@ class CommentTest < ActiveSupport::TestCase
  end

  def test_create_should_send_notification
-    Setting.notified_events << 'news_comment_added'
    Watcher.create!(:watchable => @news, :user => @jsmith)

-    assert_difference 'ActionMailer::Base.deliveries.size' do
-      Comment.create!(:commented => @news, :author => @jsmith, :comments => "my comment")
+    with_settings :notified_events => %w(news_comment_added) do
+      assert_difference 'ActionMailer::Base.deliveries.size' do
+        Comment.create!(:commented => @news, :author => @jsmith, :comments => "my comment")
+      end
    end
  end