Tests should not change settings.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9949 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-07-08 12:23:47 +00:00
parent 133ca59edb
commit 7acd04fb87
15 changed files with 94 additions and 61 deletions
@@ -91,11 +91,12 @@ class MessagesControllerTest < ActionController::TestCase
  def test_post_new
    @request.session[:user_id] = 2
    ActionMailer::Base.deliveries.clear
-    Setting.notified_events = ['message_posted']

-    post :new, :board_id => 1,
+    with_settings :notified_events => %w(message_posted) do
+      post :new, :board_id => 1,
               :message => { :subject => 'Test created message',
                             :content => 'Message body'}
+    end
    message = Message.find_by_subject('Test created message')
    assert_not_nil message
    assert_redirected_to "/boards/1/topics/#{message.to_param}"