Converted routing and urls to follow the Rails REST convention.
Patch supplied by commits from Gerrit Kaiser on Github. Existing routes will still work (backwards compatible) but any new urls will be generated using the new routing rules. Changes listed below: * made the URLs for some project tabs and project settings follow the new rails RESTful conventions of /collection/:id/subcollection/:sub_id * prettier URL for project roadmap * more nice project URLs * use GET for filtering form * prettified URLs used on issues tab * custom route for activity atom feeds * prettier repository urls * fixed broken route definition * fixed failing tests for issuecontroller that were hardcoding the url string * more RESTful routes for boards and messages * RESTful routes for wiki pages * RESTful routes for documents * moved old routes that are retained for compatibility to the bottom and grouped them together * added RESTful URIs for issues * RESTfulness for the news section * fixed route order * changed hardcoded URLs in tests * fixed badly written tests * fixed forgotten parameter in routes * changed hardcoded URLS to new scheme * changed project add url to the standard POST to collection * create new issue by POSTing to collection * changed hardcoded URLs in integrations tests * made project add form work again * restful routes for project deletion * prettier routes for project (un)archival * made routes table more readable * fixed note quoting * user routing * fixed bug * always sort by GET * Fixed: cross-project issue list should not show issues of projects for which the issue tracking module was disabled. * prettified URLs used on issues tab * urls for time log * fixed reply routing * eliminate revision query paremeter for diff and entry actions * fixed test failures with hard-coded urls * ensure ajax links always use get * refactored ajax link generation into separate method #1901 git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2317 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
@@ -31,6 +31,13 @@ class MessagesControllerTest < Test::Unit::TestCase
|
||||
User.current = nil
|
||||
end
|
||||
|
||||
def test_show_routing
|
||||
assert_routing(
|
||||
{:method => :get, :path => '/boards/22/topics/2'},
|
||||
:controller => 'messages', :action => 'show', :id => '2', :board_id => '22'
|
||||
)
|
||||
end
|
||||
|
||||
def test_show
|
||||
get :show, :board_id => 1, :id => 1
|
||||
assert_response :success
|
||||
@@ -54,6 +61,17 @@ class MessagesControllerTest < Test::Unit::TestCase
|
||||
assert_response 404
|
||||
end
|
||||
|
||||
def test_new_routing
|
||||
assert_routing(
|
||||
{:method => :get, :path => '/boards/lala/topics/new'},
|
||||
:controller => 'messages', :action => 'new', :board_id => 'lala'
|
||||
)
|
||||
assert_recognizes(#TODO: POST to collection, need to adjust form accordingly
|
||||
{:controller => 'messages', :action => 'new', :board_id => 'lala'},
|
||||
{:method => :post, :path => '/boards/lala/topics/new'}
|
||||
)
|
||||
end
|
||||
|
||||
def test_get_new
|
||||
@request.session[:user_id] = 2
|
||||
get :new, :board_id => 1
|
||||
@@ -86,6 +104,17 @@ class MessagesControllerTest < Test::Unit::TestCase
|
||||
assert mail.bcc.include?('dlopper@somenet.foo')
|
||||
end
|
||||
|
||||
def test_edit_routing
|
||||
assert_routing(
|
||||
{:method => :get, :path => '/boards/lala/topics/22/edit'},
|
||||
:controller => 'messages', :action => 'edit', :board_id => 'lala', :id => '22'
|
||||
)
|
||||
assert_recognizes( #TODO: use PUT to topic_path, modify form accordingly
|
||||
{:controller => 'messages', :action => 'edit', :board_id => 'lala', :id => '22'},
|
||||
{:method => :post, :path => '/boards/lala/topics/22/edit'}
|
||||
)
|
||||
end
|
||||
|
||||
def test_get_edit
|
||||
@request.session[:user_id] = 2
|
||||
get :edit, :board_id => 1, :id => 1
|
||||
@@ -104,6 +133,13 @@ class MessagesControllerTest < Test::Unit::TestCase
|
||||
assert_equal 'New body', message.content
|
||||
end
|
||||
|
||||
def test_reply_routing
|
||||
assert_recognizes(
|
||||
{:controller => 'messages', :action => 'reply', :board_id => '22', :id => '555'},
|
||||
{:method => :post, :path => '/boards/22/topics/555/replies'}
|
||||
)
|
||||
end
|
||||
|
||||
def test_reply
|
||||
@request.session[:user_id] = 2
|
||||
post :reply, :board_id => 1, :id => 1, :reply => { :content => 'This is a test reply', :subject => 'Test reply' }
|
||||
@@ -111,6 +147,13 @@ class MessagesControllerTest < Test::Unit::TestCase
|
||||
assert Message.find_by_subject('Test reply')
|
||||
end
|
||||
|
||||
def test_destroy_routing
|
||||
assert_recognizes(#TODO: use DELETE to topic_path, adjust form accordingly
|
||||
{:controller => 'messages', :action => 'destroy', :board_id => '22', :id => '555'},
|
||||
{:method => :post, :path => '/boards/22/topics/555/destroy'}
|
||||
)
|
||||
end
|
||||
|
||||
def test_destroy_topic
|
||||
@request.session[:user_id] = 2
|
||||
post :destroy, :board_id => 1, :id => 1
|
||||
|
||||
Reference in New Issue
Block a user