Use Object#tap instead of #returning (#6887).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4406 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
@@ -154,7 +154,7 @@ module CollectiveIdea #:nodoc:
|
||||
def each_root_valid?(roots_to_validate)
|
||||
left = right = 0
|
||||
roots_to_validate.all? do |root|
|
||||
returning(root.left > left && root.right > right) do
|
||||
(root.left > left && root.right > right).tap do
|
||||
left = root.left
|
||||
right = root.right
|
||||
end
|
||||
|
||||
+1
-1
@@ -76,7 +76,7 @@ class PluginMigrationGenerator < Rails::Generator::Base
|
||||
# plugin names involved is shorter than 230 characters that one will be
|
||||
# used. Otherwise a shorter name will be returned.
|
||||
def build_migration_name
|
||||
returning descriptive_migration_name do |name|
|
||||
descriptive_migration_name.tap do |name|
|
||||
name.replace short_migration_name if name.length > MAX_FILENAME_LENGTH
|
||||
end
|
||||
end
|
||||
|
||||
+1
-1
@@ -71,7 +71,7 @@ module GravatarHelper
|
||||
email_hash = Digest::MD5.hexdigest(email)
|
||||
options = DEFAULT_OPTIONS.merge(options)
|
||||
options[:default] = CGI::escape(options[:default]) unless options[:default].nil?
|
||||
returning gravatar_api_url(email_hash, options.delete(:ssl)) do |url|
|
||||
gravatar_api_url(email_hash, options.delete(:ssl)).tap do |url|
|
||||
opts = []
|
||||
[:rating, :size, :default].each do |opt|
|
||||
unless options[opt].nil?
|
||||
|
||||
Reference in New Issue
Block a user