Removed some shoulda context.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11862 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang
@@ -24,177 +24,149 @@ class Redmine::ApiTest::MembershipsTest < Redmine::ApiTest::Base
|
||||
Setting.rest_api_enabled = '1'
|
||||
end
|
||||
|
||||
context "/projects/:project_id/memberships" do
|
||||
context "GET" do
|
||||
context "xml" do
|
||||
should "return memberships" do
|
||||
get '/projects/1/memberships.xml', {}, credentials('jsmith')
|
||||
test "GET /projects/:project_id/memberships.xml should return memberships" do
|
||||
get '/projects/1/memberships.xml', {}, credentials('jsmith')
|
||||
|
||||
assert_response :success
|
||||
assert_equal 'application/xml', @response.content_type
|
||||
assert_tag :tag => 'memberships',
|
||||
:attributes => {:type => 'array'},
|
||||
:child => {
|
||||
:tag => 'membership',
|
||||
assert_response :success
|
||||
assert_equal 'application/xml', @response.content_type
|
||||
assert_tag :tag => 'memberships',
|
||||
:attributes => {:type => 'array'},
|
||||
:child => {
|
||||
:tag => 'membership',
|
||||
:child => {
|
||||
:tag => 'id',
|
||||
:content => '2',
|
||||
:sibling => {
|
||||
:tag => 'user',
|
||||
:attributes => {:id => '3', :name => 'Dave Lopper'},
|
||||
:sibling => {
|
||||
:tag => 'roles',
|
||||
:child => {
|
||||
:tag => 'id',
|
||||
:content => '2',
|
||||
:sibling => {
|
||||
:tag => 'user',
|
||||
:attributes => {:id => '3', :name => 'Dave Lopper'},
|
||||
:sibling => {
|
||||
:tag => 'roles',
|
||||
:child => {
|
||||
:tag => 'role',
|
||||
:attributes => {:id => '2', :name => 'Developer'}
|
||||
}
|
||||
}
|
||||
}
|
||||
:tag => 'role',
|
||||
:attributes => {:id => '2', :name => 'Developer'}
|
||||
}
|
||||
}
|
||||
end
|
||||
end
|
||||
}
|
||||
}
|
||||
}
|
||||
end
|
||||
|
||||
context "json" do
|
||||
should "return memberships" do
|
||||
get '/projects/1/memberships.json', {}, credentials('jsmith')
|
||||
test "GET /projects/:project_id/memberships.json should return memberships" do
|
||||
get '/projects/1/memberships.json', {}, credentials('jsmith')
|
||||
|
||||
assert_response :success
|
||||
assert_equal 'application/json', @response.content_type
|
||||
json = ActiveSupport::JSON.decode(response.body)
|
||||
assert_equal({
|
||||
"memberships" =>
|
||||
[{"id"=>1,
|
||||
"project" => {"name"=>"eCookbook", "id"=>1},
|
||||
"roles" => [{"name"=>"Manager", "id"=>1}],
|
||||
"user" => {"name"=>"John Smith", "id"=>2}},
|
||||
{"id"=>2,
|
||||
"project" => {"name"=>"eCookbook", "id"=>1},
|
||||
"roles" => [{"name"=>"Developer", "id"=>2}],
|
||||
"user" => {"name"=>"Dave Lopper", "id"=>3}}],
|
||||
"limit" => 25,
|
||||
"total_count" => 2,
|
||||
"offset" => 0},
|
||||
json)
|
||||
end
|
||||
end
|
||||
end
|
||||
assert_response :success
|
||||
assert_equal 'application/json', @response.content_type
|
||||
json = ActiveSupport::JSON.decode(response.body)
|
||||
assert_equal({
|
||||
"memberships" =>
|
||||
[{"id"=>1,
|
||||
"project" => {"name"=>"eCookbook", "id"=>1},
|
||||
"roles" => [{"name"=>"Manager", "id"=>1}],
|
||||
"user" => {"name"=>"John Smith", "id"=>2}},
|
||||
{"id"=>2,
|
||||
"project" => {"name"=>"eCookbook", "id"=>1},
|
||||
"roles" => [{"name"=>"Developer", "id"=>2}],
|
||||
"user" => {"name"=>"Dave Lopper", "id"=>3}}],
|
||||
"limit" => 25,
|
||||
"total_count" => 2,
|
||||
"offset" => 0},
|
||||
json)
|
||||
end
|
||||
|
||||
context "POST" do
|
||||
context "xml" do
|
||||
should "create membership" do
|
||||
assert_difference 'Member.count' do
|
||||
post '/projects/1/memberships.xml', {:membership => {:user_id => 7, :role_ids => [2,3]}}, credentials('jsmith')
|
||||
test "POST /projects/:project_id/memberships.xml should create the membership" do
|
||||
assert_difference 'Member.count' do
|
||||
post '/projects/1/memberships.xml', {:membership => {:user_id => 7, :role_ids => [2,3]}}, credentials('jsmith')
|
||||
|
||||
assert_response :created
|
||||
end
|
||||
end
|
||||
|
||||
should "return errors on failure" do
|
||||
assert_no_difference 'Member.count' do
|
||||
post '/projects/1/memberships.xml', {:membership => {:role_ids => [2,3]}}, credentials('jsmith')
|
||||
|
||||
assert_response :unprocessable_entity
|
||||
assert_equal 'application/xml', @response.content_type
|
||||
assert_tag 'errors', :child => {:tag => 'error', :content => "Principal can't be blank"}
|
||||
end
|
||||
end
|
||||
end
|
||||
assert_response :created
|
||||
end
|
||||
end
|
||||
|
||||
context "/memberships/:id" do
|
||||
context "GET" do
|
||||
context "xml" do
|
||||
should "return the membership" do
|
||||
get '/memberships/2.xml', {}, credentials('jsmith')
|
||||
test "POST /projects/:project_id/memberships.xml with invalid parameters should return errors" do
|
||||
assert_no_difference 'Member.count' do
|
||||
post '/projects/1/memberships.xml', {:membership => {:role_ids => [2,3]}}, credentials('jsmith')
|
||||
|
||||
assert_response :success
|
||||
assert_equal 'application/xml', @response.content_type
|
||||
assert_tag :tag => 'membership',
|
||||
assert_response :unprocessable_entity
|
||||
assert_equal 'application/xml', @response.content_type
|
||||
assert_tag 'errors', :child => {:tag => 'error', :content => "Principal can't be blank"}
|
||||
end
|
||||
end
|
||||
|
||||
test "GET /memberships/:id.xml should return the membership" do
|
||||
get '/memberships/2.xml', {}, credentials('jsmith')
|
||||
|
||||
assert_response :success
|
||||
assert_equal 'application/xml', @response.content_type
|
||||
assert_tag :tag => 'membership',
|
||||
:child => {
|
||||
:tag => 'id',
|
||||
:content => '2',
|
||||
:sibling => {
|
||||
:tag => 'user',
|
||||
:attributes => {:id => '3', :name => 'Dave Lopper'},
|
||||
:sibling => {
|
||||
:tag => 'roles',
|
||||
:child => {
|
||||
:tag => 'id',
|
||||
:content => '2',
|
||||
:sibling => {
|
||||
:tag => 'user',
|
||||
:attributes => {:id => '3', :name => 'Dave Lopper'},
|
||||
:sibling => {
|
||||
:tag => 'roles',
|
||||
:child => {
|
||||
:tag => 'role',
|
||||
:attributes => {:id => '2', :name => 'Developer'}
|
||||
}
|
||||
}
|
||||
}
|
||||
:tag => 'role',
|
||||
:attributes => {:id => '2', :name => 'Developer'}
|
||||
}
|
||||
end
|
||||
end
|
||||
}
|
||||
}
|
||||
}
|
||||
end
|
||||
|
||||
context "json" do
|
||||
should "return the membership" do
|
||||
get '/memberships/2.json', {}, credentials('jsmith')
|
||||
test "GET /memberships/:id.json should return the membership" do
|
||||
get '/memberships/2.json', {}, credentials('jsmith')
|
||||
|
||||
assert_response :success
|
||||
assert_equal 'application/json', @response.content_type
|
||||
json = ActiveSupport::JSON.decode(response.body)
|
||||
assert_equal(
|
||||
{"membership" => {
|
||||
"id" => 2,
|
||||
"project" => {"name"=>"eCookbook", "id"=>1},
|
||||
"roles" => [{"name"=>"Developer", "id"=>2}],
|
||||
"user" => {"name"=>"Dave Lopper", "id"=>3}}
|
||||
},
|
||||
json)
|
||||
end
|
||||
end
|
||||
assert_response :success
|
||||
assert_equal 'application/json', @response.content_type
|
||||
json = ActiveSupport::JSON.decode(response.body)
|
||||
assert_equal(
|
||||
{"membership" => {
|
||||
"id" => 2,
|
||||
"project" => {"name"=>"eCookbook", "id"=>1},
|
||||
"roles" => [{"name"=>"Developer", "id"=>2}],
|
||||
"user" => {"name"=>"Dave Lopper", "id"=>3}}
|
||||
},
|
||||
json)
|
||||
end
|
||||
|
||||
test "PUT /memberships/:id.xml should update the membership" do
|
||||
assert_not_equal [1,2], Member.find(2).role_ids.sort
|
||||
assert_no_difference 'Member.count' do
|
||||
put '/memberships/2.xml', {:membership => {:user_id => 3, :role_ids => [1,2]}}, credentials('jsmith')
|
||||
|
||||
assert_response :ok
|
||||
assert_equal '', @response.body
|
||||
end
|
||||
member = Member.find(2)
|
||||
assert_equal [1,2], member.role_ids.sort
|
||||
end
|
||||
|
||||
context "PUT" do
|
||||
context "xml" do
|
||||
should "update membership" do
|
||||
assert_not_equal [1,2], Member.find(2).role_ids.sort
|
||||
assert_no_difference 'Member.count' do
|
||||
put '/memberships/2.xml', {:membership => {:user_id => 3, :role_ids => [1,2]}}, credentials('jsmith')
|
||||
test "PUT /memberships/:id.xml with invalid parameters should return errors" do
|
||||
put '/memberships/2.xml', {:membership => {:user_id => 3, :role_ids => [99]}}, credentials('jsmith')
|
||||
|
||||
assert_response :ok
|
||||
assert_equal '', @response.body
|
||||
end
|
||||
member = Member.find(2)
|
||||
assert_equal [1,2], member.role_ids.sort
|
||||
end
|
||||
assert_response :unprocessable_entity
|
||||
assert_equal 'application/xml', @response.content_type
|
||||
assert_tag 'errors', :child => {:tag => 'error', :content => /member_roles is invalid/}
|
||||
end
|
||||
|
||||
should "return errors on failure" do
|
||||
put '/memberships/2.xml', {:membership => {:user_id => 3, :role_ids => [99]}}, credentials('jsmith')
|
||||
test "DELETE /memberships/:id.xml should destroy the membership" do
|
||||
assert_difference 'Member.count', -1 do
|
||||
delete '/memberships/2.xml', {}, credentials('jsmith')
|
||||
|
||||
assert_response :unprocessable_entity
|
||||
assert_equal 'application/xml', @response.content_type
|
||||
assert_tag 'errors', :child => {:tag => 'error', :content => /member_roles is invalid/}
|
||||
end
|
||||
end
|
||||
assert_response :ok
|
||||
assert_equal '', @response.body
|
||||
end
|
||||
assert_nil Member.find_by_id(2)
|
||||
end
|
||||
|
||||
context "DELETE" do
|
||||
context "xml" do
|
||||
should "destroy membership" do
|
||||
assert_difference 'Member.count', -1 do
|
||||
delete '/memberships/2.xml', {}, credentials('jsmith')
|
||||
test "DELETE /memberships/:id.xml should respond with 422 on failure" do
|
||||
assert_no_difference 'Member.count' do
|
||||
# A membership with an inherited role can't be deleted
|
||||
Member.find(2).member_roles.first.update_attribute :inherited_from, 99
|
||||
delete '/memberships/2.xml', {}, credentials('jsmith')
|
||||
|
||||
assert_response :ok
|
||||
assert_equal '', @response.body
|
||||
end
|
||||
assert_nil Member.find_by_id(2)
|
||||
end
|
||||
|
||||
should "respond with 422 on failure" do
|
||||
assert_no_difference 'Member.count' do
|
||||
# A membership with an inherited role can't be deleted
|
||||
Member.find(2).member_roles.first.update_attribute :inherited_from, 99
|
||||
delete '/memberships/2.xml', {}, credentials('jsmith')
|
||||
|
||||
assert_response :unprocessable_entity
|
||||
end
|
||||
end
|
||||
end
|
||||
assert_response :unprocessable_entity
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user