From 9e743932d1bd76e3beaf937f3843a9f43643b705 Mon Sep 17 00:00:00 2001 From: Eric Davis Date: Fri, 23 May 2008 16:18:40 -0700 Subject: [PATCH] Updated deliverable.progress to return 100 if it has no issues. #1136 --- app/models/deliverable.rb | 2 +- spec/models/deliverable_spec.rb | 9 ++++++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/app/models/deliverable.rb b/app/models/deliverable.rb index 2cd3bbe..cbdcdaf 100644 --- a/app/models/deliverable.rb +++ b/app/models/deliverable.rb @@ -17,7 +17,7 @@ class Deliverable < ActiveRecord::Base # TODO LATER: Shouldn't require the default_done_ratio patch def progress - return 100 unless self.issues.count > 0 + return 100 unless self.issues.size > 0 total = self.issues.collect(&:estimated_hours).inject {|sum, n| sum + n} balance = 0.0 diff --git a/spec/models/deliverable_spec.rb b/spec/models/deliverable_spec.rb index 411ca1f..b8b76a7 100644 --- a/spec/models/deliverable_spec.rb +++ b/spec/models/deliverable_spec.rb @@ -149,7 +149,14 @@ describe Deliverable, '.progress' do @deliverable.progress.should eql(66) end - it 'should return 100 if there are no assigned issues' + it 'should return 100 if there are no assigned issues' do + @deliverable = Deliverable.new({ :subject => 'test' }) + @deliverable.should_receive(:issues).and_return([]) + + @deliverable.progress.should eql(100) + end + + it 'should not change when hours are clocked' it 'should change if issues are assigned' it 'should change if issues are unassigned'