From 55aa5052434032cdd03ef92362cacb39f7a0456f Mon Sep 17 00:00:00 2001 From: Eric Davis Date: Thu, 12 Jun 2008 15:41:49 -0700 Subject: [PATCH] Refactored arrows. #1274 --- app/helpers/deliverables_helper.rb | 20 ++++++++++++++++++++ app/views/deliverables/_deliverable.html.erb | 9 +-------- 2 files changed, 21 insertions(+), 8 deletions(-) diff --git a/app/helpers/deliverables_helper.rb b/app/helpers/deliverables_helper.rb index 0537a33..410ffd4 100644 --- a/app/helpers/deliverables_helper.rb +++ b/app/helpers/deliverables_helper.rb @@ -43,4 +43,24 @@ module DeliverablesHelper def l_field(field, prefix='') l((prefix + field.to_s).to_sym) end + + def toggle_arrows(deliverable_id) + open_js = "$('deliverable-details-#{deliverable_id}').show(); $$('.toggle_#{deliverable_id}').each(function(e) {e.toggle();})" + close_js = "$('deliverable-details-#{deliverable_id}').hide(); $$('.toggle_#{deliverable_id}').each(function(e) {e.toggle();})" + + return toggle_arrow(deliverable_id, "toggle-arrow-closed.gif", open_js, false) + + toggle_arrow(deliverable_id, "toggle-arrow-open.gif", close_js, true) + end + + def toggle_arrow(deliverable_id, image, js, hide=false) + style = "display:none;" if hide + style ||= '' + + content_tag(:span, + link_to_function(image_tag(image, :plugin => "budget_plugin"), js), + :class => "toggle_" + deliverable_id.to_s, + :style => style + ) + + end end diff --git a/app/views/deliverables/_deliverable.html.erb b/app/views/deliverables/_deliverable.html.erb index 7b4c284..277cf68 100644 --- a/app/views/deliverables/_deliverable.html.erb +++ b/app/views/deliverables/_deliverable.html.erb @@ -1,14 +1,7 @@ <% css = cycle('odd','even') %> - - <%= link_to_function(image_tag("toggle-arrow-closed.gif", :plugin => "budget_plugin"), - "$('deliverable-details-#{deliverable.id}').show(); $$('.toggle_#{deliverable.id}').each(function(e) {e.toggle();})") %> - - + <%= toggle_arrows(deliverable.id) %> <%= content_tag(:td, deliverable.id) %>