From fd0284bcc4809f3cb93fdaf06cb58c3fa85708c8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javier=20B=C3=A9rtoli?= <javier@netmanagers.com.ar>
Date: Sat, 10 Aug 2013 12:00:23 -0300
Subject: [PATCH] Remove /bin/true as a default value for actions

---
 manifests/action.pp                  | 10 +++++-----
 spec/defines/fail2ban_action_spec.rb |  5 -----
 2 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/manifests/action.pp b/manifests/action.pp
index 2117b69..7d22769 100644
--- a/manifests/action.pp
+++ b/manifests/action.pp
@@ -75,7 +75,7 @@ define fail2ban::action (
 
   $array_start = is_array($actionstart) ? {
     false     => $actionstart ? {
-      ''      => ['/bin/true'],
+      ''      => [],
       default => [$actionstart],
     },
     default   => $actionstart,
@@ -83,7 +83,7 @@ define fail2ban::action (
 
   $array_stop = is_array($actionstop) ? {
     false     => $actionstop? {
-      ''      => ['/bin/true'],
+      ''      => [],
       default => [$actionstop],
     },
     default   => $actionstop,
@@ -91,7 +91,7 @@ define fail2ban::action (
 
   $array_check = is_array($actioncheck) ? {
     false     => $actioncheck? {
-      ''      => ['/bin/true'],
+      ''      => [],
       default => [$actioncheck],
     },
     default   => $actioncheck,
@@ -99,7 +99,7 @@ define fail2ban::action (
 
   $array_ban = is_array($actionban) ? {
     false     => $actionban? {
-      ''      => ['/bin/true'],
+      ''      => [],
       default => [$actionban],
     },
     default   => $actionban,
@@ -107,7 +107,7 @@ define fail2ban::action (
 
   $array_unban = is_array($actionunban) ? {
     false     => $actionunban? {
-      ''      => ['/bin/true'],
+      ''      => [],
       default => [$actionunban],
     },
     default   => $actionunban,
diff --git a/spec/defines/fail2ban_action_spec.rb b/spec/defines/fail2ban_action_spec.rb
index ec35ea1..999c73a 100644
--- a/spec/defines/fail2ban_action_spec.rb
+++ b/spec/defines/fail2ban_action_spec.rb
@@ -24,11 +24,6 @@ describe 'fail2ban::action' do
 
 [Definition]
 
-actionstart = /bin/true
-actionstop = /bin/true
-actioncheck = /bin/true
-actionban = /bin/true
-actionunban = /bin/true
 
 [Init]
 "