From 7b4eabf0c585f6b5b372ce786b5b6b0fad64d51e Mon Sep 17 00:00:00 2001 From: Kevin McAllister Date: Thu, 6 Sep 2012 15:13:21 -0400 Subject: [PATCH] Remove explicit wrapping of Shellwords.escape in double quotes According to http://www.ruby-doc.org/stdlib-1.9.3/libdoc/shellwords/rdoc/Shellwords.html#method-c-shellescape "Note that a resulted string should be used unquoted and is not intended for use in double quotes nor in single quotes." --- lib/foreman/export/base.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/foreman/export/base.rb b/lib/foreman/export/base.rb index 72dd464..5541006 100644 --- a/lib/foreman/export/base.rb +++ b/lib/foreman/export/base.rb @@ -91,7 +91,7 @@ private ###################################################################### end def shell_quote(value) - '"' + Shellwords.escape(value) + '"' + Shellwords.escape(value) end # deprecated