diff --git a/lib/foreman/engine.rb b/lib/foreman/engine.rb index ca9cc65..b624986 100644 --- a/lib/foreman/engine.rb +++ b/lib/foreman/engine.rb @@ -22,7 +22,7 @@ class Foreman::Engine @procfile = read_procfile(procfile) @directory = File.expand_path(File.dirname(procfile)) @options = options - @environment = read_environment(options[:env]) + @environment = read_environment_files(options[:env]) end def processes @@ -202,22 +202,29 @@ private ###################################################################### puts "!!! e.g. web: thin start" end - def read_environment(filename) - error "No such file: #{filename}" if filename && !File.exists?(filename) - filename ||= ".env" + def read_environment_files(filenames) environment = {} - if File.exists?(filename) - File.read(filename).split("\n").each do |line| - if line =~ /\A([A-Za-z_]+)=(.*)\z/ - environment[$1] = $2 - end - end + (filenames || "").split(",").map(&:strip).each do |filename| + error "No such file: #{filename}" unless File.exists?(filename) + environment.merge!(read_environment(filename)) end + environment.merge!(read_environment(".env")) unless filenames environment end + def read_environment(filename) + return {} unless File.exists?(filename) + + File.read(filename).split("\n").inject({}) do |hash, line| + if line =~ /\A([A-Za-z_]+)=(.*)\z/ + hash[$1] = $2 + end + hash + end + end + def runner File.expand_path("../../../bin/foreman-runner", __FILE__) end diff --git a/spec/foreman/engine_spec.rb b/spec/foreman/engine_spec.rb index 17273de..74022fe 100644 --- a/spec/foreman/engine_spec.rb +++ b/spec/foreman/engine_spec.rb @@ -79,6 +79,16 @@ describe "Foreman::Engine" do engine.execute("alpha") end + it "should read more than one if specified" do + File.open("/tmp/env1", "w") { |f| f.puts("FOO=bar") } + File.open("/tmp/env2", "w") { |f| f.puts("BAZ=qux") } + engine = Foreman::Engine.new("Procfile", :env => "/tmp/env1,/tmp/env2") + stub(engine).info + mock(engine).watch_for_termination + engine.environment.should == { "FOO"=>"bar", "BAZ"=>"qux" } + engine.execute("alpha") + end + it "should fail if specified and doesnt exist" do mock.instance_of(Foreman::Engine).error("No such file: /tmp/env") engine = Foreman::Engine.new("Procfile", :env => "/tmp/env")