oops, changing error messages breaks tests. make them match again. don't change the tests. change the error messages. that way the error message's awkwardness hints at the code's awkwardness.

This commit is contained in:
Scott Walters committed 2014-08-21 07:34:19 -04:00
1 parent f2ce9511e0
commit d2f324a7f2
2 files changed
+2 -2

No files matched your search

+1 -1
View File
@@ -106,7 +106,7 @@ sub serialize {
@possible_namespace_names = sort { $a eq '#default' ? 1 : $b eq '#default' ? -1 : $a cmp $b } @possible_namespace_names; @possible_namespace_names = sort { $a eq '#default' ? 1 : $b eq '#default' ? -1 : $a cmp $b } @possible_namespace_names;
if( grep( $_ ne '#default', @possible_namespace_names ) > 1 or ! @possible_namespace_names ) { if( grep( $_ ne '#default', @possible_namespace_names ) > 1 or ! @possible_namespace_names ) {
die "no or too many possible names for our namespace of ``$ns'': ``@possible_namespace_names''; there should be just one and maybe a '#default' entry"; die "No prefix found for namespace $ns, or too many possible names: ``@possible_namespace_names''; there should be just one and maybe a '#default' entry";
} }
my $prefix = $possible_namespace_names[0]; my $prefix = $possible_namespace_names[0];
+1 -1
View File
@@ -109,7 +109,7 @@ sub _serialize_single {
@possible_namespace_names = sort { $a eq '#default' ? 1 : $b eq '#default' ? -1 : $a cmp $b } @possible_namespace_names; @possible_namespace_names = sort { $a eq '#default' ? 1 : $b eq '#default' ? -1 : $a cmp $b } @possible_namespace_names;
if( grep( $_ ne '#default', @possible_namespace_names ) > 1 or ! @possible_namespace_names ) { if( grep( $_ ne '#default', @possible_namespace_names ) > 1 or ! @possible_namespace_names ) {
die "no or too many possible names for our namespace of ``$ns'': ``@possible_namespace_names''; there should be just one and maybe a '#default' entry"; die "No prefix found for namespace $ns, or too many possible names: ``@possible_namespace_names''; there should be just one and maybe a '#default' entry";
} }
my $prefix = $possible_namespace_names[0]; my $prefix = $possible_namespace_names[0];
$xml .= ' type="' . $prefix . ':' . $self->get_name() .'"'; $xml .= ' type="' . $prefix . ':' . $self->get_name() .'"';