dinislage/SOAP-WSDL
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

protip: reverse %hash with '#default' => 'urn:myNamespace', 'tns' =>

Browse Source 
'urn:myNamespace' results in misery.  random hash ordering made a pile of
tests in t/003_wsdl_based_serializer.t randomly pass and fail in unison.
I smelled a smell.
This commit is contained in:
Scott Walters
2014-08-21 06:32:11 -04:00
parent 3670df3e69
commit 47dc61bd9e
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/SOAP/WSDL/XSD/SimpleType.pm
View File

@@ -100,10 +100,18 @@ sub _serialize_single {
$xml .= '<' . join ' ', $name, @{ $opt->{ attributes } }; $xml .= '<' . join ' ', $name, @{ $opt->{ attributes } };
if ( $opt->{ autotype }) { if ( $opt->{ autotype }) {
# reverse namespace by prefix hash # reverse namespace by prefix hash
my %prefix_of = reverse %{ $opt->{ namespace } };
my $ns = $self->get_targetNamespace(); my $ns = $self->get_targetNamespace();
my $prefix = $prefix_of{ $ns }
|| die 'No prefix found for namespace '. $ns; # build a list of hash keys (eg '#default', 'tns') whose values match our namespace (eg 'urn:myNamespace')
(my @possible_namespace_names) = grep { $opt->{ namespace }->{$_} eq $ns } keys %{ $opt->{ namespace } };
# put any '#default' option last
@possible_namespace_names = sort { $a eq '#default' ? 1 : $b eq '#default' ? -1 : $a cmp $b } @possible_namespace_names;
if( grep( $_ ne '#default', @possible_namespace_names ) > 1 or ! @possible_namespace_names ) {
die "no or too many possible names for our namespace of ``$ns'': ``@possible_namespace_names''; there should be just one and maybe a '#default' entry";
}
my $prefix = $possible_namespace_names[0];
$xml .= ' type="' . $prefix . ':' . $self->get_name() .'"'; $xml .= ' type="' . $prefix . ':' . $self->get_name() .'"';
} }