// Release branch merged

CONTRIBUTORS.md

@@ -16,14 +16,13 @@
 - bMancone
 - bumbu
 - Burhan
+- Cédric Mouleyre
 - Caleydon Media
 - cam.lafit
 - Captain FLAM
 - Captain-FLAM
 - ccauw
-- Cédric Mouleyre
 - ChristopheBoucaut
-- CINS
 - cippest
 - cmouleyre
 - Corentin Delcourt
@@ -35,50 +34,42 @@
 - David Gasperoni
 - Davy Rolink
 - djfm
-- dlage
 - dMetzger
 - (d)oekia
 - Dragan Skrbic
+- DrÿSs'
 - dreammeup
 - DrySs
-- DrÿSs
-- DrÿSs'
 - dSevere
 - Edouard Gaulué
 - emily-d
 - Fabio Chelly
 - fBrignoli
 - fram
-- Francois Gaillard
 - François Gaillard
-- Fran?s Gaillard
 - fSerny
 - Gabriel Schwardy
 - gBrunier
 - gCharmes
 - gPoulain
-- gr4devel
 - Grégoire Bélorgey
 - Gregory Roussac
 - gRoussac
 - Guillaume DELOINCE
-- ha99y
 - hAitmansour
 - Ha!*!*y
 - indesign47
 - inem0o
 - ivancasasempere
+- Jérôme Nadaud
 - jBreux
-- jeckyl
 - jeromenadaud
 - Jerome Nadaud
-- Jérôme Nadaud
 - jessylenne
 - jmCollin
 - jObregon
 - Jonathan Danse
 - joseantgv
-- Julien
 - Kevin Granger
 - kpodemski
 - Krystian Podemski
@@ -86,11 +77,8 @@
 - lCherifi
 - ldecoker
 - lLefevre
-- LOIC ROSSET ltd
-- makk1ntosh
 - marcinsz101
 - Marco Cervellin
-- matiasiglesias
 - Mats Rynge
 - MatthieuB
 - Maxence
@@ -113,39 +101,32 @@
 - PhpMadman
 - Pierre
 - Piotr Kaczor
-- Piotr Mocko
+- Piotr Moćko
 - PrestaEdit
 - prestarocket
-- Prestaspirit
 - pxls
+- Rémi Gaillard
 - Raphaël Malié
 - raulgundin
-- Rémi Gaillard
 - rGaillard
 - Rimas Kudelis
 - rMalie
 - rMontagne
-- romainberger
 - root
 - runningz
-- sagaradonis
+- Sébastien
+- Sébastien Bocahu
 - Samy Rabih
 - Sarah Lorenzini
 - Seb
-- Sébastien
-- Sébastien Bocahu
 - Seynaeve
 - Shagshag
-- sjousse
 - sLorenzini
-- smartdatasoft
-- soufyan
 - soware
 - Staging
 - sThiebaut
 - Sylvain WITMEYER
 - tDidierjean
-- unknown
 - vAugagneur
 - vChabot
 - Vincent Augagneur
@@ -157,5 +138,3 @@
 - Xavier
 - Xavier POITAU
 - Yoozio
-- zimmi1
-

README.md

@@ -2,45 +2,44 @@ README
 ======
 ![PrestaShop](http://www.prestashop.com/images/banners/general/prestashop_728x90.png "PrestaShop")
 
-ABOUT
+PREPARATION
 --------
 
-PrestaShop is a free and open-source e-commerce web application, committed to providing the best shopping cart experience for both merchants and consumers.
+To install PrestaShop, you need a remote web server or on your computer (MAMP), with access to a database like MySQL.
-
+You'll need access to phpMyAdmin to create a database and to indicate the information in the database in the installer.
-
-SERVER CONFIGURATION
---------
-
-To install PrestaShop, you need a web server running PHP5 and any flavor of MySQL5 (MySQL, MariaDB, Percona Server...).
-You will also need a database administration tool, such as phpMyAdmin, in order to create a database for PrestaShop.
-We recommend the Apache or Nginx web servers.
-
-If your host does not offer PHP5 by default, here are a few [explanations][2] about PHP5 or the .htaccess file for certain hosting services (1&1, Free, Lycos, OVH, Infomaniak, Amen, GoDaddy, etc).
-
-If you want your online store ready to go, visit [http://www.prestabox.com][1]: it lets you create your online store in less than 10 minutes without any technical knowledge.
 
+If you do not host and unable to create your store, we offer a turnkey store, which lets you create your online store in less than 10 minutes without any technical knowledge.
+We invite you to visit: [http://www.prestabox.com][1]
 
 INSTALLATION
 --------
 
-With your web browser, go to the root of your PrestaShop directory, and the installer will start. Follow the instructions until PrestaShop is installed.
+Simply go to your PrestaShop web directory and use installer :-)
 
-If you have any PHP error, perhaps you don't have PHP5 or you need to activate it on your web host. See the page linked above.
+If you have any PHP error, perhaps you don't have PHP5 or you need to activate it on your web host.
-If you don't find any solution to start the installer, please post on [the PrestaShop forums][3].
+Please go to our forum to find pre-installation settings (PHP 5, htaccess) for certain hosting services (1&1, Free, Lycos, OVH, Infomaniak, Amen, GoDaddy, etc).
 
+English webhost [specifics settings][2]
+
+
+If you don't find any solution to launch installer, please post on [our forum][3]
+
+
+There are always solutions for your issues ;-)
 
 DOCUMENTATION
 --------
 
-The official PrestaShop documentation is available online [on its own website][4].
+For any extra documentation (how-to), please read our [Online documentation][4]
 
 
 FORUMS
 --------
 
-You can discuss, help and contribute with PrestaShop community on [the PrestaShop forums][5].
+You can also discuss, help and contribute with PrestaShop community on [our forums][5]
 
-Thank you for downloading and using PrestaShop e-commerce Open-source solution!
+
+Thanks for downloading and using PrestaShop e-commerce Open-source solution!
 
 [1]: http://www.prestabox.com
 [2]: http://www.prestashop.com/forums/topic/2946-pre-installation-settings-php-5-htaccess-for-certain-hosting-services/

admin-dev/ajax.php

@@ -26,12 +26,45 @@
 
 define('_PS_ADMIN_DIR_', getcwd());
 include(_PS_ADMIN_DIR_.'/../config/config.inc.php');
-
 /* Getting cookie or logout */
 require_once(_PS_ADMIN_DIR_.'/init.php');
 
 $context = Context::getContext();
 
+if (Tools::isSubmit('changeParentUrl'))
+	echo '<script type="text/javascript">parent.parent.document.location.href = "'.addslashes(urldecode(Tools::getValue('changeParentUrl'))).'";</script>';
+if (Tools::isSubmit('installBoughtModule'))
+{
+	$file = false;
+	while ($file === false OR file_exists(_PS_MODULE_DIR_.$file))
+		$file = uniqid();
+	$file = _PS_MODULE_DIR_.$file.'.zip';
+	$sourceFile = 'http://addons.prestashop.com/iframe/getboughtfile.php?id_order_detail='.Tools::getValue('id_order_detail').'&token='.Tools::getValue('token');
+	if (!copy($sourceFile, $file))
+	{
+		if (!($content = file_get_contents($sourceFile)))
+			die(displayJavascriptAlert('Access denied: Please download your module directly from PrestaShop Addons website'));
+		elseif (!file_put_contents($file, $content))
+			die(displayJavascriptAlert('Local error: your module directory is not writable'));
+	}
+	$first6 = fread($fd = fopen($file, 'r'), 6);
+	if (!strncmp($first6, 'Error:', 6))
+	{
+		$displayJavascriptAlert = displayJavascriptAlert(fread($fd, 1024));
+		fclose($fd);
+		unlink($file);
+		die($displayJavascriptAlert);
+	}
+	fclose($fd);
+	if (!Tools::ZipExtract($file, _PS_MODULE_DIR_))
+	{
+		unlink($file);
+		die(displayJavascriptAlert('Cannot unzip file'));
+	}
+	unlink($file);
+	die(displayJavascriptAlert('Module copied to disk'));
+}
+
 if (Tools::isSubmit('ajaxReferrers'))
 {
 	require(_PS_CONTROLLER_DIR_.'admin/AdminReferrersController.php');
@@ -68,6 +101,39 @@ if (Tools::isSubmit('ajaxProductPackItems'))
 	die('['.implode(',', $jsonArray).']');
 }
 
+if (Tools::isSubmit('ajaxStates') AND Tools::isSubmit('id_country'))
+{
+	$states = Db::getInstance()->executeS('
+	SELECT s.id_state, s.name
+	FROM '._DB_PREFIX_.'state s
+	LEFT JOIN '._DB_PREFIX_.'country c ON (s.`id_country` = c.`id_country`)
+	WHERE s.id_country = '.(int)(Tools::getValue('id_country')).' AND s.active = 1 AND c.`contains_states` = 1
+	ORDER BY s.`name` ASC');
+
+	if (is_array($states) AND !empty($states))
+	{
+		$list = '';
+		if (Tools::getValue('no_empty') != true)
+		{
+			$empty_value = (Tools::isSubmit('empty_value')) ? Tools::getValue('empty_value') : '----------';
+			$list = '<option value="0">'.Tools::htmlentitiesUTF8($empty_value).'</option>'."\n";
+		}
+
+		foreach ($states AS $state)
+			$list .= '<option value="'.(int)($state['id_state']).'"'.((isset($_GET['id_state']) AND $_GET['id_state'] == $state['id_state']) ? ' selected="selected"' : '').'>'.$state['name'].'</option>'."\n";
+	}
+	else
+		$list = 'false';
+
+	die($list);
+}
+
+if (Tools::getValue('form_language_id'))
+{
+	if (!($context->cookie->employee_form_lang = (int)(Tools::getValue('form_language_id'))))
+		die ('Error while updating cookie.');
+	die ('Form language updated.');
+}
 
 if (Tools::isSubmit('submitTrackClickOnHelp'))
 {
@@ -78,6 +144,15 @@ if (Tools::isSubmit('submitTrackClickOnHelp'))
         HelpAccess::trackClick($label, $version);
 }
 
+if (Tools::isSubmit('toggleScreencast'))
+{
+	if (Validate::isLoadedObject($context->employee))
+	{
+		$context->employee->bo_show_screencast = !$context->employee->bo_show_screencast;
+		$context->employee->update();
+	}
+}
+
 if (Tools::isSubmit('getChildrenCategories') && Tools::isSubmit('id_category_parent'))
 {
 	$children_categories = Category::getChildrenWithNbSelectedSubCat(Tools::getValue('id_category_parent'), Tools::getValue('selectedCat'), Context::getContext()->language->id, null, Tools::getValue('use_shop_context'));
@@ -125,6 +200,17 @@ if (Tools::isSubmit('getParentCategoriesId') && $id_category = Tools::getValue('
 	die(Tools::jsonEncode($output));
 }
 
+/* Update attribute */
+if (Tools::isSubmit('ajaxUpdateTaxRule'))
+{
+	$id_tax_rule = Tools::getValue('id_tax_rule');
+	$tax_rules = new TaxRule((int)$id_tax_rule);
+	$output = array();
+	foreach ($tax_rules as $key => $result)
+		$output[$key] = $result;
+	die(Tools::jsonEncode($output));
+}
+
 if (Tools::isSubmit('getZones'))
 {
 	$zones = Zone::getZones();
@@ -137,3 +223,8 @@ if (Tools::isSubmit('getZones'))
 	$array = array('hasError' => false, 'errors' => '', 'data' => $html);
 	die(Tools::jsonEncode($html));
 }
+
+function displayJavascriptAlert($s)
+{
+	echo '<script type="text/javascript">alert(\''.addslashes($s).'\');</script>';
+}

admin-dev/index.php

@@ -27,9 +27,6 @@
 $timer_start = microtime(true);
 define('_PS_ADMIN_DIR_', getcwd());
 
-if (!defined('PS_ADMIN_DIR'))
-	define('PS_ADMIN_DIR', _PS_ADMIN_DIR_);
-
 require(_PS_ADMIN_DIR_.'/../config/config.inc.php');
 require(_PS_ADMIN_DIR_.'/functions.php');
 

admin-dev/init.php

@@ -49,12 +49,9 @@ try
 	AdminTab::$currentIndex = $currentIndex;
 
 	$iso = $context->language->iso_code;
-	if (file_exists(_PS_TRANSLATIONS_DIR_.$iso.'/errors.php'))
+	include(_PS_TRANSLATIONS_DIR_.$iso.'/errors.php');
-		include(_PS_TRANSLATIONS_DIR_.$iso.'/errors.php');
+	include(_PS_TRANSLATIONS_DIR_.$iso.'/fields.php');
-	if (file_exists(_PS_TRANSLATIONS_DIR_.$iso.'/fields.php'))
+	include(_PS_TRANSLATIONS_DIR_.$iso.'/admin.php');
-		include(_PS_TRANSLATIONS_DIR_.$iso.'/fields.php');
-	if (file_exists(_PS_TRANSLATIONS_DIR_.$iso.'/admin.php'))
-		include(_PS_TRANSLATIONS_DIR_.$iso.'/admin.php');
 
 	/* Server Params */
 	$protocol_link = (Configuration::get('PS_SSL_ENABLED')) ? 'https://' : 'http://';

admin-dev/themes/default/css/admin.css

@@ -30,7 +30,6 @@ select[disabled="disabled"], input[disabled="disabled"],textarea[disabled="disab
 
 /*BUTTON*/
 .button{
-	cursor: pointer;
 	background: #e3e3e3 url('../img/bg-button-degrade.png') repeat-x scroll left top;
 	background: -moz-linear-gradient(center top , #F9F9F9, #E3E3E3) repeat scroll 0 0 transparent;
 	background: -webkit-gradient(linear, center top ,center bottom, from(#F9F9F9), to(#E3E3E3)) repeat scroll 0 0 transparent;

admin-dev/themes/default/template/controllers/addresses/helpers/form/form.tpl

@@ -66,8 +66,7 @@
 						{
 							if (msg)
 							{
-								var infos = msg.infos.replace("\\'", "'").split('_');
+								var infos = msg.infos.split('_');
-
 								$('input[name=firstname]').val(infos[0]);
 								$('input[name=lastname]').val(infos[1]);
 								$('input[name=company]').val(infos[2]);

admin-dev/themes/default/template/controllers/groups/helpers/form/form.tpl

@@ -48,11 +48,11 @@
 		<script type="text/javascript">
 		$(document).ready(function() {
 			$("#group_discount_category").fancybox({
-				beforeLoad: function () {
+				onStart: function () {
 					$('#group_discount_category_fancybox').show();
 					initFancyBox();
 				},
-				beforeClose: function () {
+				onClosed: function () {
 					$('#group_discount_category_fancybox').hide();
 				}
 			});

admin-dev/themes/default/template/controllers/groups/helpers/view/view.tpl

@@ -58,7 +58,6 @@
 		</ul>
 	</fieldset>
 	<h2>{l s='Members of this customer group'}</h2>
-	<p>{l s='Limited to the first 100 customers.'} {l s='Please use filters to narrow your search.'}</p>
 	{$customerList}
 
 {/block}

admin-dev/themes/default/template/controllers/home/content.tpl

@@ -110,14 +110,14 @@ $(document).ready(function() {
 		</ul>
 
 	<div id="partner_preactivation">
-		<p class="center"><img src="../img/loader.gif" alt="" /> {l s='Loading...'}</p>
+		<p class="center"><img src="../img/loader.gif" alt="" /></p>
 	</div>
 
 	<div class="separation"></div>
 
 
 	{$tips_optimization}
-	<div id="discover_prestashop"><p class="center"><img src="../img/loader.gif" alt="" /> {l s='Loading...'}</p></div>
+	<div id="discover_prestashop"><p class="center"><img src="../img/loader.gif" alt="" />{l s='Loading...'}</p></div>
 
 	{hook h="displayAdminHomeInfos"}
 	{hook h="displayBackOfficeHome"} {*old name of the hook*}
@@ -212,7 +212,7 @@ $(document).ready(function() {
 		{
 			// don't show/hide screencast if it's deactivated
 			{if $employee->bo_show_screencast}
-				$('#adminpresentation').fadeOut('slow');
+			$('#adminpresentation').fadeOut('slow');
 			{/if}
 			$('#partner_preactivation').fadeOut('slow');
 			$('#discover_prestashop').fadeOut('slow');

admin-dev/themes/default/template/controllers/import/helpers/form/form.tpl

@@ -1,8 +1,8 @@
 {*
 * 2007-2013 PrestaShop
-**
+*
 * NOTICE OF LICENSE
-**
+*
 * This source file is subject to the Academic Free License (AFL 3.0)
 * that is bundled with this package in the file LICENSE.txt.
 * It is also available through the world-wide-web at this URL:
@@ -10,25 +10,72 @@
 * If you did not receive a copy of the license and are unable to
 * obtain it through the world-wide-web, please send an email
 * to license@prestashop.com so we can send you a copy immediately.
-**
+*
 * DISCLAIMER
-**
+*
 * Do not edit or add to this file if you wish to upgrade PrestaShop to newer
 * versions in the future. If you wish to customize PrestaShop for your
 * needs please refer to http://www.prestashop.com for more information.
-**
+*
 *  @author PrestaShop SA <contact@prestashop.com>
 *  @copyright  2007-2013 PrestaShop SA
 *  @license    http://opensource.org/licenses/afl-3.0.php  Academic Free License (AFL 3.0)
 *  International Registered Trademark & Property of PrestaShop SA
 *}
+
 {include file="toolbar.tpl" toolbar_btn=$toolbar_btn toolbar_scroll=$toolbar_scroll title=$title}
 <div class="leadin">{block name="leadin"}{/block}</div>
+
 {if $module_confirmation}
 	<div class="module_confirmation conf confirm">
 		{l s='Your .CSV file has been sucessfully imported into your shop.'}
 	</div>
 {/if}
+
+<script type="text/javascript">
+
+	var truncateAuthorized = {$truncateAuthorized|intval};
+
+	$(document).ready(function(){
+		activeClueTip();
+		$("a#upload_file_import_link").fancybox({
+				'titleShow' : false,
+				'transitionIn' : 'elastic',
+				'transitionOut' : 'elastic'
+		});
+
+		$('#preview_import').submit(function(e) {
+			if ($('#truncate').get(0).checked)
+			{
+				console.log(truncateAuthorized);
+				if (truncateAuthorized)
+				{
+					if (!confirm('{l s='Are you sure that you would like to delete this' js=1}' + ' ' + $.trim($('#entity > option:selected').text().toLowerCase()) + '?'))
+					{
+						e.preventDefault();
+					}
+				}
+				else
+				{
+					jAlert('{l s='You do not have permission to delete here. When the multistore is enabled, only a SuperAdmin can delete all items before an import.' js=1}');
+					return false;
+				}
+			}
+		});
+	});
+
+	function activeClueTip()
+	{
+		$('.info_import').cluetip({
+			splitTitle: '|',
+		    showTitle: false
+	 	});
+	};
+</script>
+
+{** 
+ * Upload fancybox 
+ *}
 <div style="display: none">
 	<div id="upload_file_import" style="padding-left: 10px; background-color: #EBEDF4; border: 1px solid #CCCED7">
 		<div class="clear">&nbsp;</div>
@@ -50,16 +97,28 @@
 		</form>
 	</div>
 </div>
+
 <div class="clear">&nbsp;</div>
-<form id="preview_import" action="{$current}&token={$token}" method="post" style="display:inline" enctype="multipart/form-data" class="clear">
+
+{** 
+ * Import fieldset 
+ *}
+<form id="preview_import"
+	action="{$current}&token={$token}"
+	method="post"
+	style="display:inline"
+	enctype="multipart/form-data"
+	class="clear">
+	
 	<fieldset style="float: left; margin: 0pt 20px 0pt 0pt; width: 70%;">
 		<legend><img src="../img/admin/import.gif" />{l s='Import   '}</legend>
+
 			<label class="clear">{if count($files_to_import) > 1}{l s='Your CSV file (%d files):' sprintf=count($files_to_import)}{else}{l s='Your CSV file (%d file):' sprintf=count($files_to_import)}{/if}</label>
 			<div class="margin-form">
 				{if count($files_to_import)}
 					<select name="csv">
 						{foreach $files_to_import AS $filename}
-							<option value="{$filename}"{if $csv_selected == $filename} selected="selected"{/if}>{$filename|escape:'htmlall':'UTF-8'}</option>
+							<option value="{$filename}">{$filename}</option>
 						{/foreach}
 					</select>
 				{/if}
@@ -67,43 +126,33 @@
 				<a href="#upload_file_import" id="upload_file_import_link" class="button"><img src="../img/admin/add.gif" alt="Uplaod" title="Upload" />{l s='Upload'}</a>
 			</div>
 			<div style="width:50%; margin: 0 auto;">
-				<div style="width:50%; display: inline-block; float :left;">
+				<a href="#" onclick="$('#sample_files_import').slideToggle(); return false;">{l s='Click to view our sample import csv files.'}</a>
-					<a href="#" onclick="$('#sample_files_import').slideToggle(); return false;">{l s='Click to view our sample import csv files.'}</a>
+				<ul id="sample_files_import" style="display:none">
-					<ul id="sample_files_import" style="display:none;">
+					<li><a href="../docs/csv_import/categories_import.csv">{l s='Sample Categories file'}</a></li>
-						<li><a class="_blank" href="../docs/csv_import/categories_import.csv">{l s='Sample Categories file'}</a></li>
+					<li><a href="../docs/csv_import/products_import.csv">{l s='Sample Products file'}</a></li>
-						<li><a class="_blank" href="../docs/csv_import/products_import.csv">{l s='Sample Products file'}</a></li>
+					<li><a href="../docs/csv_import/combinations_import.csv">{l s='Sample Combinations file'}</a></li>
-						<li><a class="_blank" href="../docs/csv_import/combinations_import.csv">{l s='Sample Combinations file'}</a></li>
+					<li><a href="../docs/csv_import/customers_import.csv">{l s='Sample Customers file'}</a></li>
-						<li><a class="_blank" href="../docs/csv_import/customers_import.csv">{l s='Sample Customers file'}</a></li>
+					<li><a href="../docs/csv_import/addresses_import.csv">{l s='Sample Addresses file'}</a></li>
-						<li><a class="_blank" href="../docs/csv_import/addresses_import.csv">{l s='Sample Addresses file'}</a></li>
+					<li><a href="../docs/csv_import/manufacturers_import.csv">{l s='Sample Manufacturers file'}</a></li>
-						<li><a class="_blank" href="../docs/csv_import/manufacturers_import.csv">{l s='Sample Manufacturers file'}</a></li>
+					<li><a href="../docs/csv_import/suppliers_import.csv">{l s='Sample Suppliers file'}</a></li>
-						<li><a class="_blank" href="../docs/csv_import/suppliers_import.csv">{l s='Sample Suppliers file'}</a></li>
+					{if $PS_ADVANCED_STOCK_MANAGEMENT}
-						{if $PS_ADVANCED_STOCK_MANAGEMENT}
+						<li><a href="../docs/csv_import/supply_orders_import.csv">{l s='Supply Orders sample file'}</a></li>
-							<li><a class="_blank" href="../docs/csv_import/supply_orders_import.csv">{l s='Supply Orders sample file'}</a></li>
+						<li><a href="../docs/csv_import/supply_orders_details_import.csv">{l s='Supply Orders Details sample file'}</a></li>
-							<li><a class="_blank" href="../docs/csv_import/supply_orders_details_import.csv">{l s='Supply Orders Details sample file'}</a></li>
+					{/if}
-						{/if}
+				</ul>
-					</ul>
-				</div>
-				<div style="width:50%; float:left;">
-					<a href="#" onclick="$('#csv_files_import').slideToggle(); return false;">{l s='Click to view your csv files.'}</a>
-					<ul id="csv_files_import" style="display:none;">
-							{foreach $files_to_import AS $filename}
-								<li><a href="{$current}&token={$token}&csvfilename={$filename|@base64_encode}">{$filename}</a>&nbsp;&nbsp;
-<a href="{$current}&token={$token}&csvfilename={$filename|@base64_encode}&delete=1"><img src="../img/admin/delete.gif" /></a></li>
-							{/foreach}
-					</ul>
-				</div>
 				<div class="clear">&nbsp;</div>
 			</div>
 			<label class="clear">{l s='What kind of entity would you like to import?'} </label>
 			<div class="margin-form">
 				<select name="entity" id="entity">
 					{foreach $entities AS $entity => $i}
-						<option value="{$i}"{if $entity_selected == $i} selected="selected"{/if}>
+						<option value="{$i}" {if $entity == $i}selected="selected"{/if}>
 							{$entity}
 						</option>
 					{/foreach}
 				</select>
 			</div>
+				
 			<label class="clear">{l s='Language of the file'}</label>
 			<div class="margin-form">
 				<select name="iso_lang">
@@ -119,30 +168,26 @@
 			</div>
 			<label class="clear">{l s='Field separator'} </label>
 			<div class="margin-form">
-				<input type="text" size="2" value="{if isset($separator_selected)}{$separator_selected|escape:'htmlall':'UTF-8'}{else};{/if}" name="separator"/>
+				<input type="text" size="2" value=";" name="separator"/>
 				{l s='e.g. '}"1<span class="bold" style="color: red">;</span>Ipod<span class="bold" style="color: red">;</span>129.90<span class="bold" style="color: red">;</span>5"
 			</div>
 			<label class="clear">{l s='Multiple value separator'} </label>
 			<div class="margin-form">
-				<input type="text" size="2" value="{if isset($multiple_value_separator_selected)}{$multiple_value_separator_selected|escape:'htmlall':'UTF-8'}{else},{/if}" name="multiple_value_separator"/>
+				<input type="text" size="2" value="," name="multiple_value_separator"/>
 				{l s='e.g. '}"Ipod;red.jpg<span class="bold" style="color: red">,</span>blue.jpg<span class="bold" style="color: red">,</span>green.jpg;129.90"
 			</div>
 			<label for="truncate" class="clear">{l s='Delete all'} <span id="entitie">{l s='categories'}</span> {l s='before import?'} </label>
 			<div class="margin-form">
 				<input name="truncate" id="truncate" type="checkbox"/>
 			</div>
-			<label for="regenerate" class="clear">{l s='No thumbnails regeneration'}</label>
+				<label for="match_ref" class="clear" style="display: none">{l s='Use product reference as key?'}</label>
 			<div class="margin-form">
-				<input name="regenerate" id="regenerate" type="checkbox" />
+				<input name="match_ref" id="match_ref" type="checkbox" style="margin-top: 6px; display:none"/>
 			</div>
 			<label for="forceIDs" class="clear">{l s='Force all ID\'s during import?'} </label>
 			<div class="margin-form">
 				<input name="forceIDs" id="forceIDs" type="checkbox"/> {l s='If you don\'t use this option, all ID\'s will be auto-incremented.'}
 			</div>
-			<label for="match_ref" class="clear" style="display: none">{l s='Use product reference as key?'}</label>
-			<div class="margin-form">
-				<input name="match_ref" id="match_ref" type="checkbox" style="margin-top: 6px; display:none"/>
-			</div>
 			<div class="space margin-form">
 				<input type="submit" name="submitImportFile" value="{l s='Next step'}" class="button" {if empty($files_to_import)}disabled{/if}/>
 				{if empty($files_to_import)}<span style="color:red;">{l s='You must upload a file in order to proceed to the next step'}</span>{/if}
@@ -165,10 +210,13 @@
 		{/if}
 	</fieldset>
 </form>
+
 <fieldset style="display:block;">
+
 	<legend>
 		<img src="../img/admin/import.gif" />{l s='Available fields'}
 	</legend>
+
 	<div id="availableFields">
 		{$available_fields}
 	</div>
@@ -176,88 +224,74 @@
 	<div class="clear">
 		<br /><br />{l s='* Required field'}
 	</div>
+
 </fieldset>
+		
 <div class="clear">&nbsp;</div>
+
 <script type="text/javascript">
-	$(document).ready(function(){
+	$("select#entity").change( function() {
-		var truncateAuthorized = {$truncateAuthorized|intval};
-		activeClueTip();
-		$("a#upload_file_import_link").fancybox({
-				'titleShow' : false,
-				'transitionIn' : 'elastic',
-				'transitionOut' : 'elastic'
-		});
 
-		$('#preview_import').submit(function(e){
+		if ($("#entity > option:selected").val() == 7 || $("#entity > option:selected").val() == 8)
-			if ($('#truncate').get(0).checked)
-				if (truncateAuthorized)
-				{
-					if (!confirm('{l s='Are you sure that you would like to delete this' js=1}' + ' ' + $.trim($('#entity > option:selected').text().toLowerCase()) + '?'))
-						e.preventDefault();
-				}
-				else
-				{
-					jAlert('{l s='You do not have permission to delete here. When the multistore is enabled, only a SuperAdmin can delete all items before an import.' js=1}');
-					return false;
-				}
-		});
-
-		$("select#entity").change(function(){
-			if ($("#entity > option:selected").val() == 7 || $("#entity > option:selected").val() == 8)
-				$("label[for=truncate],#truncate").hide();
-			else
-				$("label[for=truncate],#truncate").show();
-	
-			if ($("#entity > option:selected").val() == 8)
-			{
-				$(".import_supply_orders_details").show();
-				$('input[name=multiple_value_separator]').val('|');
-			}
-			else
-			{
-				$(".import_supply_orders_details").hide();
-				$('input[name=multiple_value_separator]').val('{if isset($multiple_value_separator_selected)}{$multiple_value_separator_selected}{else},{/if}');
-			}
-			if ($("#entity > option:selected").val() == 1)
-				$("label[for=match_ref], #match_ref, label[for=regenerate], #regenerate").show();
-			else
-				$("label[for=match_ref], #match_ref, label[for=regenerate], #regenerate").hide();
-			if ($("#entity > option:selected").val() == 1 || $("#entity > option:selected").val() == 0)
-				$(".import_products_categories, label[for=regenerate], #regenerate").show();
-			else
-				$(".import_products_categories, label[for=regenerate], #regenerate").hide();
-			if ($("#entity > option:selected").val() == 0 || $("#entity > option:selected").val() == 1 || $("#entity > option:selected").val() == 3 || $("#entity > option:selected").val() == 5 || $("#entity > option:selected").val() == 6)
-				$("label[for=forceIDs], #forceIDs").show();
-			else
-				$("label[for=forceIDs], #forceIDs").hide();
-			$("#entitie").html($("#entity > option:selected").text().toLowerCase());
-			$.ajax({
-				url: 'ajax.php',
-				data: {
-					getAvailableFields:1,
-					entity: $("#entity").val()
-				},
-				dataType: 'json',
-				success: function(j){
-					var fields = "";
-					$("#availableFields").empty();
-					
-					for (var i = 0; i < j.length; i++)
-						fields += j[i].field;
-	
-					$("#availableFields").html(fields);
-					activeClueTip();
-				},
-				error: function(j){}			
-			});
-		});
-		$("select#entity").trigger('change');
-		function activeClueTip()
 		{
-			$('.info_import').cluetip({
+			$("label[for=truncate],#truncate").hide();
-				splitTitle: '|',
+		}
-			    showTitle: false
+		else
-		 	});
+			$("label[for=truncate],#truncate").show();
-		};	
+
+
+		if ($("#entity > option:selected").val() == 8)
+		{
+			$(".import_supply_orders_details").show();
+			$('input[name=multiple_value_separator]').val('|');
+		}
+		else
+		{
+			$(".import_supply_orders_details").hide();
+			$('input[name=multiple_value_separator]').val(',');
+		}
+		
+		
+		if ($("#entity > option:selected").val() == 1)
+		{
+			$("label[for=match_ref],#match_ref").show();
+		}
+		else
+			$("label[for=match_ref],#match_ref").hide();
+
+		if ($("#entity > option:selected").val() == 1 || $("#entity > option:selected").val() == 0)
+		{
+			$(".import_products_categories").show();
+		}
+		else
+			$(".import_products_categories").hide();
+
+		if ($("#entity > option:selected").val() == 0 || $("#entity > option:selected").val() == 1 || $("#entity > option:selected").val() == 3 || $("#entity > option:selected").val() == 5 || $("#entity > option:selected").val() == 6)
+			$("label[for=forceIDs],#forceIDs").show();
+		else
+			$("label[for=forceIDs],#forceIDs").hide();
+
+		$("#entitie").html($("#entity > option:selected").text().toLowerCase());
+		$.ajax({
+			url: 'ajax.php',
+			data: {
+				getAvailableFields:1,
+				entity: $("#entity").val()
+			},
+			dataType: 'json',
+			success: function(j) {
+				var fields = "";
+				$("#availableFields").empty();
+				
+				for (var i = 0; i < j.length; i++)
+					fields += j[i].field;
+
+				$("#availableFields").html(fields);
+				activeClueTip();
+			},
+			error: function(j) {		
+			}			
+		});
+
 	});
 </script>

admin-dev/themes/default/template/controllers/import/helpers/view/view.tpl

@@ -22,52 +22,20 @@
 *  @license    http://opensource.org/licenses/afl-3.0.php  Academic Free License (AFL 3.0)
 *  International Registered Trademark & Property of PrestaShop SA
 *}
+
 {extends file="helpers/view/view.tpl"}
+
 {block name="override_tpl"}
 	<script type="text/javascript">
-		var errorEmpty = '{l s='Please name your matching configuration to save.' js=1}';
+		var errorEmpty = "{l s='Please name your matching configuration to save.'}"
 		var token = '{$token}';
-		var current = 0;
-		function showTable(nb)
-		{
-			$('#btn_left').disabled = null;
-			$('#btn_right').disabled = null;
-			if (nb <= 0)
-			{
-				nb = 0;
-				$('#btn_left').disabled = 'true';
-			}
-			if (nb >= {$nb_table} - 1)
-			{
-				nb = {$nb_table} - 1;
-				$('#btn_right').disabled = 'true';
-			}
-			$('#table' + current).hide();
-			current = nb;
-			$('#table' + current).show();
-		}
-		$(document).ready(function(){
-			var btn_save_import = $('span[class~="process-icon-save-import"]').parent();
-			var btn_submit_import = $('#import');
-			if (btn_save_import.length > 0 && btn_submit_import.length > 0)
-			{
-				btn_submit_import.hide();
-				btn_save_import.find('span').removeClass('process-icon-save-import');
-				btn_save_import.find('span').addClass('process-icon-save');
-				btn_save_import.click(function(){
-					btn_submit_import.before('<input type="hidden" name="' + btn_submit_import.attr("name") + '" value="1" />');
-					$('#import_form').submit();
-				});
-			}
-			showTable(current);
-		});
 	</script>
 	<div id="container-customer">
 	<h2>{l s='View your data'}</h2>
 	<div>
-		<b>{l s='Save and load your configuration for importing files'} : </b><br/><br/>
+		<b>{l s='Save and load your configuration for importing files'} : </b><br><br>
-		<input type="text" name="newImportMatchs" id="newImportMatchs" />
+		<input type="text" name="newImportMatchs" id="newImportMatchs">
-		<a id="saveImportMatchs" class="button" href="#">{l s='Save'}</a><br /><br />
+		<a id="saveImportMatchs" class="button" href="#">{l s='Save'}</a><br><br>
 		<div id="selectDivImportMatchs" {if !$import_matchs}style="display:none"{/if}>
 			<select id="valueImportMatchs">
 				{foreach $import_matchs as $match}
@@ -78,18 +46,21 @@
 			<a class="button" id="deleteImportMatchs" href="#">{l s='Delete'}</a>
 		</div>
 	</div>
+
 	<h3>{l s='Please set the value type of each column'}</h3>
+
 	<div id="error_duplicate_type" class="warning warn" style="display:none;">
 		<h3>{l s='Columns cannot have the same value type'}</h3>
 	</div>
+
 	<div id="required_column" class="warning warn" style="display:none;">
 		<h3>{l s='Column'} <span id="missing_column">&nbsp;</span> {l s='must be set'}</h3>
 	</div>
+
 	<form action="{$current}&token={$token}" method="post" id="import_form" name="import_form">
 		{l s='Skip'} <input type="text" size="2" name="skip" value="1" /> {l s='lines'}
 		<input type="hidden" name="csv" value="{$fields_value.csv}" />
 		<input type="hidden" name="convert" value="{$fields_value.convert}" />
-		<input type="hidden" name="regenerate" value="{$fields_value.regenerate}" />
 		<input type="hidden" name="entity" value="{$fields_value.entity}" />
 		<input type="hidden" name="iso_lang" value="{$fields_value.iso_lang}" />
 		{if $fields_value.truncate}
@@ -101,8 +72,49 @@
 		{if $fields_value.match_ref}
 			<input type="hidden" name="match_ref" value="1" />
 		{/if}
-		<input type="hidden" name="separator" value="{$fields_value.separator}" />
+		<input type="hidden" name="separator" value="{$fields_value.separator}">
-		<input type="hidden" name="multiple_value_separator" value="{$fields_value.multiple_value_separator}" />
+		<input type="hidden" name="multiple_value_separator" value="{$fields_value.multiple_value_separator}">
+		<script type="text/javascript">
+			var current = 0;
+
+			function showTable(nb)
+			{
+				getE('btn_left').disabled = null;
+				getE('btn_right').disabled = null;
+				if (nb <= 0)
+				{
+					nb = 0;
+					getE('btn_left').disabled = 'true';
+				}
+				if (nb >= {$nb_table} - 1)
+				{
+					nb = {$nb_table} - 1;
+					getE('btn_right').disabled = 'true';
+				}
+				toggle(getE('table'+current), false);
+				current = nb;
+				toggle(getE('table'+current), true);
+			}
+
+			$(function() {
+				var btn_save_import = $('span[class~="process-icon-save-import"]').parent();
+				var btn_submit_import = $('#import');
+
+				if (btn_save_import.length > 0 && btn_submit_import.length > 0)
+				{
+					btn_submit_import.hide();
+					btn_save_import.find('span').removeClass('process-icon-save-import');
+					btn_save_import.find('span').addClass('process-icon-save');
+					btn_save_import.click(function() {
+						btn_submit_import.before('<input type="hidden" name="'+btn_submit_import.attr("name")+'" value="1" />');
+
+						$('#import_form').submit();
+					});
+				}
+			});
+
+		</script>
+
 		<table>
 			<tr>
 				<td colspan="3" align="center">
@@ -111,7 +123,7 @@
 			</tr>
 			<tr>
 				<td valign="top" align="center">
-					<input id="btn_left" value="{l s='<<'}" type="button" class="button" onclick="showTable(current - 1);" />
+					<input id="btn_left" value="{l s='<<'}" type="button" class="button" onclick="showTable(current - 1)" />
 				</td>
 				<td align="left">
 					{section name=nb_i start=0 loop=$nb_table step=1}
@@ -120,10 +132,12 @@
 					{/section}
 				</td>
 				<td valign="top" align="center">
-					<input id="btn_right" value="{l s='>>'}" type="button" class="button" onclick="showTable(current + 1);" />
+					<input id="btn_right" value="{l s='>>'}" type="button" class="button" onclick="showTable(current + 1)" />
 				</td>
 			</tr>
 		</table>
+		<script type="text/javascript">showTable(current);</script>
 	</form>
 	</div>
 {/block}
+

admin-dev/themes/default/template/controllers/localization/content.tpl

@@ -24,9 +24,9 @@
 *}
 
 <div class="width4">
-	{if isset($localization_form)}{$localization_form}{/if}
+	{$localization_form}
 </div>
 <br />
 <div class="width4">
-	{if isset($localization_options)}{$localization_options}{/if}
+	{$localization_options}
 </div>

admin-dev/themes/default/template/controllers/modules/list.tpl

@@ -77,7 +77,7 @@
 							</dl>
 						</div>
 						<p class="desc">{if isset($module->description) && $module->description ne ''}{l s='Description'} : {$module->description}{else}&nbsp;{/if}</p>
-						{if isset($module->message) && (empty($module->name) === false) && (!isset($module->type) || ($module->type != 'addonsMustHave' || $module->type !== 'addonsNative'))}<div class="conf">{$module->message}</div>{/if}
+						{if isset($module->message) && (!isset($module->type) || ($module->type != 'addonsMustHave' || $module->type !== 'addonsNative'))}<div class="conf">{$module->message}</div>{/if}
 						<div class="row-actions-module">
 							{if !isset($module->not_on_disk)}
 								{$module->optionsHtml}
@@ -101,7 +101,7 @@
 								<a href="{$module->addons_buy_url}" target="_blank" class="button updated"><span><img src="../img/admin/cart_addons.png">&nbsp;&nbsp;{if isset($module->id_currency) && isset($module->price)}{displayPrice price=$module->price currency=$module->id_currency}{/if}</span></a>
 							</li>
 						{else}
-							{if isset($module->version_addons) && $module->version_addons}
+							{if $module->id && isset($module->version_addons) && $module->version_addons}
 								<li><a href="{$module->options.update_url}" class="button updated"><span>{l s='Update it!'}</span></a></li>
 							{/if}
 								<li>

admin-dev/themes/default/template/controllers/orders/form.tpl

@@ -38,11 +38,6 @@
 	var defaults_order_state = new Array();
 	var customization_errors = false;
 	var pic_dir = '{$pic_dir}';
-	var currency_format = 5;
-	var currency_sign = '';
-	var currency_blank = false;
-	var priceDisplayPrecision = 2;
-	
 	{foreach from=$defaults_order_state key='module' item='id_order_state'}
 		defaults_order_state['{$module}'] = '{$id_order_state}';
 	{/foreach}
@@ -122,7 +117,7 @@
 							$('#vouchers_err').hide();
 						var mytab = new Array();
 						for (var i = 0; i < data.vouchers.length; i++)
-							mytab[mytab.length] = { data: data.vouchers[i], value: data.vouchers[i].name + (data.vouchers[i].code.length > 0 ? ' - ' + data.vouchers[i].code : '')};
+							mytab[mytab.length] = { data: data.vouchers[i], value: data.vouchers[i].name+' - '+data.vouchers[i].description };
 						return mytab;
 					},
 					extraParams: {
@@ -510,6 +505,7 @@
 				}
 				displaySummary(res);
 				resetBind();
+				updateCurrencySign();
 			}
 		});
 	}
@@ -656,12 +652,11 @@
 			var id_product = Number(this.id_product);
 			var id_product_attribute = Number(this.id_product_attribute);
 			cart_quantity[Number(this.id_product)+'_'+Number(this.id_product_attribute)+'_'+Number(this.id_customization)] = this.cart_quantity;
-			cart_content += '<tr><td><img src="'+this.image_link+'" title="'+this.name+'" /></td><td>'+this.name+'<br />'+this.attributes_small+'</td><td>'+this.reference+'</td><td><input type="text" size="7" rel="'+this.id_product+'_'+this.id_product_attribute+'" class="product_unit_price" value="' + formatCurrency(parseFloat(this.price.replace(',', '.')), currency_format, currency_sign, currency_blank) + '" /></td><td>';
+			cart_content += '<tr><td><img src="'+this.image_link+'" title="'+this.name+'" /></td><td>'+this.name+'<br />'+this.attributes_small+'</td><td>'+this.reference+'</td><td><input type="text" size="7" rel="'+this.id_product+'_'+this.id_product_attribute+'" class="product_unit_price" value="'+this.price+'" />&nbsp;<span class="currency_sign"></span></td><td>';
 			cart_content += (!this.id_customization ? '<div style="float:left;"><a href="#" class="increaseqty_product" rel="'+this.id_product+'_'+this.id_product_attribute+'_'+(this.id_customization ? this.id_customization : 0)+'" ><img src="../img/admin/up.gif" /></a><br /><a href="#" class="decreaseqty_product" rel="'+this.id_product+'_'+this.id_product_attribute+'_'+(this.id_customization ? this.id_customization : 0)+'"><img src="../img/admin/down.gif" /></a></div>' : '');
 			cart_content += (!this.id_customization ? '<div style="float:left;"><input type="text" rel="'+this.id_product+'_'+this.id_product_attribute+'_'+(this.id_customization ? this.id_customization : 0)+'" class="cart_quantity" size="2" value="'+this.cart_quantity+'" />' : '');
 			cart_content += (!this.id_customization ? '<a href="#" class="delete_product" rel="delete_'+this.id_product+'_'+this.id_product_attribute+'_'+(this.id_customization ? this.id_customization : 0)+'" ><img src="../img/admin/delete.gif" /></a></div>' : '');
-			cart_content += '</td><td>' + formatCurrency(parseFloat(this.total.replace(',', '.')), currency_format, currency_sign, currency_blank) + '</td></tr>';
+			cart_content += '</td><td>'+this.total+'&nbsp;<span class="currency_sign"></span></td></tr>';
-			
 			if (this.id_customization && this.id_customization != 0)
 			{
 				$.each(this.customized_datas[this.id_product][this.id_product_attribute][id_address_delivery], function() {
@@ -699,15 +694,17 @@
 	function updateCartVouchers(vouchers)
 	{
 		var vouchers_html = '';
-		if (typeof(vouchers) == 'object')
+		if (vouchers.length > 0)
-			$.each(vouchers, function(){
+		{
+			$.each(vouchers, function() {
 				vouchers_html += '<tr><td>'+this.name+'</td><td>'+this.description+'</td><td>'+this.value_real+'</td><td><a href="#" class="delete_discount" rel="'+this.id_discount+'"><img src="../img/admin/delete.gif" /></a></td></tr>';
 			});
-		$('#voucher_list tbody').html($.trim(vouchers_html));
-		if ($('#voucher_list tbody').html().length == 0)
-			$('#voucher_list').hide();
-		else
 			$('#voucher_list').show();
+		}
+		else
+			$('#voucher_list').hide();
+
+		$('#voucher_list tbody').html(vouchers_html);
 	}
 
 	function updateCartPaymentList(payment_list)
@@ -717,11 +714,6 @@
 
 	function displaySummary(jsonSummary)
 	{
-		currency_format = jsonSummary.currency.format;
-		currency_sign = jsonSummary.currency.sign;
-		currency_blank = jsonSummary.currency.blank;
-		priceDisplayPrecision = jsonSummary.currency.decimals ? 2 : 0;
-	
 		updateCartProducts(jsonSummary.summary.products, jsonSummary.summary.gift_products, jsonSummary.cart.id_address_delivery);
 		updateCartVouchers(jsonSummary.summary.discounts);
 		updateAddressesList(jsonSummary.addresses, jsonSummary.cart.id_address_delivery, jsonSummary.cart.id_address_invoice);
@@ -747,19 +739,20 @@
 			$('#free_shipping').removeAttr('checked');
 
 		$('#gift_message').html(jsonSummary.cart.gift_message);
-		if (!changed_shipping_price)
+		if(!changed_shipping_price)
-			$('#shipping_price').html('<b>' + formatCurrency(parseFloat(jsonSummary.summary.total_shipping), currency_format, currency_sign, currency_blank) + '</b>');
+			$('#shipping_price').html('<b>'+jsonSummary.summary.total_shipping+'</b>');
 		shipping_price_selected_carrier = jsonSummary.summary.total_shipping;
 
-		$('#total_vouchers').html(formatCurrency(parseFloat(jsonSummary.summary.total_discounts_tax_exc.replace(',', '.')), currency_format, currency_sign, currency_blank));
+		$('#total_vouchers').html(jsonSummary.summary.total_discounts_tax_exc);
-		$('#total_shipping').html(formatCurrency(parseFloat(jsonSummary.summary.total_shipping_tax_exc.replace(',', '.')), currency_format, currency_sign, currency_blank));
+		$('#total_shipping').html(jsonSummary.summary.total_shipping_tax_exc);
-		$('#total_taxes').html(formatCurrency(parseFloat(jsonSummary.summary.total_tax.replace(',', '.')), currency_format, currency_sign, currency_blank));
+		$('#total_taxes').html(jsonSummary.summary.total_tax);
-		$('#total_without_taxes').html(formatCurrency(parseFloat(jsonSummary.summary.total_price_without_tax.replace(',', '.')), currency_format, currency_sign, currency_blank));
+		$('#total_without_taxes').html(jsonSummary.summary.total_price_without_tax);
-		$('#total_with_taxes').html(formatCurrency(parseFloat(jsonSummary.summary.total_price.replace(',', '.')), currency_format, currency_sign, currency_blank));
+		$('#total_with_taxes').html(jsonSummary.summary.total_price);
-		$('#total_products').html(formatCurrency(parseFloat(jsonSummary.summary.total_products.replace(',', '.')), currency_format, currency_sign, currency_blank));
+		$('#total_products').html(jsonSummary.summary.total_products);
 		id_currency = jsonSummary.cart.id_currency;
 		$('#id_currency option').removeAttr('selected');
 		$('#id_currency option[value="'+id_currency+'"]').attr('selected', true);
+		updateCurrencySign();
 		id_lang = jsonSummary.cart.id_lang;
 		$('#id_lang option').removeAttr('selected');
 		$('#id_lang option[value="'+id_lang+'"]').attr('selected', true);
@@ -787,21 +780,21 @@
 				qty: qty,
 				id_customer: id_customer,
 				id_cart: id_cart,
-			},
+				},
 			success : function(res)
 			{
-				displaySummary(res);
+					displaySummary(res);
-				var errors = '';
+					var errors = '';
-				if (res.errors.length)
+					if(res.errors.length)
-				{
+					{
-					$.each(res.errors, function() {
+						$.each(res.errors, function() {
-						errors += this + '<br />';
+							errors += this+'<br />';
-					});
+						});
-					$('#products_err').show();
+						$('#products_err').show();
-				}
+					}
-				else
+					else
-					$('#products_err').hide();
+						$('#products_err').hide();
-				$('#products_err').html(errors);
+					$('#products_err').html(errors);
 			}
 		});
 	}
@@ -897,6 +890,11 @@
 		});
 	}
 
+	function updateCurrencySign()
+	{
+		$('.currency_sign').html(currencies[id_currency]);
+	}
+
 	function sendMailToCustomer()
 	{
 		$.ajax({
@@ -988,7 +986,7 @@
 	<label>{l s='Search customers'}</label>
 	<div class="margin-form">
 		<input type="text" id="customer" value="" />
-		<p>{l s='Search a customer by typing the first letters of his/her name'}</p>
+		<p>{l s='Search a customer by tapping the first letters of his/her name'}</p>
 		<a class="fancybox button" href="{$link->getAdminLink('AdminCustomers')|escape:'htmlall':'UTF-8'}&addcustomer&liteDisplaying=1&submitFormAjax=1#">
 			<img src="../img/admin/add.gif" title="new"/><span>{l s='Add new customer'}</span>
 		</a>
@@ -1003,7 +1001,7 @@
 		<div class="margin-form">
 			<input type="hidden" value="" id="id_cart" name="id_cart" />
 			<input type="text" id="product" value="" />
-			<p>{l s='Search a product by typing the first letters of his/her name.'}</p>
+			<p>{l s='Search a product by tapping the first letters of his/her name.'}</p>
 		</div>
 		<div id="products_found">
 			<div id="product_list">
@@ -1188,7 +1186,7 @@
 				</select>
 			</p>
 			<p>
-				<label for="shipping_price">{l s='Shipping price'}</label> <span id="shipping_price"  name="shipping_price"></span>
+				<label for="shipping_price">{l s='Shipping price'}</label> <span id="shipping_price"  name="shipping_price"></span>&nbsp;<span class="currency_sign"></span>&nbsp;
 			</p>
 			<p>
 				<label for="free_shipping">{l s='Free shipping'}</label>
@@ -1212,12 +1210,12 @@
 	<div id="send_email_feedback"></div>
 	<div id="cart_summary" style="clear:both;float:left;">
 		<ul>
-			<li><span class="total_cart">{l s='Total products'}</span><span id="total_products"></span></li>
+			<li><span class="total_cart">{l s='Total products'}</span><span id="total_products"></span><span class="currency_sign"></span></li>
-			<li><span class="total_cart">{l s='Total vouchers'}</span><span id="total_vouchers"></span></li>
+			<li><span class="total_cart">{l s='Total vouchers'}</span><span id="total_vouchers"></span><span class="currency_sign"></span></li>
-			<li><span class="total_cart">{l s='Total shipping'}</span><span id="total_shipping"></span></li>
+			<li><span class="total_cart">{l s='Total shipping'}</span><span id="total_shipping"></span><span class="currency_sign"></span></li>
-			<li><span class="total_cart">{l s='Total taxes'}</span><span id="total_taxes"></span></li>
+			<li><span class="total_cart">{l s='Total taxes'}</span><span id="total_taxes"></span><span class="currency_sign"></span></li>
-			<li><span class="total_cart">{l s='Total without taxes'}</span><span id="total_without_taxes"></span></li>
+			<li><span class="total_cart">{l s='Total without taxes'}</span><span id="total_without_taxes"></span><span class="currency_sign"></span></li>
-			<li><span class="total_cart">{l s='Total with taxes'}</span><span id="total_with_taxes"></span></li>
+			<li><span class="total_cart">{l s='Total with taxes'}</span><span id="total_with_taxes"></span><span class="currency_sign"></span></li>
 		</ul>
 	</div>
 	<div class="order_message_right">

admin-dev/themes/default/template/controllers/orders/helpers/view/view.tpl

@@ -153,7 +153,7 @@
 			<br />
 			<fieldset>
 				<legend><img src="../img/admin/tab-customers.gif" /> {l s='Customer information'}</legend>
-				<span style="font-weight: bold; font-size: 14px;"><a href="?tab=AdminCustomers&id_customer={$customer->id}&viewcustomer&token={getAdminToken tab='AdminCustomers'}"> {$gender->name|escape:'htmlall':'UTF-8'} {$customer->firstname} {$customer->lastname}</a></span> ({l s='#'}{$customer->id})<br />
+				<span style="font-weight: bold; font-size: 14px;"><a href="?tab=AdminCustomers&id_customer={$customer->id}&viewcustomer&token={getAdminToken tab='AdminCustomers'}"> {$customer->firstname} {$customer->lastname}</a></span> ({l s='#'}{$customer->id})<br />
 				(<a href="mailto:{$customer->email}">{$customer->email}</a>)<br /><br />
 				{if ($customer->isGuest())}
 					{l s='This order has been placed by a guest.'}

admin-dev/themes/default/template/controllers/performance/helpers/form/form.tpl

@@ -41,7 +41,7 @@
 	{/if}
 	{$smarty.block.parent}
 	{if $input.type == 'radio' && $input.name == 'smarty_cache'}
-			<a href="{$current}&token={$token}&empty_smarty_cache=1" class="clear button" href="">{l s='Clear Smarty cache & Autoload cache'}</a>
+			<a href="{$current}&token={$token}&empty_smarty_cache=1" class="clear button" href="">{l s='Clear Smarty cache'}</a>
 	{/if}		
 {/block}
 

admin-dev/themes/default/template/controllers/products/informations.tpl

@@ -166,7 +166,7 @@
 	</tr>
 	<tr class="redirect_product_options" style="display:none">
 		<td class="col-left">
-			{include file="controllers/products/multishop/checkbox.tpl" field="redirect_type" type="radio" onclick=""}
+			{include file="controllers/products/multishop/checkbox.tpl" field="active" type="radio" onclick=""}
 			<label class="text">{l s='Redirect:'}</label>
 		</td>
 		<td style="padding-bottom:5px;">
@@ -184,7 +184,7 @@
 	</tr>
 	<tr class="redirect_product_options redirect_product_options_product_choise" style="display:none">
 		<td class="col-left">
-			{include file="controllers/products/multishop/checkbox.tpl" field="id_product_redirected" type="radio" onclick=""}
+			{include file="controllers/products/multishop/checkbox.tpl" field="active" type="radio" onclick=""}
 			<label class="text">{l s='Related product:'}</label>
 		</td>
 		<td style="padding-bottom:5px;">

admin-dev/themes/default/template/controllers/products/input_text_lang.tpl

@@ -29,7 +29,7 @@
 	<input size="30" type="text" id="{$input_name}_{$language.id_lang}" 
 	name="{$input_name}_{$language.id_lang}"
 		value="{$input_value[$language.id_lang]|htmlentitiesUTF8|default:''}"
-		onkeyup="if (isArrowKey(event)) return ;updateFriendlyURL();" onblur="updateLinkRewrite();"/>
+		onkeyup="if (isArrowKey(event)) return ;updateFriendlyURL();"/>
 </div>
 {/foreach}
 </div>

admin-dev/themes/default/template/controllers/products/prices.tpl

@@ -178,7 +178,7 @@ $(document).ready(function () {
 	</tr>
 	<tr {if !$ps_use_ecotax} style="display:none;"{/if}>
 		<td class="col-left">
-			{include file="controllers/products/multishop/checkbox.tpl" field="ecotax" type="default"}
+			{include file="controllers/products/multishop/checkbox.tpl" field="ecot" type="default"}
 			<label>{l s='Eco-tax (tax incl.):'}</label>
 		</td>
 		<td>

admin-dev/themes/default/template/controllers/products/suppliers.tpl

@@ -75,7 +75,7 @@
 	<p>{l s='Click "Save and Stay" after changing selected suppliers to display the associated product references.'}</p>
 	<div id="suppliers_accordion" style="margin-top:10px; display:block;">
 		{foreach from=$associated_suppliers item=supplier}
-		    <h3 style="margin-bottom:0;"><a href="#">{if isset($supplier->name)}{$supplier->name}{/if}</a></h3>
+		    <h3 style="margin-bottom:0;"><a href="#">{$supplier->name}</a></h3>
 		    <div style="display:block;">
 
 				<table cellpadding="10" cellspacing="0" class="table">

admin-dev/themes/default/template/controllers/specific_price_rule/helpers/form/form.tpl

@@ -41,7 +41,7 @@
 				<div class="margin-form">
 					<select id="id_category" name="id_category">
 						{foreach from=$categories item='category'}
-						<option value="{$category.id_category|intval}">({$category.id_category|intval}) {$category.name}</option>
+						<option value="{$category.id_category}">{$category.name}</option>
 						{/foreach}
 					</select>
 					<a class="button bt-icon" href="#" id="add_condition_category">

admin-dev/themes/default/template/controllers/stores/helpers/options/options.tpl

@@ -30,9 +30,9 @@
     function ajaxStoreStates(id_state_selected)
 {
     $.ajax({
-	url: "index.php",
+	url: "ajax.php",
 	cache: false,
-	data: "ajax=1&tab=AdminStates&token={getAdminToken tab='AdminStates'}&action=states&id_country="+$('#PS_SHOP_COUNTRY_ID').val() + "&id_state=" + $('#PS_SHOP_STATE_ID').val(),
+	data: "ajaxStates=1&id_country="+$('#PS_SHOP_COUNTRY_ID').val() + "&id_state=" + $('#PS_SHOP_STATE_ID').val(),
 	success: function(html)
 	{
 	    if (html == 'false')

admin-dev/themes/default/template/controllers/supply_orders_change_state/helpers/form/form.tpl

@@ -54,7 +54,7 @@ $(document).ready(function() {
 </div>
 
 <div class="margin-form">
-<input type="submit" id="{$table}_form_submit_btn" value="{l s='Save'}" name="submitChangestate" class="button" style="display: none;">
+<input type="submit" id="_form_submit_btn" value="{l s='Save'}" name="submitChangestate" class="button" style="display: none;">
 </div>
 {/if}
 {/block}

admin-dev/themes/default/template/controllers/tax_rules/helpers/form/form.tpl

@@ -60,9 +60,9 @@
 			$("#states-label").hide();
 		} else {
 			$.ajax({
-				url: "index.php",
+				url: "ajax.php",
 				cache: false,
-				data: "ajax=1&tab=AdminStates&token={getAdminToken tab='AdminStates'}&action=states&id_country="+id_country+"&id_state="+id_state+"&empty_value={l s='All'}",
+				data: "ajaxStates=1&id_country="+id_country+"&id_state="+id_state+"&empty_value={l s='All'}",
 				success: function(html){
 					if (html == "false")
 					{
@@ -88,10 +88,10 @@
 	{
 		$.ajax({
 			type: 'POST',
-			url: 'index.php',
+			url: 'ajax.php',
 			async: true,
 			dataType: 'json',
-			data: 'ajax=1&tab=AdminTaxRulesGroup&token={getAdminToken tab='AdminTaxRulesGroup'}&ajaxStates=1&action=updateTaxRule&id_tax_rule='+id_tax_rule,
+			data: 'ajaxStates=1&ajaxUpdateTaxRule=1&id_tax_rule='+id_tax_rule,
 			success: function(data){
 				$('#tax_rule_form').show();
 				$('#id_tax_rule').val(data.id);

admin-dev/themes/default/template/controllers/tax_rules/helpers/list/list_header.tpl

@@ -33,22 +33,22 @@
 {/if}
 
 <form method="post" action="{$currentIndex}&{$identifier}&token={$token}&id_tax_rules_group={$id_tax_rules_group}&updatetax_rules_group#{$table}" class="form">
-	<input type="hidden" id="submitFilter{$list_id}" name="submitFilter{$list_id}" value="0"/>
+	<input type="hidden" id="submitFilter{$table}" name="submitFilter{$table}" value="0"/>
 	<table class="table_grid">
 		<tr>
 			<td style="vertical-align: bottom;">
 				<span style="float: left;">
 					{if $page > 1}
-						<input type="image" src="../img/admin/list-prev2.gif" onclick="getE('submitFilter{$list_id}').value=1"/>&nbsp;
+						<input type="image" src="../img/admin/list-prev2.gif" onclick="getE('submitFilter{$table}').value=1"/>&nbsp;
-						<input type="image" src="../img/admin/list-prev.gif" onclick="getE('submitFilter{$list_id}').value={$page - 1}"/>
+						<input type="image" src="../img/admin/list-prev.gif" onclick="getE('submitFilter{$table}').value={$page - 1}"/>
 					{/if}
 					{l s='Page'} <b>{$page}</b> / {$total_pages}
 					{if $page < $total_pages}
-						<input type="image" src="../img/admin/list-next.gif" onclick="getE('submitFilter{$list_id}').value={$page + 1};"/>&nbsp;
+						<input type="image" src="../img/admin/list-next.gif" onclick="getE('submitFilter{$table}').value={$page + 1};"/>&nbsp;
-						<input type="image" src="../img/admin/list-next2.gif" onclick="getE('submitFilter{$list_id}').value={$total_pages}"/>
+						<input type="image" src="../img/admin/list-next2.gif" onclick="getE('submitFilter{$table}').value={$total_pages}"/>
 					{/if}
 					| {l s='Display'}
-					<select name="{$list_id}_pagination" onchange="submit()">
+					<select name="pagination" onchange="submit()">
 						{* Choose number of results per page *}
 						{foreach $pagination AS $value}
 							<option value="{$value|intval}"{if $selected_pagination == $value} selected="selected" {elseif $selected_pagination == NULL && $value == $pagination[1]} selected="selected2"{/if}>{$value|intval}</option>
@@ -57,7 +57,7 @@
 					/ {$list_total} {l s='result(s)'}
 				</span>
 				<span style="float: right;">
-					<input type="submit" name="submitReset{$list_id}" value="{l s='Reset'}" class="button" />
+					<input type="submit" name="submitReset{$table}" value="{l s='Reset'}" class="button" />
 				</span>
 				<span class="clear"></span>
 			</td>
@@ -66,7 +66,7 @@
 			<td>
 				<table
 				{if $table_id} id={$table_id}{/if}
-				class="table {if $table_dnd}tableDnD{/if} {$list_id}"
+				class="table {if $table_dnd}tableDnD{/if} {$table}"
 				cellpadding="0" cellspacing="0"
 				style="width: 100%; margin-bottom:10px;"
 				>
@@ -84,7 +84,7 @@
 						<tr class="nodrag nodrop">
 							<th class="center">
 								{if $has_bulk_actions}
-									<input type="checkbox" name="checkme" class="noborder" onclick="checkDelBoxes(this.form, '{$list_id}Box[]', this.checked)" />
+									<input type="checkbox" name="checkme" class="noborder" onclick="checkDelBoxes(this.form, '{$table}Box[]', this.checked)" />
 								{/if}
 							</th>
 							{foreach $fields_display AS $key => $params}

admin-dev/themes/default/template/helpers/form/form.tpl

@@ -30,7 +30,7 @@
 
 {if isset($fields.title)}<h2>{$fields.title}</h2>{/if}
 {block name="defaultForm"}
-<form id="{if isset($fields.form.form.id_form)}{$fields.form.form.id_form|escape:'htmlall':'UTF-8'}{else}{if $table == null}configuration_form{else}{$table}_form{/if}{/if}" class="defaultForm {$name_controller}" action="{$current}&{if !empty($submit_action)}{$submit_action}=1{/if}&token={$token}" method="post" enctype="multipart/form-data" {if isset($style)}style="{$style}"{/if}>
+<form id="{if isset($fields.form.form.id_form)}{$fields.form.form.id_form|escape:'htmlall':'UTF-8'}{else}{$table}_form{/if}" class="defaultForm {$name_controller}" action="{$current}&{if !empty($submit_action)}{$submit_action}=1{/if}&token={$token}" method="post" enctype="multipart/form-data" {if isset($style)}style="{$style}"{/if}>
 	{if $form_id}
 		<input type="hidden" name="{$identifier}" id="{$identifier}" value="{$form_id}" />
 	{/if}
@@ -192,7 +192,7 @@
 									{/if}
 								{elseif $input.type == 'radio'}
 									{foreach $input.values as $value}
-										<input type="radio" name="{$input.name}" id="{$value.id}" value="{$value.value|escape:'htmlall':'UTF-8'}"
+										<input type="radio"	name="{$input.name}"id="{$value.id}" value="{$value.value|escape:'htmlall':'UTF-8'}"
 												{if $fields_value[$input.name] == $value.value}checked="checked"{/if}
 												{if isset($input.disabled) && $input.disabled}disabled="disabled"{/if} />
 										<label {if isset($input.class)}class="{$input.class}"{/if} for="{$value.id}">
@@ -432,8 +432,7 @@
 			};
 		{/foreach}
 		// we need allowEmployeeFormLang var in ajax request
-		allowEmployeeFormLang = {$allowEmployeeFormLang|intval};
+		allowEmployeeFormLang = {$allowEmployeeFormLang};
-		employee_token = '{getAdminToken tab='AdminEmployees'}';
 		displayFlags(languages, id_language, allowEmployeeFormLang);
 
 		$(document).ready(function() {
@@ -455,7 +454,6 @@
 				});
 
 		});
-	state_token = '{getAdminToken tab='AdminStates'}';
 	{block name="script"}{/block}
 	</script>
 {/if}

admin-dev/themes/default/template/helpers/options/options.tpl

@@ -34,7 +34,7 @@
 
 {block name="defaultOptions"}
 <form action="{$current}&token={$token}"
-	id="{if $table == null}configuration_form{else}{$table}_form{/if}"
+	id="{$table}_form"
 	{if isset($categoryData['name'])} name={$categoryData['name']}{/if}
 	{if isset($categoryData['id'])} id={$categoryData['id']} {/if}
 	method="post"

admin-dev/themes/default/template/toolbar.tpl

@@ -36,7 +36,7 @@
 						{if $k == 'modules-list'}
 							<div id="modules_list_container" style="display:none">
 							<div style="float:right;margin:5px">
-								<a href="#" onclick="$('#modules_list_container').slideUp();return false;"><img alt="X" src="../img/admin/close.png" /></a>
+								<a href="#" onclick="$('#modules_list_container').slideUp();return false;"><img alt="X" src="../img/admin/close.png"></a>
 							</div>
 							<div id="modules_list_loader"><img src="../img/loader.gif" alt="" border="0" /></div>
 							<div id="modules_list_container_tab" style="display:none;"></div>

classes/AdminTab.php

@@ -1303,7 +1303,7 @@ abstract class AdminTabCore
 		}
 
 		$asso = Shop::getAssoTable($this->table);
-		if ($asso !== false && $asso['type'] == 'shop')
+		if ($asso !== false && $assos['type'] == 'shop')
 		{
 			$filterKey = $asso['type'];
 			$idenfierShop = Shop::getContextListShopID();

classes/Autoload.php

@@ -54,8 +54,6 @@ class Autoload
 		$this->root_dir = dirname(dirname(__FILE__)).'/';
 		if (file_exists($this->root_dir.Autoload::INDEX_FILE))
 			$this->index = include($this->root_dir.Autoload::INDEX_FILE);
-		else
-			$this->generateIndex();
 	}
 
 	/**
@@ -82,8 +80,9 @@ class Autoload
 		if (strpos(strtolower($classname), 'smarty_') === 0)
 			return;
 
-		// regenerate the class index if the requested file doesn't exists
+		// regenerate the class index if the requested class is not found in the index or if the requested file doesn't exists
-		if ((isset($this->index[$classname]) && $this->index[$classname] && !is_file($this->root_dir.$this->index[$classname]))
+		if (!isset($this->index[$classname])
+			|| ($this->index[$classname] && !is_file($this->root_dir.$this->index[$classname]))
 			|| (isset($this->index[$classname.'Core']) && $this->index[$classname.'Core'] && !is_file($this->root_dir.$this->index[$classname.'Core'])))
 			$this->generateIndex();
 
@@ -139,14 +138,18 @@ class Autoload
 		{
 			$filename_tmp = tempnam(dirname($filename), basename($filename.'.'));
 			if($filename_tmp !== FALSE and file_put_contents($filename_tmp, $content, LOCK_EX) !== FALSE)
-			{
+            {
-				@rename($filename_tmp, $filename);
+				rename($filename_tmp, $filename);
-				@chmod($filename, 0666);
+                @chmod($filename, 0664);
 			}
-			else
+            else
-				// $filename_tmp couldn't be written. $filename should be there anyway (even if outdated), no need to die.
+            {
+				// $filename_tmp couldn't be written. $filename should be there anyway (even if outdated),
+				// no need to die.
 				error_log('Cannot write temporary file '.$filename_tmp);
+			}
 		}
+
 		$this->index = $classes;
 	}
 
@@ -189,3 +192,4 @@ class Autoload
 		return isset($this->index[$classname]) ? $this->index[$classname] : null;
 	}
 }
+

classes/Carrier.php

@@ -775,11 +775,11 @@ class CarrierCore extends ObjectModel
 			if ($delete)
 				Db::getInstance()->execute('
 					DELETE FROM `'._DB_PREFIX_.'delivery` 
-					WHERE '.(is_null($values['id_shop']) ? 'ISNULL(`id_shop`) ' : 'id_shop = '.(int)$values['id_shop']).' 
+					WHERE id_shop = '.(int)$values['id_shop'].' 
-					AND '.(is_null($values['id_shop_group']) ? 'ISNULL(`id_shop`) ' : 'id_shop_group='.(int)$values['id_shop_group']).'
+					AND id_shop_group='.(int)$values['id_shop_group'].' 
 					AND id_carrier='.(int)$values['id_carrier'].
-					($values['id_range_price'] !== null ? ' AND id_range_price='.(int)$values['id_range_price'] : ' AND (ISNULL(`id_range_price`) OR `id_range_price` = 0)').
+					($values['id_range_price'] !== null ? ' AND id_range_price='.(int)$values['id_range_price'] : '').
-					($values['id_range_weight'] !== null ? ' AND id_range_weight='.(int)$values['id_range_weight'] : ' AND (ISNULL(`id_range_weight`) OR `id_range_weight` = 0)').'
+					($values['id_range_weight'] !== null ? ' AND id_range_weight='.(int)$values['id_range_weight'] : '').'
 					AND id_zone='.(int)$values['id_zone']
 				);
 

classes/Cart.php

@@ -340,7 +340,6 @@ class CartCore extends ObjectModel
 				'.($filter == CartRule::FILTER_ACTION_SHIPPING ? 'AND free_shipping = 1' : '').'
 				'.($filter == CartRule::FILTER_ACTION_GIFT ? 'AND gift_product != 0' : '').'
 				'.($filter == CartRule::FILTER_ACTION_REDUCTION ? 'AND (reduction_percent != 0 OR reduction_amount != 0)' : '')
-				.' ORDER by cr.priority ASC'
 			);
 			Cache::store($cache_key, $result);
 		}
@@ -430,7 +429,7 @@ class CartCore extends ObjectModel
 						product_shop.`available_for_order`, product_shop.`price`, product_shop.`active`, product_shop.`unity`, product_shop.`unit_price_ratio`, 
 						stock.`quantity` AS quantity_available, p.`width`, p.`height`, p.`depth`, stock.`out_of_stock`, p.`weight`,
 						p.`date_add`, p.`date_upd`, IFNULL(stock.quantity, 0) as quantity, pl.`link_rewrite`, cl.`link_rewrite` AS category,
-						CONCAT(LPAD(cp.`id_product`, 10, 0), LPAD(IFNULL(cp.`id_product_attribute`, 0), 10, 0), IFNULL(cp.`id_address_delivery`, 0)) AS unique_id, cp.id_address_delivery,
+						CONCAT(cp.`id_product`, IFNULL(cp.`id_product_attribute`, 0), IFNULL(cp.`id_address_delivery`, 0)) AS unique_id, cp.id_address_delivery,
 						product_shop.`wholesale_price`, product_shop.advanced_stock_management, ps.product_supplier_reference supplier_reference');
 
 		// Build FROM
@@ -763,11 +762,10 @@ class CartCore extends ObjectModel
 	{
 		// You can't add a cart rule that does not exist
 		$cartRule = new CartRule($id_cart_rule, Context::getContext()->language->id);
-
 		if (!Validate::isLoadedObject($cartRule))
 			return false;
 		
-		if (Db::getInstance()->getValue('SELECT id_cart_rule FROM '._DB_PREFIX_.'cart_cart_rule WHERE id_cart_rule = '.(int)$id_cart_rule.' AND id_cart = '.(int)$this->id))
+		if (Db::getInstance()->getValue('SELECT id_cart_rule FROM '._DB_PREFIX_.'cart_cart_rule WHERE id_cart = '.(int)$this->id))
 			return false;
 			
 		// Add the cart rule to the cart
@@ -1261,7 +1259,7 @@ class CartCore extends ObjectModel
 		return true;
 	}
 
-	public static function getTotalCart($id_cart, $use_tax_display = false, $type = Cart::BOTH)
+	public static function getTotalCart($id_cart, $use_tax_display = false, $type = CART::BOTH)
 	{
 		$cart = new Cart($id_cart);
 		if (!Validate::isLoadedObject($cart))
@@ -1677,7 +1675,6 @@ class CartCore extends ObjectModel
 				$warehouse_count_by_address[$product['id_address_delivery']][$warehouse['id_warehouse']]++;
 			}
 		}
-		unset($product);
 
 		arsort($warehouse_count_by_address);
 
@@ -1695,12 +1692,9 @@ class CartCore extends ObjectModel
 			$id_warehouse = 0;
 			foreach ($warehouse_count_by_address[$product['id_address_delivery']] as $id_war => $val)
 			{
-				if (in_array((int)$id_war, $product['warehouse_list']))
+				$product['carrier_list'] = array_merge($product['carrier_list'], Carrier::getAvailableCarrierList(new Product($product['id_product']), $id_war, $product['id_address_delivery'], null, $this));
-				{
+				if (in_array((int)$id_war, $product['warehouse_list']) && $id_warehouse == 0)
-					$product['carrier_list'] = array_merge($product['carrier_list'], Carrier::getAvailableCarrierList(new Product($product['id_product']), $id_war, $product['id_address_delivery'], null, $this));
+					$id_warehouse = (int)$id_war;
-					if (!$id_warehouse)
-						$id_warehouse = (int)$id_war;
-				}
 			}
 
 			if (!isset($grouped_by_warehouse[$product['id_address_delivery']]['in_stock'][$id_warehouse]))
@@ -1719,7 +1713,6 @@ class CartCore extends ObjectModel
 
 			$grouped_by_warehouse[$product['id_address_delivery']][$key][$id_warehouse][] = $product;
 		}
-		unset($product);
 
 		// Step 3 : grouped product from grouped_by_warehouse by available carriers
 		$grouped_by_carriers = array();
@@ -1738,6 +1731,7 @@ class CartCore extends ObjectModel
 				{
 					if (!isset($grouped_by_carriers[$id_address_delivery][$key][$id_warehouse]))
 						$grouped_by_carriers[$id_address_delivery][$key][$id_warehouse] = array();
+
 					foreach ($product_list as $product)
 					{
 						$package_carriers_key = implode(',', $product['carrier_list']);
@@ -1802,6 +1796,7 @@ class CartCore extends ObjectModel
 									);
 								$package_list[$id_address_delivery][$key][$id_warehouse][$id_carrier]['carrier_list'] =
 									array_intersect($package_list[$id_address_delivery][$key][$id_warehouse][$id_carrier]['carrier_list'], $data['carrier_list']);
+
 								$package_list[$id_address_delivery][$key][$id_warehouse][$id_carrier]['product_list'] =
 									array_merge($package_list[$id_address_delivery][$key][$id_warehouse][$id_carrier]['product_list'], $data['product_list']);
 
@@ -3420,7 +3415,6 @@ class CartCore extends ObjectModel
 	 */
 	public function setNoMultishipping()
 	{
-		$emptyCache = $result = false;
 		if (Configuration::get('PS_ALLOW_MULTISHIPPING'))
 		{
 			// Upgrading quantities
@@ -3439,9 +3433,7 @@ class CartCore extends ObjectModel
 						AND `id_shop` = '.(int)$this->id_shop.'
 						AND id_product = '.$product['id_product'].'
 						AND id_product_attribute = '.$product['id_product_attribute'];
-				$result = Db::getInstance()->execute($sql);
+					Db::getInstance()->execute($sql);
-				if ($result)
-					$emptyCache = true;
 			}
 
 			// Merging multiple lines
@@ -3459,17 +3451,14 @@ class CartCore extends ObjectModel
 		}
 		
 		// Update delivery address for each product line
-		$sql = 'UPDATE `'._DB_PREFIX_.'cart_product`
+		Db::getInstance()->execute('
+		UPDATE `'._DB_PREFIX_.'cart_product`
 		SET `id_address_delivery` = (
 			SELECT `id_address_delivery` FROM `'._DB_PREFIX_.'cart`
 			WHERE `id_cart` = '.(int)$this->id.' AND `id_shop` = '.(int)$this->id_shop.'
 		)
 		WHERE `id_cart` = '.(int)$this->id.'
-		'.(Configuration::get('PS_ALLOW_MULTISHIPPING') ? ' AND `id_shop` = '.(int)$this->id_shop : '');
+		'.(Configuration::get('PS_ALLOW_MULTISHIPPING') ? ' AND `id_shop` = '.(int)$this->id_shop : ''));
-	
-		$result = Db::getInstance()->execute($sql);
-		if ($result)
-			$emptyCache = true;
 		
 		if (Customization::isFeatureActive())
 			Db::getInstance()->execute('
@@ -3479,9 +3468,6 @@ class CartCore extends ObjectModel
 				WHERE `id_cart` = '.(int)$this->id.'
 			)
 			WHERE `id_cart` = '.(int)$this->id);
-
-		if ($emptyCache)	
-			$this->_products = null;
 	}
 
 	/**

classes/CartRule.php

@@ -464,7 +464,7 @@ class CartRuleCore extends ObjectModel
 		// Check if the products chosen by the customer are usable with the cart rule
 		if ($this->product_restriction)
 		{
-			$r = $this->checkProductRestrictions($context, false, $display_error, $alreadyInCart);
+			$r = $this->checkProductRestrictions($context, false, $display_error);
 			if ($r !== false && $display_error)
 				return $r;
 			elseif (!$r && !$display_error)
@@ -523,7 +523,6 @@ class CartRuleCore extends ObjectModel
 					return (!$display_error) ? false : Tools::displayError('This voucher is already in your cart');
 				if ($otherCartRule['gift_product'])
 					--$nb_products;
-
 				if ($this->cart_rule_restriction && $otherCartRule['cart_rule_restriction'] && $otherCartRule['id_cart_rule'] != $this->id)
 				{
 					$combinable = Db::getInstance()->getValue('
@@ -551,7 +550,7 @@ class CartRuleCore extends ObjectModel
 			return true;
 	}
 
-	protected function checkProductRestrictions(Context $context, $return_products = false, $display_error = true, $alreadyInCart = false)
+	protected function checkProductRestrictions(Context $context, $return_products = false, $display_error = true)
 	{
 		$selectedProducts = array();
 
@@ -586,8 +585,6 @@ class CartRuleCore extends ObjectModel
 								if (in_array($cartAttribute['id_attribute'], $productRule['values']))
 								{
 									$countMatchingProducts += $cartAttribute['quantity'];
-									if ($alreadyInCart && $this->gift_product == $cartProduct['id_product']&& $this->gift_product_attribute == $cartProduct['id_product_attribute'])
-										--$countMatchingProducts;
 									$matchingProductsList[] = $cartAttribute['id_product'].'-'.$cartAttribute['id_product_attribute'];
 								}
 							if ($countMatchingProducts < $productRuleGroup['quantity'])
@@ -606,8 +603,6 @@ class CartRuleCore extends ObjectModel
 								if (in_array($cartProduct['id_product'], $productRule['values']))
 								{
 									$countMatchingProducts += $cartProduct['quantity'];
-									if ($alreadyInCart && $this->gift_product == $cartProduct['id_product'])
-										--$countMatchingProducts;
 									$matchingProductsList[] = $cartProduct['id_product'].'-0';
 								}
 							if ($countMatchingProducts < $productRuleGroup['quantity'])
@@ -1190,7 +1185,7 @@ class CartRuleCore extends ObjectModel
 			SELECT cr.*, crl.*
 			FROM '._DB_PREFIX_.'cart_rule cr
 			LEFT JOIN '._DB_PREFIX_.'cart_rule_lang crl ON (cr.id_cart_rule = crl.id_cart_rule AND crl.id_lang = '.(int)$id_lang.')
-			WHERE code LIKE \'%'.pSQL($name).'%\' OR name LIKE \'%'.pSQL($name).'%\'
+			WHERE code LIKE \'%'.pSQL($name).'%\'
 		');
 	}
 }

classes/Category.php

@@ -107,8 +107,8 @@ class CategoryCore extends ObjectModel
 			'date_upd' => 			array('type' => self::TYPE_DATE, 'validate' => 'isDate'),
 
 			// Lang fields
-			'name' => 				array('type' => self::TYPE_STRING, 'lang' => true, 'validate' => 'isCatalogName', 'required' => true, 'size' => 128),
+			'name' => 				array('type' => self::TYPE_STRING, 'lang' => true, 'validate' => 'isCatalogName', 'required' => true, 'size' => 64),
-			'link_rewrite' => 		array('type' => self::TYPE_STRING, 'lang' => true, 'validate' => 'isLinkRewrite', 'required' => true, 'size' => 128),
+			'link_rewrite' => 		array('type' => self::TYPE_STRING, 'lang' => true, 'validate' => 'isLinkRewrite', 'required' => true, 'size' => 64),
 			'description' => 		array('type' => self::TYPE_HTML, 'lang' => true, 'validate' => 'isCleanHtml'),
 			'meta_title' => 		array('type' => self::TYPE_STRING, 'lang' => true, 'validate' => 'isGenericName', 'size' => 128),
 			'meta_description' => 	array('type' => self::TYPE_STRING, 'lang' => true, 'validate' => 'isGenericName', 'size' => 255),

classes/ConfigurationTest.php

@@ -58,8 +58,7 @@ class ConfigurationTestCore
 			'theme_cache_dir' => 'themes/'._THEME_NAME_.'/cache/',
 			'translations_dir' => 'translations',
 			'customizable_products_dir' => 'upload',
-			'virtual_products_dir' => 'download',
+			'virtual_products_dir' => 'download'
-			'files' => false
 		);
 	}
 
@@ -319,21 +318,4 @@ class ConfigurationTestCore
 	{
 		return extension_loaded('Dom');
 	}
-	
-	public static function test_files()
-	{
-		$files = array(
-			'/cache/smarty/compile/index.php',
-			'/classes/log/index.php',
-			'/classes/cache/index.php',
-			'/config/index.php',
-			'/tools/tar/Archive_Tar.php',
-			'/tools/pear/PEAR.php',
-			'/index.php'
-		);
-		foreach ($files as $file)
-			if (!file_exists(rtrim(_PS_ROOT_DIR_, DIRECTORY_SEPARATOR).str_replace('/', DIRECTORY_SEPARATOR, $file)))
-				return false;
-		return true;		
-	}
 }

classes/Connection.php

@@ -97,7 +97,7 @@ class ConnectionCore extends ObjectModel
 			'id_connections' => (int)$cookie->id_connections,
 			'id_page' => (int)$id_page,
 			'time_start' => $time_start
-		), false, true, Db::INSERT_IGNORE);
+		));
 
 		// This array is serialized and used by the ajax request to identify the page
 		return array(
@@ -114,7 +114,7 @@ class ConnectionCore extends ObjectModel
 			// This is a bot and we have to retrieve its connection ID
 			$sql = 'SELECT `id_connections` FROM `'._DB_PREFIX_.'connections`
 					WHERE ip_address = '.ip2long(Tools::getRemoteAddr()).'
-						AND `date_add` > \''.pSQL(date('Y-m-d H:i:00', time() - 1800)).'\'
+						AND DATE_ADD(`date_add`, INTERVAL 30 MINUTE) > \''.pSQL(date('Y-m-d H:i:00')).'\'
 						'.Shop::addSqlRestriction(Shop::SHARE_CUSTOMER).'
 					ORDER BY `date_add` DESC';
 			if ($id_connections = Db::getInstance()->getValue($sql))
@@ -128,7 +128,7 @@ class ConnectionCore extends ObjectModel
 		$sql = 'SELECT `id_guest`
 				FROM `'._DB_PREFIX_.'connections`
 				WHERE `id_guest` = '.(int)$cookie->id_guest.'
-					AND `date_add` > \''.pSQL(date('Y-m-d H:i:00', time() - 1800)).'\'
+					AND DATE_ADD(`date_add`, INTERVAL 30 MINUTE) > \''.pSQL(date('Y-m-d H:i:00')).'\'
 					'.Shop::addSqlRestriction(Shop::SHARE_CUSTOMER).'
 				ORDER BY `date_add` DESC';
 		$result = Db::getInstance()->getRow($sql);

classes/Currency.php

@@ -81,7 +81,6 @@ class CurrencyCore extends ObjectModel
 
 	/** @var array Currency cache */
 	static protected $currencies = array();
-	protected static $countActiveCurrencies = array();
 
 	protected $webserviceParameters = array(
 		'objectsNodeName' => 'currencies',
@@ -188,9 +187,8 @@ class CurrencyCore extends ObjectModel
 			4 => array('left' => '', 'right' => &$formated_strings['right']),
 			5 => array('left' => '', 'right' => &$formated_strings['right'])
 		);
-		if (isset($formats[$this->format][$side]))
+
-			return ($formats[$this->format][$side]);
+		return ($formats[$this->format][$side]);
-		return $this->sign;
 	}
 
 	/**
@@ -416,23 +414,5 @@ class CurrencyCore extends ObjectModel
 			self::$currencies[(int)($id)] = new Currency($id);
 		return self::$currencies[(int)($id)];
 	}
-	
-	public static function countActiveCurrencies($id_shop = null)
-	{
-		if ($id_shop === null)
-			$id_shop = (int)Context::getContext()->shop->id;
-
-		if (!isset(self::$countActiveCurrencies[$id_shop]))
-			self::$countActiveCurrencies[$id_shop] = Db::getInstance()->getValue('
-				SELECT COUNT(DISTINCT c.id_currency) FROM `'._DB_PREFIX_.'currency` c
-				LEFT JOIN '._DB_PREFIX_.'currency_shop cs ON (cs.id_currency = c.id_currency AND cs.id_shop = '.(int)$id_shop.')
-				WHERE c.`active` = 1
-			');
-		return self::$countActiveCurrencies[$id_shop];
-	}
-
-	public static function isMultiCurrencyActivated($id_shop = null)
-	{
-		return (Currency::countActiveCurrencies($id_shop) > 1);
-	}
 }
+

classes/Dispatcher.php

@@ -369,7 +369,7 @@ class DispatcherCore
 
 		// If there are several languages, get language from uri
 		if ($this->use_routes && Language::isMultiLanguageActivated())
-			if (preg_match('#^/([a-z]{2})/?#', $this->request_uri, $m))
+			if (preg_match('#^/([a-z]{2})/#', $this->request_uri, $m))
 			{
 				$_GET['isolang'] = $m[1];
 				$this->request_uri = substr($this->request_uri, 3);
@@ -549,7 +549,7 @@ class DispatcherCore
 		if ($id_shop === null)
 			$id_shop = (int)Context::getContext()->shop->id;
 
-		if (!isset($this->routes[$id_shop]))
+		if ($this->use_routes && !isset($this->routes[$id_shop]))
 			$this->loadRoutes($id_shop);
 
 		if (!isset($this->routes[$id_shop]) || !isset($this->routes[$id_shop][$id_lang]) || !isset($this->routes[$id_shop][$id_lang][$route_id]))
@@ -594,14 +594,14 @@ class DispatcherCore
 		if ($id_shop === null)
 			$id_shop = (int)Context::getContext()->shop->id;
 		
-		if (!isset($this->routes[$id_shop]))
+		if ($this->use_routes && !isset($this->routes[$id_shop]))
 			$this->loadRoutes($id_shop);
 		
 		if (!isset($this->routes[$id_shop][$id_lang][$route_id]))
 		{
 			$query = http_build_query($params, '', '&');
 			$index_link = $this->use_routes ? '' : 'index.php';
-			return ($route_id == 'index') ? $index_link.(($query) ? '?'.$query : '') : ((trim($route_id) == '') ? '' : 'index.php?controller='.$route_id).(($query) ? '&'.$query : '').$anchor;
+			return ($route_id == 'index') ? $index_link.(($query) ? '?'.$query : '') : 'index.php?controller='.$route_id.(($query) ? '&'.$query : '').$anchor;
 		}
 		$route = $this->routes[$id_shop][$id_lang][$route_id];
 		// Check required fields

classes/FeatureValue.php

@@ -128,44 +128,34 @@ class FeatureValueCore extends ObjectModel
 				return $tab['value'];
 	}
 
-	public static function addFeatureValueImport($id_feature, $value, $id_product = null, $id_lang = null)
+	public static function addFeatureValueImport($id_feature, $name)
 	{
-		if (!is_null($id_product) && $id_product)
+		$rq = Db::getInstance()->executeS('
-		{
+			SELECT fv.`id_feature_value`
-			$id_feature_value = Db::getInstance()->getValue('
+			FROM '._DB_PREFIX_.'feature_value fv
-				SELECT `id_feature_value`
+			LEFT JOIN '._DB_PREFIX_.'feature_value_lang fvl
-				FROM '._DB_PREFIX_.'feature_product
+				ON (fvl.`id_feature_value` = fv.`id_feature_value`)
-				WHERE `id_feature` = '.(int)$id_feature.'
+			WHERE `value` = \''.pSQL($name).'\'
-				AND `id_product` = '.(int)$id_product);
-
-			if ($id_feature_value && !is_null($id_lang) && $id_lang)
-				Db::getInstance()->execute('
-				UPDATE '._DB_PREFIX_.'feature_value_lang 
-				SET `value` = \''.pSQL($value).'\' 
-				WHERE `id_feature_value` = '.(int)$id_feature_value.' 
-				AND `id_lang` = '.(int)$id_lang);
-		}
-		else
-			$id_feature_value = Db::getInstance()->getValue('
-				SELECT fv.`id_feature_value`
-				FROM '._DB_PREFIX_.'feature_value fv
-				LEFT JOIN '._DB_PREFIX_.'feature_value_lang fvl ON (fvl.`id_feature_value` = fv.`id_feature_value`)
-				WHERE `value` = \''.pSQL($value).'\'
 				AND fv.`id_feature` = '.(int)$id_feature.'
-				GROUP BY fv.`id_feature_value`');
+			GROUP BY fv.`id_feature_value` LIMIT 1
+		');
 
-		if ($id_feature_value)
+		if (!isset($rq[0]['id_feature_value']) || !$id_feature_value = (int)$rq[0]['id_feature_value'])
-			return (int)$id_feature_value;
+		{
+			// Feature doesn't exist, create it
+			$feature_value = new FeatureValue();
 
-		// Feature doesn't exist, create it
+			$languages = Language::getLanguages();
-		$feature_value = new FeatureValue();
+			foreach ($languages as $language)
-		$feature_value->id_feature = (int)$id_feature;
+				$feature_value->value[$language['id_lang']] = strval($name);
-		$feature_value->custom = 0;
-		foreach (Language::getLanguages() as $language)
-			$feature_value->value[$language['id_lang']] = $value;
-		$feature_value->add();
 
-		return (int)$feature_value->id;
+			$feature_value->id_feature = (int)$id_feature;
+			$feature_value->custom = 1;
+			$feature_value->add();
+
+			return (int)$feature_value->id;
+		}
+		return (int)$id_feature_value;
 	}
 
 	public function add($autodate = true, $nullValues = false)

classes/GroupReduction.php

@@ -137,7 +137,6 @@ class GroupReductionCore extends ObjectModel
 			SELECT `reduction`
 			FROM `'._DB_PREFIX_.'product_group_reduction_cache`
 			WHERE `id_product` = '.(int)$id_product.' AND `id_group` = '.(int)$id_group);
-		// Should return string (decimal in database) and not a float
 		return self::$reduction_cache[$id_product.'-'.$id_group];
 	}
 

classes/Image.php

@@ -120,22 +120,16 @@ class ImageCore extends ObjectModel
 	 *
 	 * @param integer $id_lang Language ID
 	 * @param integer $id_product Product ID
-	 * @param integer $id_product_attribute Product Attribute ID
 	 * @return array Images
 	 */
-	public static function getImages($id_lang, $id_product, $id_product_attribute = NULL)
+	public static function getImages($id_lang, $id_product)
 	{
-		$attribute_filter = ($id_product_attribute ? ' AND ai.`id_product_attribute` = '.(int)$id_product_attribute : '');
+		return Db::getInstance()->executeS('
-		$sql = 'SELECT *
+		SELECT *
-			FROM `'._DB_PREFIX_.'image` i
+		FROM `'._DB_PREFIX_.'image` i
-			LEFT JOIN `'._DB_PREFIX_.'image_lang` il ON (i.`id_image` = il.`id_image`)';
+		LEFT JOIN `'._DB_PREFIX_.'image_lang` il ON (i.`id_image` = il.`id_image`)
-
+		WHERE i.`id_product` = '.(int)$id_product.' AND il.`id_lang` = '.(int)$id_lang.'
-		if ($id_product_attribute)
+		ORDER BY i.`position` ASC');
-			$sql .= ' LEFT JOIN `'._DB_PREFIX_.'product_attribute_image` ai ON (i.`id_image` = ai.`id_image`)';
-
-		$sql .= ' WHERE i.`id_product` = '.(int)$id_product.' AND il.`id_lang` = '.(int)$id_lang . $attribute_filter.'
-			ORDER BY i.`position` ASC';
-		return Db::getInstance()->executeS($sql);
 	}
 
 	/**
@@ -650,7 +644,7 @@ class ImageCore extends ObjectModel
 	 */
 	public static function testFileSystem()
 	{
-		$safe_mode = Tools::getSafeModeStatus();
+		$safe_mode = ini_get('safe_mode');
 		if ($safe_mode)
 			return false;
 		$folder1 = _PS_PROD_IMG_DIR_.'testfilesystem/';

classes/Language.php

@@ -111,22 +111,18 @@ class LanguageCore extends ObjectModel
 		$iso_code = $newIso ? $newIso : $this->iso_code;
 
 		if (!file_exists(_PS_TRANSLATIONS_DIR_.$iso_code))
-		{
+			mkdir(_PS_TRANSLATIONS_DIR_.$iso_code);
-			if (@mkdir(_PS_TRANSLATIONS_DIR_.$iso_code))
-				@chmod(_PS_TRANSLATIONS_DIR_.$iso_code, 0777);
-		}
-
 		foreach ($this->translationsFilesAndVars as $file => $var)
 		{
 			$path_file = _PS_TRANSLATIONS_DIR_.$iso_code.'/'.$file.'.php';
 			if (!file_exists($path_file))
 				if ($file != 'tabs')
-					@file_put_contents($path_file, '<?php
+					file_put_contents($path_file, '<?php
 	global $'.$var.';
 	$'.$var.' = array();
 ?>');
 				else
-					@file_put_contents($path_file, '<?php
+					file_put_contents($path_file, '<?php
 	$'.$var.' = array();
 	return $'.$var.';
 ?>');
@@ -196,7 +192,7 @@ class LanguageCore extends ObjectModel
 
 	public function add($autodate = true, $nullValues = false, $only_add = false)
 	{
-		if (!parent::add($autodate, $nullValues))
+		if (!parent::add($autodate))
 			return false;
 
 		if ($only_add)
@@ -206,9 +202,10 @@ class LanguageCore extends ObjectModel
 		$this->_generateFiles();
 
 		// @todo Since a lot of modules are not in right format with their primary keys name, just get true ...
-		$this->loadUpdateSQL();
+		$resUpdateSQL = $this->loadUpdateSQL();
-
+		$resUpdateSQL = true;
-		return Tools::generateHtaccess();
+		Tools::generateHtaccess();
+		return $resUpdateSQL;
 	}
 
 	public function toggleStatus()
@@ -464,8 +461,7 @@ class LanguageCore extends ObjectModel
 				}
 			closedir($handle);
 		}
-		if (is_writable($dir))
+		rmdir($dir);
-			rmdir($dir);
 	}
 
 	public function delete()
@@ -492,8 +488,7 @@ class LanguageCore extends ObjectModel
 			// Files deletion
 			foreach (Language::getFilesList($this->iso_code, _THEME_NAME_, false, false, false, true, true) as $key => $file)
 				if (file_exists($key))
-					unlink($key);
+				unlink($key);
-
 			$modList = scandir(_PS_MODULE_DIR_);
 			foreach ($modList as $mod)
 			{
@@ -515,32 +510,37 @@ class LanguageCore extends ObjectModel
 				Language::recurseDeleteDir(_PS_MAIL_DIR_.$this->iso_code);
 			if (file_exists(_PS_TRANSLATIONS_DIR_.$this->iso_code))
 				Language::recurseDeleteDir(_PS_TRANSLATIONS_DIR_.$this->iso_code);
-
-			$images = array(
-				'.jpg',
-				'-default-'.ImageType::getFormatedName('thickbox').'.jpg',
-				'-default-'.ImageType::getFormatedName('home').'.jpg',
-				'-default-'.ImageType::getFormatedName('large').'.jpg',
-				'-default-'.ImageType::getFormatedName('medium').'.jpg',
-				'-default-'.ImageType::getFormatedName('small').'.jpg'
-			);
-			$images_directories = array(_PS_CAT_IMG_DIR_, _PS_MANU_IMG_DIR_, _PS_PROD_IMG_DIR_, _PS_SUPP_IMG_DIR_);
-			foreach ($images_directories as $image_directory)
-				foreach ($images as $image)
-				{
-					if (file_exists($image_directory.$this->iso_code.$image))
-						unlink($image_directory.$this->iso_code.$image);
-					if (file_exists(dirname(__FILE__).'/../img/l/'.$this->id.'.jpg'))
-						unlink(dirname(__FILE__).'/../img/l/'.$this->id.'.jpg');
-				}
 		}
 		
 		if (!parent::delete())
 			return false;
+		if (!$this->hasMultishopEntries() || Shop::getContext() == Shop::CONTEXT_ALL)
+		{
+			// delete images
+			$files_copy = array(
+				'/en.jpg',
+				'/en-default-'.ImageType::getFormatedName('thickbox').'.jpg',
+				'/en-default-'.ImageType::getFormatedName('home').'.jpg',
+				'/en-default-'.ImageType::getFormatedName('large').'.jpg',
+				'/en-default-'.ImageType::getFormatedName('medium').'.jpg',
+				'/en-default-'.ImageType::getFormatedName('small').'.jpg'
+			);
+			$tos = array(_PS_CAT_IMG_DIR_, _PS_MANU_IMG_DIR_, _PS_PROD_IMG_DIR_, _PS_SUPP_IMG_DIR_);
+			foreach ($tos as $to)
+				foreach ($files_copy as $file)
+				{
+					$name = str_replace('/en', ''.$this->iso_code, $file);
 	
+					if (file_exists($to.$name))
+						unlink($to.$name);
+					if (file_exists(dirname(__FILE__).'/../img/l/'.$this->id.'.jpg'))
+						unlink(dirname(__FILE__).'/../img/l/'.$this->id.'.jpg');
+				}
+		}
 		return Tools::generateHtaccess();
 	}
 
+
 	public function deleteSelection($selection)
 	{
 		if (!is_array($selection))
@@ -549,10 +549,11 @@ class LanguageCore extends ObjectModel
 		$result = true;
 		foreach ($selection as $id)
 		{
-			$language = new Language($id);
+			$this->id = (int)($id);
-			$result = $result && $language->delete();
+			$result = $result && $this->delete();
 		}
 
+		Tools::generateHtaccess();
 		return $result;
 	}
 
@@ -688,27 +689,25 @@ class LanguageCore extends ObjectModel
 		if (Language::getIdByIso($iso_code))
 			return true;
 
-		// Initialize the language
 		$lang = new Language();
 		$lang->iso_code = $iso_code;
-		$lang->language_code = $iso_code;
 		$lang->active = true;
 
-		// If the language pack has not been provided, retrieve it from prestashop.com
 		if (!$lang_pack)
 			$lang_pack = Tools::jsonDecode(Tools::file_get_contents('http://www.prestashop.com/download/lang_packs/get_language_pack.php?version='._PS_VERSION_.'&iso_lang='.$iso_code));
 
-		// If a language pack has been found or provided, prefill the language object with the value
 		if ($lang_pack)
-			foreach (get_object_vars($lang_pack) as $key => $value)
+		{
-				if ($key != 'iso_code' && isset(Language::$definition['fields'][$key]))
+			if (isset($lang_pack->name)
-					$lang->$key = $value;
+				&& isset($lang_pack->version)
-
+				&& isset($lang_pack->iso_code))
-		// Use the values given in parameters to override the data retrieved automatically
+					$lang->name = $lang_pack->name;
-		if ($params_lang !== null && is_array($params_lang))
+		}
+		elseif ($params_lang !== null && is_array($params_lang))
 			foreach ($params_lang as $key => $value)
-				if ($key != 'iso_code' && isset(Language::$definition['fields'][$key]))
+				$lang->$key = $value;
-					$lang->$key = $value;
+		else
+			return false;
 		
 		if (!$lang->add(true, false, $only_add))
 			return false;
@@ -790,22 +789,13 @@ class LanguageCore extends ObjectModel
 		$lang_pack_ok = false;
 		$errors = array();
 		$file = _PS_TRANSLATIONS_DIR_.$iso.'.gzip';
-
 		if (!$lang_pack_link = Tools::file_get_contents('http://www.prestashop.com/download/lang_packs/get_language_pack.php?version='.$version.'&iso_lang='.Tools::strtolower($iso)))
 			$errors[] = Tools::displayError('Archive cannot be downloaded from prestashop.com.');
 		elseif (!$lang_pack = Tools::jsonDecode($lang_pack_link))
 			$errors[] = Tools::displayError('Error occurred when language was checked according to your Prestashop version.');
 		elseif ($content = Tools::file_get_contents('http://translations.prestashop.com/download/lang_packs/gzip/'.$lang_pack->version.'/'.Tools::strtolower($lang_pack->iso_code.'.gzip')))
 			if (!@file_put_contents($file, $content))
-			{
+				$errors[] = Tools::displayError('Server does not have permissions for writing.');
-				if (is_writable(dirname($file)))
-				{
-					@unlink($file);
-					@file_put_contents($file, $content);
-				}
-				elseif (!is_writable($file))
-					$errors[] = Tools::displayError('Server does not have permissions for writing.').' ('.$file.')';
-			}
 		if (file_exists($file))
 		{
 			$gz = new Archive_Tar($file, true);

classes/Link.php

@@ -91,8 +91,12 @@ class LinkCore
 		if (!$id_lang)
 			$id_lang = Context::getContext()->language->id;
 
+		if (Configuration::get('PS_MULTISHOP_FEATURE_ACTIVE') && $id_shop !== null)
+			$shop = new Shop($id_shop);
+		else
+			$shop = Context::getContext()->shop;
 		
-		$url = $this->getBaseLink($id_shop).$this->getLangLink($id_lang, null, $id_shop);
+		$url = 'http://'.$shop->domain.$shop->getBaseURI().$this->getLangLink($id_lang, null, $id_shop);
 
 		if (!is_object($product))
 		{
@@ -159,7 +163,11 @@ class LinkCore
 		if (!$id_lang)
 			$id_lang = Context::getContext()->language->id;
 		
-		$url = $this->getBaseLink($id_shop).$this->getLangLink($id_lang, null, $id_shop);
+		if ($id_shop === null)
+			$shop = Context::getContext()->shop;
+		else
+			$shop = new Shop($id_shop);
+		$url = 'http://'.$shop->domain.$shop->getBaseURI().$this->getLangLink($id_lang, null, $id_shop);
 
 		if (!is_object($category))
 			$category = new Category($category, $id_lang);
@@ -198,7 +206,11 @@ class LinkCore
 		if (!$id_lang)
 			$id_lang = Context::getContext()->language->id;
 
-		$url = $this->getBaseLink($id_shop).$this->getLangLink($id_lang, null, $id_shop);
+		if ($id_shop === null)
+			$shop = Context::getContext()->shop;
+		else
+			$shop = new Shop($id_shop);
+		$url = 'http://'.$shop->domain.$shop->getBaseURI().$this->getLangLink($id_lang, null, $id_shop);
 
 		$dispatcher = Dispatcher::getInstance();
 		if (!is_object($cms_category))
@@ -227,12 +239,19 @@ class LinkCore
 	 * @param int $id_lang
 	 * @return string
 	 */
-	public function getCMSLink($cms, $alias = null, $ssl = null, $id_lang = null, $id_shop = null)
+	public function getCMSLink($cms, $alias = null, $ssl = false, $id_lang = null, $id_shop = null)
 	{
+		$base = (($ssl && $this->ssl_enable) ? 'https://' : 'http://');
+
 		if (!$id_lang)
 			$id_lang = Context::getContext()->language->id;
 		
-		$url = $this->getBaseLink($id_shop, $ssl).$this->getLangLink($id_lang, null, $id_shop);
+		if ($id_shop === null)
+			$shop = Context::getContext()->shop;
+		else
+			$shop = new Shop($id_shop);
+		$url = $base.$shop->domain.$shop->getBaseURI().$this->getLangLink($id_lang, null, $id_shop);
+
 
 		$dispatcher = Dispatcher::getInstance();
 		if (!is_object($cms))
@@ -271,8 +290,11 @@ class LinkCore
 		if (!$id_lang)
 			$id_lang = Context::getContext()->language->id;
 
-
+		if ($id_shop === null)
-		$url = $this->getBaseLink($id_shop).$this->getLangLink($id_lang, null, $id_shop);
+			$shop = Context::getContext()->shop;
+		else
+			$shop = new Shop($id_shop);
+		$url = 'http://'.$shop->domain.$shop->getBaseURI().$this->getLangLink($id_lang, null, $id_shop);
 		
 		$dispatcher = Dispatcher::getInstance();
 		if (!is_object($supplier))
@@ -305,7 +327,11 @@ class LinkCore
 		if (!$id_lang)
 			$id_lang = Context::getContext()->language->id;
 
-		$url = $this->getBaseLink($id_shop).$this->getLangLink($id_lang, null, $id_shop);
+		if ($id_shop === null)
+			$shop = Context::getContext()->shop;
+		else
+			$shop = new Shop($id_shop);
+		$url = 'http://'.$shop->domain.$shop->getBaseURI().$this->getLangLink($id_lang, null, $id_shop);
 
 		$dispatcher = Dispatcher::getInstance();
 		if (!is_object($manufacturer))
@@ -334,12 +360,18 @@ class LinkCore
 	 * @param int $id_lang
 	 * @return string
 	 */
-	public function getModuleLink($module, $controller = 'default', array $params = array(), $ssl = null, $id_lang = null, $id_shop = null)
+	public function getModuleLink($module, $controller = 'default', array $params = array(), $ssl = false, $id_lang = null, $id_shop = null)
 	{
+		$base = (($ssl && $this->ssl_enable) ? 'https://' : 'http://');
+
 		if (!$id_lang)
 			$id_lang = Context::getContext()->language->id;
 
-		$url = $this->getBaseLink($id_shop, $ssl).$this->getLangLink($id_lang, null, $id_shop);
+		if ($id_shop === null)
+			$shop = Context::getContext()->shop;
+		else
+			$shop = new Shop($id_shop);
+		$url = $base.$shop->domain.$shop->getBaseURI().$this->getLangLink($id_lang, null, $id_shop);
 
 		// If the module has its own route ... just use it !
 		if (Dispatcher::getInstance()->hasRoute('module-'.$module.'-'.$controller, $id_lang, $id_shop))
@@ -421,9 +453,10 @@ class LinkCore
 	 *
 	 * @return string Page link
 	 */
-	public function getPageLink($controller, $ssl = null, $id_lang = null, $request = null, $request_url_encode = false, $id_shop = null)
+	public function getPageLink($controller, $ssl = false, $id_lang = null, $request = null, $request_url_encode = false, $id_shop = null)
 	{
 		$controller = Tools::strReplaceFirst('.php', '', $controller);
+
 		if (!$id_lang)
 			$id_lang = (int)Context::getContext()->language->id;
 
@@ -436,9 +469,16 @@ class LinkCore
 			parse_str($request, $request);
 		}
 
-		$uri_path = Dispatcher::getInstance()->createUrl($controller, $id_lang, $request, false, '', $id_shop);
+		if ($id_shop === null)
+			$shop = Context::getContext()->shop;
+		else
+			$shop = new Shop($id_shop);
 
-		return $this->getBaseLink($id_shop, $ssl).$this->getLangLink($id_lang, null, $id_shop).ltrim($uri_path, '/');
+		$uri_path = Dispatcher::getInstance()->createUrl($controller, $id_lang, $request, false, '', $id_shop);
+		$url = ($ssl && $this->ssl_enable) ? 'https://' : 'http://';
+		$url .= $shop->domain.$shop->getBaseURI().$this->getLangLink($id_lang, null, $id_shop).ltrim($uri_path, '/');
+
+		return $url;
 	}
 
 	public function getCatImageLink($name, $id_category, $type = null)
@@ -602,26 +642,5 @@ class LinkCore
 
 		return Language::getIsoById($id_lang).'/';
 	}
-	
-	protected function getBaseLink($id_shop = null, $ssl = null)
-	{
-		static $force_ssl = null;
-		
-		if ($ssl === null)
-		{
-			if ($force_ssl === null)
-				$force_ssl = (Configuration::get('PS_SSL_ENABLED') && Configuration::get('PS_SSL_ENABLED_EVERYWHERE'));
-			$ssl = $force_ssl;
-		}
-
-		if (Configuration::get('PS_MULTISHOP_FEATURE_ACTIVE') && $id_shop !== null)
-			$shop = new Shop($id_shop);
-		else
-			$shop = Context::getContext()->shop;
-
-		$base = (($ssl && $this->ssl_enable) ? 'https://'.$shop->domain_ssl : 'http://'.$shop->domain);
-
-		return $base.$shop->getBaseURI();
-	}
 }
 

classes/Logger.php

@@ -150,11 +150,6 @@ class	LoggerCore extends ObjectModel
 		return $this->hash;
 	}
 
-	public static function eraseAllLogs()
-	{
-		return Db::getInstance()->execute('TRUNCATE TABLE '._DB_PREFIX_.'log');
-	}
-
 	/**
 	 * check if this log message already exists in database.
 	 *

classes/Mail.php

@@ -50,11 +50,9 @@ class MailCore
 	 * @param bool $modeSMTP
 	 * @param string $template_path
 	 * @param bool $die
-         * @param string $bcc Bcc recipient
 	 */
 	public static function Send($id_lang, $template, $subject, $template_vars, $to,
-		$to_name = null, $from = null, $from_name = null, $file_attachment = null, $mode_smtp = null,
+		$to_name = null, $from = null, $from_name = null, $file_attachment = null, $mode_smtp = null, $template_path = _PS_MAIL_DIR_, $die = false, $id_shop = null)
-		$template_path = _PS_MAIL_DIR_, $die = false, $id_shop = null, $bcc = null)
 	{
 		$configuration = Configuration::getMultiple(array(
 			'PS_SHOP_EMAIL',
@@ -128,9 +126,9 @@ class MailCore
 		}
 
 		/* Construct multiple recipients list if needed */
-		$to_list = new Swift_RecipientList();
 		if (is_array($to) && isset($to))
 		{
+			$to_list = new Swift_RecipientList();
 			foreach ($to as $key => $addr)
 			{
 				$to_name = null;
@@ -148,26 +146,17 @@ class MailCore
 				if ($to_name == null)
 					$to_name = $addr;
 				/* Encode accentuated chars */
-				if (function_exists('mb_encode_mimeheader'))
+				$to_list->addTo($addr, '=?UTF-8?B?'.base64_encode($to_name).'?=');
-					$to_list->addTo($addr, mb_encode_mimeheader($to_name, 'utf-8'));
-				else
-					$to_list->addTo($addr, self::mimeEncode($to_name));
 			}
 			$to_plugin = $to[0];
+			$to = $to_list;
 		} else {
 			/* Simple recipient, one address */
 			$to_plugin = $to;
 			if ($to_name == null)
 				$to_name = $to;
-			if (function_exists('mb_encode_mimeheader'))
+			$to = new Swift_Address($to, '=?UTF-8?B?'.base64_encode($to_name).'?=');
-				$to_list->addTo($to, mb_encode_mimeheader($to_name, 'utf-8'));
-			else
-				$to_list->addTo($to, self::mimeEncode($to_name));
 		}
-		if(isset($bcc)) {
-			$to_list->addBcc($bcc);
-		}
-		$to = $to_list;
 		try {
 			/* Connect with the appropriate configuration */
 			if ($configuration['PS_MAIL_METHOD'] == 2)
@@ -241,8 +230,6 @@ class MailCore
 			/* Create mail and attach differents parts */
 			$message = new Swift_Message('['.Configuration::get('PS_SHOP_NAME', null, null, $id_shop).'] '.$subject);
 
-			$message->setCharset('utf-8');
-
 			/* Set Message-ID - getmypid() is blocked on some hosting */
 			$message->setId(Mail::generateId());
 
@@ -385,68 +372,4 @@ class MailCore
 		return vsprintf("<%s.%d.%s@%s>", $midparams);
 	}
 	
-	public static function isMultibyte($data)
-	{
-		$length = strlen($data);
-
-		for ($i = 0; $i < $length; $i++)
-		{
-			$result = ord(($data[$i]));
-
-			if ($result > 128)
-			{
-				return true;
-			}
-		}
-
-		return false;
-	}
-
-	public static function mimeEncode($string, $charset = 'UTF-8', $newline = "\r\n")
-	{
-		if (!self::isMultibyte($string) && strlen($string) < 75)
-		{
-			return $string;
-		}
-
-		$charset = strtoupper($charset);
-		$start   = '=?' . $charset . '?B?';
-		$end     = '?=';
-		$sep     = $end . $newline . ' ' . $start;
-		$length  = 75 - strlen($start) - strlen($end);
-		$length  = $length - ($length % 4);
-
-		if ($charset === 'UTF-8')
-		{
-			$parts = array();
-			$maxchars = floor(($length * 3) / 4);
-			$stringLength = strlen($string);
-
-			while ($stringLength > $maxchars)
-			{
-				$i = (int)$maxchars;
-				$result = ord($string[$i]);
-
-				while ($result >= 128 && $result <= 191)
-				{
-					$i--;
-					$result = ord($string[$i]);
-				}
-
-				$parts[] = base64_encode(substr($string, 0, $i));
-				$string = substr($string, $i);
-				$stringLength = strlen($string);
-			}
-
-			$parts[] = base64_encode($string);
-			$string = implode($sep, $parts);
-		}
-		else
-		{
-			$string = chunk_split(base64_encode($string), $length, $sep);
-			$string = preg_replace('/' . preg_quote($sep) . '$/', '', $string);
-		}
-
-		return $start . $string . $end;
-	}
 }

classes/Manufacturer.php

@@ -79,7 +79,7 @@ class ManufacturerCore extends ObjectModel
 
 			// Lang fields
 			'description' => 		array('type' => self::TYPE_HTML, 'lang' => true, 'validate' => 'isCleanHtml'),
-			'short_description' => 	array('type' => self::TYPE_HTML, 'lang' => true, 'validate' => 'isCleanHtml'),
+			'short_description' => 	array('type' => self::TYPE_HTML, 'lang' => true, 'validate' => 'isCleanHtml', 'size' => 254),
 			'meta_title' => 		array('type' => self::TYPE_STRING, 'lang' => true, 'validate' => 'isGenericName', 'size' => 128),
 			'meta_description' => 	array('type' => self::TYPE_STRING, 'lang' => true, 'validate' => 'isGenericName', 'size' => 255),
 			'meta_keywords' => 		array('type' => self::TYPE_STRING, 'lang' => true, 'validate' => 'isGenericName'),

classes/Media.php

@@ -39,7 +39,7 @@ class MediaCore
 		'ui.accordion' => array('fileName' => 'jquery.ui.accordion.min.js', 'dependencies' => array('ui.core', 'ui.widget'), 'theme' => true),
 		'ui.autocomplete' => array('fileName' => 'jquery.ui.autocomplete.min.js', 'dependencies' => array('ui.core', 'ui.widget', 'ui.position'), 'theme' => true),
 		'ui.button' => array('fileName' => 'jquery.ui.button.min.js', 'dependencies' => array('ui.core', 'ui.widget'), 'theme' => true),
-		'ui.dialog' => array('fileName' => 'jquery.ui.dialog.min.js', 'dependencies' => array('ui.core', 'ui.widget', 'ui.position','ui.button'), 'theme' => true),
+		'ui.dialog' => array('fileName' => 'jquery.ui.dialog.min.js', 'dependencies' => array('ui.core', 'ui.widget', 'ui.position'), 'theme' => true),
 		'ui.slider' => array('fileName' => 'jquery.ui.slider.min.js', 'dependencies' => array('ui.core', 'ui.widget', 'ui.mouse'), 'theme' => true),
 		'ui.tabs' => array('fileName' => 'jquery.ui.tabs.min.js', 'dependencies' => array('ui.core', 'ui.widget'), 'theme' => true),
 		'ui.datepicker' => array('fileName' => 'jquery.ui.datepicker.min.js', 'dependencies' => array('ui.core'), 'theme' => true),
@@ -201,7 +201,7 @@ class MediaCore
 		if (!preg_match('/^http(s?):\/\//i', $file_uri) && !@filemtime($file_uri))
 			return false;
 
-		if (Context::getContext()->controller->controller_type == 'admin' && !array_key_exists('host', $url_data))
+		if (Context::getContext()->controller->controller_type == 'admin')
 		{
 			$js_uri = preg_replace('/^'.preg_quote(__PS_BASE_URI__, '/').'/', '/', $js_uri);
 			$js_uri = dirname(preg_replace('/\?.+$/', '', $_SERVER['REQUEST_URI']).'a').'/..'.$js_uri;

classes/Meta.php

@@ -68,11 +68,8 @@ class MetaCore extends ObjectModel
 		{
 			if ($file != 'index.php' && !in_array(strtolower(str_replace('Controller.php', '', $file)), $exlude_pages))
 			{
-				$class_name = str_replace('.php', '', $file);
+				$reflection = new ReflectionClass(str_replace('.php', '', $file));
-				if (class_exists($class_name))
+				$properties = $reflection->getDefaultProperties();
-					$reflection = new ReflectionClass(str_replace('.php', '', $file));
-				if (isset($reflection) && $reflection)
-					$properties = $reflection->getDefaultProperties();
 				if (isset($properties['php_self']))
 					$selected_pages[$properties['php_self']] = $properties['php_self'];
 				else if (preg_match('/^[a-z0-9_.-]*\.php$/i', $file))

classes/PaymentModule.php

@@ -399,8 +399,6 @@ abstract class PaymentModuleCore extends Module
 					} // end foreach ($products)
 
 					$cart_rules_list = '';
-					$total_reduction_value_ti = 0;
-					$total_reduction_value_tex = 0;
 					foreach ($cart_rules as $cart_rule)
 					{
 						$package = array('id_carrier' => $order->id_carrier, 'id_address' => $order->id_address_delivery, 'products' => $order->product_list);
@@ -421,8 +419,7 @@ abstract class PaymentModuleCore extends Module
 						** THEN
 						** The voucher is cloned with a new value corresponding to the remainder
 						*/
-
+						if (count($order_list) == 1 && $values['tax_incl'] > $order->total_products_wt && $cart_rule['obj']->partial_use == 1 && $cart_rule['obj']->reduction_amount > 0)
-						if (count($order_list) == 1 && $values['tax_incl'] > ($order->total_products_wt - $total_reduction_value_ti) && $cart_rule['obj']->partial_use == 1 && $cart_rule['obj']->reduction_amount > 0)
 						{
 							// Create a new voucher from the original
 							$voucher = new CartRule($cart_rule['obj']->id); // We need to instantiate the CartRule without lang parameter to allow saving it
@@ -435,9 +432,9 @@ abstract class PaymentModuleCore extends Module
 
 							// Set the new voucher value
 							if ($voucher->reduction_tax)
-								$voucher->reduction_amount = $values['tax_incl'] - ($order->total_products_wt - $total_reduction_value_ti) - ($voucher->free_shipping == 1 ? $order->total_shipping_tax_incl : 0);
+								$voucher->reduction_amount = $values['tax_incl'] - $order->total_products_wt - ($voucher->free_shipping == 1 ? $order->total_shipping_tax_incl : 0);
 							else
-								$voucher->reduction_amount = $values['tax_excl'] - ($order->total_products - $total_reduction_value_tex) - ($voucher->free_shipping == 1 ? $order->total_shipping_tax_excl : 0);
+								$voucher->reduction_amount = $values['tax_excl'] - $order->total_products - ($voucher->free_shipping == 1 ? $order->total_shipping_tax_excl : 0);
 
 							$voucher->id_customer = $order->id_customer;
 							$voucher->quantity = 1;
@@ -469,10 +466,7 @@ abstract class PaymentModuleCore extends Module
 
 							$values['tax_incl'] -= $values['tax_incl'] - $order->total_products_wt;
 							$values['tax_excl'] -= $values['tax_excl'] - $order->total_products;
-
 						}
-						$total_reduction_value_ti += $values['tax_incl'];
-						$total_reduction_value_tex += $values['tax_excl'];	
 
 						$order->addCartRule($cart_rule['obj']->id, $cart_rule['obj']->name, $values, 0, $cart_rule['obj']->free_shipping);
 

classes/Product.php

@@ -1368,8 +1368,8 @@ class ProductCore extends ObjectModel
 			}
 
 			$product_supplier->product_supplier_reference = pSQL($supplier_reference);
-			$product_supplier->product_supplier_price_te = !is_null($price) ? (float)$price : (float)$product_supplier->product_supplier_price_te;
+			$product_supplier->product_supplier_price_te = (float)$price;
-			$product_supplier->id_currency = !is_null($id_currency) ? (int)$id_currency : (int)$product_supplier->id_currency;
+			$product_supplier->id_currency = (int)$id_currency;
 			$product_supplier->save();
 		}
 	}
@@ -2468,9 +2468,8 @@ class ProductCore extends ObjectModel
 
 		if (!Validate::isBool($usetax) || !Validate::isUnsignedId($id_product))
 			die(Tools::displayError());
-
 		// Initializations
-		$id_group = (int)Group::getCurrent()->id;
+		$id_group = (isset($context->customer) ? $context->customer->id_default_group : (int)Configuration::get('PS_CUSTOMER_GROUP'));
 
 		// If there is cart in context or if the specified id_cart is different from the context cart id
 		if (!is_object($cur_cart) || (Validate::isUnsignedInt($id_cart) && $id_cart && $cur_cart->id != $id_cart))
@@ -2509,7 +2508,7 @@ class ProductCore extends ObjectModel
 		$id_state = 0;
 		$zipcode = 0;
 
-		if (!$id_address && Validate::isLoadedObject($cur_cart))
+		if (!$id_address)
 			$id_address = $cur_cart->{Configuration::get('PS_TAX_ADDRESS_TYPE')};
 
 		if ($id_address)
@@ -2720,7 +2719,8 @@ class ProductCore extends ObjectModel
 		if ($use_group_reduction)
 		{
 			$reduction_from_category = GroupReduction::getValueForProduct($id_product, $id_group);
-			if ($reduction_from_category !== false)
+
+			if (!empty($reduction_from_category) && (float)$reduction_from_category == 0)
 				$price -= $price * (float)$reduction_from_category;
 			else // apply group reduction if there is no group reduction for this category
 				$price *= ((100 - Group::getReductionByIdGroup($id_group)) / 100);
@@ -2914,7 +2914,7 @@ class ProductCore extends ObjectModel
 	 * @param Shop $shop
 	 * @return string
 	 */
-	public static function sqlStock($product_alias, $product_attribute = null, $inner_join = false, Shop $shop = null)
+	public static function sqlStock($product_alias, $product_attribute = 0, $inner_join = false, Shop $shop = null)
 	{
 		$id_shop = ($shop !== null ? (int)$shop->id : null);
 		$sql = (($inner_join) ? ' INNER ' : ' LEFT ').'
@@ -3055,18 +3055,18 @@ class ProductCore extends ObjectModel
 		if (!Combination::isFeatureActive())
 			return array();
 		$sql = 'SELECT ag.`id_attribute_group`, ag.`is_color_group`, agl.`name` AS group_name, agl.`public_name` AS public_group_name,
-					a.`id_attribute`, al.`name` AS attribute_name, a.`color` AS attribute_color, product_attribute_shop.`id_product_attribute`,
+					a.`id_attribute`, al.`name` AS attribute_name, a.`color` AS attribute_color, pa.`id_product_attribute`,
-					IFNULL(stock.quantity, 0) as quantity, product_attribute_shop.`price`, product_attribute_shop.`ecotax`, product_attribute_shop.`weight`,
+					IFNULL(stock.quantity, 0) as quantity, product_attribute_shop.`price`, product_attribute_shop.`ecotax`, pa.`weight`,
 					product_attribute_shop.`default_on`, pa.`reference`, product_attribute_shop.`unit_price_impact`,
-					product_attribute_shop.`minimal_quantity`, product_attribute_shop.`available_date`, ag.`group_type`
+					pa.`minimal_quantity`, pa.`available_date`, ag.`group_type`
 				FROM `'._DB_PREFIX_.'product_attribute` pa
 				'.Shop::addSqlAssociation('product_attribute', 'pa').'
 				'.Product::sqlStock('pa', 'pa').'
-				LEFT JOIN `'._DB_PREFIX_.'product_attribute_combination` pac ON (pac.`id_product_attribute` = pa.`id_product_attribute`)
+				LEFT JOIN `'._DB_PREFIX_.'product_attribute_combination` pac ON pac.`id_product_attribute` = pa.`id_product_attribute`
-				LEFT JOIN `'._DB_PREFIX_.'attribute` a ON (a.`id_attribute` = pac.`id_attribute`)
+				LEFT JOIN `'._DB_PREFIX_.'attribute` a ON a.`id_attribute` = pac.`id_attribute`
-				LEFT JOIN `'._DB_PREFIX_.'attribute_group` ag ON (ag.`id_attribute_group` = a.`id_attribute_group`)
+				LEFT JOIN `'._DB_PREFIX_.'attribute_group` ag ON ag.`id_attribute_group` = a.`id_attribute_group`
-				LEFT JOIN `'._DB_PREFIX_.'attribute_lang` al ON (a.`id_attribute` = al.`id_attribute`)
+				LEFT JOIN `'._DB_PREFIX_.'attribute_lang` al ON a.`id_attribute` = al.`id_attribute`
-				LEFT JOIN `'._DB_PREFIX_.'attribute_group_lang` agl ON (ag.`id_attribute_group` = agl.`id_attribute_group`)
+				LEFT JOIN `'._DB_PREFIX_.'attribute_group_lang` agl ON ag.`id_attribute_group` = agl.`id_attribute_group`
 				'.Shop::addSqlAssociation('attribute', 'a').'
 				WHERE pa.`id_product` = '.(int)$this->id.'
 					AND al.`id_lang` = '.(int)$id_lang.'
@@ -3159,9 +3159,8 @@ class ProductCore extends ObjectModel
 				LEFT JOIN `'._DB_PREFIX_.'manufacturer` m ON (p.`id_manufacturer`= m.`id_manufacturer`)
 				'.Product::sqlStock('p', 0).'
 				WHERE `id_product_1` = '.(int)$this->id.
-				($active ? ' AND product_shop.`active` = 1 AND product_shop.`visibility` != \'none\'' : '').'
+				($active ? ' AND product_shop.`active` = 1' : '').'
 				GROUP BY product_shop.id_product';
-
 		if (!$result = Db::getInstance(_PS_USE_SQL_SLAVE_)->executeS($sql))
 			return false;
 		foreach ($result as &$row)

classes/ProductDownload.php

@@ -299,10 +299,10 @@ class ProductDownloadCore extends ObjectModel
 	 */
 	public static function getNewFilename()
 	{
-		do {
+		$ret = sha1(microtime());
-			$filename = sha1(microtime());
+		if (file_exists(_PS_DOWNLOAD_DIR_.$ret))
-		} while (file_exists(_PS_DOWNLOAD_DIR_.$filename));
+			$ret = ProductDownload::getNewFilename();
-		return $filename;
+		return $ret;
 	}
 
 	/**

classes/ProductSale.php

@@ -103,7 +103,7 @@ class ProductSaleCore
 				LEFT JOIN `'._DB_PREFIX_.'tax` t ON (t.`id_tax` = tr.`id_tax`)
 				'.Product::sqlStock('p').'
 				WHERE product_shop.`active` = 1
-					AND product_shop.`visibility` != \'none\'
+					AND p.`visibility` != \'none\'
 					AND p.`id_product` IN (
 						SELECT cp.`id_product`
 						FROM `'._DB_PREFIX_.'category_group` cg
@@ -156,7 +156,7 @@ class ProductSaleCore
 					ON cl.`id_category` = product_shop.`id_category_default`
 					AND cl.`id_lang` = '.(int)$id_lang.Shop::addSqlRestrictionOnLang('cl').'
 				WHERE product_shop.`active` = 1
-					AND product_shop.`visibility` != \'none\'
+					AND p.`visibility` != \'none\'
 					AND p.`id_product` IN (
 						SELECT cp.`id_product`
 						FROM `'._DB_PREFIX_.'category_group` cg

classes/Search.php

@@ -140,33 +140,36 @@ class SearchCore
 			$string = implode(' ', $processed_words);
 		}
 
-		// If the language is constituted with symbol and there is no "words", then split every chars
+		if ($indexation)
-		if (in_array($iso_code, array('zh', 'tw', 'ja')) && function_exists('mb_strlen'))
 		{
-			// Cut symbols from letters
+			// If the language is constituted with symbol and there is no "words", then split every chars
-			$symbols = '';
+			if (in_array($iso_code, array('zh', 'tw', 'ja')) && function_exists('mb_strlen'))
-			$letters = '';
-			foreach (explode(' ', $string) as $mb_word)
-				if (strlen(Tools::replaceAccentedChars($mb_word)) == mb_strlen(Tools::replaceAccentedChars($mb_word)))
-					$letters .= $mb_word.' ';
-				else
-					$symbols .= $mb_word.' ';
-		
-			if (preg_match_all('/./u', $symbols, $matches))
-				$symbols = implode(' ', $matches[0]);
-
-			$string = $letters.$symbols;
-		}
-		elseif ($indexation)
-		{
-			$minWordLen = (int)Configuration::get('PS_SEARCH_MINWORDLEN');
-			if ($minWordLen > 1)
 			{
-				$minWordLen -= 1;
+				// Cut symbols from letters
-				$string = preg_replace('/(?<=\s)[^\s]{1,'.$minWordLen.'}(?=\s)/Su', ' ', $string);
+				$symbols = '';
-				$string = preg_replace('/^[^\s]{1,'.$minWordLen.'}(?=\s)/Su', '', $string);
+				$letters = '';
-				$string = preg_replace('/(?<=\s)[^\s]{1,'.$minWordLen.'}$/Su', '', $string);
+				foreach (explode(' ', $string) as $mb_word)
-				$string = preg_replace('/^[^\s]{1,'.$minWordLen.'}$/Su', '', $string);
+					if (strlen(Tools::replaceAccentedChars($mb_word)) == mb_strlen(Tools::replaceAccentedChars($mb_word)))
+						$letters .= $mb_word.' ';
+					else
+						$symbols .= $mb_word.' ';
+			
+				if (preg_match_all('/./u', $symbols, $matches))
+					$symbols = implode(' ', $matches[0]);
+
+				$string = $letters.$symbols;
+			}
+			else
+			{
+				$minWordLen = (int)Configuration::get('PS_SEARCH_MINWORDLEN');
+				if ($minWordLen > 1)
+				{
+					$minWordLen -= 1;
+					$string = preg_replace('/(?<=\s)[^\s]{1,'.$minWordLen.'}(?=\s)/Su', ' ', $string);
+					$string = preg_replace('/^[^\s]{1,'.$minWordLen.'}(?=\s)/Su', '', $string);
+					$string = preg_replace('/(?<=\s)[^\s]{1,'.$minWordLen.'}$/Su', '', $string);
+					$string = preg_replace('/^[^\s]{1,'.$minWordLen.'}$/Su', '', $string);
+				}
 			}
 		}
 

classes/SpecificPrice.php

@@ -169,8 +169,7 @@ class SpecificPriceCore extends ObjectModel
 
 	    $priority = SpecificPrice::getPriority($id_product);
 	    foreach (array_reverse($priority) as $k => $field)
-			if (!empty($field))
+			$select .= ' IF (`'.bqSQL($field).'` = '.(int)$$field.', '.pow(2, $k + 1).', 0) + ';
-				$select .= ' IF (`'.bqSQL($field).'` = '.(int)$$field.', '.pow(2, $k + 1).', 0) + ';
 
 	    return rtrim($select, ' +').') AS `score`';
 	}
@@ -229,7 +228,7 @@ class SpecificPriceCore extends ObjectModel
 					(`to` = \'0000-00-00 00:00:00\' OR \''.$now.'\' <= `to`)
 				)
 				AND id_cart IN (0, '.(int)$id_cart.')'.
-				(($real_quantity != 0 && !Configuration::get('PS_QTY_DISCOUNT_ON_COMBINATION')) ? ' AND IF(`from_quantity` > 1, `from_quantity`, 0) <= IF(id_product_attribute=0,'.(int)$quantity.' ,'.(int)$real_quantity.')' : 'AND `from_quantity` <= '.max(1, (int)$real_quantity)).'
+				(($real_quantity != 0 && !Configuration::get('PS_QTY_DISCOUNT_ON_COMBINATION')) ? ' AND IF(`from_quantity` > 1, `from_quantity`, 0) <= IF(id_product_attribute=0,'.(int)$quantity.' ,'.(int)$real_quantity.')' : 'AND `from_quantity` <= '.(int)$real_quantity).'
 				ORDER BY `id_product_attribute` DESC, `from_quantity` DESC, `id_specific_price_rule` ASC, `score` DESC');
 		}
 		return self::$_specificPriceCache[$key];
@@ -302,7 +301,7 @@ class SpecificPriceCore extends ObjectModel
 			if (!isset($last_quantity[(int)$specific_price['id_product_attribute']]))
 				 $last_quantity[(int)$specific_price['id_product_attribute']] = $specific_price['from_quantity'];
 			elseif ($last_quantity[(int)$specific_price['id_product_attribute']] == $specific_price['from_quantity'])
-		        continue;
+		        break;
 
 			$last_quantity[(int)$specific_price['id_product_attribute']] = $specific_price['from_quantity'];
             if ($specific_price['from_quantity'] > 1)

classes/SpecificPriceRule.php

@@ -183,7 +183,7 @@ class SpecificPriceRuleCore extends ObjectModel
 
 		if ($conditions_group)
 		{
-			$where .= ' AND ((';
+			$where .= ' AND (';
 			foreach ($conditions_group as $id_condition_group => $condition_group)
 			{
 				$fields = array(
@@ -235,7 +235,7 @@ class SpecificPriceRuleCore extends ObjectModel
 				
 				$where = rtrim($where, ' AND ').') OR (';
 			}
-			$where = rtrim($where, 'OR (').')';
+			$where = rtrim($where, 'OR (');
 		}
 		if ($products && count($products))
 			$where .= ' AND p.id_product IN ('.implode(', ', array_map('intval', $products)).')';
@@ -267,7 +267,7 @@ class SpecificPriceRuleCore extends ObjectModel
 	public static function applyRuleToProduct($id_rule, $id_product, $id_product_attribute = null)
 	{
 		$rule = new SpecificPriceRule((int)$id_rule);
-		if (!Validate::isLoadedObject($rule) || !$id_product)
+		if (!Validate::isLoadedObject($rule))
 			return false;
 
 		$specific_price = new SpecificPrice();

classes/Supplier.php

@@ -72,7 +72,7 @@ class SupplierCore extends ObjectModel
 			'date_upd' => 			array('type' => self::TYPE_DATE, 'validate' => 'isDate'),
 
 			// Lang fields
-			'description' => 		array('type' => self::TYPE_HTML, 'lang' => true, 'validate' => 'isCleanHtml'),
+			'description' => 		array('type' => self::TYPE_STRING, 'lang' => true, 'validate' => 'isGenericName'),
 			'meta_title' => 		array('type' => self::TYPE_STRING, 'lang' => true, 'validate' => 'isGenericName', 'size' => 128),
 			'meta_description' => 	array('type' => self::TYPE_STRING, 'lang' => true, 'validate' => 'isGenericName', 'size' => 255),
 			'meta_keywords' => 		array('type' => self::TYPE_STRING, 'lang' => true, 'validate' => 'isGenericName', 'size' => 255),

classes/Tag.php

@@ -40,7 +40,7 @@ class TagCore extends ObjectModel
 		'primary' => 'id_tag',
 		'fields' => array(
 			'id_lang' => 	array('type' => self::TYPE_INT, 'validate' => 'isUnsignedId', 'required' => true),
-			'name' => 		array('type' => self::TYPE_STRING, 'validate' => 'isGenericName', 'required' => true, 'size' => 32),
+			'name' => 		array('type' => self::TYPE_STRING, 'validate' => 'isGenericName', 'required' => true),
 		),
 	);
 
@@ -100,24 +100,22 @@ class TagCore extends ObjectModel
 	 		$tag_list = array_filter(array_unique(array_map('trim', preg_split('#\\'.$separator.'#', $tag_list, null, PREG_SPLIT_NO_EMPTY))));
 
 	 	$list = array();
-		if (is_array($tag_list))
+		foreach ($tag_list as $tag)
-			foreach ($tag_list as $tag)
+		{
-			{
+	 	 	if (!Validate::isGenericName($tag))
-		 	 	if (!Validate::isGenericName($tag))
+	 	 		return false;
-		 	 		return false;
+			$tag_obj = new Tag(null, trim($tag), (int)$id_lang);
-				$tag = trim(substr($tag, 0, self::$definition['fields']['name']['size']));
-				$tag_obj = new Tag(null, $tag, (int)$id_lang);
 
-				/* Tag does not exist in database */
+			/* Tag does not exist in database */
-				if (!Validate::isLoadedObject($tag_obj))
+			if (!Validate::isLoadedObject($tag_obj))
-				{
+			{
-					$tag_obj->name = $tag;
+				$tag_obj->name = trim($tag);
-					$tag_obj->id_lang = (int)$id_lang;
+				$tag_obj->id_lang = (int)$id_lang;
-					$tag_obj->add();
+				$tag_obj->add();
-				}
-				if (!in_array($tag_obj->id, $list))
-					$list[] = $tag_obj->id;
 			}
+			if (!in_array($tag_obj->id, $list))
+				$list[] = $tag_obj->id;
+		}
 		$data = '';
 		foreach ($list as $tag)
 			$data .= '('.(int)$tag.','.(int)$id_product.'),';

classes/Tools.php

@@ -494,20 +494,6 @@ class ToolsCore
 		if (($is_negative = ($price < 0)))
 			$price *= -1;
 		$price = Tools::ps_round($price, $c_decimals);
-
-		/*
-		* If the language is RTL and the selected currency format contains spaces as thousands separator
-		* then the number will be printed in reverse since the space is interpreted as separating words.
-		* To avoid this we replace the currency format containing a space with the one containing a comma (,) as thousand
-		* separator when the language is RTL.
-		*
-		* TODO: This is not ideal, a currency format should probably be tied to a language, not to a currency.
-		*/
-		if(($c_format == 2) && ($context->language->is_rtl == 1))
-		{
-			$c_format = 4;
-		}
-
 		switch ($c_format)
 		{
 			/* X 0,000.00 */
@@ -526,9 +512,9 @@ class ToolsCore
 			case 4:
 				$ret = number_format($price, $c_decimals, '.', ',').$blank.$c_char;
 				break;
-			/* 0'000.00 X  Added for the switzerland currency */
+			/* 0 000.00 X  Added for the switzerland currency */
 			case 5:
-				$ret = number_format($price, $c_decimals, '.', "'").$blank.$c_char;
+				$ret = number_format($price, $c_decimals, '.', ' ').$blank.$c_char;
 				break;
 		}
 		if ($is_negative)
@@ -1274,13 +1260,6 @@ class ToolsCore
 		return Tools::strtoupper(Tools::substr($str, 0, 1)).Tools::substr($str, 1);
 	}
 
-	public static function ucwords($str)
-	{
-		if (function_exists('mb_convert_case'))
-			return mb_convert_case($str, MB_CASE_TITLE);
-		return ucwords(strtolower($str));
-	}
-
 	public static function orderbyPrice(&$array, $order_way)
 	{
 		foreach ($array as &$row)
@@ -1422,9 +1401,26 @@ class ToolsCore
 	
 	public static function copy($source, $destination, $stream_context = null)
 	{
-		if (is_null($stream_context) && !preg_match('/^https?:\/\//', $source))
+		if ($stream_context == null && preg_match('/^https?:\/\//', $source))
-			return @copy($source, $destination);
+			$stream_context = @stream_context_create(array('http' => array('timeout' => 10)));
-		return @file_put_contents($destination, Tools::file_get_contents($source, false, $stream_context));
+
+		if (in_array(@ini_get('allow_url_fopen'), array('On', 'on', '1')) || !preg_match('/^https?:\/\//', $source))
+			return @copy($source, $destination, $stream_context);
+		elseif (function_exists('curl_init'))
+		{
+			$curl = curl_init();
+			curl_setopt($curl, CURLOPT_RETURNTRANSFER, 1);
+			curl_setopt($curl, CURLOPT_URL, $source);
+			curl_setopt($curl, CURLOPT_CONNECTTIMEOUT, 5);
+			curl_setopt($curl, CURLOPT_TIMEOUT, 10);
+			curl_setopt($curl, CURLOPT_SSL_VERIFYPEER, 0);
+			$opts = stream_context_get_options($stream_context);
+			$content = curl_exec($curl);
+			curl_close($curl);
+			return file_put_contents($destination, $content);
+		}
+		else
+			return false;
 	}
 
 	/**
@@ -1600,8 +1596,7 @@ class ToolsCore
 
 		if (self::$_cache_nb_media_servers && ($id_media_server = (abs(crc32($filename)) % self::$_cache_nb_media_servers + 1)))
 			return constant('_MEDIA_SERVER_'.$id_media_server.'_');
-
+		return Tools::getShopDomain();
-		return Tools::usingSecureMode() ? Tools::getShopDomainSSL() : Tools::getShopDomain();
 	}
 
 	public static function generateHtaccess($path = null, $rewrite_settings = null, $cache_control = null, $specific = '', $disable_multiviews = null, $medias = false, $disable_modsec = null)
@@ -1681,9 +1676,6 @@ class ToolsCore
 		// RewriteEngine
 		fwrite($write_fd, "<IfModule mod_rewrite.c>\n");
 
-		// Ensure HTTP_MOD_REWRITE variable is set in environment
-		fwrite($write_fd, "SetEnv HTTP_MOD_REWRITE On\n");
-
 		// Disable multiviews ?
 		if ($disable_multiviews)
 			fwrite($write_fd, "\n# Disable Multiviews\nOptions -Multiviews\n\n");
@@ -2486,66 +2478,89 @@ exit;
 		return preg_replace('/\\\[px]\{[a-z]\}{1,2}|(\/[a-z]*)u([a-z]*)$/i', "$1$2", $pattern);
 	}
 
-	protected static $is_addons_up = true;
 	public static function addonsRequest($request, $params = array())
 	{
-		if (!self::$is_addons_up)
+		$addons_url = 'api.addons.prestashop.com';
-			return false;
+		$postData = '';
-
+		$postDataArray = array(
-		$postData = http_build_query(array(
 			'version' => isset($params['version']) ? $params['version'] : _PS_VERSION_,
 			'iso_lang' => Tools::strtolower(isset($params['iso_lang']) ? $params['iso_lang'] : Context::getContext()->language->iso_code),
 			'iso_code' => Tools::strtolower(isset($params['iso_country']) ? $params['iso_country'] : Country::getIsoById(Configuration::get('PS_COUNTRY_DEFAULT'))),
-			'shop_url' => isset($params['shop_url']) ? $params['shop_url'] : Tools::getShopDomain(),
+			'shop_url' => urlencode(isset($params['shop_url']) ? $params['shop_url'] : Tools::getShopDomain()),
-			'mail' => isset($params['email']) ? $params['email'] : Configuration::get('email')
+			'mail' => urlencode(isset($params['email']) ? $params['email'] : Configuration::get('email'))
-		));
+		);
+		foreach ($postDataArray as $postDataKey => $postDataValue)
+			$postData .= '&'.$postDataKey.'='.$postDataValue;
+		$postData = ltrim($postData, '&');
 
-		$protocols = array('https');
+		// Config for each request
-		switch ($request)
+		if ($request == 'native')
 		{
-			case 'native':
+			// Define protocol accepted and post data values for this request
-				$protocols[] = 'http';
+			$protocolsList = array('https://' => 443, 'http://' => 80);
-				$postData .= '&method=listing&action=native';
+			$postData .= '&method=listing&action=native';
-				break;
+		}
-			case 'must-have':
+		if ($request == 'must-have')
-				$protocols[] = 'http';
+		{
-				$postData .= '&method=listing&action=must-have';
+			// Define protocol accepted and post data values for this request
-				break;
+			$protocolsList = array('https://' => 443, 'http://' => 80);
-			case 'customer':
+			$postData .= '&method=listing&action=must-have';
-				$postData .= '&method=listing&action=customer&username='.urlencode(trim(Context::getContext()->cookie->username_addons)).'&password='.urlencode(trim(Context::getContext()->cookie->password_addons));
+		}
-				break;
+		if ($request == 'customer')
-			case 'check_customer':
+		{
-				$postData .= '&method=check_customer&username='.urlencode($params['username_addons']).'&password='.urlencode($params['password_addons']);
+			// Define protocol accepted and post data values for this request
-				break;
+			$protocolsList = array('https://' => 443);
-			case 'module':
+			$postData .= '&method=listing&action=customer&username='.urlencode(trim(Context::getContext()->cookie->username_addons)).'&password='.urlencode(trim(Context::getContext()->cookie->password_addons));
+		}
+		if ($request == 'check_customer')
+		{
+			// Define protocol accepted and post data values for this request
+			$protocolsList = array('https://' => 443);
+			$postData .= '&method=check_customer&username='.urlencode($params['username_addons']).'&password='.urlencode($params['password_addons']);
+		}
+		if ($request == 'module')
+		{
+			// Define protocol accepted and post data values for this request
+			if (isset($params['username_addons']) && isset($params['password_addons']))
+			{
+				$protocolsList = array('https://' => 443);
+				$postData .= '&method=module&id_module='.urlencode($params['id_module']).'&username='.urlencode($params['username_addons']).'&password='.urlencode($params['password_addons']);
+			}
+			else
+			{
+				$protocolsList = array('https://' => 443, 'http://' => 80);
 				$postData .= '&method=module&id_module='.urlencode($params['id_module']);
-				if (isset($params['username_addons']) && isset($params['password_addons']))
+			}
-					$postData .= '&username='.urlencode($params['username_addons']).'&password='.urlencode($params['password_addons']);
-				else
-					$protocols[] = 'http';
-
-				break;
-			case 'install-modules':
-				$protocols[] = 'http';
-				$postData .= '&method=listing&action=install-modules';
-				break;
-			default:
-				return false;
 		}
 		
-		$context = stream_context_create(array(
+		if ($request == 'install-modules')
-			'http' => array(
+		{
+			// Define protocol accepted and post data values for this request
+			$protocolsList = array('https://' => 443, 'http://' => 80);
+			$postData .= '&method=listing&action=install-modules';
+			
+		}
+
+		// Make the request
+		$opts = array(
+			'http'=>array(
 				'method'=> 'POST',
 				'content' => $postData,
 				'header'  => 'Content-type: application/x-www-form-urlencoded',
 				'timeout' => 5,
 			)
-		));
+		);
-		foreach ($protocols as $protocol)
+		$context = stream_context_create($opts);
-			if ($content = Tools::file_get_contents($protocol.'://api.addons.prestashop.com', false, $context))
+		foreach ($protocolsList as $protocol => $port)
-				return $content;
+		{
+			$content = Tools::file_get_contents($protocol.$addons_url, false, $context);
 
-		self::$is_addons_up = false;
+			// If content returned, we cache it
+			if ($content)
+				return $content;
+		}
+
+		// No content, return false
 		return false;
 	}
 

classes/Validate.php

@@ -592,7 +592,7 @@ class ValidateCore
 	 */
 	public static function isOrderBy($order)
 	{
-		return preg_match('/^[a-zA-Z0-9.!_-]+$/', $order);
+		return preg_match('/^[a-zA-Z0-9._-]+$/', $order);
 	}
 
 	/**

classes/cache/CacheApc.php

@@ -34,12 +34,9 @@ class CacheApcCore extends Cache
 	public function __construct()
 	{
 		$this->keys = array();
-		$cache_info = apc_cache_info((extension_loaded('apcu') === true )? '' : 'user' );
+		$cache_info = apc_cache_info('user');
 		foreach ($cache_info['cache_list'] as $entry)
-			if ( extension_loaded('apcu') === true )
+			$this->keys[$entry['info']] = $entry['ttl'];
-				$this->keys[$entry['key']] = $entry['ttl'];
-			else
-				$this->keys[$entry['info']] = $entry['ttl'];
 	}
 
 	/**

classes/cache/CacheMemcache.php

@@ -49,7 +49,7 @@ class CacheMemcacheCore extends Cache
        
 		if(is_array($servers) && count($servers) > 0)
 		{
-		    $this->keys = @$this->memcache->get(_COOKIE_IV_);
+		    $this->keys = $this->memcache->get(_COOKIE_IV_);
 		    if (!is_array($this->keys))
 		        $this->keys = array();		
 		}

classes/controller/AdminController.php

@@ -45,7 +45,7 @@ class AdminControllerCore extends Controller
 	public $template = 'content.tpl';
 
 	/** @var string Associated table name */
-	public $table = 'configuration';
+	public $table;
 
 	public $list_id;
 
@@ -387,7 +387,7 @@ class AdminControllerCore extends Controller
 			$filter = '';
 			foreach ($this->fields_list AS $field => $t)
 			{
-				if ($val = Tools::getValue($this->table.'Filter_'.$field))
+				if ($val = htmlspecialchars(Tools::getValue($this->table.'Filter_'.$field), ENT_QUOTES, 'UTF-8'))
 				{
 					if(!is_array($val) && !empty($val))
 						$filter .= ($filter ?  ', ' : $this->l(' filter by ')).$t['title'].' : ';
@@ -395,13 +395,13 @@ class AdminControllerCore extends Controller
 					if (isset($t['type']) && $t['type'] == 'bool')
 						$filter .= ((bool)$val) ? $this->l('yes') : $this->l('no');
 					elseif(is_string($val))
-						$filter .= htmlspecialchars($val, ENT_QUOTES, 'UTF-8');
+						$filter .= $val;
 					elseif(is_array($val))
 					{
 						$tmp = '';
 						foreach($val as $v)
 							if(is_string($v) && !empty($v))
-								$tmp .= ' - '.htmlspecialchars($v, ENT_QUOTES, 'UTF-8');
+								$tmp .= ' - '.$v;
 						if(Tools::strlen($tmp))
 						{
 							$tmp = ltrim($tmp, ' - ');
@@ -726,8 +726,6 @@ class AdminControllerCore extends Controller
 	 */
 	public function processAdd()
 	{
-		if (!isset($this->className) || empty($this->className))
-			return false;
 		/* Checking fields validity */
 		$this->validateRules();
 		if (count($this->errors) <= 0)
@@ -1144,8 +1142,6 @@ class AdminControllerCore extends Controller
 	 */
 	protected function loadObject($opt = false)
 	{
-		if (!isset($this->className) || empty($this->className))
-			return true;
 		$id = (int)Tools::getValue($this->identifier);
 		if ($id && Validate::isUnsignedId($id))
 		{
@@ -1539,23 +1535,21 @@ class AdminControllerCore extends Controller
 	
 	protected function addToolBarModulesListButton()
 	{
+		
 		if (!$this->isFresh(Module::CACHE_FILE_DEFAULT_COUNTRY_MODULES_LIST, 86400))
 			file_put_contents(_PS_ROOT_DIR_.Module::CACHE_FILE_DEFAULT_COUNTRY_MODULES_LIST, Tools::addonsRequest('native'));
 		
-		$country_module_list = file_get_contents(_PS_ROOT_DIR_.Module::CACHE_FILE_DEFAULT_COUNTRY_MODULES_LIST);
+		$country_module_list_xml = simplexml_load_file(_PS_ROOT_DIR_.Module::CACHE_FILE_DEFAULT_COUNTRY_MODULES_LIST);
-		if (!empty($country_module_list) && $country_module_list_xml = simplexml_load_string($country_module_list))
+			$country_module_list = array();
-		{
-			$country_module_list_array = array();
 			foreach ($country_module_list_xml->module as $k => $m)
-				$country_module_list_array[] = (string)$m->name;
+				$country_module_list[] = (string)$m->name;
-			$this->tab_modules_list['slider_list'] = array_intersect($this->tab_modules_list['slider_list'], $country_module_list_array);
+		$this->tab_modules_list['slider_list'] = array_intersect($this->tab_modules_list['slider_list'], $country_module_list);
-		}
 		
 		if (is_array($this->tab_modules_list['slider_list']) && count($this->tab_modules_list['slider_list']))
 			$this->toolbar_btn['modules-list'] = array(
-				'href' => '#',
+					'href' => '#',
-				'desc' => $this->l('Modules List')
+					'desc' => $this->l('Modules List')
-			);
+				);
 	}
 
 	/**
@@ -2112,7 +2106,6 @@ class AdminControllerCore extends Controller
 	 */
 	public function getList($id_lang, $order_by = null, $order_way = null, $start = 0, $limit = null, $id_lang_shop = false)
 	{
-
 		if (!isset($this->list_id))
 			$this->list_id = $this->table;
 
@@ -2160,38 +2153,28 @@ class AdminControllerCore extends Controller
 			|| !Validate::isUnsignedId($id_lang))
 			throw new PrestaShopException('get list params is not valid');
 
-		if (!isset($this->fields_list[$order_by]['order_key']) && isset($this->fields_list[$order_by]['filter_key']))
+		if (isset($this->fields_list[$order_by]) && isset($this->fields_list[$order_by]['filter_key']))
-			$this->fields_list[$order_by]['order_key'] = $this->fields_list[$order_by]['filter_key'];
+			$order_by = $this->fields_list[$order_by]['filter_key'];
-
-		if (isset($this->fields_list[$order_by]) && isset($this->fields_list[$order_by]['order_key']))
-			$order_by = $this->fields_list[$order_by]['order_key'];
 
 		/* Determine offset from current page */
-
-		
 		if ((isset($_POST['submitFilter'.$this->list_id]) ||
 		isset($_POST['submitFilter'.$this->list_id.'_x']) ||
 		isset($_POST['submitFilter'.$this->list_id.'_y'])) &&
 		!empty($_POST['submitFilter'.$this->list_id]) &&
 		is_numeric($_POST['submitFilter'.$this->list_id]))
 			$start = ((int)$_POST['submitFilter'.$this->list_id] - 1) * $limit;
-		elseif (empty($start) && isset($this->context->cookie->{$this->list_id.'_start'}) && Tools::isSubmit('export'.$this->table))
-			$start = $this->context->cookie->{$this->list_id.'_start'};
-		else
-			$start = 0;
-
-		$this->context->cookie->{$this->list_id.'_start'} = $start;
 
 		/* Cache */
 		$this->_lang = (int)$id_lang;
-		$this->_orderBy = $order_by;
 
 		if (preg_match('/[.!]/', $order_by))
 		{
 			$order_by_split = preg_split('/[.!]/', $order_by);
 			$order_by = pSQL($order_by_split[0]).'.`'.pSQL($order_by_split[1]).'`';
+			$this->_orderBy = (isset($order_by_split) && isset($order_by_split[1])) ? $order_by_split[1] : $order_by;
 		}
-
+		else
+			$this->_orderBy = $order_by;
 		$this->_orderWay = Tools::strtoupper($order_way);
 
 		/* SQL table : orders, but class name is Order */
@@ -2250,6 +2233,8 @@ class AdminControllerCore extends Controller
 				$having_clause .= $this->_having.' ';
 		}
 
+
+
 		$this->_listsql = '
 		SELECT SQL_CALC_FOUND_ROWS
 		'.($this->_tmpTableFilter ? ' * FROM (SELECT ' : '');
@@ -2416,7 +2401,7 @@ class AdminControllerCore extends Controller
 	public function getFieldValue($obj, $key, $id_lang = null)
 	{
 		if ($id_lang)
-			$default_value = (isset($obj->id) && $obj->id && isset($obj->{$key}[$id_lang])) ? $obj->{$key}[$id_lang] : false;
+			$default_value = ($obj->id && isset($obj->{$key}[$id_lang])) ? $obj->{$key}[$id_lang] : false;
 		else
 			$default_value = isset($obj->{$key}) ? $obj->{$key} : false;
 
@@ -2523,18 +2508,12 @@ class AdminControllerCore extends Controller
 			foreach ($rules['validateLang'] as $field_lang => $function)
 				foreach ($languages as $language)
 					if (($value = Tools::getValue($field_lang.'_'.$language['id_lang'])) !== false && !empty($value))
-					{
+						if (!Validate::$function($value))
-						if (Tools::strtolower($function) == 'iscleanhtml' && Configuration::get('PS_ALLOW_HTML_IFRAME'))
-							$res = Validate::$function($value, true);
-						else
-							$res = Validate::$function($value);
-						if (!$res)
 							$this->errors[$field_lang.'_'.$language['id_lang']] = sprintf(
 								Tools::displayError('The %1$s field (%2$s) is invalid.'),
 								call_user_func(array($class_name, 'displayFieldName'), $field_lang, $class_name),
 								$language['name']
 							);
-					}
 	}
 
 	/**
@@ -2961,17 +2940,21 @@ class AdminControllerCore extends Controller
 
 	public function isFresh($file, $timeout = 604800000)
 	{
-		if (file_exists(_PS_ROOT_DIR_.$file) && filesize(_PS_ROOT_DIR_.$file) > 0)
+		if (file_exists(_PS_ROOT_DIR_.$file))
+		{
+			if (filesize(_PS_ROOT_DIR_.$file) < 1)
+				return false;
 			return ((time() - filemtime(_PS_ROOT_DIR_.$file)) < $timeout);
-		return false;
+		}
+		else
+			return false;
 	}
 
-	protected static $is_prestashop_up = true;
 	public function refresh($file_to_refresh, $external_file)
 	{
-		if (self::$is_prestashop_up && $content = Tools::file_get_contents($external_file))
+		$content = Tools::file_get_contents($external_file);
+		if ($content)
 			return (bool)file_put_contents(_PS_ROOT_DIR_.$file_to_refresh, $content);
-		self::$is_prestashop_up = false;
 		return false;
 	}
 	

classes/controller/FrontController.php

@@ -65,9 +65,6 @@ class FrontControllerCore extends Controller
 
 		parent::__construct();
 
-		if (Configuration::get('PS_SSL_ENABLED') && Configuration::get('PS_SSL_ENABLED_EVERYWHERE'))
-			$this->ssl = true;
-
 		if (isset($useSSL))
 			$this->ssl = $useSSL;
 		else
@@ -148,6 +145,8 @@ class FrontControllerCore extends Controller
 		// @TODO This method must be moved into switchLanguage
 		Tools::setCookieLanguage($this->context->cookie);
 		
+		$currency = Tools::setCurrency($this->context->cookie);
+
 		$protocol_link = (Configuration::get('PS_SSL_ENABLED') || Tools::usingSecureMode()) ? 'https://' : 'http://';
 		$useSSL = ((isset($this->ssl) && $this->ssl && Configuration::get('PS_SSL_ENABLED')) || Tools::usingSecureMode()) ? true : false;
 		$protocol_content = ($useSSL) ? 'https://' : 'http://';
@@ -168,8 +167,6 @@ class FrontControllerCore extends Controller
 			if (($newDefault = $this->geolocationManagement($this->context->country)) && Validate::isLoadedObject($newDefault))
 				$this->context->country = $newDefault;
 
-		$currency = Tools::setCurrency($this->context->cookie);
-
 		if (isset($_GET['logout']) || ($this->context->customer->logged && Customer::isBanned($this->context->customer->id)))
 		{
 			$this->context->customer->logout();
@@ -515,7 +512,7 @@ class FrontControllerCore extends Controller
 			if (Configuration::get('PS_CSS_THEME_CACHE'))
 				$this->css_files = Media::cccCSS($this->css_files);
 			//JS compressor management
-			if (Configuration::get('PS_JS_THEME_CACHE') && !$this->context->getMobileDevice())
+			if (Configuration::get('PS_JS_THEME_CACHE'))
 				$this->js_files = Media::cccJs($this->js_files);
 		}
 
@@ -600,7 +597,7 @@ class FrontControllerCore extends Controller
 		if (!$canonical_url || !Configuration::get('PS_CANONICAL_REDIRECT') || strtoupper($_SERVER['REQUEST_METHOD']) != 'GET' || Tools::getValue('live_edit'))
 			return;
 
-		$match_url = (Configuration::get('PS_SSL_ENABLED') && ($this->ssl || Configuration::get('PS_SSL_ENABLED_EVERYWHERE')) ? 'https://' : 'http://').$_SERVER['HTTP_HOST'].$_SERVER['REQUEST_URI'];
+		$match_url = (($this->ssl && Configuration::get('PS_SSL_ENABLED')) ? 'https://' : 'http://').$_SERVER['HTTP_HOST'].$_SERVER['REQUEST_URI'];
 		$match_url = rawurldecode($match_url);
 		if (!preg_match('/^'.Tools::pRegexp(rawurldecode($canonical_url), '/').'([&?].*)?$/', $match_url))
 		{
@@ -670,7 +667,6 @@ class FrontControllerCore extends Controller
 						}
 					}
 				}
-
 				if (isset($this->context->cookie->iso_code_country) && $this->context->cookie->iso_code_country && !Validate::isLanguageIsoCode($this->context->cookie->iso_code_country))
 					$this->context->cookie->iso_code_country = Country::getIsoById(Configuration::get('PS_COUNTRY_DEFAULT'));
 				if (isset($this->context->cookie->iso_code_country) && ($id_country = Country::getByIso(strtoupper($this->context->cookie->iso_code_country))))

classes/controller/ModuleFrontController.php

@@ -60,7 +60,7 @@ class ModuleFrontControllerCore extends FrontController
 		elseif (Tools::file_exists_cache($this->getTemplatePath().$template))
 			$this->template = $this->getTemplatePath().$template;
 		else
-			throw new PrestaShopException("Template '$template' not found");
+			throw new PrestaShopException("Template '$template'' not found");
 	}
 
 	/**

classes/helper/Helper.php

@@ -27,7 +27,7 @@
 class HelperCore
 {
 	public $currentIndex;
-	public $table = 'configuration';
+	public $table;
 	public $identifier;
 	public $token;
 	public $toolbar_btn;

classes/helper/HelperForm.php

@@ -35,8 +35,10 @@ class HelperFormCore extends Helper
 	/** @var array of forms fields */
 	protected $fields_form = array();
 
-	/** @var array values of form fields */
+	/** @var array values ​​of form fields */
 	public $fields_value = array();
+
+	public $table;
 	public $name_controller = '';
 
 	/** @var string if not null, a title will be added on that list */

classes/helper/HelperList.php

@@ -136,9 +136,6 @@ class HelperListCore extends Helper
 		$this->_list = $list;
 		$this->fields_list = $fields_display;
 
-		$this->orderBy = preg_replace('/^([a-z _]*!)/Ui', '', $this->orderBy);
-		$this->orderWay = preg_replace('/^([a-z _]*!)/Ui', '', $this->orderWay);
-
 		// Display list header (filtering, pagination and column names)
 		$tpl_vars['header'] = $this->displayListHeader();
 
@@ -459,7 +456,7 @@ class HelperListCore extends Helper
 		);
 		
 		if ($this->specificConfirmDelete !== false)
-			$data['confirm'] = !is_null($this->specificConfirmDelete) ? '\r'.$this->specificConfirmDelete : Tools::safeOutput(addcslashes(self::$cache_lang['DeleteItem'].$name, '\''));
+			$data['confirm'] = !is_null($this->specificConfirmDelete) ? '\r'.$this->specificConfirmDelete : addcslashes(Tools::htmlentitiesDecodeUTF8(self::$cache_lang['DeleteItem'].$name), '\'');
 		
 		$tpl->assign(array_merge($this->tpl_delete_link_vars, $data));
 
@@ -525,6 +522,9 @@ class HelperListCore extends Helper
 			isset($this->context->cookie->{$this->list_id.'_pagination'}) ? $this->context->cookie->{$this->list_id.'_pagination'} : null
 		);
 
+		// Cleaning links
+		if (Tools::getValue($this->table.'Orderby') && Tools::getValue($this->table.'Orderway'))
+			$this->currentIndex = preg_replace('/&'.$this->table.'Orderby=([a-z _]*)&'.$this->table.'Orderway=([a-z]*)/i', '', $this->currentIndex);
 
 		if ($this->position_identifier && (int)Tools::getValue($this->position_identifier, 1))
 			$table_id = substr($this->identifier, 3, strlen($this->identifier));

classes/module/Module.php

@@ -119,9 +119,6 @@ abstract class ModuleCore
 	/** @var Smarty_Data */
 	protected $smarty;
 	
-	/** @var currentSmartySubTemplate */	
-	protected $current_subtemplate = null;
-	
 	
 	const CACHE_FILE_MODULES_LIST = '/config/xml/modules_list.xml';
 	
@@ -302,7 +299,7 @@ abstract class ModuleCore
 					$this->_errors[] = $upgrade_detail['number_upgrade_left'].' '.$this->l('upgrade left');
 				}
 
-				if (isset($upgrade_detail['duplicate']) && $upgrade_detail['duplicate'])
+				if ($upgrade_detail['duplicate'])
 					$this->_errors[] = sprintf(Tools::displayError('Module %s cannot be upgraded this time: please refresh this page to update it.'), $this->name);
 				else
 					$this->_errors[] = $this->l('To prevent any problem, this module has been turned off');
@@ -1630,18 +1627,15 @@ abstract class ModuleCore
 	
 	protected function getCacheId($name = null)
 	{
-		$cache_array = array();
+		$cache_array = array(
-		$cache_array[] = $name !== null ? $name : $this->name;
+			$name !== null ? $name : $this->name,
-		if (Configuration::get('PS_SSL_ENABLED'))
+			(int)Tools::usingSecureMode(),
-			$cache_array[] = (int)Tools::usingSecureMode();
+			(int)$this->context->shop->id,
-		if (Shop::isFeatureActive())
+			(int)Group::getCurrent()->id,
-			$cache_array[] = (int)$this->context->shop->id;
+			(int)$this->context->language->id,
-		$cache_array[] = (int)Group::getCurrent()->id;
+			(int)$this->context->currency->id,
-		if (Language::isMultiLanguageActivated())
+			(int)$this->context->country->id
-			$cache_array[] = (int)$this->context->language->id;
+		);
-		if (Currency::isMultiCurrencyActivated())
-			$cache_array[] = (int)$this->context->currency->id;
-		$cache_array[] = (int)$this->context->country->id;
 		return implode('|', $cache_array);
 	}
 
@@ -1659,36 +1653,21 @@ abstract class ModuleCore
 			if ($cacheId !== null)
 				Tools::enableCache();
 
-			$result = $this->getCurrentSubTemplate($template, $cacheId, $compileId)->fetch();
+			$smarty_subtemplate = $this->context->smarty->createTemplate(
+				$this->getTemplatePath($template),
+				$cacheId,
+				$compileId,
+				$this->smarty
+			);
+			$result = $smarty_subtemplate->fetch();
 
 			if ($cacheId !== null)
 				Tools::restoreCacheSettings();
 
-			$this->resetCurrentSubTemplate($template, $cacheId, $compileId);
-
 			return $result;
 		}
 	}
 
-	protected function getCurrentSubTemplate($template, $cache_id = null, $compile_id = null)
-	{
-		if (!isset($this->current_subtemplate[$template.'_'.$cache_id.'_'.$compile_id]))
-		{
-			$this->current_subtemplate[$template.'_'.$cache_id.'_'.$compile_id] = $this->context->smarty->createTemplate(
-				$this->getTemplatePath($template),
-				$cache_id,
-				$compile_id,
-				$this->smarty
-			);
-		}
-		return $this->current_subtemplate[$template.'_'.$cache_id.'_'.$compile_id];
-	}
-	
-	protected function resetCurrentSubTemplate($template, $cache_id, $compile_id)
-	{
-		$this->current_subtemplate[$template.'_'.$cache_id.'_'.$compile_id] = null;
-	}
-
 	/**
 	 * Get realpath of a template of current module (check if template is overriden too)
 	 *
@@ -1704,12 +1683,10 @@ abstract class ModuleCore
 		
 		if ($overloaded)
 			return $overloaded;
-		elseif (file_exists(_PS_MODULE_DIR_.$this->name.'/views/templates/hook/'.$template))
+		else if (file_exists(_PS_MODULE_DIR_.$this->name.'/views/templates/hook/'.$template))
 			return _PS_MODULE_DIR_.$this->name.'/views/templates/hook/'.$template;
-		elseif (file_exists(_PS_MODULE_DIR_.$this->name.'/'.$template))
-			return _PS_MODULE_DIR_.$this->name.'/'.$template;
 		else
-			return null;
+			return _PS_MODULE_DIR_.$this->name.'/'.$template;
 	}
 
 	protected function _getApplicableTemplateDir($template)
@@ -1719,8 +1696,10 @@ abstract class ModuleCore
 
 	public function isCached($template, $cacheId = null, $compileId = null)
 	{
+		$context = Context::getContext();
+
 		Tools::enableCache();
-		$is_cached = $this->getCurrentSubTemplate($this->getTemplatePath($template), $cacheId, $compileId)->isCached($this->getTemplatePath($template), $cacheId, $compileId);
+		$is_cached =  $context->smarty->isCached($this->getTemplatePath($template), $cacheId, $compileId);
 		Tools::restoreCacheSettings();
 
 		return $is_cached;
@@ -1729,8 +1708,6 @@ abstract class ModuleCore
 	protected function _clearCache($template, $cache_id = null, $compile_id = null)
 	{
 		Tools::enableCache();
-		if ($cache_id === null)
-			$cache_id = $this->name;
 		Tools::clearCache(Context::getContext()->smarty, $this->getTemplatePath($template), $cache_id, $compile_id);
 		Tools::restoreCacheSettings();
 	}
@@ -1749,15 +1726,7 @@ abstract class ModuleCore
             <need_instance>'.(int)$this->need_instance.'</need_instance>'.(isset($this->limited_countries) ? "\n\t".'<limited_countries>'.(count($this->limited_countries) == 1 ? $this->limited_countries[0] : '').'</limited_countries>' : '').'
         </module>';
 		if (is_writable(_PS_MODULE_DIR_.$this->name.'/'))
-		{
+			file_put_contents(_PS_MODULE_DIR_.$this->name.'/config.xml', $xml);
-			$file = _PS_MODULE_DIR_.$this->name.'/config.xml';
-			if (!@file_put_contents($file, $xml))
-				if (!is_writable($file))
-				{
-					@unlink($file);
-					@file_put_contents($file, $xml);
-				}
-		}
 	}
 
 	/**
@@ -1982,43 +1951,7 @@ abstract class ModuleCore
 		$path = Autoload::getInstance()->getClassPath($classname.'Core');
 
 		// Check if there is already an override file, if not, we just need to copy the file
-		if (Autoload::getInstance()->getClassPath($classname))
+		if (!($classpath = Autoload::getInstance()->getClassPath($classname)))
-		{
-			// Check if override file is writable
-			$override_path = _PS_ROOT_DIR_.'/'.Autoload::getInstance()->getClassPath($classname);
-			if ((!file_exists($override_path) && !is_writable(dirname($override_path))) || (file_exists($override_path) && !is_writable($override_path)))
-				throw new Exception(sprintf(Tools::displayError('file (%s) not writable'), $override_path));
-
-			// Get a uniq id for the class, because you can override a class (or remove the override) twice in the same session and we need to avoid redeclaration
-			do $uniq = uniqid();
-			while (class_exists($classname.'OverrideOriginal_remove', false));
-				
-			// Make a reflection of the override class and the module override class
-			$override_file = file($override_path);
-			eval(preg_replace(array('#^\s*<\?php#', '#class\s+'.$classname.'\s+extends\s+([a-z0-9_]+)(\s+implements\s+([a-z0-9_]+))?#i'), array('', 'class '.$classname.'OverrideOriginal'.$uniq), implode('', $override_file)));
-			$override_class = new ReflectionClass($classname.'OverrideOriginal'.$uniq);
-
-			$module_file = file($this->getLocalPath().'override'.DIRECTORY_SEPARATOR.$path);
-			eval(preg_replace(array('#^\s*<\?php#', '#class\s+'.$classname.'(\s+extends\s+([a-z0-9_]+)(\s+implements\s+([a-z0-9_]+))?)?#i'), array('', 'class '.$classname.'Override'.$uniq), implode('', $module_file)));
-			$module_class = new ReflectionClass($classname.'Override'.$uniq);
-
-			// Check if none of the methods already exists in the override class
-			foreach ($module_class->getMethods() as $method)
-				if ($override_class->hasMethod($method->getName()))
-					throw new Exception(sprintf(Tools::displayError('The method %1$s in the class %2$s is already overriden.'), $method->getName(), $classname));
-
-			// Check if none of the properties already exists in the override class
-			foreach ($module_class->getProperties() as $property)
-				if ($override_class->hasProperty($property->getName()))
-					throw new Exception(sprintf(Tools::displayError('The property %1$s in the class %2$s is already defined.'), $property->getName(), $classname));
-
-			// Insert the methods from module override in override
-			$copy_from = array_slice($module_file, $module_class->getStartLine() + 1, $module_class->getEndLine() - $module_class->getStartLine() - 2);
-			array_splice($override_file, $override_class->getEndLine() - 1, 0, $copy_from);
-			$code = implode('', $override_file);
-			file_put_contents($override_path, $code);
-		}
-		else
 		{
 			$override_src = $this->getLocalPath().'override'.DIRECTORY_SEPARATOR.$path;
 			$override_dest = _PS_ROOT_DIR_.DIRECTORY_SEPARATOR.'override'.DIRECTORY_SEPARATOR.$path;
@@ -2027,7 +1960,39 @@ abstract class ModuleCore
 			copy($override_src, $override_dest);
 			// Re-generate the class index
 			Autoload::getInstance()->generateIndex();
+			return true;
 		}
+		
+		// Check if override file is writable
+		$override_path = _PS_ROOT_DIR_.'/'.Autoload::getInstance()->getClassPath($classname);
+		if ((!file_exists($override_path) && !is_writable(dirname($override_path))) || (file_exists($override_path) && !is_writable($override_path)))
+			throw new Exception(sprintf(Tools::displayError('file (%s) not writable'), $override_path));
+			
+		// Make a reflection of the override class and the module override class
+		$override_file = file($override_path);
+		eval(preg_replace(array('#^\s*<\?php#', '#class\s+'.$classname.'\s+extends\s+([a-z0-9_]+)(\s+implements\s+([a-z0-9_]+))?#i'), array('', 'class '.$classname.'OverrideOriginal'), implode('', $override_file)));
+		$override_class = new ReflectionClass($classname.'OverrideOriginal');
+
+		$module_file = file($this->getLocalPath().'override'.DIRECTORY_SEPARATOR.$path);
+		eval(preg_replace(array('#^\s*<\?php#', '#class\s+'.$classname.'(\s+extends\s+([a-z0-9_]+)(\s+implements\s+([a-z0-9_]+))?)?#i'), array('', 'class '.$classname.'Override'), implode('', $module_file)));
+		$module_class = new ReflectionClass($classname.'Override');
+
+		// Check if none of the methods already exists in the override class
+		foreach ($module_class->getMethods() as $method)
+			if ($override_class->hasMethod($method->getName()))
+				throw new Exception(sprintf(Tools::displayError('The method %1$s in the class %2$s is already overriden.'), $method->getName(), $classname));
+
+		// Check if none of the properties already exists in the override class
+		foreach ($module_class->getProperties() as $property)
+			if ($override_class->hasProperty($property->getName()))
+				throw new Exception(sprintf(Tools::displayError('The property %1$s in the class %2$s is already defined.'), $property->getName(), $classname));
+
+		// Insert the methods from module override in override
+		$copy_from = array_slice($module_file, $module_class->getStartLine() + 1, $module_class->getEndLine() - $module_class->getStartLine() - 2);
+		array_splice($override_file, $override_class->getEndLine() - 1, 0, $copy_from);
+		$code = implode('', $override_file);
+		file_put_contents($override_path, $code);
+
 		return true;
 	}
 
@@ -2049,18 +2014,14 @@ abstract class ModuleCore
 		if (!is_writable($override_path))
 			return false;
 
-		// Get a uniq id for the class, because you can override a class (or remove the override) twice in the same session and we need to avoid redeclaration
-		do $uniq = uniqid();
-		while (class_exists($classname.'OverrideOriginal_remove', false));
-			
 		// Make a reflection of the override class and the module override class
 		$override_file = file($override_path);
-		eval(preg_replace(array('#^\s*<\?php#', '#class\s+'.$classname.'\s+extends\s+([a-z0-9_]+)(\s+implements\s+([a-z0-9_]+))?#i'), array('', 'class '.$classname.'OverrideOriginal_remove'.$uniq), implode('', $override_file)));
+		eval(preg_replace(array('#^\s*<\?php#', '#class\s+'.$classname.'\s+extends\s+([a-z0-9_]+)(\s+implements\s+([a-z0-9_]+))?#i'), array('', 'class '.$classname.'OverrideOriginal_remove'), implode('', $override_file)));
-		$override_class = new ReflectionClass($classname.'OverrideOriginal_remove'.$uniq);
+		$override_class = new ReflectionClass($classname.'OverrideOriginal_remove');
 
 		$module_file = file($this->getLocalPath().'override/'.$path);
-		eval(preg_replace(array('#^\s*<\?php#', '#class\s+'.$classname.'(\s+extends\s+([a-z0-9_]+)(\s+implements\s+([a-z0-9_]+))?)?#i'), array('', 'class '.$classname.'Override_remove'.$uniq), implode('', $module_file)));
+		eval(preg_replace(array('#^\s*<\?php#', '#class\s+'.$classname.'(\s+extends\s+([a-z0-9_]+)(\s+implements\s+([a-z0-9_]+))?)?#i'), array('', 'class '.$classname.'Override_remove'), implode('', $module_file)));
-		$module_class = new ReflectionClass($classname.'Override_remove'.$uniq);
+		$module_class = new ReflectionClass($classname.'Override_remove');
 
 		// Remove methods from override file
 		$override_file = file($override_path);

classes/order/Order.php

@@ -716,6 +716,7 @@ class OrderCore extends ObjectModel
 		return Db::getInstance(_PS_USE_SQL_SLAVE_)->executeS('
 		SELECT *
 		FROM `'._DB_PREFIX_.'order_cart_rule` ocr
+		LEFT JOIN `'._DB_PREFIX_.'cart_rule` cr ON cr.`id_cart_rule` = ocr.`id_cart_rule`
 		WHERE ocr.`id_order` = '.(int)$this->id);
 	}
 

classes/order/OrderCartRule.php

@@ -47,9 +47,6 @@ class OrderCartRuleCore extends ObjectModel
 	/** @var float value (tax excl.) of voucher */
 	public $value_tax_excl;
 
-	/** @var boolean value : voucher gives free shipping or not */
-	public $free_shipping;
-
 	/**
 	 * @see ObjectModel::$definition
 	 */
@@ -62,8 +59,7 @@ class OrderCartRuleCore extends ObjectModel
 			'id_order_invoice' =>	array('type' => self::TYPE_INT, 'validate' => 'isUnsignedId'),
 			'name' => 				array('type' => self::TYPE_STRING, 'validate' => 'isCleanHtml', 'required' => true),
 			'value' => 				array('type' => self::TYPE_FLOAT, 'validate' => 'isFloat', 'required' => true),
-			'value_tax_excl' => 	array('type' => self::TYPE_FLOAT, 'validate' => 'isFloat', 'required' => true),
+			'value_tax_excl' => 	array('type' => self::TYPE_FLOAT, 'validate' => 'isFloat', 'required' => true)
-			'free_shipping' => 		array('type' => self::TYPE_BOOL, 'validate' => 'isBool')
 		)
 	);
 

classes/order/OrderInvoice.php

@@ -243,7 +243,7 @@ class OrderInvoiceCore extends ObjectModel
 		WHERE od.`id_order` = '.(int)$this->id_order.'
 		AND od.`id_order_invoice` = '.(int)$this->id.'
 		AND od.`tax_computation_method` = '.(int)TaxCalculator::ONE_AFTER_ANOTHER_METHOD
-		) || Configuration::get('PS_INVOICE_TAXES_BREAKDOWN');
+		);
 	}
 
 	/**
@@ -301,7 +301,7 @@ class OrderInvoiceCore extends ObjectModel
 		{
 			// sum by order details in order to retrieve real taxes rate
 			$taxes_infos = Db::getInstance()->executeS('
-			SELECT odt.`id_order_detail`, t.`rate` AS `name`, od.`total_price_tax_excl` AS total_price_tax_excl, SUM(t.`rate`) AS rate, SUM(`total_amount`) AS `total_amount`, od.`ecotax`, od.`ecotax_tax_rate`, od.`product_quantity`
+			SELECT odt.`id_order_detail`, t.`rate` AS `name`, SUM(od.`total_price_tax_excl`) AS total_price_tax_excl, SUM(t.`rate`) AS rate, SUM(`total_amount`) AS `total_amount`, od.`ecotax`, od.`ecotax_tax_rate`, od.`product_quantity`
 			FROM `'._DB_PREFIX_.'order_detail_tax` odt
 			LEFT JOIN `'._DB_PREFIX_.'tax` t ON (t.`id_tax` = odt.`id_tax`)
 			LEFT JOIN `'._DB_PREFIX_.'order_detail` od ON (od.`id_order_detail` = odt.`id_order_detail`)

classes/order/OrderPayment.php

@@ -49,7 +49,7 @@ class OrderPaymentCore extends ObjectModel
 			'id_currency' => 		array('type' => self::TYPE_INT, 'validate' => 'isUnsignedId', 'required' => true),
 			'amount' => 			array('type' => self::TYPE_FLOAT, 'validate' => 'isNegativePrice', 'required' => true),
 			'payment_method' => 	array('type' => self::TYPE_STRING, 'validate' => 'isGenericName'),
-			'conversion_rate' => 	array('type' => self::TYPE_FLOAT, 'validate' => 'isFloat'),
+			'conversion_rate' => 	array('type' => self::TYPE_INT, 'validate' => 'isFloat'),
 			'transaction_id' => 	array('type' => self::TYPE_STRING, 'validate' => 'isAnything', 'size' => 254),
 			'card_number' => 		array('type' => self::TYPE_STRING, 'validate' => 'isAnything', 'size' => 254),
 			'card_brand' => 		array('type' => self::TYPE_STRING, 'validate' => 'isAnything', 'size' => 254),

classes/order/OrderSlip.php

@@ -129,6 +129,19 @@ class OrderSlipCore extends ObjectModel
 			{
 				$products[$key] = $product;
 				$products[$key]['product_quantity'] = $slip_quantity[$product['id_order_detail']];
+				if (count($cart_rules))
+				{
+					$order->setProductPrices($product);
+					$realProductPrice = $products[$key]['product_price'];
+					// Todo : must be updated to use the cart rules
+					foreach ($cart_rules as $cart_rule)
+					{
+						if ($cart_rule['reduction_percent'])
+							$products[$key]['product_price'] -= $realProductPrice * ($cart_rule['reduction_percent'] / 100);
+						elseif ($cart_rule['reduction_amount'])
+							$products[$key]['product_price'] -= (($cart_rule['reduction_amount'] * ($product['product_price_wt'] / $order->total_products_wt)) / (1.00 + ($product['tax_rate'] / 100)));
+					}
+				}
 			}
 		return $order->getProducts($products);
 	}

classes/pdf/HTMLTemplateDeliverySlip.php

@@ -90,7 +90,7 @@ class HTMLTemplateDeliverySlipCore extends HTMLTemplate
 	 */
 	public function getFilename()
 	{
-		return Configuration::get('PS_DELIVERY_PREFIX', Context::getContext()->language->id, null, $this->order->id_shop).sprintf('%06d', $this->order->delivery_number).'.pdf';
+		return Configuration::get('PS_DELIVERY_PREFIX', Context::getContext()->language->id, null, $this->order->id_shop).sprintf('%06d', $this->order->invoice_number).'.pdf';
 	}
 }
 

classes/shop/Shop.php

@@ -363,12 +363,10 @@ class ShopCore extends ObjectModel
 			// Define some $_SERVER variables like HTTP_HOST if PHP is launched with php-cli
 			if (Tools::isPHPCLI())
 			{
-				if (!isset($_SERVER['HTTP_HOST']) || empty($_SERVER['HTTP_HOST']))
+				if(!isset($_SERVER['HTTP_HOST']) || empty($_SERVER['HTTP_HOST']))
 					$_SERVER['HTTP_HOST'] = $shop->domain;
-				if (!isset($_SERVER['SERVER_NAME']) || empty($_SERVER['SERVER_NAME']))
+				if(!isset($_SERVER['SERVER_NAME']) || empty($_SERVER['SERVER_NAME']))
 					$_SERVER['SERVER_NAME'] = $shop->domain;
-				if (!isset($_SERVER['REMOTE_ADDR']) || empty($_SERVER['REMOTE_ADDR']))
-					$_SERVER['REMOTE_ADDR'] = '127.0.0.1';
 			}
 		}
 		else

classes/stock/StockAvailable.php

@@ -305,7 +305,11 @@ class StockAvailableCore extends ObjectModel
 		if (!Validate::isUnsignedId($id_product))
 			return false;
 
-		$existing_id = StockAvailable::getStockAvailableIdByProductId((int)$id_product, (int)$id_product_attribute, $id_shop);
+		if ($id_shop === null)
+			$id_shop = Context::getContext()->shop->id;
+
+		$existing_id = StockAvailable::getStockAvailableIdByProductId((int)$id_product, (int)$id_product_attribute, (int)$id_shop);
+
 		if ($existing_id > 0)
 		{
 			Db::getInstance()->update(

classes/tax/TaxRulesTaxManager.php

@@ -80,7 +80,7 @@ class TaxRulesTaxManagerCore implements TaxManagerInterface
 		if (!empty($this->address->postcode))
 			$postcode = $this->address->postcode;
 
-		if (!isset(self::$cache_tax_calculator[(int)$this->address->id_country.'-'.$postcode.'-'.$this->type]))
+		if (!isset(self::$cache_tax_calculator[$postcode.'-'.$this->type]))
 		{
 			$rows = Db::getInstance()->executeS('
 			SELECT *

classes/webservice/WebserviceRequest.php

@@ -1187,7 +1187,7 @@ class WebserviceRequestCore
 				else
 				{
 					$object = new $this->resourceConfiguration['retrieveData']['className']();
-					if ($object->isMultiShopField($this->resourceConfiguration['fields'][$fieldName]['sqlId']) || $fieldName == 'id')
+					if ($object->isMultiShopField($this->resourceConfiguration['fields'][$fieldName]['sqlId']))
 						$table_alias = 'multi_shop_'.$this->resourceConfiguration['retrieveData']['table'];
 					else
 						$table_alias = '';
@@ -1260,39 +1260,40 @@ class WebserviceRequestCore
 		if (!isset($this->urlFragments['display']))
 			$this->fieldsToDisplay = 'full';
 
+		// Check if Object is accessible for this/those id_shop
+		$assoc = Shop::getAssoTable($this->resourceConfiguration['retrieveData']['table']);
+		if ($assoc !== false)
+		{
+			$check_shop_group = false;
+
+			$sql = 'SELECT 1
+ 						FROM `'.bqSQL(_DB_PREFIX_.$this->resourceConfiguration['retrieveData']['table']);
+			if ($assoc['type'] != 'fk_shop')
+				$sql .= '_'.$assoc['type'];
+			else
+			{
+				$def = ObjectModel::getDefinition($this->resourceConfiguration['retrieveData']['className']);
+				if (isset($def['fields']) && isset($def['fields']['id_shop_group']))
+					$check_shop_group = true;
+			}
+			$sql .= '`';
+
+			foreach (self::$shopIDs as $id_shop)
+				$OR[] = ' (id_shop = '.(int)$id_shop.($check_shop_group ? ' OR (id_shop = 0 AND id_shop_group='.(int)Shop::getGroupFromShop((int)$id_shop).')' : '').') ';
+
+			$check = ' WHERE ('.implode('OR', $OR).') AND `'.bqSQL($this->resourceConfiguration['fields']['id']['sqlId']).'` = '.(int)$this->urlSegment[1];
+			if (!Db::getInstance()->getValue($sql.$check))
+				$this->setError(403, 'Bad id_shop : You are not allowed to access this '.$this->resourceConfiguration['retrieveData']['className'].' ('.(int)$this->urlSegment[1].')', 131);
+		}
+
 		//get entity details
 		$object = new $this->resourceConfiguration['retrieveData']['className']((int)$this->urlSegment[1]);
 		if ($object->id)
 		{
 			$objects[] = $object;
-			// Check if Object is accessible for this/those id_shop
-			$assoc = Shop::getAssoTable($this->resourceConfiguration['retrieveData']['table']);
-			if ($assoc !== false)
-			{
-				$check_shop_group = false;
-
-				$sql = 'SELECT 1
-	 						FROM `'.bqSQL(_DB_PREFIX_.$this->resourceConfiguration['retrieveData']['table']);
-				if ($assoc['type'] != 'fk_shop')
-					$sql .= '_'.$assoc['type'];
-				else
-				{
-					$def = ObjectModel::getDefinition($this->resourceConfiguration['retrieveData']['className']);
-					if (isset($def['fields']) && isset($def['fields']['id_shop_group']))
-						$check_shop_group = true;
-				}
-				$sql .= '`';
-
-				foreach (self::$shopIDs as $id_shop)
-					$OR[] = ' (id_shop = '.(int)$id_shop.($check_shop_group ? ' OR (id_shop = 0 AND id_shop_group='.(int)Shop::getGroupFromShop((int)$id_shop).')' : '').') ';
-
-				$check = ' WHERE ('.implode('OR', $OR).') AND `'.bqSQL($this->resourceConfiguration['fields']['id']['sqlId']).'` = '.(int)$this->urlSegment[1];
-				if (!Db::getInstance()->getValue($sql.$check))
-					$this->setError(404, 'This '.$this->resourceConfiguration['retrieveData']['className'].' ('.(int)$this->urlSegment[1].') does not exists on this shop', 131);
-			}
 			return $objects;
 		}
-		if (!count($this->errors))
+		elseif (!count($this->errors))
 		{
 			$this->objOutput->setStatus(404);
 			$this->_outputEnabled = false;

controllers/admin/AdminAddressesController.php

@@ -77,7 +77,7 @@ class AdminAddressesControllerCore extends AdminController
 		parent::initToolbar();
 		if (!$this->display)
 			$this->toolbar_btn['import'] = array(
-				'href' => $this->context->link->getAdminLink('AdminImport', true).'&import_type=addresses',
+				'href' => $this->context->link->getAdminLink('AdminImport', true).'&import_type='.$this->table,
 				'desc' => $this->l('Import')
 			);
 	}

controllers/admin/AdminAttributesGroupsController.php

@@ -54,7 +54,6 @@ class AdminAttributesGroupsControllerCore extends AdminController
 				'title' => $this->l('Values count'),
 				'width' => 120,
 				'align' => 'center',
-				'orderby' => false,
 				'search' => false
 			),
 			'position' => array(
@@ -264,7 +263,7 @@ class AdminAttributesGroupsControllerCore extends AdminController
 			'input' => array(
 				array(
 					'type' => 'select',
-					'label' => $this->l('Attribute group:'),
+					'label' => $this->l('Attribute type:'),
 					'name' => 'id_attribute_group',
 					'required' => true,
 					'options' => array(
@@ -272,7 +271,7 @@ class AdminAttributesGroupsControllerCore extends AdminController
 						'id' => 'id_attribute_group',
 						'name' => 'name'
 					),
-					'desc' => $this->l('Choose the group of the attribute')
+					'desc' => $this->l('Choose the type of the attribute')
 				),
 				array(
 					'type' => 'text',

controllers/admin/AdminCarrierWizardController.php

@@ -38,9 +38,6 @@ class AdminCarrierWizardControllerCore extends AdminController
 		$this->deleted = true;
 		$this->step_number = 0;
 		
-		$this->multishop_context = Shop::CONTEXT_ALL;
-		$this->context = Context::getContext();
-		
 		$this->fieldImageSettings = array(
 			'name' => 'logo',
 			'dir' => 's'
@@ -71,7 +68,7 @@ class AdminCarrierWizardControllerCore extends AdminController
 					'title' => $this->l('Shipping locations and costs'),
 				),
 				array(
-					'title' => $this->l('Size, weight, and group access'),
+                    'title' => $this->l('Size, weight, and group access'),
 				),
 				array(
 					'title' => $this->l('Summary'),
@@ -128,8 +125,8 @@ class AdminCarrierWizardControllerCore extends AdminController
 			array_splice($this->tpl_view_vars['wizard_contents']['contents'], 1, 0, array(0 => $this->renderStepTwo($carrier)));
 			
 		$this->context->smarty->assign(array(
-				'carrier_logo' => (Validate::isLoadedObject($carrier) && file_exists(_PS_SHIP_IMG_DIR_.$carrier->id.'.jpg') ? _THEME_SHIP_DIR_.$carrier->id.'.jpg' : false)
+			'carrier_logo' => (Validate::isLoadedObject($carrier) && file_exists(_PS_SHIP_IMG_DIR_.$carrier->id.'.jpg') ? _THEME_SHIP_DIR_.$carrier->id.'.jpg' : false)
-			));
+		));
 		$this->content .= $this->createTemplate('logo.tpl')->fetch();
 		$this->addjQueryPlugin(array('ajaxfileupload'));
 
@@ -308,6 +305,10 @@ class AdminCarrierWizardControllerCore extends AdminController
 							)
 						)
 					),
+					array(
+						'type' => 'zone',
+						'name' => 'zones'
+					),
 					array(
 						'type' => 'select',
 						'label' => $this->l('Out-of-range behavior:'),
@@ -328,14 +329,9 @@ class AdminCarrierWizardControllerCore extends AdminController
 						),
 						'desc' => $this->l('Out-of-range behavior occurs when no defined range matches the customer\'s cart (e.g. when the weight of the cart is greater than the highest weight limit defined by the weight ranges)')
 					)
-					,
-					array(
-						'type' => 'zone',
-						'name' => 'zones'
 					),
-				),
 					
-			));
+				));
 		
 		$tpl_vars = array();
 		$tpl_vars['PS_WEIGHT_UNIT'] = Configuration::get('PS_WEIGHT_UNIT');
@@ -360,7 +356,8 @@ class AdminCarrierWizardControllerCore extends AdminController
 						'name' => 'max_height',
 						'required' => false,
 						'size' => 10,
-						'desc' => $this->l('Maximum height managed by this carrier. Set the value to "0", or leave this field blank to ignore.').' '.$this->l('The value must be an integer.')
+						'desc' => $this->l('Maximum height managed by this carrier. Set the value to "0", or leave this field blank to ignore.').' '.$this->l('The value must be an integer
+.')
 					),
 					array(
 						'type' => 'text',
@@ -368,7 +365,8 @@ class AdminCarrierWizardControllerCore extends AdminController
 						'name' => 'max_width',
 						'required' => false,
 						'size' => 10,
-						'desc' => $this->l('Maximum width managed by this carrier. Set the value to "0", or leave this field blank to ignore.').' '.$this->l('The value must be an integer.')
+						'desc' => $this->l('Maximum width managed by this carrier. Set the value to "0", or leave this field blank to ignore.').' '.$this->l('The value must be an integer
+.')
 					),
 					array(
 						'type' => 'text',
@@ -376,7 +374,8 @@ class AdminCarrierWizardControllerCore extends AdminController
 						'name' => 'max_depth',
 						'required' => false,
 						'size' => 10,
-						'desc' => $this->l('Maximum depth managed by this carrier. Set the value to "0", or leave this field blank to ignore.').' '.$this->l('The value must be an integer.')
+						'desc' => $this->l('Maximum depth managed by this carrier. Set the value to "0", or leave this field blank to ignore.').' '.$this->l('The value must be an integer
+.')
 					),
 					array(
 						'type' => 'text',
@@ -405,7 +404,7 @@ class AdminCarrierWizardControllerCore extends AdminController
 			foreach ($carrier_groups as $carrier_group)
 				$carrier_groups_ids[] = $carrier_group['id_group'];
 
-			$groups = Group::getGroups($this->context->language->id);
+		$groups = Group::getGroups($this->context->language->id);
 
 		foreach ($groups as $group)
 			$fields_value['groupBox_'.$group['id_group']] = Tools::getValue('groupBox_'.$group['id_group'], (in_array($group['id_group'], $carrier_groups_ids) || empty($carrier_groups_ids) && !$carrier->id));
@@ -465,7 +464,7 @@ class AdminCarrierWizardControllerCore extends AdminController
 			foreach ($carrier_zones as $carrier_zone)
 				$carrier_zones_ids[] = $carrier_zone['id_zone'];
 
-			$range_table = $carrier->getRangeTable();
+		$range_table = $carrier->getRangeTable();
 		$shipping_method = $carrier->getShippingMethod();
 		
 		$zones = Zone::getZones(false);
@@ -512,10 +511,10 @@ class AdminCarrierWizardControllerCore extends AdminController
 		$helper->id = (int)Tools::getValue('id_carrier');
 		$helper->identifier = $this->identifier;
 		$helper->tpl_vars = array_merge(array(
-				'fields_value' => $fields_value,
+			'fields_value' => $fields_value,
-				'languages' => $this->getLanguages(),
+			'languages' => $this->getLanguages(),
-				'id_language' => $this->context->language->id
+			'id_language' => $this->context->language->id
-			), $tpl_vars);
+		), $tpl_vars);
 		$helper->override_folder = 'carrier_wizard/';
 
 		return $helper->generateForm($fields_form);
@@ -592,7 +591,7 @@ class AdminCarrierWizardControllerCore extends AdminController
 		$template->assign('change_ranges', 1);
 		
 		$template->assign('fields_value', $fields_value);
-		$template->assign('input', array('type' => 'zone', 'name' => 'zones' ));
+		$template->assign('input', array('type' => 'zone',	'name' => 'zones'	));
 		
 		$currency = new Currency(Configuration::get('PS_CURRENCY_DEFAULT'));
 		$template->assign('currency_sign', $currency->sign);
@@ -765,9 +764,9 @@ class AdminCarrierWizardControllerCore extends AdminController
 					$this->changeGroups((int)$new_carrier->id);
 					// Call of hooks
 					Hook::exec('actionCarrierUpdate', array(
-							'id_carrier' => (int)$current_carrier->id,
+						'id_carrier' => (int)$current_carrier->id,
-							'carrier' => $new_carrier
+						'carrier' => $new_carrier
-						));
+					));
 					$this->postImage($new_carrier->id);
 					$this->changeZones($new_carrier->id);
 					$new_carrier->setTaxRulesGroup((int)Tools::getValue('id_tax_rules_group'));
@@ -867,11 +866,11 @@ class AdminCarrierWizardControllerCore extends AdminController
 				if (!isset($_POST['zone_'.$zone['id_zone']]) || !$_POST['zone_'.$zone['id_zone']])
 					$return &= $carrier->deleteZone((int)$zone['id_zone']);
 			}
-		else
+			else
-			if (isset($_POST['zone_'.$zone['id_zone']]) && $_POST['zone_'.$zone['id_zone']])
+				if (isset($_POST['zone_'.$zone['id_zone']]) && $_POST['zone_'.$zone['id_zone']])
-				$return &= $carrier->addZone((int)$zone['id_zone']);
+					$return &= $carrier->addZone((int)$zone['id_zone']);
 
-			return $return;
+		return $return;
 	}
 	
 	public static function getValidationRules()
@@ -905,7 +904,7 @@ class AdminCarrierWizardControllerCore extends AdminController
 						unset($rules[$key_r][$key_f]);
 				} 
 				else if(!in_array($key_f, $step_fields[$step_number]))
-						unset($rules[$key_r][$key_f]);
+					unset($rules[$key_r][$key_f]);
 			}
 		return $rules;
 	}

controllers/admin/AdminCartsController.php

@@ -684,21 +684,18 @@ class AdminCartsControllerCore extends AdminController
 					$free_shipping = true;
 					break;
 				}
-		return array(
+		return array('summary' => $this->getCartSummary(),
-			'summary' => $this->getCartSummary(),
+						'delivery_option_list' => $this->getDeliveryOptionList(),
-			'delivery_option_list' => $this->getDeliveryOptionList(),
+						'cart' => $this->context->cart,
-			'cart' => $this->context->cart,
+						'addresses' => $this->context->customer->getAddresses((int)$this->context->cart->id_lang),
-			'currency' => new Currency($this->context->cart->id_currency),
+						'id_cart' => $id_cart,
-			'addresses' => $this->context->customer->getAddresses((int)$this->context->cart->id_lang),
+						'order_message' => $message_content,
-			'id_cart' => $id_cart,
+						'link_order' => $this->context->link->getPageLink(
-			'order_message' => $message_content,
+							'order', false,
-			'link_order' => $this->context->link->getPageLink(
+							(int)$this->context->cart->id_lang,
-				'order', false,
+							'step=3&recover_cart='.$id_cart.'&token_cart='.md5(_COOKIE_KEY_.'recover_cart_'.$id_cart)),
-				(int)$this->context->cart->id_lang,
+						'free_shipping' => (int)$free_shipping
-				'step=3&recover_cart='.$id_cart.'&token_cart='.md5(_COOKIE_KEY_.'recover_cart_'.$id_cart)
+						);
-			),
-			'free_shipping' => (int)$free_shipping
-		);
 	}
 
 	public function initToolbar()

controllers/admin/AdminCategoriesController.php

@@ -246,7 +246,7 @@ class AdminCategoriesControllerCore extends AdminController
 				'desc' => $this->l('Add New')
 			);
 			$this->toolbar_btn['import'] = array(
-				'href' => $this->context->link->getAdminLink('AdminImport', true).'&import_type=categories',
+				'href' => $this->context->link->getAdminLink('AdminImport', true).'&import_type='.$this->table,
 				'desc' => $this->l('Import')
 			);
 		}

controllers/admin/AdminCmsController.php

@@ -110,10 +110,10 @@ class AdminCmsControllerCore extends AdminController
 					'type' => 'text',
 					'label' => $this->l('Meta title:'),
 					'name' => 'meta_title',
-					'id' => 'name', // for copyMeta2friendlyURL compatibility
+					'id' => 'name', // for copy2friendlyUrl compatibility
 					'lang' => true,
 					'required' => true,
-					'class' => 'copyMeta2friendlyURL',
+					'class' => 'copy2friendlyUrl',
 					'hint' => $this->l('Invalid characters:').' <>;=#{}',
 					'size' => 50
 				),

controllers/admin/AdminCurrenciesController.php

@@ -151,7 +151,7 @@ class AdminCurrenciesControllerCore extends AdminController
 							array('key' => 2, 'name' => '0 000,00X ('.$this->l('as with Euros').')'),
 							array('key' => 3, 'name' => 'X0.000,00'),
 							array('key' => 4, 'name' => '0,000.00X'),
-							array('key' => 5, 'name' => '0\'000.00X') // Added for the switzerland currency
+							array('key' => 5, 'name' => '0 000.00X') // Added for the switzerland currency
 						),
 						'name' => 'name',
 						'id' => 'key'

controllers/admin/AdminCustomerThreadsController.php

@@ -380,7 +380,7 @@ class AdminCustomerThreadsControllerCore extends AdminController
 				$cm->id_employee = (int)$this->context->employee->id;
 				$cm->id_customer_thread = $ct->id;
 				
-				$cm->message = Tools::getValue('reply_message');
+				$cm->message = Tools::htmlentitiesutf8(Tools::getValue('reply_message'));
 				$cm->ip_address = ip2long($_SERVER['REMOTE_ADDR']);
 				if (isset($_FILES) && !empty($_FILES['joinFile']['name']) && $_FILES['joinFile']['error'] != 0)
 					$this->errors[] = Tools::displayError('An error occurred during the file upload process.');
@@ -597,12 +597,11 @@ class AdminCustomerThreadsControllerCore extends AdminController
 		}
 		$message['date_add'] = Tools::displayDate($message['date_add'], null, true);
 		$message['user_agent'] = strip_tags($message['user_agent']);
-
 		$message['message'] = preg_replace(
 			'/(https?:\/\/[a-z0-9#%&_=\(\)\.\? \+\-@\/]{6,1000})([\s\n<])/Uui',
 			'<a href="\1">\1</a>\2',
 			html_entity_decode($message['message'],
-			ENT_QUOTES, 'UTF-8')
+			ENT_NOQUOTES, 'UTF-8')
 		);
 
 		$tpl->assign(array(

controllers/admin/AdminCustomersController.php

@@ -190,7 +190,7 @@ class AdminCustomersControllerCore extends AdminController
 		else if (!$this->display) //display import button only on listing
 		{
 			$this->toolbar_btn['import'] = array(
-				'href' => $this->context->link->getAdminLink('AdminImport', true).'&import_type=customers',
+				'href' => $this->context->link->getAdminLink('AdminImport', true).'&import_type='.$this->table,
 				'desc' => $this->l('Import')
 			);
 		}
@@ -774,8 +774,7 @@ class AdminCustomersControllerCore extends AdminController
 			if ($customer_email != $this->object->email)
 			{
 				$customer = new Customer();
-				if (Validate::isEmail($customer_email))
+				$customer->getByEmail($customer_email);
-					$customer->getByEmail($customer_email);
 				if ($customer->id)
 					$this->errors[] = Tools::displayError('An account already exists for this email address:').' '.$customer_email;
 			}

controllers/admin/AdminEmployeesController.php

@@ -473,14 +473,6 @@ class AdminEmployeesControllerCore extends AdminController
 		return $res;
 	}
 
-	protected function ajaxProcessFormLanguage()
-	{
-		$this->context->cookie->employee_form_lang = (int)Tools::getValue('form_language_id');
-		if (!$this->context->cookie->write())
-			die ('Error while updating cookie.');
-		die ('Form language updated.');
-	}
-	
 	public function ajaxProcessGetTabByIdProfile()
 	{
 		$id_profile = Tools::getValue('id_profile');

controllers/admin/AdminGroupsController.php

@@ -30,7 +30,6 @@ class AdminGroupsControllerCore extends AdminController
 	{
 		$this->table = 'group';
 		$this->className = 'Group';
-		$this->list_id = 'group';
 		$this->lang = true;
 		$this->addRowAction('edit');
 		$this->addRowAction('view');
@@ -154,16 +153,6 @@ class AdminGroupsControllerCore extends AdminController
 		if (Tools::isSubmit('changeShowPricesVal') && $this->id_object)
 			$this->action = 'change_show_prices_val';
 
-		if (Tools::getIsset('viewgroup'))
-		{
-			$this->list_id = 'customer_group';
-
-			if (isset($_POST['submitReset'.$this->list_id]))
-				$this->processResetFilters();
-		}
-		else
-			$this->list_id = 'group';
-
 		parent::initProcess();
 	}
 
@@ -192,29 +181,30 @@ class AdminGroupsControllerCore extends AdminController
 			$genders_icon[$gender->id] = '../genders/'.(int)$gender->id.'.jpg';
 			$genders[$gender->id] = $gender->name;
 		}
-		$this->table = 'customer_group';
+		$customer_fields_display = (array(
-		$this->lang = false;
+				'id_customer' => array('title' => $this->l('ID'), 'width' => 15, 'align' => 'center'),
-		$this->list_id = 'customer_group';
-		$this->actions = array();
-		$this->bulk_actions = false;
-		$this->no_link = true;
-		$this->fields_list = (array(
-				'id_customer' => array('title' => $this->l('ID'), 'width' => 15, 'align' => 'center', 'filter_key' => 'c!id_customer'),
 				'id_gender' => array('title' => $this->l('Titles'), 'align' => 'center', 'width' => 50,'icon' => $genders_icon, 'list' => $genders),
-				'firstname' => array('title' => $this->l('First name'), 'align' => 'center'),
+				'firstname' => array('title' => $this->l('Name'), 'align' => 'center'),
-				'lastname' => array('title' => $this->l('Last name'), 'align' => 'center'),
+				'lastname' => array('title' => $this->l('Name'), 'align' => 'center'),
-				'email' => array('title' => $this->l('Email address'), 'width' => 150, 'align' => 'center', 'filter_key' => 'c!email', 'orderby' => true),
+				'email' => array('title' => $this->l('Email address'), 'width' => 150, 'align' => 'center'),
 				'birthday' => array('title' => $this->l('Birth date'), 'width' => 150, 'align' => 'right', 'type' => 'date'),
 				'date_add' => array('title' => $this->l('Register date'), 'width' => 150, 'align' => 'right', 'type' => 'date'),
+				'orders' => array('title' => $this->l('Orders'), 'align' => 'center'),
 				'active' => array('title' => $this->l('Enabled'),'align' => 'center','width' => 20, 'active' => 'status','type' => 'bool')
 			));
 
-		$this->_select = 'c.*';
+		$customer_list = $group->getCustomers(false, 0, 0, true);
-		$this->_join = 'LEFT JOIN `'._DB_PREFIX_.'customer` c ON (a.`id_customer` = c.`id_customer`)';
+
-		$this->_where = 'AND a.`id_group` = '.(int)$group->id.' AND c.`deleted` != 1';
+		$helper = new HelperList();
-		self::$currentIndex = self::$currentIndex.'&viewgroup';
+		$helper->currentIndex = Context::getContext()->link->getAdminLink('AdminCustomers', false);
-		$this->processFilter();
+		$helper->token = Tools::getAdminTokenLite('AdminCustomers');
-		return parent::renderList();
+		$helper->shopLinkType = '';
+		$helper->table = 'customer';
+		$helper->identifier = 'id_customer';
+		$helper->actions = array('edit', 'view');
+		$helper->show_toolbar = false;
+
+		return $helper->generateList($customer_list, $customer_fields_display);
 	}
 
 	public function renderForm()

controllers/admin/AdminImagesController.php

@@ -52,17 +52,8 @@ class AdminImagesControllerCore extends AdminController
 			'stores' => array('title' => $this->l('Stores'), 'width' => 50, 'align' => 'center', 'type' => 'bool', 'callback' => 'printEntityActiveIcon', 'orderby' => false)
 		);
 		
-		// No need to display the old image system migration tool except if product images are in _PS_PROD_IMG_DIR_
+		// No need to display the old image system if the install has been made later than 2013-03-26
-		$this->display_move = false;
+		$this->display_move = (!Configuration::get('PS_LEGACY_IMAGES') && defined('_PS_CREATION_DATE_') && strtotime(_PS_CREATION_DATE_) > strtotime('2013-03-26')) ? false : true;
-		$dir = _PS_PROD_IMG_DIR_;
-		if (is_dir($dir))
-			if ($dh = opendir($dir))
-			{
-				while (($file = readdir($dh)) !== false && $this->display_move == false)
-						if (!is_dir($dir.DIRECTORY_SEPARATOR.$file) && $file[0] != '.' && is_numeric($file[0]))
-							$this->display_move = true;
-				closedir($dh);
-			}
 
 		$this->fields_options = array(
 			'images' => array(
@@ -543,16 +534,18 @@ class AdminImagesControllerCore extends AdminController
 	protected function _regenerateNoPictureImages($dir, $type, $languages)
 	{
 		$errors = false;
-		foreach ($type as $image_type)
+		foreach ($type as $imageType)
+		{
 			foreach ($languages as $language)
 			{
 				$file = $dir.$language['iso_code'].'.jpg';
 				if (!file_exists($file))
-					$file = _PS_PROD_IMG_DIR_.Language::getIsoById((int)Configuration::get('PS_LANG_DEFAULT')).'.jpg';
+					$file = _PS_PROD_IMG_DIR_.Language::getIsoById((int)(Configuration::get('PS_LANG_DEFAULT'))).'.jpg';
-				if (!file_exists($dir.$language['iso_code'].'-default-'.stripslashes($image_type['name']).'.jpg'))
+				if (!file_exists($dir.$language['iso_code'].'-default-'.stripslashes($imageType['name']).'.jpg'))
-					if (!ImageManager::resize($file, $dir.$language['iso_code'].'-default-'.stripslashes($image_type['name']).'.jpg', (int)$image_type['width'], (int)$image_type['height']))
+					if (!ImageManager::resize($file, $dir.$language['iso_code'].'-default-'.stripslashes($imageType['name']).'.jpg', (int)$imageType['width'], (int)$imageType['height']))
 						$errors = true;
 			}
+		}
 		return $errors;
 	}
 
@@ -650,7 +643,7 @@ class AdminImagesControllerCore extends AdminController
 	public function initMoveImages()
 	{
 		$this->context->smarty->assign(array(
-			'safe_mode' => Tools::getSafeModeStatus(),
+			'safe_mode' => ini_get('safe_mode'),
 			'link_ppreferences' => 'index.php?tab=AdminPPreferences&token='.Tools::getAdminTokenLite('AdminPPreferences').'#PS_LEGACY_IMAGES_on',
 		));
 }

controllers/admin/AdminImportController.php

@@ -293,7 +293,6 @@ class AdminImportControllerCore extends AdminController
 			case $this->entities[$this->l('Addresses')]:
 				//Overwrite required_fields
 				$this->required_fields = array(
-					'alias',
 					'lastname',
 					'firstname',
 					'address1',
@@ -308,7 +307,7 @@ class AdminImportControllerCore extends AdminController
 					'id' => array('label' => $this->l('ID')),
 					'alias' => array('label' => $this->l('Alias *')),
 					'active' => array('label' => $this->l('Active  (0/1)')),
-					'customer_email' => array('label' => $this->l('Customer email *')),
+					'customer_email' => array('label' => $this->l('Customer email')),
 					'id_customer' => array('label' => $this->l('Customer ID:')),
 					'manufacturer' => array('label' => $this->l('Manufacturer')),
 					'supplier' => array('label' => $this->l('Supplier')),
@@ -317,7 +316,7 @@ class AdminImportControllerCore extends AdminController
 					'firstname' => array('label' => $this->l('First Name *')),
 					'address1' => array('label' => $this->l('Address 1 *')),
 					'address2' => array('label' => $this->l('Address 2')),
-					'postcode' => array('label' => $this->l('Postal code / Zipcode *')),
+					'postcode' => array('label' => $this->l('Postal code / Zipcode*')),
 					'city' => array('label' => $this->l('City *')),
 					'country' => array('label' => $this->l('Country *')),
 					'state' => array('label' => $this->l('State')),
@@ -364,13 +363,10 @@ class AdminImportControllerCore extends AdminController
 					'shop' => Shop::getGroupFromShop(Configuration::get('PS_SHOP_DEFAULT')),
 				);
 			break;
-		}
+			// @since 1.5.0
-		
+			case $this->entities[$this->l('Supply Orders')]:
-		// @since 1.5.0
+				if (Configuration::get('PS_ADVANCED_STOCK_MANAGEMENT'))
-		if (Configuration::get('PS_ADVANCED_STOCK_MANAGEMENT'))
+				{
-			switch ((int)Tools::getValue('entity'))
-			{
-				case $this->entities[$this->l('Supply Orders')]:
 					// required fields
 					$this->required_fields = array(
 						'id_supplier',
@@ -398,8 +394,12 @@ class AdminImportControllerCore extends AdminController
 						'discount_rate' => '0',
 						'is_template' => '0',
 					);
-				break;
+				}
-				case $this->entities[$this->l('Supply Order Details')]:
+			break;
+			// @since 1.5.0
+			case $this->entities[$this->l('Supply Order Details')]:
+				if (Configuration::get('PS_ADVANCED_STOCK_MANAGEMENT'))
+				{
 					// required fields
 					$this->required_fields = array(
 						'supply_order_reference',
@@ -423,11 +423,10 @@ class AdminImportControllerCore extends AdminController
 						'discount_rate' => '0',
 						'tax_rate' => '0',
 					);
-				break;
+				}
+		}
 
-			}
+		$this->separator = strval(trim(Tools::getValue('separator', ';')));
-
-		$this->separator = substr(strval(trim(Tools::getValue('separator', ';'))), 0, 1);
 
 		if (is_null(Tools::getValue('multiple_value_separator')) || trim(Tools::getValue('multiple_value_separator')) == '')
 			$this->multiple_value_separator = ',';
@@ -466,42 +465,14 @@ class AdminImportControllerCore extends AdminController
 		$this->addCSS(_PS_CSS_DIR_.'jquery.fancybox-1.3.4.css', 'screen');
 		$this->addJqueryPlugin(array('fancybox'));
 
-		$entity_selected = 0;
-		if (isset($this->entities[$this->l(Tools::ucfirst(Tools::getValue('import_type')))]))
-		{
-			$entity_selected = $this->entities[$this->l(Tools::ucfirst(Tools::getValue('import_type')))];
-			$this->context->cookie->entity_selected = (int)$entity_selected;
-		}
-		elseif (isset($this->context->cookie->entity_selected))
-			$entity_selected = (int)$this->context->cookie->entity_selected;
-
-		$csv_selected = '';
-		if (isset($this->context->cookie->csv_selected))
-			$csv_selected = base64_decode($this->context->cookie->csv_selected);
-
-		$id_lang_selected = '';
-		if (isset($this->context->cookie->iso_lang_selected) && $this->context->cookie->iso_lang_selected)
-			$id_lang_selected = (int)Language::getIdByIso(base64_decode($this->context->cookie->iso_lang_selected));
-
-		$separator_selected = '';
-		if (isset($this->context->cookie->separator_selected) && $this->context->cookie->separator_selected)
-			$separator_selected = base64_decode($this->context->cookie->separator_selected);
-
-		$multiple_value_separator_selected = '';
-		if (isset($this->context->cookie->multiple_value_separator_selected) && $this->context->cookie->multiple_value_separator_selected)
-			$multiple_value_separator_selected = base64_decode($this->context->cookie->multiple_value_separator_selected);
-
 		$this->tpl_form_vars = array(
 			'module_confirmation' => (Tools::getValue('import')) && (isset($this->warnings) && !count($this->warnings)),
 			'path_import' => _PS_ADMIN_DIR_.'/import/',
 			'entities' => $this->entities,
-			'entity_selected' => $entity_selected,
+			'entity' => Tools::getValue('entity'),
-			'csv_selected' => $csv_selected,
-			'separator_selected' => $separator_selected,
-			'multiple_value_separator_selected' => $multiple_value_separator_selected,
 			'files_to_import' => $files_to_import,
 			'languages' => Language::getLanguages(false),
-			'id_language' => ($id_lang_selected) ? $id_lang_selected : $this->context->language->id,
+			'id_language' => $this->context->language->id,
 			'available_fields' => $this->getAvailableFields(),
 			'truncateAuthorized' => (Shop::isFeatureActive() && $this->context->employee->isSuperAdmin()) || !Shop::isFeatureActive(),
 			'PS_ADVANCED_STOCK_MANAGEMENT' => Configuration::get('PS_ADVANCED_STOCK_MANAGEMENT'),
@@ -526,12 +497,6 @@ class AdminImportControllerCore extends AdminController
 		for ($i = 0; $i < $nb_table; $i++)
 			$data[$i] = $this->generateContentTable($i, $nb_column, $handle, $this->separator);
 
-		$this->context->cookie->entity_selected = (int)Tools::getValue('entity');
-		$this->context->cookie->iso_lang_selected = base64_encode(Tools::getValue('iso_lang'));
-		$this->context->cookie->separator_selected = base64_encode(Tools::getValue('separator'));
-		$this->context->cookie->multiple_value_separator_selected = base64_encode(Tools::getValue('multiple_value_separator'));
-		$this->context->cookie->csv_selected = base64_encode(Tools::getValue('csv'));
-
 		$this->tpl_view_vars = array(
 			'import_matchs' => Db::getInstance()->executeS('SELECT * FROM '._DB_PREFIX_.'import_match'),
 			'fields_value' => array(
@@ -541,7 +506,6 @@ class AdminImportControllerCore extends AdminController
 				'iso_lang' => Tools::getValue('iso_lang'),
 				'truncate' => Tools::getValue('truncate'),
 				'forceIDs' => Tools::getValue('forceIDs'),
-				'regenerate' => Tools::getValue('regenerate'),
 				'match_ref' => Tools::getValue('match_ref'),
 				'separator' => $this->separator,
 				'multiple_value_separator' => $this->multiple_value_separator
@@ -590,12 +554,17 @@ class AdminImportControllerCore extends AdminController
 		for ($i = 0; $i < $nb_column; $i++)
 			if (MAX_COLUMNS * (int)$current_table <= $i && (int)$i < MAX_COLUMNS * ((int)$current_table + 1))
 				$html .= '<th style="width: '.(900 / MAX_COLUMNS).'px; vertical-align: top; padding: 4px">
-							<select style="width: '.(900 / MAX_COLUMNS).'px;"
+							<select onchange="askFeatureName(this, '.$i.');"
+								style="width: '.(900 / MAX_COLUMNS).'px;"
 								id="type_value['.$i.']"
 								name="type_value['.$i.']"
 								class="type_value">
 								'.$this->getTypeValuesOptions($i).'
 							</select>
+							<div id="features_'.$i.'" style="display: none;">
+								<input style="width: 90px" type="text" name="" id="feature_name_'.$i.'">
+								<input type="button" value="ok" onclick="replaceFeature($(\'#feature_name_'.$i.'\').attr(\'name\'), '.$i.');">
+							</div>
 						</th>';
 		$html .= '</tr>';
 
@@ -681,8 +650,7 @@ class AdminImportControllerCore extends AdminController
 			$fd = fopen($uniqid_path, 'r');
 			$tab = fgetcsv($fd, MAX_LINE_SIZE, $separator);
 			fclose($fd);
-			if (file_exists($uniqid_path))
+			unlink($uniqid_path);
-				@unlink($uniqid_path);
 		}
 
 		if (empty($tab) || (!is_array($tab)))
@@ -827,7 +795,7 @@ class AdminImportControllerCore extends AdminController
 	 * @param string entity 'products' or 'categories'
 	 * @return void
 	 */
-	protected static function copyImg($id_entity, $id_image = null, $url, $entity = 'products', $regenerate = true)
+	protected static function copyImg($id_entity, $id_image = null, $url, $entity = 'products')
 	{
 		$tmpfile = tempnam(_PS_TMP_IMG_DIR_, 'ps_import');
 		$watermark_types = explode(',', Configuration::get('WATERMARK_TYPES'));
@@ -855,14 +823,11 @@ class AdminImportControllerCore extends AdminController
 		{
 			ImageManager::resize($tmpfile, $path.'.jpg');
 			$images_types = ImageType::getImagesTypes($entity);
+			foreach ($images_types as $image_type)
+				ImageManager::resize($tmpfile, $path.'-'.stripslashes($image_type['name']).'.jpg', $image_type['width'], $image_type['height']);
 
-			if ($regenerate)
+			if (in_array($image_type['id_image_type'], $watermark_types))
-				foreach ($images_types as $image_type)
+				Hook::exec('actionWatermark', array('id_image' => $id_image, 'id_product' => $id_entity));
-				{
-					ImageManager::resize($tmpfile, $path.'-'.stripslashes($image_type['name']).'.jpg', $image_type['width'], $image_type['height']);
-					if (in_array($image_type['id_image_type'], $watermark_types))
-						Hook::exec('actionWatermark', array('id_image' => $id_image, 'id_product' => $id_entity));
-				}
 		}
 		else
 		{
@@ -880,9 +845,6 @@ class AdminImportControllerCore extends AdminController
 		$this->receiveTab();
 		$handle = $this->openCsvFile();
 		$default_language_id = (int)Configuration::get('PS_LANG_DEFAULT');
-		$id_lang = Language::getIdByIso(Tools::getValue('iso_lang'));
-		if (!Validate::isUnsignedId($id_lang))
-			$id_lang = $default_language_id;
 		AdminImportController::setLocale();
 		for ($current_line = 0; $line = fgetcsv($handle, MAX_LINE_SIZE, $this->separator); $current_line++)
 		{
@@ -929,8 +891,8 @@ class AdminImportControllerCore extends AdminController
 					$category_to_create = new Category();
 					$category_to_create->name = AdminImportController::createMultiLangField($category->parent);
 					$category_to_create->active = 1;
-					$category_link_rewrite = Tools::link_rewrite($category_to_create->name[$id_lang]);
+					$category_link_rewrite = Tools::link_rewrite($category_to_create->name[$default_language_id]);
-					$category_to_create->link_rewrite = AdminImportController::createMultiLangField($category_link_rewrite);
+					$category_to_create->link_rewrite = $category_link_rewrite;
 					$category_to_create->id_parent = Configuration::get('PS_HOME_CATEGORY'); // Default parent is home for unknown category to create
 					if (($field_error = $category_to_create->validateFields(UNFRIENDLY_ERROR, true)) === true &&
 						($lang_field_error = $category_to_create->validateFieldsLang(UNFRIENDLY_ERROR, true)) === true && $category_to_create->add())
@@ -940,7 +902,7 @@ class AdminImportControllerCore extends AdminController
 						$this->errors[] = sprintf(
 							Tools::displayError('%1$s (ID: %2$s) cannot be saved'),
 							$category_to_create->name[$default_language_id],
-							(isset($category_to_create->id) && !empty($category_to_create->id))? $category_to_create->id : 'null'
+							(isset($category_to_create->id) ? $category_to_create->id : 'null')
 						);
 						$this->errors[] = ($field_error !== true ? $field_error : '').(isset($lang_field_error) && $lang_field_error !== true ? $lang_field_error : '').
 							Db::getInstance()->getMsgError();
@@ -973,7 +935,7 @@ class AdminImportControllerCore extends AdminController
 				$this->warnings[] = sprintf(
 					Tools::displayError('Rewrite link for %1$s (ID: %2$s) was re-written as %3$s.'),
 					$bak,
-					(isset($info['id']) && !empty($info['id']))? $info['id'] : 'null',
+					(isset($info['id']) ? $info['id'] : 'null'),
 					$category->link_rewrite[$default_language_id]
 				);
 			$res = false;
@@ -1014,15 +976,15 @@ class AdminImportControllerCore extends AdminController
 			}
 			//copying images of categories
 			if (isset($category->image) && !empty($category->image))
-				if (!(AdminImportController::copyImg($category->id, null, $category->image, 'categories', !Tools::getValue('regenerate'))))
+				if (!(AdminImportController::copyImg($category->id, null, $category->image, 'categories')))
 					$this->warnings[] = $category->image.' '.Tools::displayError('cannot be copied.');
 			// If both failed, mysql error
 			if (!$res)
 			{
 				$this->errors[] = sprintf(
 					Tools::displayError('%1$s (ID: %2$s) cannot be saved'),
-					(isset($info['name']) && !empty($info['name']))? Tools::safeOutput($info['name']) : 'No Name',
+					(isset($info['name']) ? Tools::safeOutput($info['name']) : 'No Name'),
-					(isset($info['id']) && !empty($info['id']))? Tools::safeOutput($info['id']) : 'No ID'
+					(isset($info['id']) ? Tools::safeOutput($info['id']) : 'No ID')
 				);
 				$error_tmp = ($field_error !== true ? $field_error : '').(isset($lang_field_error) && $lang_field_error !== true ? $lang_field_error : '').Db::getInstance()->getMsgError();
 				if ($error_tmp != '')
@@ -1066,9 +1028,6 @@ class AdminImportControllerCore extends AdminController
 		$this->receiveTab();
 		$handle = $this->openCsvFile();
 		$default_language_id = (int)Configuration::get('PS_LANG_DEFAULT');
-		$id_lang = Language::getIdByIso(Tools::getValue('iso_lang'));
-		if (!Validate::isUnsignedId($id_lang))
-			$id_lang = $default_language_id;
 		AdminImportController::setLocale();
 		$shop_ids = Shop::getCompleteListOfShopsID();
 		for ($current_line = 0; $line = fgetcsv($handle, MAX_LINE_SIZE, $this->separator); $current_line++)
@@ -1079,23 +1038,13 @@ class AdminImportControllerCore extends AdminController
 
 			if (Tools::getValue('forceIDs') && isset($info['id']) && (int)$info['id'])
 				$product = new Product((int)$info['id']);
-			elseif (Tools::getValue('match_ref') && array_key_exists('reference', $info))
-			{
-					$datas = Db::getInstance()->getRow('
-						SELECT p.`id_product`
-						FROM `'._DB_PREFIX_.'product` p
-						'.Shop::addSqlAssociation('product', 'p').'
-						WHERE p.`reference` = "'.pSQL($info['reference']).'"
-					');
-					if (isset($datas['id_product']) && $datas['id_product'])
-						$product = new Product((int)$datas['id_product']);
-					else
-						$product = new Product();
-			}
-			elseif (array_key_exists('id', $info) && (int)$info['id'] && Product::existsInDatabase((int)$info['id'], 'product'))
-					$product = new Product((int)$info['id']);
 			else
-				$product = new Product();
+			{
+				if (array_key_exists('id', $info) && (int)$info['id'] && Product::existsInDatabase((int)$info['id'], 'product'))
+					$product = new Product((int)$info['id']);
+				else
+					$product = new Product();
+			}
 
 			if (array_key_exists('id', $info) && (int)$info['id'] && Product::existsInDatabase((int)$info['id'], 'product'))
 			{
@@ -1160,7 +1109,7 @@ class AdminImportControllerCore extends AdminController
 						$this->errors[] = sprintf(
 							Tools::displayError('%1$s (ID: %2$s) cannot be saved'),
 							$manufacturer->name,
-							(isset($manufacturer->id) && !empty($manufacturer->id))? $manufacturer->id : 'null'
+							(isset($manufacturer->id) ? $manufacturer->id : 'null')
 						);
 						$this->errors[] = ($field_error !== true ? $field_error : '').(isset($lang_field_error) && $lang_field_error !== true ? $lang_field_error : '').
 							Db::getInstance()->getMsgError();
@@ -1191,7 +1140,7 @@ class AdminImportControllerCore extends AdminController
 						$this->errors[] = sprintf(
 							Tools::displayError('%1$s (ID: %2$s) cannot be saved'),
 							$supplier->name,
-							(isset($supplier->id) && !empty($supplier->id))? $supplier->id : 'null'
+							(isset($supplier->id) ? $supplier->id : 'null')
 						);
 						$this->errors[] = ($field_error !== true ? $field_error : '').(isset($lang_field_error) && $lang_field_error !== true ? $lang_field_error : '').
 							Db::getInstance()->getMsgError();
@@ -1237,7 +1186,7 @@ class AdminImportControllerCore extends AdminController
 								$this->errors[] = sprintf(
 									Tools::displayError('%1$s (ID: %2$s) cannot be saved'),
 									$category_to_create->name[$default_language_id],
-									(isset($category_to_create->id) && !empty($category_to_create->id))? $category_to_create->id : 'null'
+									(isset($category_to_create->id) ? $category_to_create->id : 'null')
 								);
 								$this->errors[] = ($field_error !== true ? $field_error : '').(isset($lang_field_error) && $lang_field_error !== true ? $lang_field_error : '').
 									Db::getInstance()->getMsgError();
@@ -1269,7 +1218,7 @@ class AdminImportControllerCore extends AdminController
 								$this->errors[] = sprintf(
 									Tools::displayError('%1$s (ID: %2$s) cannot be saved'),
 									$category_to_create->name[$default_language_id],
-									(isset($category_to_create->id) && !empty($category_to_create->id))? $category_to_create->id : 'null'
+									(isset($category_to_create->id) ? $category_to_create->id : 'null')
 								);
 								$this->errors[] = ($field_error !== true ? $field_error : '').(isset($lang_field_error) && $lang_field_error !== true ? $lang_field_error : '').
 									Db::getInstance()->getMsgError();
@@ -1281,13 +1230,13 @@ class AdminImportControllerCore extends AdminController
 
 			$product->id_category_default = isset($product->id_category[0]) ? (int)$product->id_category[0] : '';
 
-			$link_rewrite = (is_array($product->link_rewrite) && isset($product->link_rewrite[$id_lang])) ? trim($product->link_rewrite[$id_lang]) : '';
+			$link_rewrite = (is_array($product->link_rewrite) && count($product->link_rewrite)) ? trim($product->link_rewrite[$default_language_id]) : '';
 
 			$valid_link = Validate::isLinkRewrite($link_rewrite);
 
-			if ((isset($product->link_rewrite[$id_lang]) && empty($product->link_rewrite[$id_lang])) || !$valid_link)
+			if ((isset($product->link_rewrite[$default_language_id]) && empty($product->link_rewrite[$default_language_id])) || !$valid_link)
 			{
-				$link_rewrite = Tools::link_rewrite($product->name[$id_lang]);
+				$link_rewrite = Tools::link_rewrite($product->name[$default_language_id]);
 				if ($link_rewrite == '')
 					$link_rewrite = 'friendly-url-autogeneration-failed';
 			}
@@ -1295,20 +1244,18 @@ class AdminImportControllerCore extends AdminController
 			if (!$valid_link)
 				$this->warnings[] = sprintf(
 					Tools::displayError('Rewrite link for %1$s (ID: %2$s) was re-written as %3$s.'),
-					$product->name[$id_lang],
+					$product->name[$default_language_id],
-					(isset($info['id']) && !empty($info['id']))? $info['id'] : 'null',
+					(isset($info['id']) ? $info['id'] : 'null'),
 					$link_rewrite
 				);
 
-			if (!Tools::getValue('match_ref') || !(is_array($product->link_rewrite) && count($product->link_rewrite) && !empty($product->link_rewrite[$id_lang])))
+			$product->link_rewrite = AdminImportController::createMultiLangField($link_rewrite);
-				$product->link_rewrite = AdminImportController::createMultiLangField($link_rewrite);
 
 			// replace the value of separator by coma
 			if ($this->multiple_value_separator != ',')
-				if (is_array($product->meta_keywords))
+				foreach ($product->meta_keywords as &$meta_keyword)
-					foreach ($product->meta_keywords as &$meta_keyword)
+					if (!empty($meta_keyword))
-						if (!empty($meta_keyword))
+						$meta_keyword = str_replace($this->multiple_value_separator, ',', $meta_keyword);
-							$meta_keyword = str_replace($this->multiple_value_separator, ',', $meta_keyword);
 
 			// Convert comma into dot for all floating values
 			foreach (Product::$definition['fields'] as $key => $array)
@@ -1334,7 +1281,7 @@ class AdminImportControllerCore extends AdminController
 						SELECT product_shop.`date_add`, p.`id_product`
 						FROM `'._DB_PREFIX_.'product` p
 						'.Shop::addSqlAssociation('product', 'p').'
-						WHERE p.`reference` = "'.pSQL($product->reference).'"
+						WHERE p.`reference` = "'.$product->reference.'"
 					');
 					$product->id = (int)$datas['id_product'];
 					$product->date_add = pSQL($datas['date_add']);
@@ -1380,8 +1327,8 @@ class AdminImportControllerCore extends AdminController
 			{
 				$this->errors[] = sprintf(
 					Tools::displayError('%1$s (ID: %2$s) cannot be saved'),
-					(isset($info['name']) && !empty($info['name']))? Tools::safeOutput($info['name']) : 'No Name',
+					(isset($info['name']) ? Tools::safeOutput($info['name']) : 'No Name'),
-					(isset($info['id']) && !empty($info['id']))? Tools::safeOutput($info['id']) : 'No ID'
+					(isset($info['id']) ? Tools::safeOutput($info['id']) : 'No ID')
 				);
 				$this->errors[] = ($field_error !== true ? $field_error : '').(isset($lang_field_error) && $lang_field_error !== true ? $lang_field_error : '').
 					Db::getInstance()->getMsgError();
@@ -1390,7 +1337,7 @@ class AdminImportControllerCore extends AdminController
 			else
 			{
 				// Product supplier
-				if (isset($product->id_supplier) && property_exists($product, 'supplier_reference'))
+				if (isset($product->id_supplier) && isset($product->supplier_reference))
 				{
 					$id_product_supplier = ProductSupplier::getIdByProductAndSupplier((int)$product->id, 0, (int)$product->id_supplier);
 					if ($id_product_supplier)
@@ -1407,67 +1354,31 @@ class AdminImportControllerCore extends AdminController
 				}
 
 				// SpecificPrice (only the basic reduction feature is supported by the import)
-				if (!Shop::isFeatureActive())
+				if ((isset($info['reduction_price']) && $info['reduction_price'] > 0) || (isset($info['reduction_percent']) && $info['reduction_percent'] > 0))
-					$info['shop'] = 1;
+				{
-				elseif (!isset($info['shop']) || empty($info['shop']))
+					$specific_price = new SpecificPrice();
-					$info['shop'] = implode($this->multiple_value_separator, Shop::getContextListShopID());
+					$specific_price->id_product = (int)$product->id;
-	
+					// @todo multishop specific price import
-				// Get shops for each attributes
+					$specific_price->id_shop = $this->context->shop->id;
-				$info['shop'] = explode($this->multiple_value_separator, $info['shop']);
+					$specific_price->id_currency = 0;
-					
+					$specific_price->id_country = 0;
-				$id_shop_list = array();
+					$specific_price->id_group = 0;
-				foreach ($info['shop'] as $shop)
+					$specific_price->price = -1;
-					if (!is_numeric($shop))
+					$specific_price->id_customer = 0;
-						$id_shop_list[] = (int)Shop::getIdByName($shop);
+					$specific_price->from_quantity = 1;
-					else
+					$specific_price->reduction = (isset($info['reduction_price']) && $info['reduction_price']) ? $info['reduction_price'] : $info['reduction_percent'] / 100;
-						$id_shop_list[] = $shop;
+					$specific_price->reduction_type = (isset($info['reduction_price']) && $info['reduction_price']) ? 'amount' : 'percentage';
-
+					$specific_price->from = (isset($info['reduction_from']) && Validate::isDate($info['reduction_from'])) ? $info['reduction_from'] : '0000-00-00 00:00:00';
-					if ((isset($info['reduction_price']) && $info['reduction_price'] > 0) || (isset($info['reduction_percent']) && $info['reduction_percent'] > 0))
+					$specific_price->to = (isset($info['reduction_to']) && Validate::isDate($info['reduction_to']))  ? $info['reduction_to'] : '0000-00-00 00:00:00';
-						foreach($id_shop_list as $id_shop)
+					if (!$specific_price->add())
-						{
+						$this->addProductWarning(Tools::safeOutput($info['name']), $product->id, $this->l('Discount is invalid'));
-							$specific_price = SpecificPrice::getSpecificPrice($product->id, $id_shop, 0, 0, 0, 1, 0, 0, 0, 0);
+				}
-
-							if (is_array($specific_price))
-								$specific_price = new SpecificPrice((int)$specific_price['id_specific_price']);
-							else
-								$specific_price = new SpecificPrice();
-							$specific_price->id_product = (int)$product->id;
-							$specific_price->id_specific_price_rule = 0;
-							$specific_price->id_shop = $id_shop;
-							$specific_price->id_currency = 0;
-							$specific_price->id_country = 0;
-							$specific_price->id_group = 0;
-							$specific_price->price = -1;
-							$specific_price->id_customer = 0;
-							$specific_price->from_quantity = 1;
-							$specific_price->reduction = (isset($info['reduction_price']) && $info['reduction_price']) ? $info['reduction_price'] : $info['reduction_percent'] / 100;
-							$specific_price->reduction_type = (isset($info['reduction_price']) && $info['reduction_price']) ? 'amount' : 'percentage';
-							$specific_price->from = (isset($info['reduction_from']) && Validate::isDate($info['reduction_from'])) ? $info['reduction_from'] : '0000-00-00 00:00:00';
-							$specific_price->to = (isset($info['reduction_to']) && Validate::isDate($info['reduction_to']))  ? $info['reduction_to'] : '0000-00-00 00:00:00';
-							if (!$specific_price->save())
-								$this->addProductWarning(Tools::safeOutput($info['name']), $product->id, $this->l('Discount is invalid'));
-						}
 
 				if (isset($product->tags) && !empty($product->tags))
 				{
-					if (isset($product->id) && $product->id)
-					{
-						$tags = Tag::getProductTags($product->id);
-						if (is_array($tags) && count($tags))
-						{
-							if (!empty($product->tags))
-								$product->tags = explode($this->multiple_value_separator, $product->tags);
-							if (is_array($product->tags) && count($product->tags))
-							{
-								foreach ($product->tags as $key => $tag)
-									$product->tags[$key] = trim($tag);
-								$tags[$id_lang] = $product->tags;
-								$product->tags = $tags;
-							}
-						}
-					}
 					// Delete tags for this id product, for no duplicating error
 					Tag::deleteTagsForProduct($product->id);
+
 					if (!is_array($product->tags))
 					{
 						$product->tags = AdminImportController::createMultiLangField($product->tags);
@@ -1527,7 +1438,7 @@ class AdminImportControllerCore extends AdminController
 							{
 								// associate image to selected shops
 								$image->associateTo($shops);
-								if (!AdminImportController::copyImg($product->id, $image->id, $url, 'products', !Tools::getValue('regenerate')))
+								if (!AdminImportController::copyImg($product->id, $image->id, $url))
 								{
 									$image->delete();
 									$this->warnings[] = sprintf(Tools::displayError('Error copying image: %s'), $url);
@@ -1559,7 +1470,7 @@ class AdminImportControllerCore extends AdminController
 						if(!empty($feature_name) && !empty($feature_value))
 						{
 							$id_feature = Feature::addFeatureImport($feature_name, $position);
-							$id_feature_value = FeatureValue::addFeatureValueImport($id_feature, $feature_value, $product->id, $id_lang);
+							$id_feature_value = FeatureValue::addFeatureValueImport($id_feature, $feature_value);
 							Product::addFeatureProductImport($product->id, $id_feature, $id_feature_value);
 						}
 					}
@@ -1653,7 +1564,7 @@ class AdminImportControllerCore extends AdminController
 				if ($field_error === true && $lang_field_error === true && $image->add())
 				{
 					$image->associateTo($id_shop_list);
-					if (!AdminImportController::copyImg($product->id, $image->id, $url, 'products', !Tools::getValue('regenerate')))
+					if (!AdminImportController::copyImg($product->id, $image->id, $url))
 					{
 						$this->warnings[] = sprintf(Tools::displayError('Error copying image: %s'), $url);
 						$image->delete();
@@ -1820,9 +1731,8 @@ class AdminImportControllerCore extends AdminController
 											null,
 											$id_shop_list
 										);
+	
 										$id_product_attribute_update = true;
-										if (isset($info['supplier_reference']) && !empty($info['supplier_reference']))
-											$product->addSupplierReference($product->id_supplier, $id_product_attribute, $info['supplier_reference']);
 									}
 								}
 							}
@@ -1848,8 +1758,6 @@ class AdminImportControllerCore extends AdminController
 								(int)$info['minimal_quantity'],
 								$id_shop_list
 							);
-							if (isset($info['supplier_reference']) && !empty($info['supplier_reference']))
-								$product->addSupplierReference($product->id_supplier, $id_product_attribute, $info['supplier_reference']);
 						}
 	
 						// fills our attributes array, in order to add the attributes to the product_attribute afterwards
@@ -2026,7 +1934,7 @@ class AdminImportControllerCore extends AdminController
 				$this->errors[] = sprintf(
 					Tools::displayError('%1$s (ID: %2$s) cannot be saved'),
 					$info['email'],
-					(isset($info['id']) && !empty($info['id']))? $info['id'] : 'null'
+					(isset($info['id']) ? $info['id'] : 'null')
 				);
 				$this->errors[] = ($field_error !== true ? $field_error : '').(isset($lang_field_error) && $lang_field_error !== true ? $lang_field_error : '').
 					Db::getInstance()->getMsgError();
@@ -2123,7 +2031,7 @@ class AdminImportControllerCore extends AdminController
 							Tools::displayError('%1$s does not exist in database %2$s (ID: %3$s) cannot be saved'),
 							Db::getInstance()->getMsgError(),
 							$address->customer_email,
-							(isset($info['id']) && !empty($info['id']))? $info['id'] : 'null'
+							(isset($info['id']) ? $info['id'] : 'null')
 						);
 				}
 				else
@@ -2172,7 +2080,7 @@ class AdminImportControllerCore extends AdminController
 					$this->errors[] = Db::getInstance()->getMsgError().' '.sprintf(
 						Tools::displayError('%1$s (ID: %2$s) cannot be saved'),
 						$manufacturer->name,
-						(isset($manufacturer->id) && !empty($manufacturer->id))? $manufacturer->id : 'null'
+						(isset($manufacturer->id) ? $manufacturer->id : 'null')
 					);
 					$this->errors[] = ($field_error !== true ? $field_error : '').(isset($lang_field_error) && $lang_field_error !== true ? $lang_field_error : '').
 						Db::getInstance()->getMsgError();
@@ -2193,7 +2101,7 @@ class AdminImportControllerCore extends AdminController
 					$this->errors[] = Db::getInstance()->getMsgError().' '.sprintf(
 						Tools::displayError('%1$s (ID: %2$s) cannot be saved'),
 						$supplier->name,
-						(isset($supplier->id) && !empty($supplier->id))? $supplier->id : 'null'
+						(isset($supplier->id) ? $supplier->id : 'null')
 					);
 					$this->errors[] = ($field_error !== true ? $field_error : '').(isset($lang_field_error) && $lang_field_error !== true ? $lang_field_error : '').
 						Db::getInstance()->getMsgError();
@@ -2222,7 +2130,7 @@ class AdminImportControllerCore extends AdminController
 							$this->errors[] = sprintf(
 								Tools::displayError('%1$s (ID: %2$s) cannot be saved'),
 								$info['alias'],
-								(isset($info['id']) && !empty($info['id']))? $info['id'] : 'null'
+								(isset($info['id']) ? $info['id'] : 'null')
 							);
 					}
 				}
@@ -2239,7 +2147,7 @@ class AdminImportControllerCore extends AdminController
 				$this->errors[] = sprintf(
 					Tools::displayError('%1$s (ID: %2$s) cannot be saved'),
 					$info['alias'],
-					(isset($info['id']) && !empty($info['id']))? $info['id'] : 'null'
+					(isset($info['id']) ? $info['id'] : 'null')
 				);
 				$this->errors[] = ($field_error !== true ? $field_error : '').(isset($lang_field_error) && $lang_field_error !== true ? $lang_field_error : '').
 					Db::getInstance()->getMsgError();
@@ -2309,8 +2217,8 @@ class AdminImportControllerCore extends AdminController
 			{
 				$this->errors[] = Db::getInstance()->getMsgError().' '.sprintf(
 					Tools::displayError('%1$s (ID: %2$s) cannot be saved'),
-					(isset($info['name']) && !empty($info['name']))? Tools::safeOutput($info['name']) : 'No Name',
+					(isset($info['name']) ? Tools::safeOutput($info['name']) : 'No Name'),
-					(isset($info['id']) && !empty($info['id']))? Tools::safeOutput($info['id']) : 'No ID'
+					(isset($info['id']) ? Tools::safeOutput($info['id']) : 'No ID')
 				);
 				$this->errors[] = ($field_error !== true ? $field_error : '').(isset($lang_field_error) && $lang_field_error !== true ? $lang_field_error : '').
 					Db::getInstance()->getMsgError();
@@ -2356,8 +2264,8 @@ class AdminImportControllerCore extends AdminController
 				if (!$res)
 					$this->errors[] = Db::getInstance()->getMsgError().' '.sprintf(
 						Tools::displayError('%1$s (ID: %2$s) cannot be saved'),
-						(isset($info['name']) && !empty($info['name']))? Tools::safeOutput($info['name']) : 'No Name',
+						(isset($info['name']) ? Tools::safeOutput($info['name']) : 'No Name'),
-						(isset($info['id']) && !empty($info['id']))? Tools::safeOutput($info['id']) : 'No ID'
+						(isset($info['id']) ? Tools::safeOutput($info['id']) : 'No ID')
 					);
 				else
 				{
@@ -2527,12 +2435,17 @@ class AdminImportControllerCore extends AdminController
 				$discount_rate = (float)$info['discount_rate'];
 				$tax_rate = (float)$info['tax_rate'];
 
-				// checks if one product/attribute is there only once
+				// checks if one product is there only once
-				if (isset($products[$id_product][$id_product_attribute]))
+				if (isset($product['id_product']))
-					$this->errors[] = sprintf($this->l('Product/Attribute (%d/%d) cannot be added twice (at line %d).'), $id_product,
+				{
-						$id_product_attribute, $current_line + 1);					
+					if ($product['id_product'] == $id_product_attribute)
+						$this->errors[] = sprintf($this->l('Product (%d/%D) cannot be added twice (at line %d).'), $id_product,
+							$id_product_attribute, $current_line + 1);
+					else
+						$product['id_product'] = $id_product_attribute;
+				}
 				else
-					$products[$id_product][$id_product_attribute] = $quantity_expected;	
+					$product['id_product'] = 0;
 
 				// checks parameters
 				if (false === ($supplier_reference = ProductSupplier::getProductSupplierReference($id_product, $id_product_attribute, $supply_order->id_supplier)))
@@ -2615,9 +2528,13 @@ class AdminImportControllerCore extends AdminController
 
 	protected static function usortFiles($a, $b)
 	{
+		$a = strrev(substr(strrev($a), 0, 14));
+		$b = strrev(substr(strrev($b), 0, 14));
+
 		if ($a == $b)
 			return 0;
-		return ($b < $a) ? 1 : -1;
+
+		return ($a < $b) ? 1 : -1;
 	}
 
 	protected function openCsvFile()
@@ -2662,37 +2579,37 @@ class AdminImportControllerCore extends AdminController
 						unlink(_PS_CAT_IMG_DIR_.$d);
 				break;
 			case $this->entities[$this->l('Products')]:
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_shop`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_shop');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'feature_product`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'feature_product');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_lang`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_lang');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'category_product`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'category_product');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_tag`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_tag');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'image`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'image');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'image_lang`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'image_lang');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'image_shop`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'image_shop');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'specific_price`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'specific_price');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'specific_price_priority`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'specific_price_priority');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_carrier`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_carrier');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'cart_product`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'cart_product');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'compare_product`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'compare_product');
 				if (count(Db::getInstance()->executeS('SHOW TABLES LIKE \''._DB_PREFIX_.'favorite_product\' '))) //check if table exist
-					Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'favorite_product`');
+					Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'favorite_product');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_attachment`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_attachment');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_country_tax`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_country_tax');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_download`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_download');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_group_reduction_cache`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_group_reduction_cache');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_sale`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_sale');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_supplier`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_supplier');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'scene_products`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'scene_products');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'warehouse_product_location`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'warehouse_product_location');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'stock`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'stock');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'stock_available`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'stock_available');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'stock_mvt`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'stock_mvt');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'customization`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'customization');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'customization_field`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'customization_field');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'supply_order_detail`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'supply_order_detail');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'attribute_impact`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'attribute_impact');
 				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_attribute`');
 				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_attribute_shop`');
 				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_attribute_combination`');
@@ -2703,7 +2620,7 @@ class AdminImportControllerCore extends AdminController
 				break;
 			case $this->entities[$this->l('Combinations')]:
 				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'attribute`');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'attribute_impact`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'attribute_impact');
 				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'attribute_lang`');
 				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'attribute_group`');
 				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'attribute_group_lang`');
@@ -2713,26 +2630,26 @@ class AdminImportControllerCore extends AdminController
 				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_attribute_shop`');
 				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_attribute_combination`');
 				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'product_attribute_image`');
-				Db::getInstance()->execute('DELETE FROM `'._DB_PREFIX_.'stock_available` WHERE id_product_attribute != 0');
+				Db::getInstance()->execute('DELETE FROM `'._DB_PREFIX_.'stock_available` WHERE id_product_attribute !=0');
 				break;
 			case $this->entities[$this->l('Customers')]:
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'customer`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'customer');
 				break;
 			case $this->entities[$this->l('Addresses')]:
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'address`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'address');
 				break;
 			case $this->entities[$this->l('Manufacturers')]:
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'manufacturer`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'manufacturer');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'manufacturer_lang`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'manufacturer_lang');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'manufacturer_shop`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'manufacturer_shop');
 				foreach (scandir(_PS_MANU_IMG_DIR_) as $d)
 					if (preg_match('/^[0-9]+(\-(.*))?\.jpg$/', $d))
 						unlink(_PS_MANU_IMG_DIR_.$d);
 				break;
 			case $this->entities[$this->l('Suppliers')]:
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'supplier`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'supplier');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'supplier_lang`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'supplier_lang');
-				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'supplier_shop`');
+				Db::getInstance()->execute('TRUNCATE TABLE `'._DB_PREFIX_.'supplier_shop');
 				foreach (scandir(_PS_SUPP_IMG_DIR_) as $d)
 					if (preg_match('/^[0-9]+(\-(.*))?\.jpg$/', $d))
 						unlink(_PS_SUPP_IMG_DIR_.$d);
@@ -2761,7 +2678,6 @@ class AdminImportControllerCore extends AdminController
 
 		if (Tools::isSubmit('submitFileUpload'))
 		{
-			$path = _PS_ADMIN_DIR_.'/import/'.date('Ymdhis').'-';
 			if (isset($_FILES['file']) && !empty($_FILES['file']['error']))
 			{
 				switch ($_FILES['file']['error'])
@@ -2787,18 +2703,13 @@ class AdminImportControllerCore extends AdminController
 					break;
 				}
 			}
-			elseif (!preg_match('/.*\.csv$/i', $_FILES['file']['name']))
+			else if (!file_exists($_FILES['file']['tmp_name']) ||
-				$this->errors[] = Tools::displayError('The extension of your file should be .csv.');
+				!@move_uploaded_file($_FILES['file']['tmp_name'], _PS_ADMIN_DIR_.'/import/'.date('Ymdhis').'-'.$_FILES['file']['name']))
-			elseif (!file_exists($_FILES['file']['tmp_name']) ||
-				!@move_uploaded_file($_FILES['file']['tmp_name'], $path.$_FILES['file']['name']))
 				$this->errors[] = $this->l('An error occurred while uploading / copying the file.');
 			else
-			{
-				@chmod($path.$_FILES['file']['name'], 0664);
 				Tools::redirectAdmin(self::$currentIndex.'&token='.Tools::getValue('token').'&conf=18');
-			}
 		}
-		elseif (Tools::getValue('import'))
+		else if (Tools::getValue('import'))
 		{
 			// Check if the CSV file exist
 			if (Tools::getValue('csv'))
@@ -2814,6 +2725,7 @@ class AdminImportControllerCore extends AdminController
 						$this->clearSmartyCache();
 						break;
 					case $this->entities[$import_type = $this->l('Products')]:
+					$import_type = $this->l('Categories');
 						$this->productImport();
 						$this->clearSmartyCache();
 						break;
@@ -2835,22 +2747,19 @@ class AdminImportControllerCore extends AdminController
 						$this->supplierImport();
 						$this->clearSmartyCache();
 						break;
+					// @since 1.5.0
+					case $this->entities[$import_type = $this->l('Supply Orders')]:
+						if (Configuration::get('PS_ADVANCED_STOCK_MANAGEMENT'))
+							$this->supplyOrdersImport();
+						break;
+					// @since 1.5.0
+					case $this->entities[$import_type = $this->l('Supply Order Details')]:
+						if (Configuration::get('PS_ADVANCED_STOCK_MANAGEMENT'))
+							$this->supplyOrdersDetailsImport();
+						break;
+					default:
+						$this->errors[] = $this->l('Please select what you would like to import');
 				}
-				
-				// @since 1.5.0
-				if (Configuration::get('PS_ADVANCED_STOCK_MANAGEMENT'))
-					switch ((int)Tools::getValue('entity'))
-					{
-						case $this->entities[$import_type = $this->l('Supply Orders')]:
-							if (Configuration::get('PS_ADVANCED_STOCK_MANAGEMENT'))
-								$this->supplyOrdersImport();
-							break;
-						case $this->entities[$import_type = $this->l('Supply Order Details')]:
-							if (Configuration::get('PS_ADVANCED_STOCK_MANAGEMENT'))
-								$this->supplyOrdersDetailsImport();
-							break;	
-					}
-				
 				if ($import_type !== false)
 				{
 					$log_message = sprintf($this->l('%s import'), $import_type);
@@ -2862,41 +2771,7 @@ class AdminImportControllerCore extends AdminController
 			else
 				$this->errors[] = $this->l('You must upload a file in order to proceed to the next step');
 		}
-		elseif ($filename = Tools::getValue('csvfilename'))
-		{
-			$filename = base64_decode($filename);
-			$file =  _PS_ADMIN_DIR_.'/import/'.basename($filename);
-			if (realpath(dirname($file)) != _PS_ADMIN_DIR_.'/import')
-				exit();
-			if (!empty($filename))
-			{
-				$bName = basename($filename);
-				if ($delete = Tools::getValue('delete') && file_exists($file))
-					@unlink($file);
-				elseif (file_exists($file))
-				{
-					$bName = explode('.', $bName);
-					$bName = strtolower($bName[count($bName) - 1]);
-					$mimeTypes = array('csv' => 'text/csv');
 
-					if (isset($mimeTypes[$bName]))
-						$mimeType = $mimeTypes[$bName];
-					else
-						$mimeType = 'application/octet-stream';
-					if (ob_get_level()) 
-						ob_end_clean();
-	
-					header('Content-Transfer-Encoding: binary');
-					header('Content-Type: '.$mimeType);
-					header('Content-Length: '.filesize($file));
-					header('Content-Disposition: attachment; filename="'.$filename.'"');
-					$fp = fopen($file, 'rb');
-					while (is_resource($fp) && !feof($fp))
-						echo fgets($fp, 16384);
-					exit;
-				}
-			}	
-		}
 		parent::postProcess();
 	}
 

controllers/admin/AdminInvoicesController.php

@@ -42,12 +42,6 @@ class AdminInvoicesControllerCore extends AdminController
 						'cast' => 'intval',
 						'type' => 'bool'
 					),
-					'PS_INVOICE_TAXES_BREAKDOWN' => array(
-						'title' => $this->l('Enable the breakdown of taxes on the invoice:'),
-						'desc' => $this->l('Show a breakdown of taxes by tax rate on the invoice when there are several taxes combined'),
-						'cast' => 'intval',
-						'type' => 'bool'
-					),
 					'PS_INVOICE_PREFIX' => array(
 						'title' => $this->l('Invoice prefix:'),
 						'desc' => $this->l('Prefix used for invoice name (e.g. IN00001)'),

controllers/admin/AdminLocalizationController.php

@@ -28,6 +28,9 @@ class AdminLocalizationControllerCore extends AdminController
 {
 	public function __construct()
 	{
+		$this->className = 'Configuration';
+		$this->table = 'configuration';
+
 		parent::__construct();
 
 		$this->fields_options = array(

controllers/admin/AdminLogsController.php

@@ -35,7 +35,7 @@ class AdminLogsControllerCore extends AdminController
 
 		$this->fields_list = array(
 			'id_log' => array('title' => $this->l('ID'), 'align' => 'center', 'width' => 25),
-			'employee' => array('title' => $this->l('Employee'), 'align' => 'center', 'width' => 100, 'havingFilter' => true),
+			'employee' => array('title' => $this->l('Employee'), 'align' => 'center', 'width' => 100),
 			'severity' => array('title' => $this->l('Severity (1-4)'), 'align' => 'center', 'width' => 50),
 			'message' => array('title' => $this->l('Message')),
 			'object_type' => array('title' => $this->l('Object type'), 'width' => 75),
@@ -65,19 +65,9 @@ class AdminLogsControllerCore extends AdminController
 		parent::__construct();
 	}
 
-	public function processDelete()
-	{
-		return Logger::eraseAllLogs();
-	}
-
 	public function initToolbar()
 	{
 		parent::initToolbar();
-		$this->toolbar_btn['delete'] = array(
-			'short' => 'Erase',
-			'desc' => $this->l('Erase all'),
-			'js' => 'if (confirm(\''.$this->l('Are you sure?').'\')) document.location = \''.$this->context->link->getAdminLink('AdminLogs').'&token='.$this->token.'&deletelog=1\';'
-		);
 		unset($this->toolbar_btn['new']);
 	}
 

controllers/admin/AdminManufacturersController.php

@@ -140,7 +140,7 @@ class AdminManufacturersControllerCore extends AdminController
 			'lastname' => array(
 				'title' => $this->l('Last name'),
 				'width' => 100,
-				'filter_key' => 'a!lastname'
+				'filter_key' => 'a!name'
 			),
 			'postcode' => array(
 				'title' => $this->l('Zip Code/Postal Code'),
@@ -256,7 +256,7 @@ class AdminManufacturersControllerCore extends AdminController
 					'lang' => true,
 					'cols' => 60,
 					'rows' => 10,
-					'autoload_rte' => 'rte', //Enable TinyMCE editor for short description
+					'class' => 'rte',
 					'hint' => $this->l('Invalid characters:').' <>;=#{}'
 				),
 				array(
@@ -266,7 +266,7 @@ class AdminManufacturersControllerCore extends AdminController
 					'lang' => true,
 					'cols' => 60,
 					'rows' => 10,
-					'autoload_rte' => 'rte', //Enable TinyMCE editor for description
+					'class' => 'rte',
 					'hint' => $this->l('Invalid characters:').' <>;=#{}'
 				),
 				array(
@@ -570,7 +570,7 @@ class AdminManufacturersControllerCore extends AdminController
 			default:
 				parent::initToolbar();
 				$this->toolbar_btn['import'] = array(
-					'href' => $this->context->link->getAdminLink('AdminImport', true).'&import_type=manufacturers',
+					'href' => $this->context->link->getAdminLink('AdminImport', true).'&import_type='.$this->table,
 					'desc' => $this->l('Import')
 				);
 		}

controllers/admin/AdminModulesController.php

@@ -98,8 +98,6 @@ class AdminModulesControllerCore extends AdminController
 		$this->list_modules_categories['others']['name'] = $this->l('Other Modules');
 		$this->list_modules_categories['mobile']['name'] = $this->l('Mobile');
 
-		uasort($this->list_modules_categories, array($this, 'checkCategoriesNames'));
-
 		// Set Id Employee, Iso Default Country and Filter Configuration
 		$this->id_employee = (int)$this->context->employee->id;
 		$this->iso_default_country = $this->context->country->iso_code;
@@ -131,14 +129,6 @@ class AdminModulesControllerCore extends AdminController
 			$this->logged_on_addons = true;
 	}
 	
-	public function checkCategoriesNames($a, $b)
-	{
-		if ($a['name'] === $this->l('Other Modules'))
-			return true;
-
-		return (bool)($a['name'] > $b['name']);
-	}
-	
 	public function setMedia()
 	{
 		parent::setMedia();
@@ -778,7 +768,7 @@ class AdminModulesControllerCore extends AdminController
 		}
 
 		if (isset($_GET['update']))
-			Tools::redirectAdmin(self::$currentIndex.'&token='.$this->token.'&updated=1tab_module='.$module->tab.'&module_name='.$module->name.'&anchor=anchor'.ucfirst($module->name).(isset($modules_list_save) ? '&modules_list='.$modules_list_save : ''));
+			Tools::redirectAdmin(self::$currentIndex.'&token='.$this->token.'&updated=1tab_module='.$module->tab.'&module_name='.$module->name.'&anchor=anchor'.ucfirst($module->name).(isset($modules_list_save) ? '&modules_list='.$modules_list_save : '').$params);
 	}
 	
 	public function postProcess()
@@ -1108,8 +1098,8 @@ class AdminModulesControllerCore extends AdminController
 					$modules[$km]->preferences = $modules_preferences[$modules[$km]->name];
 			}
 			unset($object);
-			if ($module->installed && isset($module->version_addons) && $module->version_addons)
+			if (isset($module->version_addons))
-				$upgrade_available[] = array('anchor' => ucfirst($module->name), 'name' => $module->displayName);
+				$upgrade_available[] = array('anchor' => ucfirst($module->name), 'name' => $module->displayName);;
 		}
 
 		// Don't display categories without modules

controllers/admin/AdminModulesPositionsController.php

@@ -308,6 +308,7 @@ class AdminModulesPositionsControllerCore extends AdminController
 		$dir = str_replace($admin_dir, '', dirname($_SERVER['SCRIPT_NAME']));
 		if (Configuration::get('PS_REWRITING_SETTINGS') && count(Language::getLanguages(true)) > 1)
 			$lang = Language::getIsoById($this->context->employee->id_lang).'/';
+
 		$url = Tools::getCurrentUrlProtocolPrefix().Tools::getHttpHost().$dir.$lang.Dispatcher::getInstance()->createUrl('index', (int)$this->context->language->id, $live_edit_params);
 		return $url;
 	}

controllers/admin/AdminOrdersController.php

@@ -110,8 +110,7 @@ class AdminOrdersControllerCore extends AdminController
 			'type' => 'select',
 			'list' => $statuses_array,
 			'filter_key' => 'os!id_order_state',
-			'filter_type' => 'int',
+			'filter_type' => 'int'
-			'order_key' => 'osname'
 		),
 		'date_add' => array(
 			'title' => $this->l('Date'),
@@ -507,7 +506,7 @@ class AdminOrdersControllerCore extends AdminController
 						if (Tools::isSubmit('generateDiscountRefund') && !count($this->errors))
 						{
 							$cart_rule = new CartRule();
-							$cart_rule->description = sprintf($this->l('Credit slip for order #%d'), $order->id);
+							$cart_rule->description = sprintf($this->l('Credit card slip for order #%d'), $order->id);
 							$languages = Language::getLanguages(false);
 							foreach ($languages as $language)
 								// Define a temporary name
@@ -805,7 +804,7 @@ class AdminOrdersControllerCore extends AdminController
 
 				if (!Validate::isLoadedObject($order))
 					$this->errors[] = Tools::displayError('The order cannot be found');
-				elseif (!Validate::isNegativePrice($amount) || !(float)$amount)
+				elseif (!Validate::isNegativePrice($amount))
 					$this->errors[] = Tools::displayError('The amount is invalid.');
 				elseif (!Validate::isString(Tools::getValue('payment_method')))
 					$this->errors[] = Tools::displayError('The selected payment method is invalid.');
@@ -1342,14 +1341,11 @@ class AdminOrdersControllerCore extends AdminController
 				$product['warehouse_name'] = '--';
 		}
 
-		$gender = new Gender((int)$customer->id_gender, $this->context->language->id);
-
 		// Smarty assign
 		$this->tpl_view_vars = array(
 			'order' => $order,
 			'cart' => new Cart($order->id_cart),
 			'customer' => $customer,
-			'gender' => $gender,
 			'customer_addresses' => $customer->getAddresses($this->context->language->id),
 			'addresses' => array(
 				'delivery' => $addressDelivery,

controllers/admin/AdminPaymentController.php

@@ -213,7 +213,6 @@ class AdminPaymentControllerCore extends AdminController
 					if ($name_id == 'country'
 						&& isset($module->limited_countries)
 						&& !empty($module->limited_countries)
-						&& is_array($module->limited_countries)
 						&& !(in_array(strtoupper($item['iso_code']), array_map('strtoupper', $module->limited_countries))))
 						$list['items'][$key_item]['check_list'][$key_module] = null;
 				}