From e813ea996d9259e074e2cf7b185f484054206218 Mon Sep 17 00:00:00 2001
From: mMarinetti <michael.marinetti@prestashop.com>
Date: Tue, 20 Dec 2011 19:04:56 +0000
Subject: [PATCH] // minor notice fix when new order, related to
 OrderHistory::getLastOrderState() returning false instead of an object

git-svn-id: http://dev.prestashop.com/svn/v1/branches/1.5.x@11441 b9a71923-0436-4b27-9f14-aed3839534dd
---
 classes/order/OrderHistory.php | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/classes/order/OrderHistory.php b/classes/order/OrderHistory.php
index 9306783be..038ea8a2a 100644
--- a/classes/order/OrderHistory.php
+++ b/classes/order/OrderHistory.php
@@ -80,12 +80,16 @@ class OrderHistoryCore extends ObjectModel
 				foreach ($order->getProductsDetail() as $product)
 				{
 					/* If becoming logable => adding sale */
-					if ($newOS->logable AND (!$oldOrderStatus OR !$oldOrderStatus->logable))
+					if ($newOS->logable 
+						&& $oldOrderStatus instanceof OrderHistory
+						&& $oldOrderStatus->logable)
 					{
 						ProductSale::addProductSale($product['product_id'], $product['product_quantity']);
 					}
 					/* If becoming unlogable => removing sale */
-					else if (!$newOS->logable AND ($oldOrderStatus AND $oldOrderStatus->logable))
+					else if (!$newOS->logable 
+						&& $oldOrderStatus instanceof OrderHistory
+						&& $oldOrderStatus->logable)
 					{
 						ProductSale::removeProductSale($product['product_id'], $product['product_quantity']);
 						// @since 1.5.0
@@ -95,8 +99,7 @@ class OrderHistoryCore extends ObjectModel
 					if ((!Configuration::get('PS_ADVANCED_STOCK_MANAGEMENT') || (int)$product['advanced_stock_management'] != 1)
 						&& !$isValidated
 						&& $newOS->logable
-						&& isset($oldOrderStatus)
-						&& $oldOrderStatus
+						&& $oldOrderStatus instanceof OrderHistory
 						&& $oldOrderStatus->id == Configuration::get('PS_OS_ERROR')
 					)
 						StockAvailable::updateQuantity($product['product_id'], $product['product_attribute_id'], (int)$product['product_quantity'], $order->id_shop);
@@ -105,6 +108,7 @@ class OrderHistoryCore extends ObjectModel
 					// The product is removed from the physical stock. $id_warehouse is needed
 					// @TODO Checks $id_warehouse
 					else if ($newOS->shipped == 1
+						&& $oldOrderStatus instanceof OrderHistory
 						&& $oldOrderStatus->shipped == 0
 						&& Configuration::get('PS_ADVANCED_STOCK_MANAGEMENT')
 						&& (int)$product['advanced_stock_management'] == 1
@@ -129,6 +133,7 @@ class OrderHistoryCore extends ObjectModel
 							StockAvailable::updateQuantity($product['product_id'], $product['product_attribute_id'], -(int)$product['product_quantity'], $order->id_shop);
 					}
 					else if ($newOS->shipped == 0
+						&& $oldOrderStatus instanceof OrderHistory
 						&& $oldOrderStatus->shipped == 1
 						&& Configuration::get('PS_ADVANCED_STOCK_MANAGEMENT')
 						&& (int)$product['advanced_stock_management'] == 1