From e21927403071b43656fe657da2f1eeb2196e68fa Mon Sep 17 00:00:00 2001 From: Vincent Augagneur Date: Wed, 21 Nov 2012 12:08:36 +0100 Subject: [PATCH] [-] CORE : fixed bug #PSCFV-5700 - loop on undefined variable, typo, quote missing in generic_add_missing_column.php --- install-dev/upgrade/php/generic_add_missing_column.php | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/install-dev/upgrade/php/generic_add_missing_column.php b/install-dev/upgrade/php/generic_add_missing_column.php index fdcb3fcd0..6d59c6c97 100644 --- a/install-dev/upgrade/php/generic_add_missing_column.php +++ b/install-dev/upgrade/php/generic_add_missing_column.php @@ -1,18 +1,15 @@ executeS('SHOW FIELDS FROM `'._DB_PREFIX_.$table.'`'); + $column_exist = Db::getInstance()->executeS('SHOW FIELDS FROM `'._DB_PREFIX_.$table.'`'); $column_formated = array(); foreach($column_exist as $c) $column_formated[] = $c['Field'] ; - + $res = true; foreach($column_to_add as $name => $details) if (!in_array($name, $column_formated)) - $res &= Db::getInstance()->execute('ALTER TABLE `'._DB_PREFIX_.$table'` ADD COLUMN `'.$name.'` '.$details); - + $res &= Db::getInstance()->execute('ALTER TABLE `'._DB_PREFIX_.$table.'` ADD COLUMN `'.$name.'` '.$details); return $res; } \ No newline at end of file