dinislage/PrestaShop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[-] SQL error in Combination::setAttributes

Browse Source 
If $ids_attribute is empty, it cause SQL error.
This commit is contained in:
Shagshag
2013-03-11 12:39:22 +01:00
parent fd0e0618ab
commit d293ae61cc
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
classes/Combination.php
+3 -5
View File
@@ -134,8 +134,8 @@ class CombinationCore extends ObjectModel
public function setAttributes($ids_attribute) public function setAttributes($ids_attribute)
{ {
if ($this->deleteAssociations()) $result = $this->deleteAssociations();
{ if ($result && !empty($ids_attribute)) {
$sql_values = array(); $sql_values = array();
foreach ($ids_attribute as $value) foreach ($ids_attribute as $value)
$sql_values[] = '('.(int)$value.', '.(int)$this->id.')'; $sql_values[] = '('.(int)$value.', '.(int)$this->id.')';
@@ -144,10 +144,8 @@ class CombinationCore extends ObjectModel
INSERT INTO `'._DB_PREFIX_.'product_attribute_combination` (`id_attribute`, `id_product_attribute`) INSERT INTO `'._DB_PREFIX_.'product_attribute_combination` (`id_attribute`, `id_product_attribute`)
VALUES '.implode(',', $sql_values) VALUES '.implode(',', $sql_values)
); );
return $result;
} }
return false; return $result;
} }
public function setWsProductOptionValues($values) public function setWsProductOptionValues($values)