dinislage/PrestaShop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[-] BO : fixed bug #PSCFV-4668 - added check if module folder is writable before upgrade it

Browse Source
This commit is contained in:
vAugagneur
2013-01-09 11:37:02 +01:00
parent 68e5a6746a
commit 58100276a6
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
controllers/admin/AdminModulesController.php
+8 -2
View File
@@ -528,11 +528,17 @@ class AdminModulesControllerCore extends AdminController
if ($modules) if ($modules)
foreach ($modules as $name) foreach ($modules as $name)
{ {
if ($key == 'update') $full_report = null;
if ($key == 'update' && !ConfigurationTest::test_dir('modules/'.$name, true, $full_report))
{
$module = Module::getInstanceByName(urldecode($name));
$this->errors[] = $this->l(sprintf("Module %s can't be upgraded : ", $module->displayName)).$full_report;
}
else
Tools::deleteDirectory('../modules/'.$name.'/'); Tools::deleteDirectory('../modules/'.$name.'/');
// If Addons module, download and unzip it before installing it // If Addons module, download and unzip it before installing it
if (!is_dir('../modules/'.$name.'/')) if (!is_null($full_report) && !is_dir('../modules/'.$name.'/'))
{ {
$filesList = array( $filesList = array(
array('type' => 'addonsNative', 'file' => Module::CACHE_FILE_DEFAULT_COUNTRY_MODULES_LIST, 'loggedOnAddons' => 0), array('type' => 'addonsNative', 'file' => Module::CACHE_FILE_DEFAULT_COUNTRY_MODULES_LIST, 'loggedOnAddons' => 0),