From 4320f4c30c423b4840583de43796bc095449c2f1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Gaillard?= Date: Mon, 17 Dec 2012 12:29:29 +0100 Subject: [PATCH 1/2] [-] Core: Fix #PSCFV-6162 - can't add no tax for specific zip code or state --- classes/tax/TaxRulesTaxManager.php | 2 +- controllers/admin/AdminTaxRulesGroupController.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/classes/tax/TaxRulesTaxManager.php b/classes/tax/TaxRulesTaxManager.php index 049a3977d..4c1de21b7 100644 --- a/classes/tax/TaxRulesTaxManager.php +++ b/classes/tax/TaxRulesTaxManager.php @@ -83,7 +83,7 @@ class TaxRulesTaxManagerCore implements TaxManagerInterface WHERE `id_country` = '.(int)$this->address->id_country.' AND `id_tax_rules_group` = '.(int)$this->type.' AND `id_state` IN (0, '.(int)$this->address->id_state.') - AND (\''.pSQL($postcode).'\' BETWEEN `zipcode_from` AND `zipcode_to` OR `zipcode_from` = 0 OR `zipcode_from` = \''.pSQL($postcode).'\') + AND (\''.pSQL($postcode).'\' BETWEEN `zipcode_from` AND `zipcode_to` OR (`zipcode_to` = 0 AND `zipcode_from` IN(0, \''.pSQL($postcode).'\'))) ORDER BY `zipcode_from` DESC, `zipcode_to` DESC, `id_state` DESC, `id_country` DESC'); $behavior = 0; diff --git a/controllers/admin/AdminTaxRulesGroupController.php b/controllers/admin/AdminTaxRulesGroupController.php index c7621c90f..25f40f1a0 100644 --- a/controllers/admin/AdminTaxRulesGroupController.php +++ b/controllers/admin/AdminTaxRulesGroupController.php @@ -298,7 +298,7 @@ class AdminTaxRulesGroupControllerCore extends AdminController 'id' => 'id_tax', 'name' => 'name', 'default' => array( - 'value' => 'name', + 'value' => 0, 'label' => $this->l('No Tax') ) ), From 35013b82febf4c38060e8fd41f7ee0176d699156 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Gaillard?= Date: Mon, 17 Dec 2012 14:42:24 +0100 Subject: [PATCH 2/2] =?UTF-8?q?[-]=20BO:=20Fix=C2=A0#PSCFV-6172=20don't=20?= =?UTF-8?q?htmlentities=20the=20cart=20rule=20name=20&&=20increase=20size?= =?UTF-8?q?=20of=20name=20order=5Fcart=5Frule=20field?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- controllers/admin/AdminCartsController.php | 2 +- install-dev/data/db_structure.sql | 2 +- install-dev/upgrade/sql/1.5.3.0.sql | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/controllers/admin/AdminCartsController.php b/controllers/admin/AdminCartsController.php index 2dd2c32d4..959cfdc43 100755 --- a/controllers/admin/AdminCartsController.php +++ b/controllers/admin/AdminCartsController.php @@ -462,7 +462,7 @@ class AdminCartsControllerCore extends AdminController { $cart_rule = new CartRule(); $cart_rule->code = 'BO_ORDER_'.(int)$this->context->cart->id; - $cart_rule->name = array(Configuration::get('PS_LANG_DEFAULT') => $this->l('Free Shipping')); + $cart_rule->name = array(Configuration::get('PS_LANG_DEFAULT') => $this->l('Free Shipping', 'AdminTab', false, false)); $cart_rule->id_customer = (int)$this->context->cart->id_customer; $cart_rule->free_shipping = true; $cart_rule->quantity = 1; diff --git a/install-dev/data/db_structure.sql b/install-dev/data/db_structure.sql index bf5cbc15c..307dc50d3 100644 --- a/install-dev/data/db_structure.sql +++ b/install-dev/data/db_structure.sql @@ -1177,7 +1177,7 @@ CREATE TABLE `PREFIX_order_cart_rule` ( `id_order` int(10) unsigned NOT NULL, `id_cart_rule` int(10) unsigned NOT NULL, `id_order_invoice` int(10) unsigned DEFAULT 0, - `name` varchar(32) NOT NULL, + `name` varchar(254) NOT NULL, `value` decimal(17,2) NOT NULL default '0.00', `value_tax_excl` decimal(17,2) NOT NULL default '0.00', PRIMARY KEY (`id_order_cart_rule`), diff --git a/install-dev/upgrade/sql/1.5.3.0.sql b/install-dev/upgrade/sql/1.5.3.0.sql index 53cc5c870..b50f1043d 100644 --- a/install-dev/upgrade/sql/1.5.3.0.sql +++ b/install-dev/upgrade/sql/1.5.3.0.sql @@ -18,4 +18,6 @@ UPDATE `PREFIX_order_state_lang` SET `template` = 'payment' WHERE `id_order_stat DELETE FROM `PREFIX_configuration` WHERE `name`= 'PS_HIGH_HTML_THEME_COMPRESSION'; -INSERT INTO `PREFIX_configuration`(`name`, `value`, `date_add`, `date_upd`) VALUES ('PS_MAIL_COLOR', '#db3484', NOW(), NOW()); \ No newline at end of file +INSERT INTO `PREFIX_configuration`(`name`, `value`, `date_add`, `date_upd`) VALUES ('PS_MAIL_COLOR', '#db3484', NOW(), NOW()); + +ALTER TABLE `PREFIX_order_cart_rule` CHANGE `name` `name` VARCHAR(254); \ No newline at end of file