From 38a23cf9789b278a16adbe7d99c86e7aeb162bce Mon Sep 17 00:00:00 2001
From: vChabot <vincent.chabot@prestashop.com>
Date: Fri, 7 Oct 2011 09:24:44 +0000
Subject: [PATCH] // refactoring function (delete useless functions)

git-svn-id: http://dev.prestashop.com/svn/v1/branches/1.5.x@9123 b9a71923-0436-4b27-9f14-aed3839534dd
---
 ...dd_default_restrictions_modules_groups.php | 41 +++++++------------
 1 file changed, 14 insertions(+), 27 deletions(-)

diff --git a/install-dev/php/add_default_restrictions_modules_groups.php b/install-dev/php/add_default_restrictions_modules_groups.php
index ff9201478..c37d3ae7b 100644
--- a/install-dev/php/add_default_restrictions_modules_groups.php
+++ b/install-dev/php/add_default_restrictions_modules_groups.php
@@ -27,37 +27,24 @@
 
 function add_default_restrictions_modules_groups()
 {
-	$groups = getGroups();
-	$modules = getModulesInstalled();
-	foreach ($groups as $group)
-		addModulesRestrictions($group['id_group'], $modules);
-}
-
-function getGroups()
-{
-	return Db::getInstance()->ExecuteS('
+	$groups = Db::getInstance()->ExecuteS('
 		SELECT `id_group`
 		FROM `'._DB_PREFIX_.'group`');
-}
-
-function getModulesInstalled()
-{
-	return Db::getInstance()->ExecuteS('
+	$modules = Db::getInstance()->ExecuteS('
 		SELECT m.*
 		FROM `'._DB_PREFIX_.'module` m');
-}
-
-function addModulesRestrictions($id_group, $modules)
-{
-	if (!is_array($modules))
-		return false;
-	else
+	foreach ($groups as $group)
 	{
-		$sql = 'INSERT INTO `'._DB_PREFIX_.'group_module_restriction` (`id_group`, `id_module`, `authorized`) VALUES ';
-		foreach ($modules as $mod)
-			$sql .= '("'.(int)$id_group.'", "'.(int)$mod['id_module'].'", "1"),';
-		// removing last comma to avoid SQL error
-		$sql = substr($sql, 0, strlen($sql) - 1);
-		Db::getInstance()->Execute($sql);
+		if (!is_array($modules))
+			return false;
+		else
+		{
+			$sql = 'INSERT INTO `'._DB_PREFIX_.'group_module_restriction` (`id_group`, `id_module`, `authorized`) VALUES ';
+			foreach ($modules as $mod)
+				$sql .= '("'.(int)$group['id_group'].'", "'.(int)$mod['id_module'].'", "1"),';
+			// removing last comma to avoid SQL error
+			$sql = substr($sql, 0, strlen($sql) - 1);
+			Db::getInstance()->Execute($sql);
+		}
 	}
 }
\ No newline at end of file