From 230bebc7c799526ab6fd03f43414a122ec26384e Mon Sep 17 00:00:00 2001 From: aFolletete Date: Sat, 3 Sep 2011 17:21:32 +0000 Subject: [PATCH] [+] Project : adding Features detachables in order to improve performance // clean code --- admin-dev/tabs/AdminAttributeGenerator.php | 12 +- admin-dev/tabs/AdminAttributes.php | 9 + admin-dev/tabs/AdminAttributesGroups.php | 26 +- admin-dev/tabs/AdminCarts.php | 4 +- admin-dev/tabs/AdminDiscounts.php | 16 +- admin-dev/tabs/AdminFeatures.php | 26 +- admin-dev/tabs/AdminFeaturesValues.php | 6 + admin-dev/tabs/AdminOrders.php | 13 +- admin-dev/tabs/AdminPerformance.php | 57 ++++ admin-dev/tabs/AdminProducts.php | 66 ++-- admin-dev/tabs/AdminReturn.php | 4 +- classes/Alias.php | 52 ++- classes/Attribute.php | 4 +- classes/AttributeGroup.php | 7 +- classes/Cart.php | 247 ++++++++------ classes/Category.php | 2 - classes/Combination.php | 25 +- classes/Customer.php | 6 + classes/Customization.php | 20 +- classes/Discount.php | 181 +++++++--- classes/Dispatcher.php | 2 - classes/Feature.php | 13 + classes/FrontController.php | 3 + classes/Group.php | 20 +- classes/OrderSlip.php | 4 +- classes/PDF.php | 8 +- classes/Pack.php | 34 ++ classes/PaymentModule.php | 12 +- classes/Product.php | 323 +++++++++++------- classes/ProductDownload.php | 22 +- classes/Scene.php | 25 +- classes/Search.php | 6 + classes/SpecificPrice.php | 54 ++- classes/Tools.php | 49 ++- classes/Validate.php | 2 +- config/smarty.config.inc.php | 1 - controllers/CartController.php | 2 +- controllers/CategoryController.php | 22 +- controllers/GuestTrackingController.php | 4 +- controllers/OrderDetailController.php | 2 +- controllers/ParentOrderController.php | 33 +- controllers/ProductController.php | 12 +- install-dev/sql/db_settings_lite.sql | 4 +- install-dev/sql/upgrade/1.5.0.1.sql | 6 + modules/blockcart/blockcart.php | 4 +- modules/followup/followup.php | 2 +- modules/loyalty/loyalty-program.php | 2 +- modules/mailalerts/mailalerts.php | 8 +- .../referralprogram/ReferralProgramModule.php | 4 +- modules/treepodia/treepodia.php | 2 +- translations/fr/admin.php | 32 ++ 51 files changed, 1081 insertions(+), 419 deletions(-) diff --git a/admin-dev/tabs/AdminAttributeGenerator.php b/admin-dev/tabs/AdminAttributeGenerator.php index d52164457..0b7040ad1 100644 --- a/admin-dev/tabs/AdminAttributeGenerator.php +++ b/admin-dev/tabs/AdminAttributeGenerator.php @@ -99,7 +99,7 @@ class AdminAttributeGenerator extends AdminTab parent::postProcess(); } - static private function displayAndReturnAttributeJs() + private static function displayAndReturnAttributeJs() { $attributes = Attribute::getAttributes($this->context->language->id, true); $attributeJs = array(); @@ -142,7 +142,7 @@ class AdminAttributeGenerator extends AdminTab '; } - static private function setAttributesImpacts($id_product, $tab) + private static function setAttributesImpacts($id_product, $tab) { $attributes = array(); foreach ($tab AS $group) @@ -155,7 +155,7 @@ class AdminAttributeGenerator extends AdminTab ); } - static private function getAttributesImpacts($id_product) + private static function getAttributesImpacts($id_product) { $tab = array(); $result = Db::getInstance()->ExecuteS( @@ -216,6 +216,12 @@ class AdminAttributeGenerator extends AdminTab public function displayForm($isMainTab = true) { + if (!Combination::isFeatureActive()) + { + $this->displayWarning($this->l('This feature has been disabled, you can active this feature at this page:').' '.$this->l('Performances').''); + return; + } + parent::displayForm(); $jsAttributes = self::displayAndReturnAttributeJs(); diff --git a/admin-dev/tabs/AdminAttributes.php b/admin-dev/tabs/AdminAttributes.php index 776a105db..d2bd77d73 100644 --- a/admin-dev/tabs/AdminAttributes.php +++ b/admin-dev/tabs/AdminAttributes.php @@ -46,6 +46,12 @@ class AdminAttributes extends AdminTab */ public function displayForm($token = NULL) { + if (!Combination::isFeatureActive()) + { + $this->displayWarning($this->l('This feature has been disabled, you can active this feature at this page:').' '.$this->l('Performances').''); + return; + } + parent::displayForm(); if (!($obj = $this->loadObject(true))) @@ -127,6 +133,9 @@ class AdminAttributes extends AdminTab */ public function postProcess($token = NULL) { + if (!Combination::isFeatureActive()) + return; + if (Tools::getValue('submitDel'.$this->table)) { if ($this->tabAccess['delete'] === '1') diff --git a/admin-dev/tabs/AdminAttributesGroups.php b/admin-dev/tabs/AdminAttributesGroups.php index 1c8f6bf4b..97d11749d 100644 --- a/admin-dev/tabs/AdminAttributesGroups.php +++ b/admin-dev/tabs/AdminAttributesGroups.php @@ -50,20 +50,26 @@ class AdminAttributesGroups extends AdminTab public function display() { - if ((isset($_POST['submitAddattribute']) AND sizeof($this->adminAttributes->_errors)) - OR isset($_GET['updateattribute']) OR isset($_GET['addattribute'])) + if (Combination::isFeatureActive()) { - $this->adminAttributes->displayForm($this->token); - echo '

'.$this->l('Back to list').'
'; + if ((isset($_POST['submitAddattribute']) AND sizeof($this->adminAttributes->_errors)) + OR isset($_GET['updateattribute']) OR isset($_GET['addattribute'])) + { + $this->adminAttributes->displayForm($this->token); + echo '

'.$this->l('Back to list').'
'; + } + else + parent::display(); } else - { - parent::display(); - } + $this->displayWarning($this->l('This feature has been disabled, you can active this feature at this page:').' '.$this->l('Performances').''); } public function postProcess() { + if (!Combination::isFeatureActive()) + return; + $this->adminAttributes->tabAccess = Profile::getProfileAccess(Context::getContext()->employee->id_profile, $this->id); $this->adminAttributes->postProcess($this->token); @@ -166,6 +172,12 @@ class AdminAttributesGroups extends AdminTab public function displayForm($isMainTab = true) { + if (!Combination::isFeatureActive()) + { + $this->displayWarning($this->l('This feature has been disabled, you can active this feature at this page:').' '.$this->l('Performances').''); + return; + } + parent::displayForm(); if (!($obj = $this->loadObject(true))) diff --git a/admin-dev/tabs/AdminCarts.php b/admin-dev/tabs/AdminCarts.php index 9b46e18bf..25e041a04 100644 --- a/admin-dev/tabs/AdminCarts.php +++ b/admin-dev/tabs/AdminCarts.php @@ -281,7 +281,7 @@ class AdminCarts extends AdminTab '; foreach ($customization['datas'] AS $type => $datas) - if ($type == _CUSTOMIZE_FILE_) + if ($type == Product::CUSTOMIZE_FILE) { $i = 0; echo ''; } - elseif ($type == _CUSTOMIZE_TEXTFIELD_) + elseif ($type == Product::CUSTOMIZE_TEXTFIELD) { $i = 0; echo '