// refactoring function (delete useless functions)

This commit is contained in:
vChabot
2011-10-07 09:24:44 +00:00
parent 6a697acaf2
commit 22d560688d
@@ -27,37 +27,24 @@
function add_default_restrictions_modules_groups() function add_default_restrictions_modules_groups()
{ {
$groups = getGroups(); $groups = Db::getInstance()->ExecuteS('
$modules = getModulesInstalled();
foreach ($groups as $group)
addModulesRestrictions($group['id_group'], $modules);
}
function getGroups()
{
return Db::getInstance()->ExecuteS('
SELECT `id_group` SELECT `id_group`
FROM `'._DB_PREFIX_.'group`'); FROM `'._DB_PREFIX_.'group`');
} $modules = Db::getInstance()->ExecuteS('
function getModulesInstalled()
{
return Db::getInstance()->ExecuteS('
SELECT m.* SELECT m.*
FROM `'._DB_PREFIX_.'module` m'); FROM `'._DB_PREFIX_.'module` m');
} foreach ($groups as $group)
function addModulesRestrictions($id_group, $modules)
{
if (!is_array($modules))
return false;
else
{ {
$sql = 'INSERT INTO `'._DB_PREFIX_.'group_module_restriction` (`id_group`, `id_module`, `authorized`) VALUES '; if (!is_array($modules))
foreach ($modules as $mod) return false;
$sql .= '("'.(int)$id_group.'", "'.(int)$mod['id_module'].'", "1"),'; else
// removing last comma to avoid SQL error {
$sql = substr($sql, 0, strlen($sql) - 1); $sql = 'INSERT INTO `'._DB_PREFIX_.'group_module_restriction` (`id_group`, `id_module`, `authorized`) VALUES ';
Db::getInstance()->Execute($sql); foreach ($modules as $mod)
$sql .= '("'.(int)$group['id_group'].'", "'.(int)$mod['id_module'].'", "1"),';
// removing last comma to avoid SQL error
$sql = substr($sql, 0, strlen($sql) - 1);
Db::getInstance()->Execute($sql);
}
} }
} }