// refactoring function (delete useless functions)

install-dev/php/add_default_restrictions_modules_groups.php

@@ -27,27 +27,13 @@
 
 function add_default_restrictions_modules_groups()
 {
-	$groups = getGroups();
+	$groups = Db::getInstance()->ExecuteS('
-	$modules = getModulesInstalled();
-	foreach ($groups as $group)
-		addModulesRestrictions($group['id_group'], $modules);
-}
-
-function getGroups()
-{
-	return Db::getInstance()->ExecuteS('
 		SELECT `id_group`
 		FROM `'._DB_PREFIX_.'group`');
-}
+	$modules = Db::getInstance()->ExecuteS('
-
-function getModulesInstalled()
-{
-	return Db::getInstance()->ExecuteS('
 		SELECT m.*
 		FROM `'._DB_PREFIX_.'module` m');
-}
+	foreach ($groups as $group)
-
-function addModulesRestrictions($id_group, $modules)
 	{
 		if (!is_array($modules))
 			return false;
@@ -55,9 +41,10 @@ function addModulesRestrictions($id_group, $modules)
 		{
 			$sql = 'INSERT INTO `'._DB_PREFIX_.'group_module_restriction` (`id_group`, `id_module`, `authorized`) VALUES ';
 			foreach ($modules as $mod)
-			$sql .= '("'.(int)$id_group.'", "'.(int)$mod['id_module'].'", "1"),';
+				$sql .= '("'.(int)$group['id_group'].'", "'.(int)$mod['id_module'].'", "1"),';
 			// removing last comma to avoid SQL error
 			$sql = substr($sql, 0, strlen($sql) - 1);
 			Db::getInstance()->Execute($sql);
 		}
 	}
+}