Fixup js/order-address.js

Replace == with === and != with !==
Added var to for loop
This commit is contained in:
Milow
2012-11-23 22:09:15 -06:00
parent 766a9677e2
commit 0f6d6e9747
+8 -8
View File
@@ -25,7 +25,7 @@
$(document).ready(function() $(document).ready(function()
{ {
if (typeof(formatedAddressFieldsValuesList) != 'undefined') if (typeof(formatedAddressFieldsValuesList) !== 'undefined')
updateAddressesDisplay(true); updateAddressesDisplay(true);
resizeAddressesBox(); resizeAddressesBox();
}); });
@@ -49,9 +49,9 @@ function updateAddressesDisplay(first_view)
// update content of invoice address // update content of invoice address
//if addresses have to be equals... //if addresses have to be equals...
if ($('input[type=checkbox]#addressesAreEquals:checked').length == 1 && ($('#multishipping_mode_checkbox:checked').length == 0)) if ($('input[type=checkbox]#addressesAreEquals:checked').length === 1 && ($('#multishipping_mode_checkbox:checked').length === 0))
{ {
if ($('#multishipping_mode_checkbox:checked').length == 0) { if ($('#multishipping_mode_checkbox:checked').length === 0) {
$('#address_invoice_form:visible').hide('fast'); $('#address_invoice_form:visible').hide('fast');
} }
$('ul#address_invoice').html($('ul#address_delivery').html()); $('ul#address_invoice').html($('ul#address_delivery').html());
@@ -71,7 +71,7 @@ function updateAddressesDisplay(first_view)
if(!first_view) if(!first_view)
{ {
if (orderProcess == 'order') if (orderProcess === 'order')
updateAddresses(); updateAddresses();
} }
return true; return true;
@@ -99,7 +99,7 @@ function updateAddressDisplay(addressType)
function updateAddresses() function updateAddresses()
{ {
var idAddress_delivery = $('#id_address_delivery').val(); var idAddress_delivery = $('#id_address_delivery').val();
var idAddress_invoice = $('input[type=checkbox]#addressesAreEquals:checked').length == 1 ? idAddress_delivery : $('#id_address_invoice').val(); var idAddress_invoice = $('input[type=checkbox]#addressesAreEquals:checked').length === 1 ? idAddress_delivery : $('#id_address_invoice').val();
$.ajax({ $.ajax({
type: 'POST', type: 'POST',
url: baseUri, url: baseUri,
@@ -121,15 +121,15 @@ function updateAddresses()
if (jsonData.hasError) if (jsonData.hasError)
{ {
var errors = ''; var errors = '';
for(error in jsonData.errors) for(var error in jsonData.errors)
//IE6 bug fix //IE6 bug fix
if(error != 'indexOf') if(error !== 'indexOf')
errors += jsonData.errors[error] + "\n"; errors += jsonData.errors[error] + "\n";
alert(errors); alert(errors);
} }
}, },
error: function(XMLHttpRequest, textStatus, errorThrown) { error: function(XMLHttpRequest, textStatus, errorThrown) {
if (textStatus != 'abort') if (textStatus !== 'abort')
alert("TECHNICAL ERROR: unable to save adresses \n\nDetails:\nError thrown: " + XMLHttpRequest + "\n" + 'Text status: ' + textStatus); alert("TECHNICAL ERROR: unable to save adresses \n\nDetails:\nError thrown: " + XMLHttpRequest + "\n" + 'Text status: ' + textStatus);
} }
}); });