Update movie info getter with better exception handling

This commit is contained in:
Ruud
2014-01-13 23:43:10 +01:00
parent 279297b8fa
commit 8d44577dca
2 changed files with 12 additions and 6 deletions
@@ -39,7 +39,7 @@ class OMDBAPI(MovieProvider):
if cached: if cached:
result = self.parseMovie(cached) result = self.parseMovie(cached)
if result.get('titles') and len(result.get('titles')) > 0: if result.get('titles') and len(result.get('titles')) > 0:
log.info('Found: %s', result['titles'][0] + ' (' + str(result['year']) + ')') log.info('Found: %s', result['titles'][0] + ' (' + str(result.get('year')) + ')')
return [result] return [result]
return [] return []
@@ -73,10 +73,16 @@ class TheMovieDb(MovieProvider):
try: try:
log.debug('Getting info: %s', cache_key) log.debug('Getting info: %s', cache_key)
movie = tmdb3.Movie(identifier) movie = tmdb3.Movie(identifier)
result = self.parseMovie(movie, extended = extended) try: exists = movie.title is not None
self.setCache(cache_key, result) except: exists = False
if exists:
result = self.parseMovie(movie, extended = extended)
self.setCache(cache_key, result)
else:
result = {}
except: except:
pass log.error('Failed getting info for %s: %s', (identifier, traceback.format_exc()))
return result return result
@@ -157,9 +163,9 @@ class TheMovieDb(MovieProvider):
image_url = '' image_url = ''
try: try:
image_url = getattr(movie, type).geturl(size = 'original') image_url = getattr(movie, type).geturl(size = size)
except: except:
log.debug('Failed getting %s.%s for "%s"', (type, size, movie)) log.debug('Failed getting %s.%s for "%s"', (type, size, str(movie)))
return image_url return image_url