Code cleanup

couchpotato/core/media/__init__.py

@@ -1,5 +1,4 @@
 from couchpotato.core.event import addEvent
-from couchpotato.core.logger import CPLog
 from couchpotato.core.plugins.base import Plugin
 
 

couchpotato/core/media/_base/searcher/__init__.py

@@ -1,5 +1,4 @@
 from .main import Searcher
-import random
 
 def start():
     return Searcher()

couchpotato/core/media/_base/searcher/base.py

@@ -1,4 +1,3 @@
-from couchpotato.api import addApiView
 from couchpotato.core.event import addEvent, fireEvent
 from couchpotato.core.logger import CPLog
 from couchpotato.core.plugins.base import Plugin
@@ -19,12 +18,10 @@ class SearcherBase(Plugin):
 
         self.initCron()
 
-
-    """ Set the searcher cronjob
-        Make sure to reset cronjob after setting has changed
-
-    """
     def initCron(self):
+        """ Set the searcher cronjob
+            Make sure to reset cronjob after setting has changed
+        """
 
         _type = self.getType()
 
@@ -38,14 +35,11 @@ class SearcherBase(Plugin):
         addEvent('setting.save.%s_searcher.cron_hour.after' % _type, setCrons)
         addEvent('setting.save.%s_searcher.cron_minute.after' % _type, setCrons)
 
-
-    """ Return progress of current searcher
-
-    """
     def getProgress(self, **kwargs):
+        """ Return progress of current searcher"""
 
-        progress = {}
-        progress[self.getType()] = self.in_progress
+        progress = {
+            self.getType(): self.in_progress
+        }
 
         return progress
-

couchpotato/core/media/_base/searcher/main.py

@@ -173,10 +173,10 @@ class Searcher(SearcherBase):
         year_name = fireEvent('scanner.name_year', name, single = True)
         if len(found) == 0 and movie_year < datetime.datetime.now().year - 3 and not year_name.get('year', None):
             if size > 3000: # Assume dvdr
-                log.info('Quality was missing in name, assuming it\'s a DVD-R based on the size: %s', (size))
+                log.info('Quality was missing in name, assuming it\'s a DVD-R based on the size: %s', size)
                 found['dvdr'] = True
             else: # Assume dvdrip
-                log.info('Quality was missing in name, assuming it\'s a DVD-Rip based on the size: %s', (size))
+                log.info('Quality was missing in name, assuming it\'s a DVD-Rip based on the size: %s', size)
                 found['dvdrip'] = True
 
         # Allow other qualities
@@ -191,6 +191,7 @@ class Searcher(SearcherBase):
         if not isinstance(haystack, (list, tuple, set)):
             haystack = [haystack]
 
+        year_name = {}
         for string in haystack:
 
             year_name = fireEvent('scanner.name_year', string, single = True)

couchpotato/core/media/movie/_base/main.py

@@ -145,7 +145,7 @@ class MovieBase(MovieTypeBase):
 
         imdb_id = getImdb(str(movie_id))
 
-        if(imdb_id):
+        if imdb_id:
             m = db.query(Movie).filter(Movie.library.has(identifier = imdb_id)).first()
         else:
             m = db.query(Movie).filter_by(id = movie_id).first()
@@ -231,7 +231,7 @@ class MovieBase(MovieTypeBase):
             }))
 
         db.expire_all()
-        return (total_count, movies)
+        return total_count, movies
 
     def availableChars(self, status = None, release_status = None):
 
@@ -270,12 +270,12 @@ class MovieBase(MovieTypeBase):
 
     def listView(self, **kwargs):
 
-        status = splitString(kwargs.get('status', None))
-        release_status = splitString(kwargs.get('release_status', None))
-        limit_offset = kwargs.get('limit_offset', None)
-        starts_with = kwargs.get('starts_with', None)
-        search = kwargs.get('search', None)
-        order = kwargs.get('order', None)
+        status = splitString(kwargs.get('status'))
+        release_status = splitString(kwargs.get('release_status'))
+        limit_offset = kwargs.get('limit_offset')
+        starts_with = kwargs.get('starts_with')
+        search = kwargs.get('search')
+        order = kwargs.get('order')
 
         total_movies, movies = self.list(
             status = status,
@@ -372,7 +372,7 @@ class MovieBase(MovieTypeBase):
             fireEvent('status.get', ['active', 'snatched', 'ignored', 'done', 'downloaded'], single = True)
 
         default_profile = fireEvent('profile.default', single = True)
-        cat_id = params.get('category_id', None)
+        cat_id = params.get('category_id')
 
         db = get_session()
         m = db.query(Movie).filter_by(library_id = library.get('id')).first()
@@ -463,7 +463,7 @@ class MovieBase(MovieTypeBase):
 
             m.profile_id = kwargs.get('profile_id')
 
-            cat_id = kwargs.get('category_id', None)
+            cat_id = kwargs.get('category_id')
             if cat_id is not None:
                 m.category_id = tryInt(cat_id) if tryInt(cat_id) > 0 else None
 
@@ -559,7 +559,7 @@ class MovieBase(MovieTypeBase):
             log.debug('Can\'t restatus movie, doesn\'t seem to exist.')
             return False
 
-        log.debug('Changing status for %s', (m.library.titles[0].title))
+        log.debug('Changing status for %s', m.library.titles[0].title)
         if not m.profile:
             m.status_id = done_status.get('id')
         else:

couchpotato/core/media/movie/library/movie/main.py

@@ -2,8 +2,8 @@ from couchpotato import get_session
 from couchpotato.core.event import addEvent, fireEventAsync, fireEvent
 from couchpotato.core.helpers.encoding import toUnicode, simplifyString
 from couchpotato.core.logger import CPLog
-from couchpotato.core.settings.model import Library, LibraryTitle, File
 from couchpotato.core.media._base.library import LibraryBase
+from couchpotato.core.settings.model import Library, LibraryTitle, File
 from string import ascii_letters
 import time
 import traceback
@@ -66,6 +66,7 @@ class MovieLibraryPlugin(LibraryBase):
         library = db.query(Library).filter_by(identifier = identifier).first()
         done_status = fireEvent('status.get', 'done', single = True)
 
+        library_dict = None
         if library:
             library_dict = library.to_dict(self.default_dict)