Remove mutable objects from function args

couchpotato/core/plugins/file/main.py

@@ -83,7 +83,8 @@ class FileManager(Plugin):
         Env.get('app').add_handlers(".*$", [('%s%s' % (Env.get('api_base'), route), StaticFileHandler, {'path': Env.get('cache_dir')})])
 
 
-    def download(self, url = '', dest = None, overwrite = False, urlopen_kwargs = {}):
+    def download(self, url = '', dest = None, overwrite = False, urlopen_kwargs = None):
+        if not urlopen_kwargs: urlopen_kwargs = {}
 
         if not dest: # to Cache
             dest = os.path.join(Env.get('cache_dir'), '%s.%s' % (md5(url), getExt(url)))
@@ -100,7 +101,9 @@ class FileManager(Plugin):
         self.createFile(dest, filedata, binary = True)
         return dest
 
-    def add(self, path = '', part = 1, type_tuple = (), available = 1, properties = {}):
+    def add(self, path = '', part = 1, type_tuple = (), available = 1, properties = None):
+        if not properties: properties = {}
+
         type_id = self.getType(type_tuple).get('id')
         db = get_session()
 

couchpotato/core/plugins/manage/main.py

@@ -26,7 +26,8 @@ class Manage(Plugin):
         addEvent('manage.diskspace', self.getDiskSpace)
 
         # Add files after renaming
-        def after_rename(message = None, group = {}):
+        def after_rename(message = None, group = None):
+            if not group: group = {}
             return self.scanFilesToLibrary(folder = group['destination_dir'], files = group['renamed_files'])
         addEvent('renamer.after', after_rename, priority = 110)
 
@@ -168,7 +169,9 @@ class Manage(Plugin):
         fireEvent('notify.frontend', type = 'manage.updating', data = False)
         self.in_progress = False
 
-    def createAddToLibrary(self, folder, added_identifiers = []):
+    def createAddToLibrary(self, folder, added_identifiers = None):
+        if not added_identifiers: added_identifiers = []
+
         def addToLibrary(group, total_found, to_go):
             if self.in_progress[folder]['total'] is None:
                 self.in_progress[folder] = {

couchpotato/core/plugins/quality/main.py

@@ -152,7 +152,8 @@ class QualityPlugin(Plugin):
 
         return True
 
-    def guess(self, files, extra = {}):
+    def guess(self, files, extra = None):
+        if not extra: extra = {}
 
         # Create hash for cache
         hash = md5(str([f.replace('.' + getExt(f), '') for f in files]))

couchpotato/core/plugins/renamer/main.py

@@ -495,7 +495,9 @@ class Renamer(Plugin):
 
         self.renaming_started = False
 
-    def getRenameExtras(self, extra_type = '', replacements = {}, folder_name = '', file_name = '', destination = '', group = {}, current_file = '', remove_multiple = False):
+    def getRenameExtras(self, extra_type = '', replacements = None, folder_name = '', file_name = '', destination = '', group = None, current_file = '', remove_multiple = False):
+        if not group: group = {}
+        if not replacements: replacements = {}
 
         replacements = replacements.copy()
         rename_files = {}
@@ -843,11 +845,12 @@ Remove it if you want it to be renamed (again, or at least let it try again)
 
     def statusInfoComplete(self, item):
         return item['id'] and item['downloader'] and item['folder']
-    
+
     def movieInFromFolder(self, movie_folder):
         return movie_folder and self.conf('from') in movie_folder or not movie_folder
 
-    def extractFiles(self, folder = None, movie_folder = None, files = [], cleanup = False):
+    def extractFiles(self, folder = None, movie_folder = None, files = None, cleanup = False):
+        if not files: files = []
 
         # RegEx for finding rar files
         archive_regex = '(?P<file>^(?P<base>(?:(?!\.part\d+\.rar$).)*)\.(?:(?:part0*1\.)?rar)$)'
@@ -941,7 +944,7 @@ Remove it if you want it to be renamed (again, or at least let it try again)
                     self.makeDir(os.path.dirname(move_to))
                     self.moveFile(leftoverfile, move_to, cleanup)
                 except Exception, e:
-                    log.error('Failed moving left over file %s to %s: %s %s',(leftoverfile, move_to, e, traceback.format_exc()))
+                    log.error('Failed moving left over file %s to %s: %s %s', (leftoverfile, move_to, e, traceback.format_exc()))
                     # As we probably tried to overwrite the nfo file, check if it exists and then remove the original
                     if os.path.isfile(move_to):
                         if cleanup:
@@ -964,7 +967,7 @@ Remove it if you want it to be renamed (again, or at least let it try again)
         if extr_files:
             files.extend(extr_files)
 
-        # Cleanup files and folder if movie_folder was not provided 
+        # Cleanup files and folder if movie_folder was not provided
         if not movie_folder:
             files = []
             folder = None

couchpotato/core/plugins/subtitle/main.py

@@ -42,7 +42,6 @@ class Subtitle(Plugin):
                     subliminal.list_subtitles(files, cache_dir = Env.get('cache_dir'), multi = True, languages = self.getLanguages(), services = self.services)
 
     def searchSingle(self, group):
-
         if self.isDisabled(): return
 
         try:

couchpotato/core/plugins/trailer/main.py

@@ -12,8 +12,8 @@ class Trailer(Plugin):
     def __init__(self):
         addEvent('renamer.after', self.searchSingle)
 
-    def searchSingle(self, message = None, group = {}):
-
+    def searchSingle(self, message = None, group = None):
+        if not group: group = {}
         if self.isDisabled() or len(group['files']['trailer']) > 0: return
 
         trailers = fireEvent('trailer.search', group = group, merge = True)
@@ -40,4 +40,3 @@ class Trailer(Plugin):
             break
 
         return True
-