Don't return .text in urlopen
This commit is contained in:
@@ -127,7 +127,7 @@ class Plugin(object):
|
|||||||
return False
|
return False
|
||||||
|
|
||||||
# http request
|
# http request
|
||||||
def urlopen(self, url, timeout = 30, data = None, headers = None, files = None, show_error = True, return_raw = False):
|
def urlopen(self, url, timeout = 30, data = None, headers = None, files = None, show_error = True):
|
||||||
url = urllib2.quote(ss(url), safe = "%/:=&?~#+!$,;'@()*[]")
|
url = urllib2.quote(ss(url), safe = "%/:=&?~#+!$,;'@()*[]")
|
||||||
|
|
||||||
if not headers: headers = {}
|
if not headers: headers = {}
|
||||||
@@ -172,7 +172,7 @@ class Plugin(object):
|
|||||||
log.info('Opening url: %s %s, data: %s', (method, url, [x for x in data.iterkeys()] if isinstance(data, dict) else 'with data'))
|
log.info('Opening url: %s %s, data: %s', (method, url, [x for x in data.iterkeys()] if isinstance(data, dict) else 'with data'))
|
||||||
response = r.request(method, url, verify = False, **kwargs)
|
response = r.request(method, url, verify = False, **kwargs)
|
||||||
|
|
||||||
data = response.content if return_raw else response.text
|
data = response.content
|
||||||
|
|
||||||
self.http_failed_request[host] = 0
|
self.http_failed_request[host] = 0
|
||||||
except (IOError, MaxRetryError, Timeout):
|
except (IOError, MaxRetryError, Timeout):
|
||||||
|
|||||||
@@ -93,7 +93,7 @@ class FileManager(Plugin):
|
|||||||
return dest
|
return dest
|
||||||
|
|
||||||
try:
|
try:
|
||||||
filedata = self.urlopen(url, return_raw = True, **urlopen_kwargs)
|
filedata = self.urlopen(url, **urlopen_kwargs)
|
||||||
except:
|
except:
|
||||||
log.error('Failed downloading file %s: %s', (url, traceback.format_exc()))
|
log.error('Failed downloading file %s: %s', (url, traceback.format_exc()))
|
||||||
return False
|
return False
|
||||||
|
|||||||
@@ -164,7 +164,7 @@ class YarrProvider(Provider):
|
|||||||
try:
|
try:
|
||||||
if not self.login():
|
if not self.login():
|
||||||
log.error('Failed downloading from %s', self.getName())
|
log.error('Failed downloading from %s', self.getName())
|
||||||
return self.urlopen(url, return_raw = True)
|
return self.urlopen(url)
|
||||||
except:
|
except:
|
||||||
log.error('Failed downloading from %s: %s', (self.getName(), traceback.format_exc()))
|
log.error('Failed downloading from %s: %s', (self.getName(), traceback.format_exc()))
|
||||||
|
|
||||||
@@ -173,7 +173,7 @@ class YarrProvider(Provider):
|
|||||||
|
|
||||||
def download(self, url = '', nzb_id = ''):
|
def download(self, url = '', nzb_id = ''):
|
||||||
try:
|
try:
|
||||||
return self.urlopen(url, headers = {'User-Agent': Env.getIdentifier()}, show_error = False, return_raw = True)
|
return self.urlopen(url, headers = {'User-Agent': Env.getIdentifier()}, show_error = False)
|
||||||
except:
|
except:
|
||||||
log.error('Failed getting nzb from %s: %s', (self.getName(), traceback.format_exc()))
|
log.error('Failed getting nzb from %s: %s', (self.getName(), traceback.format_exc()))
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user